blob: afa358a0dc6990a5ab24c5bd743b5adad89a5706 [file] [log] [blame]
DavidPurcellb25f93d2017-01-27 12:46:27 -05001# Copyright 2017 AT&T Corporation.
DavidPurcell029d8c32017-01-06 15:27:41 -05002# All Rights Reserved.
3#
4# Licensed under the Apache License, Version 2.0 (the "License"); you may
5# not use this file except in compliance with the License. You may obtain
6# a copy of the License at
7#
8# http://www.apache.org/licenses/LICENSE-2.0
9#
10# Unless required by applicable law or agreed to in writing, software
11# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
12# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
13# License for the specific language governing permissions and limitations
14# under the License.
15
Sergey Vilgelm062fb152018-09-06 20:51:57 -050016import collections
Felipe Monteirob0595652017-01-23 16:51:58 -050017import copy
Sergey Vilgelm062fb152018-09-06 20:51:57 -050018import glob
DavidPurcell029d8c32017-01-06 15:27:41 -050019import os
20
DavidPurcell029d8c32017-01-06 15:27:41 -050021from oslo_log import log as logging
DavidPurcell029d8c32017-01-06 15:27:41 -050022from oslo_policy import policy
Felipe Monteiroae2ebab2017-03-23 22:49:06 +000023import stevedore
ghanshyam0df097d2017-08-08 09:28:17 +030024from tempest import clients
Rick Bartra503c5572017-03-09 13:49:58 -050025from tempest.common import credentials_factory as credentials
Felipe Monteiro7be94e82017-07-26 02:17:08 +010026from tempest import config
Rick Bartra503c5572017-03-09 13:49:58 -050027
Felipe Monteiro31e308e2018-05-22 12:05:10 -070028from patrole_tempest_plugin.rbac_authority import RbacAuthority
Felipe Monteirob0595652017-01-23 16:51:58 -050029from patrole_tempest_plugin import rbac_exceptions
DavidPurcell029d8c32017-01-06 15:27:41 -050030
Felipe Monteiro7be94e82017-07-26 02:17:08 +010031CONF = config.CONF
DavidPurcell029d8c32017-01-06 15:27:41 -050032LOG = logging.getLogger(__name__)
33
DavidPurcell029d8c32017-01-06 15:27:41 -050034
Felipe Monteiro88a5bab2017-08-31 04:00:32 +010035class PolicyAuthority(RbacAuthority):
Felipe Monteirof2b58d72017-08-31 22:40:36 +010036 """A class that uses ``oslo.policy`` for validating RBAC."""
DavidPurcell029d8c32017-01-06 15:27:41 -050037
Felipe Monteiro0854ded2017-05-05 16:30:55 +010038 def __init__(self, project_id, user_id, service, extra_target_data=None):
Felipe Monteirof2b58d72017-08-31 22:40:36 +010039 """Initialization of Policy Authority class.
DavidPurcell029d8c32017-01-06 15:27:41 -050040
Felipe Monteirof2b58d72017-08-31 22:40:36 +010041 Validates whether a test role can perform a policy action by querying
42 ``oslo.policy`` with necessary test data.
Felipe Monteiro9c978502017-01-27 17:07:54 -050043
Felipe Monteirof2b58d72017-08-31 22:40:36 +010044 If a policy file does not exist, checks whether the policy file is
45 registered as a namespace under "oslo.policy.policies". Nova, for
46 example, doesn't use a policy file by default; its policies are
47 implemented in code and registered as "nova" under
48 "oslo.policy.policies".
Felipe Monteiro9c978502017-01-27 17:07:54 -050049
Felipe Monteirof2b58d72017-08-31 22:40:36 +010050 If the policy file is not found in either code or in a policy file,
51 then an exception is raised.
52
53 Additionally, if a custom policy file exists along with the default
54 policy in code implementation, the custom policy is prioritized.
Felipe Monteirob0595652017-01-23 16:51:58 -050055
Felipe Monteiro3ab2c352017-07-05 22:25:34 +010056 :param uuid project_id: project_id of object performing API call
57 :param uuid user_id: user_id of object performing API call
58 :param string service: service of the policy file
59 :param dict extra_target_data: dictionary containing additional object
60 data needed by oslo.policy to validate generic checks
Felipe Monteirof2b58d72017-08-31 22:40:36 +010061
62 Example:
63
64 .. code-block:: python
65
66 # Below is the default policy implementation in code, defined in
67 # a service like Nova.
68 test_policies = [
69 policy.DocumentedRuleDefault(
70 'service:test_rule',
71 base.RULE_ADMIN_OR_OWNER,
72 "This is a description for a test policy",
73 [
74 {
75 'method': 'POST',
76 'path': '/path/to/test/resource'
77 }
78 ]),
79 'service:another_test_rule',
80 base.RULE_ADMIN_OR_OWNER,
81 "This is a description for another test policy",
82 [
83 {
84 'method': 'GET',
85 'path': '/path/to/test/resource'
86 }
87 ]),
88 ]
89
90 .. code-block:: yaml
91
92 # Below is the custom override of the default policy in a YAML
93 # policy file. Note that the default rule is "rule:admin_or_owner"
94 # and the custom rule is "rule:admin_api". The `PolicyAuthority`
95 # class will use the "rule:admin_api" definition for this policy
96 # action.
97 "service:test_rule" : "rule:admin_api"
98
99 # Note below that no override is provided for
100 # "service:another_test_rule", which means that the default policy
101 # rule is used: "rule:admin_or_owner".
DavidPurcell029d8c32017-01-06 15:27:41 -0500102 """
Felipe Monteiroae2ebab2017-03-23 22:49:06 +0000103
Felipe Monteiro0854ded2017-05-05 16:30:55 +0100104 if extra_target_data is None:
105 extra_target_data = {}
106
Sergey Vilgelm062fb152018-09-06 20:51:57 -0500107 self.service = self.validate_service(service)
Rick Bartra503c5572017-03-09 13:49:58 -0500108
Felipe Monteiro3ab2c352017-07-05 22:25:34 +0100109 # Prioritize dynamically searching for policy files over relying on
110 # deprecated service-specific policy file locations.
Felipe Monteirof6eb8622017-08-06 06:08:02 +0100111 if CONF.patrole.custom_policy_files:
Felipe Monteiro3ab2c352017-07-05 22:25:34 +0100112 self.discover_policy_files()
Felipe Monteiro3ab2c352017-07-05 22:25:34 +0100113
Sergey Vilgelmef7047d2018-09-11 14:48:55 -0500114 self.rules = self.get_rules()
Felipe Monteirofd1db982017-04-13 21:19:41 +0100115 self.project_id = project_id
Felipe Monteiro889264e2017-03-01 17:19:35 -0500116 self.user_id = user_id
Felipe Monteirofd1db982017-04-13 21:19:41 +0100117 self.extra_target_data = extra_target_data
DavidPurcell029d8c32017-01-06 15:27:41 -0500118
Felipe Monteirod9607c42017-06-12 19:28:45 +0100119 @classmethod
120 def validate_service(cls, service):
Felipe Monteiro3ab2c352017-07-05 22:25:34 +0100121 """Validate whether the service passed to ``__init__`` exists."""
Felipe Monteirod9607c42017-06-12 19:28:45 +0100122 service = service.lower().strip() if service else None
123
124 # Cache the list of available services in memory to avoid needlessly
125 # doing an API call every time.
126 if not hasattr(cls, 'available_services'):
ghanshyam0df097d2017-08-08 09:28:17 +0300127 admin_mgr = clients.Manager(
128 credentials.get_configured_admin_credentials())
Felipe Monteiro7be94e82017-07-26 02:17:08 +0100129 services_client = (admin_mgr.identity_services_v3_client
130 if CONF.identity_feature_enabled.api_v3
131 else admin_mgr.identity_services_client)
132 services = services_client.list_services()['services']
Felipe Monteirod9607c42017-06-12 19:28:45 +0100133 cls.available_services = [s['name'] for s in services]
134
135 if not service or service not in cls.available_services:
136 LOG.debug("%s is NOT a valid service.", service)
Felipe Monteiro51299a12018-06-28 20:03:27 -0400137 raise rbac_exceptions.RbacInvalidServiceException(
Felipe Monteirod9607c42017-06-12 19:28:45 +0100138 "%s is NOT a valid service." % service)
139
Sergey Vilgelm062fb152018-09-06 20:51:57 -0500140 return service
141
Felipe Monteiro3ab2c352017-07-05 22:25:34 +0100142 @classmethod
143 def discover_policy_files(cls):
Felipe Monteirof2b58d72017-08-31 22:40:36 +0100144 """Dynamically discover the policy file for each service in
Sergey Vilgelm062fb152018-09-06 20:51:57 -0500145 ``cls.available_services``. Pick all candidate paths found
Felipe Monteirof2b58d72017-08-31 22:40:36 +0100146 out of the potential paths in ``[patrole] custom_policy_files``.
147 """
Felipe Monteiro3ab2c352017-07-05 22:25:34 +0100148 if not hasattr(cls, 'policy_files'):
Sergey Vilgelm062fb152018-09-06 20:51:57 -0500149 cls.policy_files = collections.defaultdict(list)
Felipe Monteiro3ab2c352017-07-05 22:25:34 +0100150 for service in cls.available_services:
Felipe Monteirof6eb8622017-08-06 06:08:02 +0100151 for candidate_path in CONF.patrole.custom_policy_files:
Sergey Vilgelm062fb152018-09-06 20:51:57 -0500152 path = candidate_path % service
153 for filename in glob.iglob(path):
154 if os.path.isfile(filename):
155 cls.policy_files[service].append(filename)
Felipe Monteiro3ab2c352017-07-05 22:25:34 +0100156
Mykola Yakovlieve0f35502018-09-26 18:26:57 -0500157 def allowed(self, rule_name, roles):
Felipe Monteirof2b58d72017-08-31 22:40:36 +0100158 """Checks if a given rule in a policy is allowed with given role.
159
Felipe Monteiro778b7802018-05-31 19:52:58 -0400160 :param string rule_name: Policy name to pass to``oslo.policy``.
Mykola Yakovlieve0f35502018-09-26 18:26:57 -0500161 :param List[string] roles: List of roles to validate for authorization.
Felipe Monteiro778b7802018-05-31 19:52:58 -0400162 :raises RbacParsingException: If ``rule_name`` does not exist in the
Felipe Monteiro4ef7e532018-03-11 07:17:11 -0400163 cloud (in policy file or among registered in-code policy defaults).
Felipe Monteirof2b58d72017-08-31 22:40:36 +0100164 """
Mykola Yakovlieve0f35502018-09-26 18:26:57 -0500165 is_admin_context = self._is_admin_context(roles)
Felipe Monteirob0595652017-01-23 16:51:58 -0500166 is_allowed = self._allowed(
Mykola Yakovlieve0f35502018-09-26 18:26:57 -0500167 access=self._get_access_token(roles),
Felipe Monteirob0595652017-01-23 16:51:58 -0500168 apply_rule=rule_name,
Felipe Monteiro9c978502017-01-27 17:07:54 -0500169 is_admin=is_admin_context)
Felipe Monteiro9c978502017-01-27 17:07:54 -0500170 return is_allowed
DavidPurcell029d8c32017-01-06 15:27:41 -0500171
Sergey Vilgelm55e5dfe2019-01-07 11:59:41 -0600172 def _handle_deprecated_rule(self, default):
173 deprecated_rule = default.deprecated_rule
174 deprecated_msg = (
175 'Policy "%(old_name)s":"%(old_check_str)s" was deprecated in '
176 '%(release)s in favor of "%(name)s":"%(check_str)s". Reason: '
177 '%(reason)s. Either ensure your deployment is ready for the new '
178 'default or copy/paste the deprecated policy into your policy '
179 'file and maintain it manually.' % {
180 'old_name': deprecated_rule.name,
181 'old_check_str': deprecated_rule.check_str,
182 'release': default.deprecated_since,
183 'name': default.name,
184 'check_str': default.check_str,
185 'reason': default.deprecated_reason
186 }
187 )
188 LOG.warn(deprecated_msg)
Ghanshyam Mannee53f842020-04-16 11:52:57 -0500189 default.check = policy.OrCheck(
190 [policy._parser.parse_rule(cs) for cs in
191 [default.check_str,
192 deprecated_rule.check_str]])
Sergey Vilgelm55e5dfe2019-01-07 11:59:41 -0600193
Sergey Vilgelmef7047d2018-09-11 14:48:55 -0500194 def get_rules(self):
195 rules = policy.Rules()
Felipe Monteiro3ab2c352017-07-05 22:25:34 +0100196 # Check whether policy file exists and attempt to read it.
Sergey Vilgelm062fb152018-09-06 20:51:57 -0500197 for path in self.policy_files[self.service]:
Felipe Monteiroae2ebab2017-03-23 22:49:06 +0000198 try:
Sergey Vilgelm062fb152018-09-06 20:51:57 -0500199 with open(path, 'r') as fp:
Sergey Vilgelmef7047d2018-09-11 14:48:55 -0500200 for k, v in policy.Rules.load(fp.read()).items():
201 if k not in rules:
202 rules[k] = v
203 # If the policy name and rule are the same, no
204 # ambiguity, so no reason to warn.
205 elif str(v) != str(rules[k]):
206 msg = ("The same policy name: %s was found in "
207 "multiple policies files for service %s. "
208 "This can lead to policy rule ambiguity. "
209 "Using rule: %s; Rule from file: %s")
210 LOG.warning(msg, k, self.service, rules[k], v)
211 except (ValueError, IOError):
212 LOG.warning("Failed to read policy file '%s' for service %s.",
213 path, self.service)
Felipe Monteiroae2ebab2017-03-23 22:49:06 +0000214
215 # Check whether policy actions are defined in code. Nova and Keystone,
216 # for example, define their default policy actions in code.
217 mgr = stevedore.named.NamedExtensionManager(
218 'oslo.policy.policies',
Sergey Vilgelm062fb152018-09-06 20:51:57 -0500219 names=[self.service],
Felipe Monteiroae2ebab2017-03-23 22:49:06 +0000220 invoke_on_load=True,
221 warn_on_missing_entrypoint=False)
222
223 if mgr:
Sergey Vilgelm062fb152018-09-06 20:51:57 -0500224 policy_generator = {plc.name: plc.obj for plc in mgr}
Sergey Vilgelmef7047d2018-09-11 14:48:55 -0500225 if self.service in policy_generator:
Sergey Vilgelm062fb152018-09-06 20:51:57 -0500226 for rule in policy_generator[self.service]:
Sergey Vilgelmef7047d2018-09-11 14:48:55 -0500227 if rule.name not in rules:
Sergey Vilgelm55e5dfe2019-01-07 11:59:41 -0600228 if CONF.patrole.validate_deprecated_rules:
229 # NOTE (sergey.vilgelm):
230 # The `DocumentedRuleDefault` object has no
231 # `deprecated_rule` attribute in Pike
232 if getattr(rule, 'deprecated_rule', False):
Ghanshyam Mannee53f842020-04-16 11:52:57 -0500233 self._handle_deprecated_rule(rule)
Sergey Vilgelmef7047d2018-09-11 14:48:55 -0500234 rules[rule.name] = rule.check
235 elif str(rule.check) != str(rules[rule.name]):
236 msg = ("The same policy name: %s was found in the "
237 "policies files and in the code for service "
238 "%s. This can lead to policy rule ambiguity. "
239 "Using rule: %s; Rule from code: %s")
240 LOG.warning(msg, rule.name, self.service,
241 rules[rule.name], rule.check)
Felipe Monteiroae2ebab2017-03-23 22:49:06 +0000242
Sergey Vilgelmef7047d2018-09-11 14:48:55 -0500243 if not rules:
244 msg = (
Sergey Vilgelm062fb152018-09-06 20:51:57 -0500245 'Policy files for {0} service were not found among the '
Felipe Monteiro4ef7e532018-03-11 07:17:11 -0400246 'registered in-code policies or in any of the possible policy '
Sergey Vilgelmef7047d2018-09-11 14:48:55 -0500247 'files: {1}.'.format(
248 self.service,
249 [loc % self.service
250 for loc in CONF.patrole.custom_policy_files]))
251 raise rbac_exceptions.RbacParsingException(msg)
Felipe Monteiroae2ebab2017-03-23 22:49:06 +0000252
Sergey Vilgelmef7047d2018-09-11 14:48:55 -0500253 return rules
Felipe Monteiroae2ebab2017-03-23 22:49:06 +0000254
Mykola Yakovlieve0f35502018-09-26 18:26:57 -0500255 def _is_admin_context(self, roles):
Felipe Monteiro9c978502017-01-27 17:07:54 -0500256 """Checks whether a role has admin context.
257
258 If context_is_admin is contained in the policy file, then checks
259 whether the given role is contained in context_is_admin. If it is not
260 in the policy file, then default to context_is_admin: admin.
261 """
Manik Bindlish0868ded2018-12-20 08:44:50 +0000262 if 'context_is_admin' in self.rules:
Felipe Monteiro9c978502017-01-27 17:07:54 -0500263 return self._allowed(
Mykola Yakovlieve0f35502018-09-26 18:26:57 -0500264 access=self._get_access_token(roles),
Felipe Monteiro9c978502017-01-27 17:07:54 -0500265 apply_rule='context_is_admin')
Mykola Yakovlieve0f35502018-09-26 18:26:57 -0500266 return CONF.identity.admin_role in roles
DavidPurcell029d8c32017-01-06 15:27:41 -0500267
Mykola Yakovlieve0f35502018-09-26 18:26:57 -0500268 def _get_access_token(self, roles):
Felipe Monteirob0595652017-01-23 16:51:58 -0500269 access_token = {
270 "token": {
Sergey Vilgelm55e5dfe2019-01-07 11:59:41 -0600271 "roles": [{'name': r} for r in roles],
Felipe Monteirofd1db982017-04-13 21:19:41 +0100272 "project_id": self.project_id,
273 "tenant_id": self.project_id,
Felipe Monteiro889264e2017-03-01 17:19:35 -0500274 "user_id": self.user_id
Felipe Monteirob0595652017-01-23 16:51:58 -0500275 }
276 }
277 return access_token
DavidPurcell029d8c32017-01-06 15:27:41 -0500278
Felipe Monteiro9c978502017-01-27 17:07:54 -0500279 def _allowed(self, access, apply_rule, is_admin=False):
Felipe Monteirof2b58d72017-08-31 22:40:36 +0100280 """Checks if a given rule in a policy is allowed with given ``access``.
DavidPurcell029d8c32017-01-06 15:27:41 -0500281
Felipe Monteirof2b58d72017-08-31 22:40:36 +0100282 :param dict access: Dictionary from ``_get_access_token``.
283 :param string apply_rule: Rule to be checked using ``oslo.policy``.
284 :param bool is_admin: Whether admin context is used.
DavidPurcell029d8c32017-01-06 15:27:41 -0500285 """
Felipe Monteirob0595652017-01-23 16:51:58 -0500286 access_data = copy.copy(access['token'])
287 access_data['roles'] = [role['name'] for role in access_data['roles']]
Felipe Monteirob0595652017-01-23 16:51:58 -0500288 access_data['is_admin'] = is_admin
Felipe Monteiro9c978502017-01-27 17:07:54 -0500289 # TODO(felipemonteiro): Dynamically calculate is_admin_project rather
290 # than hard-coding it to True. is_admin_project cannot be determined
Felipe Monteiro94fc2ca2018-05-22 12:08:43 -0700291 # from the role, but rather from project and domain names. For more
292 # information, see:
Luigi Toscano6da06ed2019-01-07 17:50:41 +0100293 # https://git.openstack.org/cgit/openstack/keystone/tree/keystone/token/providers/common.py?id=37ce5417418f8acbd27f3dacb70c605b0fe48301#n150
Felipe Monteiro9c978502017-01-27 17:07:54 -0500294 access_data['is_admin_project'] = True
DavidPurcell029d8c32017-01-06 15:27:41 -0500295
Felipe Monteirob0595652017-01-23 16:51:58 -0500296 class Object(object):
297 pass
298 o = Object()
Felipe Monteiro9c978502017-01-27 17:07:54 -0500299 o.rules = self.rules
DavidPurcell029d8c32017-01-06 15:27:41 -0500300
Felipe Monteiro9fc782e2017-02-01 15:38:46 -0500301 target = {"project_id": access_data['project_id'],
302 "tenant_id": access_data['project_id'],
Felipe Monteiro889264e2017-03-01 17:19:35 -0500303 "network:tenant_id": access_data['project_id'],
304 "user_id": access_data['user_id']}
Felipe Monteirofd1db982017-04-13 21:19:41 +0100305 if self.extra_target_data:
306 target.update(self.extra_target_data)
Felipe Monteirob0595652017-01-23 16:51:58 -0500307
Felipe Monteiro9c978502017-01-27 17:07:54 -0500308 result = self._try_rule(apply_rule, target, access_data, o)
Felipe Monteirob0595652017-01-23 16:51:58 -0500309 return result
310
Felipe Monteiro9c978502017-01-27 17:07:54 -0500311 def _try_rule(self, apply_rule, target, access_data, o):
Samantha Blanco0d880082017-03-23 18:14:37 -0400312 if apply_rule not in self.rules:
Sergey Vilgelm062fb152018-09-06 20:51:57 -0500313 message = ('Policy action "{0}" not found in policy files: '
314 '{1} or among registered policy in code defaults for '
315 '{2} service.').format(apply_rule,
316 self.policy_files[self.service],
317 self.service)
Felipe Monteiro48c913d2017-03-15 12:07:48 -0400318 LOG.debug(message)
319 raise rbac_exceptions.RbacParsingException(message)
Samantha Blanco0d880082017-03-23 18:14:37 -0400320 else:
321 rule = self.rules[apply_rule]
322 return rule(target, access_data, o)