commit 51299a14146ec4f80fdd4eb42819dd0a4b8d5ee3
author Felipe Monteiro <felipe.monteiro@att.com> Thu Jun 28 20:03:27 2018 -0400
committer Felipe Monteiro <felipe.monteiro@att.com> Wed Jul 18 01:18:35 2018 +0000
tree 9f6655b634cd87238cafadf4c53d1f48d7009f2a
parent 561d028a636fc0982f57319a2fb78039dc9c700c

Improve exception that is raised following invalid service

This patchset changes the exception that is raised following
an invalid service being passed in for testing. Instead of
a NotFound getting raised (which doesn't make sense), the
original exception, RbacInvalidServiceException, is raised
instead. In addition "Exception" is appended to the original
exception name for greater clarity and consistency with other
exception names.

This patchset is similar to [0] which aims to simplify and
consolidate how service input is validated.

[0] https://review.openstack.org/#/c/577963/

Change-Id: Ib91a6581f89a528630d756840176b0e16663fa6f

patrole_tempest_plugin/policy_authority.py

diff --git a/patrole_tempest_plugin/policy_authority.py b/patrole_tempest_plugin/policy_authority.py
index b813f88..3339a5d 100644
--- a/patrole_tempest_plugin/policy_authority.py
+++ b/patrole_tempest_plugin/policy_authority.py
@@ -136,7 +136,7 @@
 
         if not service or service not in cls.available_services:
             LOG.debug("%s is NOT a valid service.", service)
-            raise rbac_exceptions.RbacInvalidService(
+            raise rbac_exceptions.RbacInvalidServiceException(
                 "%s is NOT a valid service." % service)
 
     @classmethod