| James E. King III | 91a4fd7 | 2019-01-30 10:24:33 -0500 | [diff] [blame^] | 1 | ### Pull Request ### |
| James E. King III | 85db0fe | 2018-04-06 08:37:11 -0400 | [diff] [blame] | 2 | |
| James E. King III | 91a4fd7 | 2019-01-30 10:24:33 -0500 | [diff] [blame^] | 3 | The [Contributing Guide](https://github.com/apache/thrift/blob/master/CONTRIBUTING.md) has more details and tips for |
| 4 | committing properly. |
| James E. King, III | 8a6d9f4 | 2018-04-09 08:11:38 -0400 | [diff] [blame] | 5 | |
| James E. King III | 91a4fd7 | 2019-01-30 10:24:33 -0500 | [diff] [blame^] | 6 | <!-- Explain the changes in the pull request below. --> |
| James E. King III | 4927179 | 2019-01-28 08:32:47 -0500 | [diff] [blame] | 7 | |
| James E. King III | 4927179 | 2019-01-28 08:32:47 -0500 | [diff] [blame] | 8 | |
| James E. King III | 4927179 | 2019-01-28 08:32:47 -0500 | [diff] [blame] | 9 | |
| James E. King III | 91a4fd7 | 2019-01-30 10:24:33 -0500 | [diff] [blame^] | 10 | <!-- We recommend you review the checklist before submitting a pull request. --> |
| 11 | Review the following checklist to ensure a smooth pull request experience. |
| James E. King III | 85db0fe | 2018-04-06 08:37:11 -0400 | [diff] [blame] | 12 | |
| James E. King III | 4927179 | 2019-01-28 08:32:47 -0500 | [diff] [blame] | 13 | - [ ] Did you squash your changes to a single commit? |
| 14 | |
| James E. King III | 91a4fd7 | 2019-01-30 10:24:33 -0500 | [diff] [blame^] | 15 | - [ ] Do you need an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?<details><summary>Expand for guidance...</summary> |
| 16 | - `Yes` if your change requires a release note. |
| 17 | - `Yes` if your change is a breaking change. |
| 18 | - `No` if you change is trivial, such as fixing a typo. |
| 19 | </details> |
| 20 | |
| 21 | - [ ] Is this change worthy of a release note? <details><summary>Examples of Release Note-worthy examples...</summary> |
| 22 | - Breaking Changes |
| 23 | - New, Deprecated, or Removed Languages |
| 24 | - Security Fixes |
| 25 | - Significant Refactoring |
| 26 | - Changing how the product is built |
| 27 | </details> |
| James E. King III | 4927179 | 2019-01-28 08:32:47 -0500 | [diff] [blame] | 28 | |
| James E. King III | 91a4fd7 | 2019-01-30 10:24:33 -0500 | [diff] [blame^] | 29 | - [ ] Breaking changes have additional requirements: <details><summary>Expand for instructions...</summary> |
| 30 | - Add or reference an existing Apache Jira THRIFT ticket. |
| 31 | - Add a `Breaking-Change` label to the Jira ticket. |
| 32 | - Add a note to the `lib/<language>/README.md` file. |
| 33 | - Add a line to the `CHANGES.md` file. |
| 34 | </details> |
| 35 | |
| 36 | - [ ] Does this change require a build? <details><summary>Expand for guidance...</summary> |
| 37 | - `Yes` for any code change |
| 38 | - `Yes` for any build script change |
| 39 | - `Yes` for any docker build environment change |
| 40 | - `Yes` for any change affecting the cross test suite |
| 41 | - `No` for documentation-only changes |
| 42 | - `No` for trivial changes, for example fixing a typo. |
| 43 | <br/> |
| 44 | If your change does not require a build, you can add [ci skip] to the end of your commit message.<br/> |
| 45 | This will avoid costly and unnecessary builds in both the pull request and once it is merged. |
| 46 | </details> |
| 47 | |
| 48 | For more information about committing, see the [Contributing Guide](https://github.com/apache/thrift/blob/master/CONTRIBUTING.md). |