| James E. King, III | 8a6d9f4 | 2018-04-09 08:11:38 -0400 | [diff] [blame^] | 1 | Some helpful tips for a successful Apache Thrift PR: |
| James E. King III | 85db0fe | 2018-04-06 08:37:11 -0400 | [diff] [blame] | 2 | |
| James E. King, III | 8a6d9f4 | 2018-04-09 08:11:38 -0400 | [diff] [blame^] | 3 | * Did you test your changes locally or using CI in your fork? |
| 4 | * Is the Apache Jira THRIFT ticket identifier in the PR title? |
| 5 | * Is the Apache Jira THRIFT ticket identifier in the commit message? |
| 6 | * Did you squash your changes to a single commit? |
| 7 | * Are these changes backwards compatible? (please say so in PR description) |
| 8 | * Do you need to update the language-specific README? |
| 9 | |
| 10 | Example ideal pull request title: |
| James E. King III | 85db0fe | 2018-04-06 08:37:11 -0400 | [diff] [blame] | 11 | |
| 12 | THRIFT-9999: an example pull request title |
| 13 | |
| James E. King, III | 8a6d9f4 | 2018-04-09 08:11:38 -0400 | [diff] [blame^] | 14 | Example ideal commit message: |
| James E. King III | 85db0fe | 2018-04-06 08:37:11 -0400 | [diff] [blame] | 15 | |
| 16 | THRIFT-9999: [summary of fix, one line if possible] |
| 17 | Client: [language(s) affected, comma separated, use lib/ directory names please] |
| 18 | |
| James E. King III | 10cfd6a | 2018-04-06 08:43:04 -0400 | [diff] [blame] | 19 | For more information about committing, see CONTRIBUTING.md |