| jfarrell | 347a5eb | 2014-04-05 12:20:07 -0400 | [diff] [blame^] | 1 | ## How to contribute |
| 2 | |
| 3 | 1. Make sure your issue is not all ready in the [Jira issue tracker]({{ conf.jira_url }}) |
| 4 | 1. If not, create a ticket describing the change you're proposing in the [Jira issue tracker]({{ conf.jira_url }}) |
| 5 | 1. Contribute your patch using one of the two methods below |
| 6 | |
| 7 | ### Contributing via a patch |
| 8 | |
| 9 | 1. Check out the latest version of the source code |
| 10 | |
| 11 | * git clone https://git-wip-us.apache.org/repos/asf/thrift.git thrift |
| 12 | |
| 13 | 1. Modify the source to include the improvement/bugfix |
| 14 | |
| 15 | * Verify that you follow the same CodingStyle you see within the language you are working on |
| 16 | * Verify that your change works by adding a unit test. |
| 17 | |
| 18 | 1. Create a patch from project root directory (e.g. you@dev:~/thrift $ ): |
| 19 | |
| 20 | * git diff > ../thrift-XXX-my-new-feature.patch |
| 21 | |
| 22 | 1. Attach the newly generated patch to the issue |
| 23 | 1. Wait for other contributors or committers to review your new addition |
| 24 | 1. Wait for a committer to commit your patch |
| 25 | |
| 26 | ### Contributing via GitHub pull requests |
| 27 | |
| 28 | 1. Create a fork for http://github.com/apache/thrift |
| 29 | 1. Create a branch with the jira ticket number you are working on |
| 30 | 1. Modify the source to include the improvement/bugfix |
| 31 | |
| 32 | * Verify that you follow the same CodingStyle you see within the language you are working on |
| 33 | * Verify that your change works by adding a unit test. |
| 34 | |
| 35 | 1. Issue a pull request for your new feature |
| 36 | 1. Wait for other contributors or committers to review your new addition |
| 37 | 1. Wait for a committer to commit your patch |
| 38 | |
| 39 | ### More info |
| 40 | |
| 41 | Plenty of information on why and how to contribute is available on the Apache Software Foundation (ASF) web site. In particular, we recommend the following: |
| 42 | |
| 43 | * [Contributors Tech Guide](http://www.apache.org/dev/contributors) |
| 44 | * [Get involved!](http://www.apache.org/foundation/getinvolved.html) |
| 45 | * [Legal aspects on Submission of Contributions (Patches)](http://www.apache.org/licenses/LICENSE-2.0.html#contributions) |