Move some params to default
Change-Id: I7f742648b471223a838e266b4f465fe8ddb23d00
Prod-related: PROD-27378 (PROD:27378)
diff --git a/defaults/init.yml b/defaults/init.yml
index 90d5f7f..42c315a 100644
--- a/defaults/init.yml
+++ b/defaults/init.yml
@@ -42,6 +42,7 @@
# Other
salt_control_xenial_image_backend: /var/lib/libvirt/images/backends/xenial.qcow2
salt_control_trusty_image_backend: /var/lib/libvirt/images/backends/trusty.qcow2
+ salt_master_api_port: 6969
salt_master_worker_threads: 40
salt_minion_ca_host: cfg01.${_param:cluster_domain}
# Make sure this global variable is defined everywhere, where used it is already set on cluster level
diff --git a/defaults/jenkins.yml b/defaults/jenkins.yml
index 36bcbfb..eddf216 100644
--- a/defaults/jenkins.yml
+++ b/defaults/jenkins.yml
@@ -3,3 +3,4 @@
jenkins_master_port: 8081
jenkins_master_protocol: http
jenkins_pipelines_branch: "master"
+ jenkins_salt_api_url: "http://${_param:salt_master_host}:${_param:salt_master_api_port}"
diff --git a/defaults/salt/init.yml b/defaults/salt/init.yml
index 61d9866..e71f560 100644
--- a/defaults/salt/init.yml
+++ b/defaults/salt/init.yml
@@ -48,3 +48,10 @@
salt_control_trusty_image: ${_param:mcp_static_images_url}/ubuntu-14-04-x64-mcp${_param:mcp_version}.qcow2
salt_control_xenial_image: ${_param:mcp_static_images_url}/ubuntu-16-04-x64-mcp${_param:mcp_version}.qcow2
+
+ salt_master_api_permissions:
+ - '.*'
+ - '@local'
+ - '@wheel' # to allow access to all wheel modules
+ - '@runner' # to allow access to all runner modules
+ - '@jobs' # to allow access to the jobs runner and/or wheel mo
diff --git a/jenkins/client/job/ceph/add-node.yml b/jenkins/client/job/ceph/add-node.yml
index 29af563..763b859 100644
--- a/jenkins/client/job/ceph/add-node.yml
+++ b/jenkins/client/job/ceph/add-node.yml
@@ -20,7 +20,7 @@
SALT_MASTER_URL:
type: string
description: URL of Salt master
- default: "http://${_param:salt_master_host}:6969"
+ default: "${_param:jenkins_salt_api_url}"
SALT_MASTER_CREDENTIALS:
type: string
description: Credentials for login to Salt API
diff --git a/jenkins/client/job/ceph/backend-migration.yml b/jenkins/client/job/ceph/backend-migration.yml
index ab3f639..c0a7c45 100644
--- a/jenkins/client/job/ceph/backend-migration.yml
+++ b/jenkins/client/job/ceph/backend-migration.yml
@@ -20,7 +20,7 @@
SALT_MASTER_URL:
type: string
description: URL of Salt master
- default: "http://${_param:salt_master_host}:6969"
+ default: "${_param:jenkins_salt_api_url}"
SALT_MASTER_CREDENTIALS:
type: string
description: Credentials for login to Salt API
diff --git a/jenkins/client/job/ceph/remove-node.yml b/jenkins/client/job/ceph/remove-node.yml
index 901e319..d6fd128 100644
--- a/jenkins/client/job/ceph/remove-node.yml
+++ b/jenkins/client/job/ceph/remove-node.yml
@@ -20,7 +20,7 @@
SALT_MASTER_URL:
type: string
description: URL of Salt master
- default: "http://${_param:salt_master_host}:6969"
+ default: "${_param:jenkins_salt_api_url}"
SALT_MASTER_CREDENTIALS:
type: string
description: Credentials for login to Salt API
diff --git a/jenkins/client/job/ceph/remove-osd.yml b/jenkins/client/job/ceph/remove-osd.yml
index 99dcb37..3af5a96 100644
--- a/jenkins/client/job/ceph/remove-osd.yml
+++ b/jenkins/client/job/ceph/remove-osd.yml
@@ -20,7 +20,7 @@
SALT_MASTER_URL:
type: string
description: URL of Salt master
- default: "http://${_param:salt_master_host}:6969"
+ default: "${_param:jenkins_salt_api_url}"
SALT_MASTER_CREDENTIALS:
type: string
description: Credentials for login to Salt API
diff --git a/jenkins/client/job/ceph/replace-failed-osd.yml b/jenkins/client/job/ceph/replace-failed-osd.yml
index a342ffb..395b5e5 100644
--- a/jenkins/client/job/ceph/replace-failed-osd.yml
+++ b/jenkins/client/job/ceph/replace-failed-osd.yml
@@ -20,7 +20,7 @@
SALT_MASTER_URL:
type: string
description: URL of Salt master
- default: "http://${_param:salt_master_host}:6969"
+ default: "${_param:jenkins_salt_api_url}"
SALT_MASTER_CREDENTIALS:
type: string
description: Credentials for login to Salt API
diff --git a/jenkins/client/job/ceph/upgrade.yml b/jenkins/client/job/ceph/upgrade.yml
index 7717761..0c07b46 100644
--- a/jenkins/client/job/ceph/upgrade.yml
+++ b/jenkins/client/job/ceph/upgrade.yml
@@ -20,7 +20,7 @@
SALT_MASTER_URL:
type: string
description: URL of Salt master
- default: "http://${_param:salt_master_host}:6969"
+ default: "${_param:jenkins_salt_api_url}"
SALT_MASTER_CREDENTIALS:
type: string
description: Credentials for login to Salt API
diff --git a/jenkins/client/job/deploy/galera_verify_restore.yml b/jenkins/client/job/deploy/galera_verify_restore.yml
index 492d76f..73e312a 100644
--- a/jenkins/client/job/deploy/galera_verify_restore.yml
+++ b/jenkins/client/job/deploy/galera_verify_restore.yml
@@ -1,6 +1,4 @@
parameters:
- _param:
- jenkins_salt_api_url: "http://${_param:salt_master_host}:6969"
jenkins:
client:
job:
diff --git a/jenkins/client/job/deploy/openstack.yml b/jenkins/client/job/deploy/openstack.yml
index d5ed556..b265161 100644
--- a/jenkins/client/job/deploy/openstack.yml
+++ b/jenkins/client/job/deploy/openstack.yml
@@ -1,6 +1,4 @@
parameters:
- _param:
- jenkins_salt_api_url: "http://${_param:salt_master_host}:6969"
jenkins:
client:
job:
diff --git a/jenkins/client/job/deploy/try_mcp.yml b/jenkins/client/job/deploy/try_mcp.yml
index 9c161ff..3ad2878 100644
--- a/jenkins/client/job/deploy/try_mcp.yml
+++ b/jenkins/client/job/deploy/try_mcp.yml
@@ -1,6 +1,4 @@
parameters:
- _param:
- jenkins_salt_api_url: "http://${_param:salt_master_host}:6969"
jenkins:
client:
job:
diff --git a/jenkins/client/job/deploy/update/cloud_update.yml b/jenkins/client/job/deploy/update/cloud_update.yml
index aef20ce..f3fe8ef 100644
--- a/jenkins/client/job/deploy/update/cloud_update.yml
+++ b/jenkins/client/job/deploy/update/cloud_update.yml
@@ -2,8 +2,6 @@
# Jobs to update cloud packages on given Salt master environment
#
parameters:
- _param:
- jenkins_salt_api_url: "http://${_param:salt_master_host}:6969"
jenkins:
client:
job:
diff --git a/jenkins/client/job/deploy/update/config.yml b/jenkins/client/job/deploy/update/config.yml
index 47ec321..5eafd70 100644
--- a/jenkins/client/job/deploy/update/config.yml
+++ b/jenkins/client/job/deploy/update/config.yml
@@ -2,8 +2,6 @@
# Jobs to run given states on given Salt master environment's
#
parameters:
- _param:
- jenkins_salt_api_url: "http://${_param:salt_master_host}:6969"
jenkins:
client:
job:
diff --git a/jenkins/client/job/deploy/update/kubernetes_update.yml b/jenkins/client/job/deploy/update/kubernetes_update.yml
index 454d92b..ee77583 100644
--- a/jenkins/client/job/deploy/update/kubernetes_update.yml
+++ b/jenkins/client/job/deploy/update/kubernetes_update.yml
@@ -2,8 +2,6 @@
# Jobs to update cloud packages on given Salt master environment
#
parameters:
- _param:
- jenkins_salt_api_url: "http://${_param:salt_master_host}:6969"
jenkins:
client:
job:
diff --git a/jenkins/client/job/deploy/update/package.yml b/jenkins/client/job/deploy/update/package.yml
index a485c3e..cb25892 100644
--- a/jenkins/client/job/deploy/update/package.yml
+++ b/jenkins/client/job/deploy/update/package.yml
@@ -2,8 +2,6 @@
# Jobs to update packages on given Salt master environment
#
parameters:
- _param:
- jenkins_salt_api_url: "http://${_param:salt_master_host}:6969"
jenkins:
client:
job:
diff --git a/jenkins/client/job/deploy/update/reclass_update_check.yml b/jenkins/client/job/deploy/update/reclass_update_check.yml
index cec8d79..dd279b3 100644
--- a/jenkins/client/job/deploy/update/reclass_update_check.yml
+++ b/jenkins/client/job/deploy/update/reclass_update_check.yml
@@ -2,8 +2,6 @@
# Jobs to to check new Reclass package version compatibility with model
#
parameters:
- _param:
- jenkins_salt_api_url: "http://${_param:salt_master_host}:6969"
jenkins:
client:
job:
diff --git a/jenkins/client/job/deploy/update/restore_cassandra.yml b/jenkins/client/job/deploy/update/restore_cassandra.yml
index 34179af..8b18eb1 100644
--- a/jenkins/client/job/deploy/update/restore_cassandra.yml
+++ b/jenkins/client/job/deploy/update/restore_cassandra.yml
@@ -2,8 +2,6 @@
# Jobs to update packages on given Salt master environment
#
parameters:
- _param:
- jenkins_salt_api_url: "http://${_param:salt_master_host}:6969"
jenkins:
client:
job:
diff --git a/jenkins/client/job/deploy/update/restore_zookeeper.yml b/jenkins/client/job/deploy/update/restore_zookeeper.yml
index ebb57f7..3d0dc05 100644
--- a/jenkins/client/job/deploy/update/restore_zookeeper.yml
+++ b/jenkins/client/job/deploy/update/restore_zookeeper.yml
@@ -2,8 +2,6 @@
# Jobs to update packages on given Salt master environment
#
parameters:
- _param:
- jenkins_salt_api_url: "http://${_param:salt_master_host}:6969"
jenkins:
client:
job:
diff --git a/jenkins/client/job/deploy/update/saltenv.yml b/jenkins/client/job/deploy/update/saltenv.yml
index 734a4e5..f2b38d2 100644
--- a/jenkins/client/job/deploy/update/saltenv.yml
+++ b/jenkins/client/job/deploy/update/saltenv.yml
@@ -3,7 +3,6 @@
#
parameters:
_param:
- jenkins_salt_api_url: "http://${_param:salt_master_host}:6969"
jenkins_salt_model_name: "salt"
jenkins_salt_model_branch: "master"
jenkins:
diff --git a/jenkins/client/job/deploy/update/update_ceph.yml b/jenkins/client/job/deploy/update/update_ceph.yml
index dd8bf58..4b7603b 100644
--- a/jenkins/client/job/deploy/update/update_ceph.yml
+++ b/jenkins/client/job/deploy/update/update_ceph.yml
@@ -2,8 +2,6 @@
# Jobs to run given states on given Salt master environment's
#
parameters:
- _param:
- jenkins_salt_api_url: "http://${_param:salt_master_host}:6969"
jenkins:
client:
job:
diff --git a/jenkins/client/job/deploy/update/update_mirror_image.yml b/jenkins/client/job/deploy/update/update_mirror_image.yml
index 73fd434..96e905c 100644
--- a/jenkins/client/job/deploy/update/update_mirror_image.yml
+++ b/jenkins/client/job/deploy/update/update_mirror_image.yml
@@ -2,8 +2,6 @@
# Jobs to update Salt master environment (formulas and models)
#
parameters:
- _param:
- jenkins_salt_api_url: "http://${_param:salt_master_host}:6969"
jenkins:
client:
job:
@@ -67,4 +65,4 @@
default: 'true'
UPDATE_FILES:
type: boolean
- default: 'true'
\ No newline at end of file
+ default: 'true'
diff --git a/jenkins/client/job/deploy/update/update_opencontrail4.yml b/jenkins/client/job/deploy/update/update_opencontrail4.yml
index 72ea870..e89d622 100644
--- a/jenkins/client/job/deploy/update/update_opencontrail4.yml
+++ b/jenkins/client/job/deploy/update/update_opencontrail4.yml
@@ -2,8 +2,6 @@
# Jobs to update packages on given Salt master environment
#
parameters:
- _param:
- jenkins_salt_api_url: "http://${_param:salt_master_host}:6969"
jenkins:
client:
job:
diff --git a/jenkins/client/job/deploy/update/upgrade.yml b/jenkins/client/job/deploy/update/upgrade.yml
index f4f5630..e3b60e1 100644
--- a/jenkins/client/job/deploy/update/upgrade.yml
+++ b/jenkins/client/job/deploy/update/upgrade.yml
@@ -2,8 +2,6 @@
# Jobs to update packages on given Salt master environment
#
parameters:
- _param:
- jenkins_salt_api_url: "http://${_param:salt_master_host}:6969"
jenkins:
client:
job:
diff --git a/jenkins/client/job/deploy/update/upgrade_compute.yml b/jenkins/client/job/deploy/update/upgrade_compute.yml
index b4628fa..ed5a222 100644
--- a/jenkins/client/job/deploy/update/upgrade_compute.yml
+++ b/jenkins/client/job/deploy/update/upgrade_compute.yml
@@ -2,8 +2,6 @@
# Jobs to update packages on given Salt master environment
#
parameters:
- _param:
- jenkins_salt_api_url: "http://${_param:salt_master_host}:6969"
jenkins:
client:
job:
diff --git a/jenkins/client/job/deploy/update/upgrade_mcp_release.yml b/jenkins/client/job/deploy/update/upgrade_mcp_release.yml
index 577e6ac..3fbd6c0 100644
--- a/jenkins/client/job/deploy/update/upgrade_mcp_release.yml
+++ b/jenkins/client/job/deploy/update/upgrade_mcp_release.yml
@@ -2,8 +2,6 @@
# Jobs to upgrade MCP release
#
parameters:
- _param:
- jenkins_salt_api_url: "http://${_param:salt_master_host}:6969"
jenkins:
client:
job:
diff --git a/jenkins/client/job/deploy/update/upgrade_opencontrail.yml b/jenkins/client/job/deploy/update/upgrade_opencontrail.yml
index 0b0d945..64c3aff 100644
--- a/jenkins/client/job/deploy/update/upgrade_opencontrail.yml
+++ b/jenkins/client/job/deploy/update/upgrade_opencontrail.yml
@@ -2,8 +2,6 @@
# Jobs to update packages on given Salt master environment
#
parameters:
- _param:
- jenkins_salt_api_url: "http://${_param:salt_master_host}:6969"
jenkins:
client:
job:
diff --git a/jenkins/client/job/deploy/update/upgrade_opencontrail4_0.yml b/jenkins/client/job/deploy/update/upgrade_opencontrail4_0.yml
index c1f448c..2d7ed69 100644
--- a/jenkins/client/job/deploy/update/upgrade_opencontrail4_0.yml
+++ b/jenkins/client/job/deploy/update/upgrade_opencontrail4_0.yml
@@ -2,8 +2,6 @@
# Jobs to update packages on given Salt master environment
#
parameters:
- _param:
- jenkins_salt_api_url: "http://${_param:salt_master_host}:6969"
jenkins:
client:
job:
diff --git a/jenkins/client/job/deploy/update/upgrade_ovs_gateway.yml b/jenkins/client/job/deploy/update/upgrade_ovs_gateway.yml
index 76bf436..9d31352 100644
--- a/jenkins/client/job/deploy/update/upgrade_ovs_gateway.yml
+++ b/jenkins/client/job/deploy/update/upgrade_ovs_gateway.yml
@@ -2,8 +2,6 @@
# Jobs to update packages on given Salt master environment
#
parameters:
- _param:
- jenkins_salt_api_url: "http://${_param:salt_master_host}:6969"
jenkins:
client:
job:
diff --git a/jenkins/client/job/deploy/update/upgrade_stacklight.yml b/jenkins/client/job/deploy/update/upgrade_stacklight.yml
index d7279a6..578fd28 100644
--- a/jenkins/client/job/deploy/update/upgrade_stacklight.yml
+++ b/jenkins/client/job/deploy/update/upgrade_stacklight.yml
@@ -2,8 +2,6 @@
# Jobs to process Stacklight update
#
parameters:
- _param:
- jenkins_salt_api_url: "http://${_param:salt_master_host}:6969"
jenkins:
client:
job:
diff --git a/jenkins/client/job/deploy/update/virt_snapshot.yml b/jenkins/client/job/deploy/update/virt_snapshot.yml
index be92c8d..22c8880 100644
--- a/jenkins/client/job/deploy/update/virt_snapshot.yml
+++ b/jenkins/client/job/deploy/update/virt_snapshot.yml
@@ -2,8 +2,6 @@
# Job to manage libvirt live snapshots
#
parameters:
- _param:
- jenkins_salt_api_url: "http://${_param:salt_master_host}:6969"
jenkins:
client:
job:
diff --git a/jenkins/client/job/validate.yml b/jenkins/client/job/validate.yml
index 9f20fc9..41a9c65 100644
--- a/jenkins/client/job/validate.yml
+++ b/jenkins/client/job/validate.yml
@@ -1,6 +1,4 @@
parameters:
- _param:
- jenkins_salt_api_url: "http://${_param:salt_master_host}:6969"
jenkins:
client:
view:
diff --git a/salt/master/api.yml b/salt/master/api.yml
index b5ede2f..f0fa081 100644
--- a/salt/master/api.yml
+++ b/salt/master/api.yml
@@ -1,12 +1,4 @@
parameters:
- _param:
- salt_master_api_port: 6969
- salt_master_api_permissions:
- - '.*'
- - '@local'
- - '@wheel' # to allow access to all wheel modules
- - '@runner' # to allow access to all runner modules
- - '@jobs' # to allow access to the jobs runner and/or wheel mo
salt:
api:
enabled: true