Merge "contrail 4.0: fix missing logs"
diff --git a/README.rst b/README.rst
index 49c542f..b936776 100644
--- a/README.rst
+++ b/README.rst
@@ -1481,37 +1481,3 @@
 Trace XMPP requests
 
 	http://<compute-node>:8085/Snh_SandeshTraceRequest?x=XmppMessageTrace
-
-
-Documentation and Bugs
-======================
-
-To learn how to install and update salt-formulas, consult the documentation
-available online at:
-
-    http://salt-formulas.readthedocs.io/
-
-In the unfortunate event that bugs are discovered, they should be reported to
-the appropriate issue tracker. Use Github issue tracker for specific salt
-formula:
-
-    https://github.com/salt-formulas/salt-formula-opencontrail/issues
-
-For feature requests, bug reports or blueprints affecting entire ecosystem,
-use Launchpad salt-formulas project:
-
-    https://launchpad.net/salt-formulas
-
-You can also join salt-formulas-users team and subscribe to mailing list:
-
-    https://launchpad.net/~salt-formulas-users
-
-Developers wishing to work on the salt-formulas projects should always base
-their work on master branch and submit pull request against specific formula.
-
-    https://github.com/salt-formulas/salt-formula-opencontrail
-
-Any questions or feedback is always welcome so feel free to join our IRC
-channel:
-
-    #salt-formulas @ irc.freenode.net
diff --git a/debian/control b/debian/control
index a7de37b..f206b81 100644
--- a/debian/control
+++ b/debian/control
@@ -1,11 +1,11 @@
 Source: salt-formula-opencontrail
-Maintainer: Jakub Pavlik <jakub.pavlik@tcpcloud.eu>
+Maintainer: Mirantis Dev <dev@mirantis.com>
 Section: admin
 Priority: optional
 Build-Depends: salt-master, python, python-yaml, debhelper (>= 9),
  salt-formula-linux, salt-formula-prometheus
 Standards-Version: 3.9.6
-Homepage: https://wiki.openstack.org/wiki/OpenStackSalt
+Homepage: https://www.mirantis.com
 Vcs-Browser: https://github.com/openstack/salt-formula-opencontrail
 Vcs-Git: https://github.com/openstack/salt-formula-opencontrail.git
 
diff --git a/debian/copyright b/debian/copyright
index cc96f85..7656ff2 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -1,12 +1,12 @@
 Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
 Upstream-Name: salt-formula-opencontrail
-Upstream-Contact: Jakub Pavlik <jakub.pavlik@tcpcloud.eu>
+Upstream-Contact: Mirantis Dev <dev@mirantis.com>
 Source: https://github.com/openstack/salt-formula-opencontrail
 
 Files: *
-Copyright: 2014-2016 tcp cloud
+Copyright: 2014-2019 Mirantis Inc. et al
 License: Apache-2.0
-  Copyright (C) 2014-2016 tcp cloud
+  Copyright (C) 2014-2019 Mirantis Inc. et al
   .
   Licensed under the Apache License, Version 2.0 (the "License");
   you may not use this file except in compliance with the License.
diff --git a/metadata.yml b/metadata.yml
index ba3b2d8..a20923f 100644
--- a/metadata.yml
+++ b/metadata.yml
@@ -3,6 +3,6 @@
 source: "https://github.com/openstack/salt-formula-opencontrail"
 dependencies:
 - name: linux
-  source: "https://github.com/salt-formulas/salt-formula-linux"
+  source: "https://gerrit.mcp.mirantis.com/salt-formulas/linux"
 - name: prometheus
-  source: "https://github.com/salt-formulas/salt-formula-prometheus"
+  source: "https://gerrit.mcp.mirantis.com/salt-formulas/prometheus"
diff --git a/metadata/service/client/cluster.yml b/metadata/service/client/cluster.yml
index 3cfd124..337e9d0 100644
--- a/metadata/service/client/cluster.yml
+++ b/metadata/service/client/cluster.yml
@@ -6,6 +6,8 @@
     opencontrail_identity_port: 35357
     opencontrail_identity_version: '2.0'
     openstack_control_address: 127.0.0.1
+    opencontrail_admin_password: 'none'
+    opencontrail_admin_user: 'contrail'
   opencontrail:
     client:
       enabled: True
@@ -16,8 +18,8 @@
         port: ${_param:opencontrail_identity_port}
         version: ${_param:opencontrail_identity_version}
         tenant: admin
-        user: admin
-        password: ${_param:keystone_admin_password}
+        user: ${_param:opencontrail_admin_user}
+        password: ${_param:opencontrail_admin_password}
       api:
         engine: contrail
         host: ${_param:opencontrail_control_address}
diff --git a/metadata/service/client/single.yml b/metadata/service/client/single.yml
index 19f73eb..8d3a509 100644
--- a/metadata/service/client/single.yml
+++ b/metadata/service/client/single.yml
@@ -5,6 +5,8 @@
     opencontrail_version: 3.0
     opencontrail_identity_port: 35357
     opencontrail_identity_version: '2.0'
+    opencontrail_admin_password: 'none'
+    opencontrail_admin_user: 'contrail'
   opencontrail:
     client:
       enabled: True
@@ -15,8 +17,8 @@
         port: ${_param:opencontrail_identity_port}
         version: ${_param:opencontrail_identity_version}
         tenant: admin
-        user: admin
-        password: ${_param:keystone_admin_password}
+        user: ${_param:opencontrail_admin_user}
+        password: ${_param:opencontrail_admin_password}
       api:
         engine: contrail
         host: ${_param:cluster_local_address}
diff --git a/metadata/service/control/analytics.yml b/metadata/service/control/analytics.yml
index b51a1fe..77ad856 100644
--- a/metadata/service/control/analytics.yml
+++ b/metadata/service/control/analytics.yml
@@ -7,7 +7,8 @@
     opencontrail_version: 2.2
     opencontrail_identity_port: 35357
     opencontrail_identity_version: '2.0'
-    keystone_admin_password: 'none'
+    opencontrail_admin_password: 'none'
+    opencontrail_admin_user: 'contrail'
     keystone_service_token: 'none'
     redis_password: 'none'
     openstack_region: RegionOne
@@ -19,7 +20,7 @@
         host: ${_param:cluster_vip_address}
         port: ${_param:opencontrail_identity_port}
         token: '${_param:keystone_service_token}'
-        password: '${_param:keystone_admin_password}'
+        password: '${_param:opencontrail_admin_password}'
       network:
         engine: neutron
         host: ${_param:network_vip_address}
@@ -55,8 +56,8 @@
         region: ${_param:openstack_region}
         host: ${_param:cluster_vip_address}
         port: ${_param:opencontrail_identity_port}
-        user: admin
-        password: '${_param:keystone_admin_password}'
+        user: ${_param:opencontrail_admin_user}
+        password: '${_param:opencontrail_admin_password}'
         token: '${_param:keystone_service_token}'
         tenant: admin
       alarm_gen:
diff --git a/metadata/service/control/cluster.yml b/metadata/service/control/cluster.yml
index d98a19e..399d330 100644
--- a/metadata/service/control/cluster.yml
+++ b/metadata/service/control/cluster.yml
@@ -7,7 +7,8 @@
     opencontrail_version: 2.2
     opencontrail_identity_port: 35357
     opencontrail_identity_version: '2.0'
-    keystone_admin_password: 'none'
+    opencontrail_admin_password: 'none'
+    opencontrail_admin_user: 'contrail'
     keystone_service_token: 'none'
     redis_password: 'none'
     openstack_region: RegionOne
@@ -19,7 +20,7 @@
         host: ${_param:cluster_vip_address}
         port: ${_param:opencontrail_identity_port}
         token: '${_param:keystone_service_token}'
-        password: '${_param:keystone_admin_password}'
+        password: '${_param:opencontrail_admin_password}'
       network:
         engine: neutron
         host: ${_param:cluster_vip_address}
@@ -58,8 +59,8 @@
         region: ${_param:openstack_region}
         host: ${_param:cluster_vip_address}
         port: ${_param:opencontrail_identity_port}
-        user: admin
-        password: '${_param:keystone_admin_password}'
+        user: ${_param:opencontrail_admin_user}
+        password: '${_param:opencontrail_admin_password}'
         token: '${_param:keystone_service_token}'
         tenant: admin
       members:
@@ -124,8 +125,8 @@
         region: RegionOne
         host: ${_param:cluster_vip_address}
         port: ${_param:opencontrail_identity_port}
-        user: admin
-        password: '${_param:keystone_admin_password}'
+        user: ${_param:opencontrail_admin_user}
+        password: '${_param:opencontrail_admin_password}'
         token: '${_param:keystone_service_token}'
         tenant: admin
       alarm_gen:
@@ -189,8 +190,8 @@
         version: ${_param:opencontrail_identity_version}
         host: ${_param:cluster_vip_address}
         port: ${_param:opencontrail_identity_port}
-        user: admin
-        password: '${_param:keystone_admin_password}'
+        user: ${_param:opencontrail_admin_user}
+        password: '${_param:opencontrail_admin_password}'
         token: '${_param:keystone_service_token}'
         tenant: admin
       network:
diff --git a/metadata/service/control/container.yml b/metadata/service/control/container.yml
index 609a448..3d17d2d 100644
--- a/metadata/service/control/container.yml
+++ b/metadata/service/control/container.yml
@@ -40,8 +40,8 @@
                   region: RegionOne
                   host: ${_param:keystone_service_host}
                   port: 35357
-                  user: admin
-                  password: '${_param:keystone_admin_password}'
+                  user: ${_param:opencontrail_admin_user}
+                  password: '${_param:opencontrail_admin_password}'
                   token: '${_param:keystone_service_token}'
                   tenant: admin
         opencontrail-collector:
@@ -99,8 +99,8 @@
                   version: '2.0'
                   host: ${_param:keystone_service_host}
                   port: 35357
-                  user: admin
-                  password: '${_param:keystone_admin_password}'
+                  user: ${_param:opencontrail_admin_user}
+                  password: '${_param:opencontrail_admin_password}'
                   token: '${_param:keystone_service_token}'
                   tenant: admin
                 network:
diff --git a/metadata/service/control/control.yml b/metadata/service/control/control.yml
index d033ccf..58b33fe 100644
--- a/metadata/service/control/control.yml
+++ b/metadata/service/control/control.yml
@@ -7,7 +7,8 @@
     opencontrail_version: 2.2
     opencontrail_identity_port: 35357
     opencontrail_identity_version: '2.0'
-    keystone_admin_password: 'none'
+    opencontrail_admin_password: 'none'
+    opencontrail_admin_user: 'contrail'
     keystone_service_token: 'none'
     openstack_region: RegionOne
     redis_password: 'none'
@@ -19,7 +20,7 @@
         host: ${_param:cluster_vip_address}
         port: ${_param:opencontrail_identity_port}
         token: '${_param:keystone_service_token}'
-        password: '${_param:keystone_admin_password}'
+        password: '${_param:opencontrail_admin_password}'
       network:
         engine: neutron
         host: ${_param:cluster_vip_address}
@@ -58,8 +59,8 @@
         region: ${_param:openstack_region}
         host: ${_param:cluster_vip_address}
         port: ${_param:opencontrail_identity_port}
-        user: admin
-        password: '${_param:keystone_admin_password}'
+        user: ${_param:opencontrail_admin_user}
+        password: '${_param:opencontrail_admin_password}'
         token: '${_param:keystone_service_token}'
         tenant: admin
       members:
@@ -151,8 +152,8 @@
         region: RegionOne
         host: ${_param:cluster_vip_address}
         port: ${_param:opencontrail_identity_port}
-        user: admin
-        password: '${_param:keystone_admin_password}'
+        user: ${_param:opencontrail_admin_user}
+        password: '${_param:opencontrail_admin_password}'
         token: '${_param:keystone_service_token}'
         tenant: admin
       network:
diff --git a/metadata/service/control/single.yml b/metadata/service/control/single.yml
index a63f28a..5c922fe 100644
--- a/metadata/service/control/single.yml
+++ b/metadata/service/control/single.yml
@@ -7,7 +7,8 @@
     opencontrail_version: 2.2
     opencontrail_identity_port: 35357
     opencontrail_identity_version: '2.0'
-    keystone_admin_password: 'none'
+    opencontrail_admin_password: 'none'
+    opencontrail_admin_user: 'contrail'
     keystone_service_token: 'none'
     openstack_region: RegionOne
     redis_password: 'none'
@@ -19,7 +20,7 @@
         host: ${_param:single_address}
         port: ${_param:opencontrail_identity_port}
         token: '${_param:keystone_service_token}'
-        password: '${_param:keystone_admin_password}'
+        password: '${_param:opencontrail_admin_password}'
       network:
         engine: neutron
         host: ${_param:single_address}
@@ -58,8 +59,8 @@
         region: ${_param:openstack_region}
         host: ${_param:single_address}
         port: ${_param:opencontrail_identity_port}
-        user: admin
-        password: '${_param:keystone_admin_password}'
+        user: ${_param:opencontrail_admin_user}
+        password: '${_param:opencontrail_admin_password}'
         token: '${_param:keystone_service_token}'
         tenant: admin
       members:
@@ -104,8 +105,8 @@
         region: RegionOne
         host: ${_param:single_address}
         port: ${_param:opencontrail_identity_port}
-        user: admin
-        password: '${_param:keystone_admin_password}'
+        user: ${_param:opencontrail_admin_user}
+        password: '${_param:opencontrail_admin_password}'
         token: '${_param:keystone_service_token}'
         tenant: admin
       alarm_gen:
@@ -159,8 +160,8 @@
         version: ${_param:opencontrail_identity_version}
         host: ${_param:single_address}
         port: ${_param:opencontrail_identity_port}
-        user: admin
-        password: '${_param:keystone_admin_password}'
+        user: ${_param:opencontrail_admin_user}
+        password: '${_param:opencontrail_admin_password}'
         token: '${_param:keystone_service_token}'
         tenant: admin
       network:
diff --git a/metadata/service/test/single.yml b/metadata/service/test/single.yml
index dcd37d9..a2d101e 100644
--- a/metadata/service/test/single.yml
+++ b/metadata/service/test/single.yml
@@ -3,6 +3,8 @@
 parameters:
   _param:
     opencontrail_identity_port: 35357
+    opencontrail_admin_password: 'none'
+    opencontrail_admin_user: 'contrail'
   opencontrail:
     test:
       enabled: True
@@ -33,9 +35,9 @@
         service_token: ${_param:keystone_service_token}
         service_tenant: service
         admin_tenant: admin
-        admin_name: admin
-        admin_password: ${_param:keystone_admin_password}
-        password: ${_param:keystone_admin_password}
+        admin_name: ${_param:opencontrail_admin_user}
+        admin_password: ${_param:opencontrail_admin_password}
+        password: ${_param:opencontrail_admin_password}
         cacert: '/etc/ssl/certs/ca-certificates.crt'
         bind:
           address: 0.0.0.0
diff --git a/opencontrail/common.sls b/opencontrail/common.sls
index 4a782fc..009ab26 100644
--- a/opencontrail/common.sls
+++ b/opencontrail/common.sls
@@ -97,29 +97,3 @@
 
 /etc/contrail:
   file.directory
-
-{%- if common.identity.engine == "keystone" %}
-/etc/contrail/ctrl-details:
-  file.managed:
-  - source: salt://opencontrail/files/{{ common.version }}/ctrl-details
-  - template: jinja
-  - require:
-    - file: /etc/contrail
-
-{%- if common.version < 3.0 %}
-/etc/contrail/openstackrc:
-  file.managed:
-  - source: salt://opencontrail/files/{{ common.version }}/openstackrc
-  - template: jinja
-  - require:
-    - file: /etc/contrail
-
-/etc/contrail/keystonerc:
-  file.managed:
-  - source: salt://opencontrail/files/{{ common.version }}/keystonerc
-  - template: jinja
-  - require:
-    - file: /etc/contrail
-{%- endif %}
-
-{%- endif %}
diff --git a/opencontrail/files/2.2/contrail-vrouter-agent.conf b/opencontrail/files/2.2/contrail-vrouter-agent.conf
index 0aa2672..1c306d5 100644
--- a/opencontrail/files/2.2/contrail-vrouter-agent.conf
+++ b/opencontrail/files/2.2/contrail-vrouter-agent.conf
@@ -115,6 +115,9 @@
 
 # Maximum flows allowed per VM (given as % of maximum system flows)
 # max_vm_flows=100
+{%- if compute.max_vm_flows is defined %}
+max_vm_flows={{ compute.max_vm_flows }}
+{%- endif %}
 # Maximum number of link-local flows allowed across all VMs
 # max_system_linklocal_flows=4096
 # Maximum number of link-local flows allowed per VM
diff --git a/opencontrail/files/3.0/contrail-vrouter-agent.conf b/opencontrail/files/3.0/contrail-vrouter-agent.conf
index 219561a..9170aee 100644
--- a/opencontrail/files/3.0/contrail-vrouter-agent.conf
+++ b/opencontrail/files/3.0/contrail-vrouter-agent.conf
@@ -161,6 +161,9 @@
 
 # Maximum flows allowed per VM (given as % of maximum system flows)
 # max_vm_flows=100
+{%- if compute.max_vm_flows is defined %}
+max_vm_flows={{ compute.max_vm_flows }}
+{%- endif %}
 # Maximum number of link-local flows allowed across all VMs
 # max_system_linklocal_flows=4096
 # Maximum number of link-local flows allowed per VM
@@ -207,7 +210,11 @@
 # this only if vhost interface is un-numbered in host-os. Agent will use one
 # of the compute_node_address to run services that need IP Address in host-os
 # (like metadata...)
-#compute_node_address = 10.204.216.28
+{%- if compute.bind is defined %}
+compute_node_address={{ compute.bind.address }}
+{%- else %}
+compute_node_address={{ compute.interface.address }}
+{%- endif %}
 
 # We can have multiple gateway sections with different indices in the
 # following format
diff --git a/opencontrail/files/4.0/contrail-vrouter-agent.conf b/opencontrail/files/4.0/contrail-vrouter-agent.conf
index 3d244cc..a0a742b 100644
--- a/opencontrail/files/4.0/contrail-vrouter-agent.conf
+++ b/opencontrail/files/4.0/contrail-vrouter-agent.conf
@@ -168,6 +168,9 @@
 #
 # Maximum flows allowed per VM (given as % of maximum system flows)
 # max_vm_flows=
+{%- if compute.max_vm_flows is defined %}
+max_vm_flows={{ compute.max_vm_flows }}
+{%- endif %}
 
 # Maximum number of link-local flows allowed across all VMs
 # max_system_linklocal_flows=4096
@@ -230,10 +233,8 @@
 # name of virtual host interface
 name=vhost0
 
-{%- if compute.version < 4.1 %}
 # IP address and prefix in ip/prefix_len format
 ip={{ compute.interface.address }}/{{ compute.interface.mask }}
-{%- endif %}
 
 # Gateway IP address for virtual host
 gateway={{ compute.interface.gateway }}
diff --git a/opencontrail/files/4.0/ctrl-details b/opencontrail/files/4.0/ctrl-details
deleted file mode 100644
index 7dac73e..0000000
--- a/opencontrail/files/4.0/ctrl-details
+++ /dev/null
@@ -1,16 +0,0 @@
-{%- from "opencontrail/map.jinja" import common with context %}
-CONTROLLER_MGMT={{ common.identity.host }}
-SERVICE_TOKEN={{ common.identity.token }}
-ADMIN_TOKEN={{ common.identity.password }}
-CONTROLLER={{ common.identity.host }}
-QUANTUM={{ common.network.host }}
-QUANTUM_PORT={{ common.network.port }}
-COMPUTE=None
-AUTH_PROTOCOL=http
-QUANTUM_PROTOCOL=http
-AMQP_SERVER={{ common.identity.host }}
-INTERNAL_VIP={{ common.identity.host }}
-HYPERVISOR=libvirt
-NOVA_PASSWORD={{ common.identity.password }}
-NEUTRON_PASSWORD={{ common.identity.password }}
-SERVICE_TENANT_NAME=service
diff --git a/opencontrail/files/4.0/keystonerc b/opencontrail/files/4.0/keystonerc
deleted file mode 100644
index b665fac..0000000
--- a/opencontrail/files/4.0/keystonerc
+++ /dev/null
@@ -1,4 +0,0 @@
-{%- from "opencontrail/map.jinja" import common with context %}
-export OS_USERNAME=admin
-export SERVICE_TOKEN={{ common.identity.token }}
-export OS_SERVICE_ENDPOINT=http://{{ common.identity.host }}:{{ common.identity.port }}/v2.0
diff --git a/opencontrail/files/4.0/openstackrc b/opencontrail/files/4.0/openstackrc
deleted file mode 100644
index 7c8ef03..0000000
--- a/opencontrail/files/4.0/openstackrc
+++ /dev/null
@@ -1,6 +0,0 @@
-{%- from "opencontrail/map.jinja" import common with context %}
-export OS_USERNAME=admin
-export OS_PASSWORD={{ common.identity.password }}
-export OS_TENANT_NAME=admin
-export OS_AUTH_URL=http://{{ common.identity.host }}:5000/v2.0/
-export OS_NO_CACHE=1