commit d58f4eced249892a897a9bb0a397a2c24fc498de
author Oleg Bondarev <obondarev@mirantis.com> Mon Sep 17 13:46:39 2018 +0400
committer Oleg Bondarev <obondarev@mirantis.com> Mon Sep 17 13:51:05 2018 +0400
tree 16a4abf4a9a39036b69fb125814b4cb662b3b668
parent d6561f8f326e6096bac146119aaab5d38dda2abf

Fix args for update func in  _resource_present()

Update methods are decorated with get_by_name_or_uuid_multiple which
expects resource id (or name) in kwargs with exact <resource_id> key
or as positional arg. _resource_present() was calling update with
name=name which was causing "IndexError: pop from empty list"

The patch fixes the issue by using positional arg.

Change-Id: I9514e1f2d26906e421bbabeb926ebc7bf63e80a3

_states/neutronv2.py

diff --git a/_states/neutronv2.py b/_states/neutronv2.py
index 0ab8248..b4fd30d 100644
--- a/_states/neutronv2.py
+++ b/_states/neutronv2.py
@@ -43,7 +43,7 @@
     try:
         method_name = '{}_update'.format(resource)
         resp = _neutronv2_call(
-            method_name, name=name, cloud_name=cloud_name, **to_update
+            method_name, name, cloud_name=cloud_name, **to_update
         )
     except Exception as e:
         log.exception('Neutron {0} update failed with {1}'.format(resource, e))