tree 1c8cfc39b7f1692e03290ad1d00a9f6e0eeb526c
parent 9dde5280367213b8c46a864ddfe2d13bb1d84f46
author Swann Croiset <scroiset@mirantis.com> 1479718508 +0100
committer Swann Croiset <scroiset@mirantis.com> 1479735441 +0100

Fix the heka grains for the aggregator/remote_collector

Previously, the heka salt grains of the node running aggregator/remote_collector
get all the metric_collector alarms from all nodes (/etc/salt/grains.d/heka).
The resulting mines data is then wrong for the monitoring node, while that
situtation fortunately has no impact regarding metric_collector alarm
configurations, the Nagios service leverging mine data get a wrong list of
alarms for the monitoring node.

This patch fixes the issue with minimal changes but it appears that the logic
behind _service.sls state is not optimal and become hard to understand.
This state is executed several times with different contexts for every heka
'server' types and is not indempotent, indeed the /etc/salt/grains.d/heka file
content is different between 'local' servers (metric|log)_collector and
'remote' servers remote_collector|aggregator.