commit 0d11305adce69a1f64c57871b86582f877e6dd89
author Martin Polreich <polreichmartin@gmail.com> Fri Jun 02 17:13:16 2017 +0200
committer Martin Polreich <polreichmartin@gmail.com> Fri Jun 02 17:15:44 2017 +0200
tree 492469bc00e597e3ddfeb7e339b42fe7d3d188dc
parent 6034f6e75bdcea113a697f27e6df5bc22aacafbe

Optimize noservices condition

etcd/server/service.sls

diff --git a/etcd/server/service.sls b/etcd/server/service.sls
index 3e1fba1..e43f2a0 100644
--- a/etcd/server/service.sls
+++ b/etcd/server/service.sls
@@ -9,10 +9,8 @@
 {%- if server.get('engine', 'systemd') %}
   - require:
     - file: /etc/default/etcd
-  {% if not grains.get('noservices', False) %}
   - watch_in:
     - service: etcd
-  {% endif %}
 {%- endif %}
 
 
@@ -84,10 +82,8 @@
     - group: root
     - require:
       - dockerng: copy-etcd-binaries
-    {% if not grains.get('noservices', False) %}
     - watch_in:
       - service: etcd
-    {% endif %}
 
 {% endfor %}
 
@@ -135,10 +131,8 @@
 {%- else %}
         initial_cluster_state: existing
 {%- endif %}
-    {% if not grains.get('noservices', False) %}
     - watch_in:
       - service: etcd
-    {% endif %}
 
 /var/lib/etcd/:
   file.directory:
@@ -154,14 +148,13 @@
     - require:
       - file: /var/lib/etcd/
 
-{% if not grains.get('noservices', False) %}
-
 etcd:
   service.running:
   - enable: True
   - name: {{ server.services }}
-
-{%- endif %}
+  {% if grains.noservices is defined %}
+  - onlyif: {% if grains.get('noservices', "True") %}"True"{% else %}False{% endif %}
+  {% endif %}
 
 {%- endif %}