Handle test=true option properly
PROD-30531
Change-Id: Id726f941121d13fa9d8f773d0afe6af3fc24b4a8
diff --git a/_states/cinderv3.py b/_states/cinderv3.py
index c35c32d..97a53d0 100644
--- a/_states/cinderv3.py
+++ b/_states/cinderv3.py
@@ -175,7 +175,7 @@
elif signal_create["result"] is None:
ret = {
'name': name,
- 'changes': keys,
+ 'changes': {},
'result': None,
'comment': 'Volume type "{0}" will be updated'.format(name)
}
@@ -188,13 +188,6 @@
}
return ret
-
-def _check_test_mode():
- if __opts__.get('test'):
- return None
- else:
- return True
-
def _succeeded(op, name, resource, changes=None):
msg_map = {
'create': '{0} {1} created',
@@ -206,7 +199,7 @@
}
changes_dict = {
'name': name,
- 'result': _check_test_mode,
+ 'result': None if __opts__.get('test') else True,
'comment': msg_map[op].format(resource, name),
'changes': changes or {},
}