)]}' { "log": [ { "commit": "a79e48874bfe03cf7195474719a85f4633931050", "tree": "f215238894835c47c604a1a3d6ee4871cf154818", "parents": [ "edde04804b3cf6196a6f19d5c08a8df619d7a0e2" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Mar 05 07:51:47 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Mar 05 07:51:47 2008 +0000" }, "message": "TNonblockingServer: Fix wrong exception names\n\nReviewed By: dreiss\n\nTest Plan: trivial :)\n\nRevert: OK\n\nDiffCamp Revision: 8789\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665556 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "edde04804b3cf6196a6f19d5c08a8df619d7a0e2", "tree": "88138f5ef3dce759331bc0018063f3a322ada51e", "parents": [ "631dcb42d1be0896c14e7830a45a5db4e3ee5ef6" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Mar 05 07:51:44 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Mar 05 07:51:44 2008 +0000" }, "message": "Thrift: Add writePtr(), wroteBytes() to TMemoryBuffer\n\nSummary: This adds the discussed interface to TMemoryBuffer, as follows:\n\n - writePtr(size) returns a ptr you can write (size) bytes to\n - wroteBytes() lets it know you wrote that many bytes\n\n To do this, I refactored an:\n - ensureCanWrite(size) private func\n\nReviewed By: dreiss\n\nTest Plan: works in my test environment\n\nRevert: OK\n\nTracCamp Project: Thrift\n\nDiffCamp Revision: 8739\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665555 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "631dcb42d1be0896c14e7830a45a5db4e3ee5ef6", "tree": "acb419cc4700851be4ba223068c6aea7a076b512", "parents": [ "6987535d65529be108f36a51f8a603d675c89e16" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Mar 05 07:51:40 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Mar 05 07:51:40 2008 +0000" }, "message": "Thrift: concurrency/Util.h: Add converters for \u0027struct timeval\u0027, cleanup\n\nSummary: - Added \u0027struct timeval\u0027 toMilliseconds and toTimeval converters modeled on the timespec ones\n - Added constants for microsecs, and got rid of the 500000 and 500 magic #\u0027s :)\n\nReviewed By: dreiss\n\nTest Plan: works in my test env\n\nRevert: OK\n\nDiffCamp Revision: 8742\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665554 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "907ad76c2db1ae834ea8d09a0aca86da008c261f", "tree": "6f11dc1f53508763c46c0f8a39d2f52ed407d406", "parents": [ "2c9824c5bdd3d9aefa0c1edb4538c996e4d513dd" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sun Mar 02 00:25:58 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sun Mar 02 00:25:58 2008 +0000" }, "message": "Adding a few integration points to the C++ TSocketPool.\n\n- Adding ability to use a vector of TSocketPoolServers to construct a TSocketPool\n- Ability to get back the list of TSocketPoolServers\n\nThis is especially useful in multithreaded client code that\nwill just keep around the list of servers, and create the pool\non every request. Since TSocketPool updates the failure stuff,\nwe need a way to get back the updated TSocketPoolServers\n\nReviewed By: aditya\n\nTest Plan: just compiling the code\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665537 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "2c9824c5bdd3d9aefa0c1edb4538c996e4d513dd", "tree": "4c993889000fd0250ed28dbd1e22c986bdb08645", "parents": [ "f50021af668da8a143a5dfd764c5380c0a330a39" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sun Mar 02 00:20:47 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sun Mar 02 00:20:47 2008 +0000" }, "message": "Fix potential out of bounds read issue with getTypeIDForTypeName().\n\nMake sure type name is at least 2 characters long.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665536 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "f50021af668da8a143a5dfd764c5380c0a330a39", "tree": "d0de3891c8db97304b9fa09e15635a0350073f03", "parents": [ "6d0cccd64000ae35ce1e648020f852ba333a5ba2" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Feb 29 07:33:47 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Feb 29 07:33:47 2008 +0000" }, "message": "Bug fix for C++ TSocketPool\n\nWasn\u0027t setting the host or port for each server in the pool on open.\n\nReviewed By: dbraginsky\n\nTest Plan: Just compiled. Will test with dbraginsky\u0027s server.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665535 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "6d0cccd64000ae35ce1e648020f852ba333a5ba2", "tree": "2f72e1d4a8b2b9c7e1101133bbaeacdace3ec630", "parents": [ "9163073ca120478733602d42e344f14c241ad2d1" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Feb 28 21:20:12 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Feb 28 21:20:12 2008 +0000" }, "message": "Fail and retry logic for TSocketPool\n\nSummary: Replicating php logic: If opening fails enough times, mark server as down for some amount of time\n\nReviewed By: aditya\n\nTest Plan: compiling thrift - any good test ideas?\n\nRevert: OK\n\nDiffCamp Revision: 8381\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665534 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "9163073ca120478733602d42e344f14c241ad2d1", "tree": "4b534e4884bca8816381a6301020dfd515dcee11", "parents": [ "1a3546464dcbb4ff59fae50c6463a4ea78d4df74" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Feb 28 21:11:39 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Feb 28 21:11:39 2008 +0000" }, "message": "Fix for JSON Protocol string-reading methods.\n\nClear return-by-reference strings before appending to them\nin the JSON Protocol reading methods.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665533 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "1a3546464dcbb4ff59fae50c6463a4ea78d4df74", "tree": "8aa8810cb9b7269b73a74cfb155ed53b5aa5d18f", "parents": [ "6f3507c42574a6e8a58e10e07c58c3ba434b4e7a" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Feb 28 21:11:34 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Feb 28 21:11:34 2008 +0000" }, "message": "Fix for Base64 decoding.\n\nPreviously, the Base64 decoding table only covered ASCII characters,\nbut the decoding function looked up any character in the table.\nThis change extends the table.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665532 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "01d187cb801a3c0462af337a8f0b6f0e2b1f2ec3", "tree": "89fbf9e6293880ddb7134900f95490ec29f9352d", "parents": [ "3de1c4e4d33cc5c32809771f2bbec746501d1f94" ], "author": { "name": "veeve", "email": "dev-null@apache.org", "time": "Tue Feb 26 05:12:08 2008 +0000" }, "committer": { "name": "veeve", "email": "dev-null@apache.org", "time": "Tue Feb 26 05:12:08 2008 +0000" }, "message": "add increase_max_fds to the new TServer.cpp\n\nSummary: - added TServer.cpp\n - increase_max_fds() defaults to 2^24.\n\nReviewed By: dreiss\n\nTest Plan: - Linked this code into chatloggerd and verified the return value.\n\nRevert: OK\n\nTracCamp Project: Chirp\n\nDiffCamp Revision: 8275\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665500 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "1e62ab468cda132ae29b849d7c1ea4eac141140b", "tree": "f5bda6d453d2d0c45702199ed0f57a857434a887", "parents": [ "215ba5c310dd82b56805982634b346e3f99c6a49" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Feb 21 22:37:45 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Feb 21 22:37:45 2008 +0000" }, "message": "TJSONProtocol no longer uses borrow, and miscellaneous fixes.\n\nSummary:\nAdded a LookaheadReader to the TJSONProtocol so it doesn\u0027t have to\nrely on the transport to borrow.\nAlso added a check to a corner case and fixed up some comments and whitespace.\n\nReviewed By: mcslee\n\nTest Plan: make check\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665491 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "d7a16f4c111599f8b78905df70f0f60af0721e08", "tree": "4cc509319fdbaac889dca4205ca34aba274ad12c", "parents": [ "2845b52f47a361d89434b3234545811e082f7716" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Feb 19 22:47:29 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Feb 19 22:47:29 2008 +0000" }, "message": "Thrift: Add \"#include \u003ccstdlib\u003e\" in a few places and s/malloc/std::malloc/\n\nSummary:\nThere were a few places where we were calling malloc/reallaoc/free without\nincluding cstdlib (or stdlib.h). This is broken, but it worked because\nother headers that we were including included stdlib.h. However, on a\nplatform where this wasn\u0027t true, it broke the Thrift build. This change\nadds the proper includes. It also changes malloc to std::malloc (same\nwith realloc and free) in a few places, because that is the correct way\nof doing it when you include cstdlib.\n\nReviewed By: mcslee\n\nTest Plan: Compiled Thrift.\n\nRevert Plan: ok\n\nOther Notes:\nThis bug was noticed by a Thrudb user, and the patch was sent in by\nRoss McFarland.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665487 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "db0ea15310339c504f37128e49421bba58051933", "tree": "50e25907ca864ba90804ca3754238fdd514dc722", "parents": [ "c005b1b65ed24bba18e843c85b9a2a281bfec265" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Feb 18 01:49:37 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Feb 18 01:49:37 2008 +0000" }, "message": "Thrift: Add a full-featured JSON protocol for C++.\n\nSummary:\nThis change adds a new and exciting protocol to Thrift. It uses\nRFC-compliant JSON as the wire protocol and is fully human readable.\n(once a little whitespace has been inserted.) Unlike the existing\nJSON protocol for Java, which is intended to allow Thrift data to be\ntransferred to scripting languages, this protocol is lossless and fully\nread-write. It was written by Chad Walters of Powerset and reviewed\nby David Reiss.\n\nTested by running make check.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665482 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "c005b1b65ed24bba18e843c85b9a2a281bfec265", "tree": "94f0ec3d3776882ec3364bbfca09183798324890", "parents": [ "9ff3b9d5fc823fdc0d25cb3e034b00d098ebbdda" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Feb 15 01:38:18 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Feb 15 01:38:18 2008 +0000" }, "message": "Thrift: Distinguish between string and binary types in C++ and Java.\n\nSummary:\nThe upcoming TJSONProtocol handles string and binary types quite differently.\nThis change makes that distinction in all parts of the C++ binding.\n\nJava already distinguished between string and binary, but this change\nalso updates the Java skip method to skip over strings as binary\nso we don\u0027t get encoding errors when skipping binary data.\n\nReviewed By: mcslee\n\nTest Plan: make check\n\nRevert Plan: ok\n\nOther Notes:\nI just pulled this out of Chad Walters\u0027 JSON patch.\nThe only other change was adding readBinary (or was it writeBinary)\nto TDenseProtocol. Maybe inheriting from TBinaryProtocol wasn\u0027t a good idea.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665481 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "a8de4895f61196d6bf139c3becbad5800b977e1c", "tree": "f72134854794ffffcc3de95164dee0705b54c650", "parents": [ "3c5d2fd9a87f3bdb07aac7afa2c50e5e90d88fa8" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Sat Feb 09 00:02:26 2008 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Sat Feb 09 00:02:26 2008 +0000" }, "message": "Patch from Ross McFarland to compile with strict warnings\n\nSummary: Use comment trick in params that are unused to prevent warnings\n\nReviewed By: dreiss\n\nTest Plan: Generate C++ code and compile -W -Wall\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665469 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "0c90f6f8af1d64ec9272bb2f6092336f3d0b8df8", "tree": "15245f459a76acc769d8fe99179176b4965bf66d", "parents": [ "3160971286aea0d5b28d5a7a87acaa8a12209ef8" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Feb 06 22:18:40 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Feb 06 22:18:40 2008 +0000" }, "message": "Thrift: Whitespace cleanup.\n\nSummary:\n- Expanded tabs to spaces where spaces were the norm.\n- Deleted almost all trailing whitespace.\n- Added newlines to the ends of a few files.\n- Ran dos2unix on one file or two.\n\nReviewed By: mcslee\n\nTest Plan: git diff -b\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665467 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "f7baf549bcea8793f7882eb7e01cb3affaea97b8", "tree": "b09ef9b309f15139699de5a417612121033d97bb", "parents": [ "adb5cad7d32c1dd2f11b18b8d0f14b6955df3606" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Feb 04 21:56:27 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Feb 04 21:56:27 2008 +0000" }, "message": "Thrift: Revamp TMemoryBuffer constructors.\n\nSummary:\nThere were some weird cases where the implicit conversion from\nconst char* to std::string was causing the wrong constructor to be called.\nThere wasn\u0027t really a clean workaround, so we\u0027re dropping the string\nconstructors.\n\nReviewed By: mcslee\n\nTest Plan:\nRan the test.\nGrepped around the /projects tree for uses that had to fixed,\nand fixed them.\n\nRevert Plan: ok\n\nOther Notes:\nThis risk was pointed out by Ben Maurer.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665461 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "20f009d6251af0f838c4ef8799d6b238cd230606", "tree": "35b26d27d4c7326e20947ef49c030c512dca4e4f", "parents": [ "46379900138403d9012cc504d9143d971920ec91" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Feb 04 19:24:00 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Feb 04 19:24:00 2008 +0000" }, "message": "Thrift: Forgot to dereference a pointer.\n\nSummary:\nThis didn\u0027t get updated when the interface changed,\nand the cast silenced the warning message. Stupid C.\n\nReviewed By: mcslee\n\nTest Plan: Trust Chad Walters.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665457 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "f495f367c9d7dd89c15b9732a7ac8d0db43596bf", "tree": "7d3510adfb14a0b9f45c3281e43d05b53344e711", "parents": [ "d46eb09befca3e43b01a00476611c7a0c0fc0254" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sat Feb 02 00:54:55 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sat Feb 02 00:54:55 2008 +0000" }, "message": "Thrift: Make borrow (almost) always succeed for TBufferedTransport.\n\nChad Walters is writing a JSON protocol for Thrift, but he wants\nborrow to always succeed. That would be a pain to implement,\nbut here is a first step: borrow will almost always work with\nTBufferedTransport.\n\nReviewed by: mcslee\n\nTest Plan: Ran the DenseProtocol test and Zlib test, but more needs to be done.\n\nOther Notes:\nAlso reviewed by Chad Walters, and maybe Ben Maurer.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665455 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "d46eb09befca3e43b01a00476611c7a0c0fc0254", "tree": "dfd7091441c87b5a760c56a6bcc2cd9e0789c931", "parents": [ "84e5022bfc9a815ce5f14e6effd980c6672da872" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sat Feb 02 00:54:48 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sat Feb 02 00:54:48 2008 +0000" }, "message": "Thrift: Update the interface for TTransport\u0027s \"borrow\" method.\n\nSummary:\nI don\u0027t know what I was thinking when I first wrote this.\nIt makes sense that the transport might not want to allocate its own memory,\nso the protocol is expected to provide a buffer for the data.\nHowever, if the transport already has the data buffered,\nthere is no need to memcpy it; it can just return a pointer into its buffer.\nThe new interface still requires the protocol to provide a buffer,\nbut allows the transport to return a pointer to an interal buffer.\nIn addition, I made len a pass-by-pointer parameter so that\nthe transport can return more than the requested data if it has it\navailable in its buffers.\n\nReviewed By: mcslee\n\nTest Plan: Ran the DenseProtocol test and the Zlib test.\n\nRevert Plan: ok\n\nOther Notes:\nAlso got this reviewed by Chad Walters from Powerset.\nBen Maurer suggested making len a reference parameter.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665454 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "2e8a8d40951ba3708ddb377e90e34b270bfc5446", "tree": "1a13a01d6dec6f6b69f40477a193199fd0df9b68", "parents": [ "1c99140ec009fad8e8e03e9896ed078fabee7c98" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Jan 16 00:38:20 2008 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Jan 16 00:38:20 2008 +0000" }, "message": "Make sure exceptinos in servers are caught\n\nSummary: There was potential for a write exception in close() because it might call flush() internally\n\nReviewed By: dreiss\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665430 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "e8abada6ad63306c38d2107601a5645ff8f1d22c", "tree": "22ddba2ae5d0353aeee37a674c011f7154c233a0", "parents": [ "7ab31e4fd1bf3c6389d1743ee0e8554aa8b97ad4" ], "author": { "name": "pfung", "email": "dev-null@apache.org", "time": "Sat Jan 05 23:23:53 2008 +0000" }, "committer": { "name": "pfung", "email": "dev-null@apache.org", "time": "Sat Jan 05 23:23:53 2008 +0000" }, "message": "[Thrift] disabling catching general type exceptions in Tthreadpoolserver\n\nthe threadpoolserver should just crash if an unknown exception type is thrown.\n\nThis should probably be true for all server types, will put this on the TODO list.\n\nreviewed by jwang\ntest plan: network selector servers in production\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665412 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "832b262acab7656ce5d5541f010c29f060580693", "tree": "8fecf364acbfb94a60a1bcf929f8f891e5130510", "parents": [ "65704511459cdfc0f3e7d70b5008ea4e18a6f538" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Dec 28 18:25:33 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Dec 28 18:25:33 2007 +0000" }, "message": "Thrift: Revamp build to use a single configure.ac.\n\nSummary:\nBen Maurer suggested that it would make sense for Thrift to build as\na single project, with one configure.ac and multiple Makefile.am.\nHe was also kind enough to do the heavy lifting, and this commit\nis the application of his patch (with minor modifications).\nThe most significant visible change from this diff is that\nin order to buidl one of the thrift sub-projects (i.e.: the compiler,\nthe C++ library, or the Python library) you must run bootstrap.sh\nand configure in the Thrift root, then make in the specific project.\nUsers who want to build and install the Python library but\ncan\u0027t run configure because they don\u0027t have Boost can simply\nrun setup.py directly.\n\nReviewed By: mcslee\n\nTest Plan: Built Thrift from scratch.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665409 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "4b6ff2dabcc67b437f9fb9e6930cb4705bd936df", "tree": "69506044310a25eca841ac4ddfac9088bcd2d171", "parents": [ "f845b7d3e097097446067b3a0bc96c6dc85008ca" ], "author": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Tue Dec 25 22:58:50 2007 +0000" }, "committer": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Tue Dec 25 22:58:50 2007 +0000" }, "message": "-- Allow ThreadPoolManager tp return immediately from addTask\n\nSummary:\n- it should be possible to specify a zero timeout if the pendingTaskQueue\n is already full\n\nReviewed By: marc\n\nTest Plan:\n- Tested in search\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665406 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "16cf270283cd08e53467baa765b05c0427a4f5b8", "tree": "ffa1212f0dd77b34bea3fd2f2d05d35528e2c258", "parents": [ "eaa61e43630c68ee2e98f7b649047e45c524f9d8" ], "author": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Fri Dec 21 07:07:31 2007 +0000" }, "committer": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Fri Dec 21 07:07:31 2007 +0000" }, "message": "[thrift] Make TTransportException::getType const throw()\n\nSummary: const so that catching via \"catch (const TTransportException\u0026 e)\" works\n properly, and throw() for good convention.\nReviewed By: mcslee\nTest Plan: still compiles\nRevert: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665403 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "eaa61e43630c68ee2e98f7b649047e45c524f9d8", "tree": "c0aac25d067e39e31e0f5e6bcbb5b9ca378e7356", "parents": [ "97264864df4e7c14d8a4323af6ad37e726c52ef9" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Dec 20 21:42:05 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Dec 20 21:42:05 2007 +0000" }, "message": "Thrift: A hack to prevent incorrect usage of Mutex Guards.\n\nReviewed By: boz\n\nTest Plan:\ndreiss@dreiss-vmware:safe_concurrency:thrift/test$ nl -ba guard_test.cc\n 1 #include \"../lib/cpp/src/concurrency/Mutex.h\"\n 2 using facebook::thrift::concurrency::Guard;\n 3 void test() {\n 4 facebook::thrift::concurrency::Mutex m;\n 5 Guard(m);\n 6 Guard g1(m);\n 7\n 8 facebook::thrift::concurrency::ReadWriteMutex rwm;\n 9 facebook::thrift::concurrency::RWGuard(m);\n 10 facebook::thrift::concurrency::RWGuard g2(rwm);\n 11 }\ndreiss@dreiss-vmware:safe_concurrency:thrift/test$ g++ -c guard_test.cc\nguard_test.cc: In function ‘void test()’:\nguard_test.cc:5: error: ‘incorrect_use_of_Guard’ was not declared in this scope\nguard_test.cc:9: error: ‘incorrect_use_of_RWGuard’ is not a member of ‘facebook::thrift::concurrency’\ndreiss@dreiss-vmware:safe_concurrency:thrift/test$\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665402 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "adad4ab20356d4c16f2df521b205aae7272c105f", "tree": "300dfb6d00a841773f2df1876b5d05d971023436", "parents": [ "15457c9b08a75e0b5a8c82936151468bddfd27b8" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Dec 14 20:56:04 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Dec 14 20:56:04 2007 +0000" }, "message": "Thrift: Fix dangling pointer errors and make messages a bit more uniform.\n\nReviewed By: mcslee\n\nTest Plan: Honestly, just built the library.\n\nRevert Plan: ok\n\nOther Notes:\nThanks to Ben Maurer.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665392 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "77a31384b89683f7cb5ae7132ca3961a88886793", "tree": "ced9915210d1b920fb93284cf07375b96cad10e5", "parents": [ "78ee85c911891231030f2045cb17f98530abf9d9" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Dec 13 22:47:33 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Dec 13 22:47:33 2007 +0000" }, "message": "Use HAVE_SYS_TIME_H instead of HAVE_CLOCK_GETTIME\n\nSummary: Still need the right include here\n\nReviewed By: mcslee\n\nTest Plan: Paul Saab used this fix to build on Leopard\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665390 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "78ee85c911891231030f2045cb17f98530abf9d9", "tree": "445175e08e8935d897b93163c3bab81698d8ee71", "parents": [ "ae3804f8f7941102d42230a59879dbec8f076223" ], "author": { "name": "pfung", "email": "dev-null@apache.org", "time": "Thu Dec 13 22:30:47 2007 +0000" }, "committer": { "name": "pfung", "email": "dev-null@apache.org", "time": "Thu Dec 13 22:30:47 2007 +0000" }, "message": "[Thrift] message debugging for std::exceptions\n\nstd::exceptions did not have debug messages printed\n\nreviewed by dreiss\ntest plan: compiles\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665389 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "ae3804f8f7941102d42230a59879dbec8f076223", "tree": "c6e391b51b59254e25a8003e0383d277afe00f61", "parents": [ "c31769cceb013d947c2349f21285dfaf90d83fe2" ], "author": { "name": "James Wang", "email": "jwang@apache.org", "time": "Thu Dec 13 19:46:27 2007 +0000" }, "committer": { "name": "James Wang", "email": "jwang@apache.org", "time": "Thu Dec 13 19:46:27 2007 +0000" }, "message": "Fix to TThriftTransport corruption detection\n\nSummary: O_APPEND means that even if the file pointer is in the middle of the file, the next write will go to the end of the file. So when initializing the TThriftTransport to be written to, we need to truncate the file after the last good event. I\u0027m pretty sure this was what was causing queuemap log corruption when the multiplexer is restarted.\n\n The corruption doesn\u0027t necessarily go away at the next chunk boundary because of the offset being recalculated. I think it\u0027s good to have the offset recalculated, but then we shouldn\u0027t use the old chunk boundary data there, but rather use the newly calculated offset to determine the padding (could be an entire chunk, but that\u0027s okay -- way better than corruption)\n\nReviewed By: mcslee\n\nTest Plan: Wrote to a ThriftFile using local scribe instance. Printed it. Then cat\u0027d garbage to it from the command line. Then wrote to it again. Then printed it again. Seems to work fine, whereas with old scribe binary the later entries were corrupted.\n\nRevert: OK\n\nDiffCamp Revision: 4683\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665388 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "c31769cceb013d947c2349f21285dfaf90d83fe2", "tree": "c44fc12e94898f77a0ba5189e763c9277c91d297", "parents": [ "5d1784a7b41939e2ac09005c688b5d8165e3b323" ], "author": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Tue Dec 11 22:23:51 2007 +0000" }, "committer": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Tue Dec 11 22:23:51 2007 +0000" }, "message": "-- better error checking for setRecvTimeout and setSendTimeout\n\nSummary:\n- could help prevent a 2.6.13 kernel bug\n\nReviewed By: mcslee, dreiss\n\nTest Plan:\n- Testing kernel crashes\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665387 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "5d1784a7b41939e2ac09005c688b5d8165e3b323", "tree": "802c0eb8384242e91a09037a01d2e8018fa66cde", "parents": [ "3f14d3ebec2028bbacbeb0991b236152f2912d1b" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Dec 05 23:20:54 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Dec 05 23:20:54 2007 +0000" }, "message": "Failing to init eventBase_ to NULL in one constructor\n\nReviewed By: dreiss\n\nTest Plan: See if scribe works for powerset\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665386 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "c37b4c5193c344d6827a197bb86c718b42d74e47", "tree": "e4abf0f936a4f47a5598aa1992c1ec1dcca72a4a", "parents": [ "2323cf642226468e6363b031fad6d9f64a45cb9f" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Dec 05 23:03:37 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Dec 05 23:03:37 2007 +0000" }, "message": "Remove unnecessary mutex from C++ socket code\n\nSummary: This is a threadsafe syscall, as it turns out.\n\nReviewed By: hzhao\n\nTest Plan: Thrift Client C++ sockets don\u0027t lock\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665384 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "2323cf642226468e6363b031fad6d9f64a45cb9f", "tree": "0a5c012af4174f85a6397cd949b8a3a29cb7f88a", "parents": [ "ef22dc652fbfaa7b7c718f752f2ca5b1fecdf94e" ], "author": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Wed Dec 05 03:40:19 2007 +0000" }, "committer": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Wed Dec 05 03:40:19 2007 +0000" }, "message": "[thrift] Better default TApplicationException messages\n\nSummary: \"Default TApplicationException\" is pretty meaningless; if we have this\n extra type information, we might as well present it.\n\nReviewed By: mcslee\nTest Plan: caught a couple of INVALID_MESSAGE_TYPE tapplicationexceptions\nRevert: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665383 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "ef22dc652fbfaa7b7c718f752f2ca5b1fecdf94e", "tree": "6c2c0d3a89436d4d4c602e9a15993dd6f08c557b", "parents": [ "9860ee2c86971cbbc1d2593ad67f8ea5bbf2aaa5" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Nov 30 20:38:49 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Nov 30 20:38:49 2007 +0000" }, "message": "Thrift: Make some server methods public.\n\nReviewed By: mcslee\n\nTest Plan: Compiles.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665382 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "b16074d53bd7b66d1e34dc6623637d59be717db5", "tree": "bbd9d04e144848717897bf23f35bd142ffb13289", "parents": [ "d0f5b28835d80fc9a0f7bdb61e88e32b98a911c0" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Nov 28 05:54:33 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Nov 28 05:54:33 2007 +0000" }, "message": "Add pkgconfig to Thrift C++ libraries\n\nReviewed By: mcslee\n\nOther Notes: Submitted by Ben Maurer\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665377 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "b4d3e7b052c960a5ab96310f7cb16ba46e6d32b4", "tree": "146204125b41bf5ae4f186bd767b21941522eac1", "parents": [ "b45529269934a053b03528e287e66812e1109ad3" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Nov 28 01:51:43 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Nov 28 01:51:43 2007 +0000" }, "message": "Create a TServerEventHandler interface in TServer\n\nSummary: Such that users can supply an event handler to a server that will be used to signal various events that take place inside the server core.\n\nReviewed By: dreiss\n\nTest Plan: Rebuilt all servers, work by default\n\nOther Notes: Partially submitted and also reviewed by Dave Simpson at Powerset\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665371 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "b45529269934a053b03528e287e66812e1109ad3", "tree": "fa7700a9706bd25b1370a3d20954ee47959bd08e", "parents": [ "fe6ed0dff423a405fabd61e4bef3e490506ba2ba" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Nov 28 00:12:11 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Nov 28 00:12:11 2007 +0000" }, "message": "Add a few utility methods and helpers to Thrift C++ Sockets\n\nSummary: Submitted by Dave Simpson @ Powerset.\n\nReviewed By: mcslee\n\nTest Plan: test/cpp\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665370 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "256bdc444866b90bbdccfb5343e9c9ea8c22603c", "tree": "4348ac98f2cf36305bbddfca45686a40e097093d", "parents": [ "844ac12489600d7647f01ab4f9b99d9e1b81e69e" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 27 08:42:19 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 27 08:42:19 2007 +0000" }, "message": "IPv6 tweaks for Thrift\n\nSummary: Need to pass hints including AI_ADDRCONFIG to getaddrinfo to make sure no IPv6 addresses come back on non-IPv6 enabled systems\n\nReviewed By: mcslee\n\nOther Notes: Submitted by Paul Saab\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665368 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "79b1694043e07a673c343c42ad75d72f3b560539", "tree": "617cb13f6ab9b974ded27479c7579b732907bd08", "parents": [ "7962223ce299bbeb20348b3819a423a72efa2335" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon Nov 26 19:05:29 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon Nov 26 19:05:29 2007 +0000" }, "message": "Refactor TNonblockingServer to use event_base construct\n\nSummary: This allows the event loop to be shared across different components of a program of for a separate thread in a TNonblockingServer to safely use its own libevent code without conflicts.\n\nReviewed By: mcslee\n\nTest Plan: Updated test/ committed here\n\nOther Notes: submitted by Ben Maurer, patched in by mcslee with slight modifications\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665364 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "fb4b514028ed073302ffa8d3dcbfba3a89b427f0", "tree": "2ef7120fc936e0dfd3f78bbdd1ef089e34bc8b62", "parents": [ "b6014f494f41ecee4f8e1c7264e99a883805e99f" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 20 01:27:08 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 20 01:27:08 2007 +0000" }, "message": "IPv6 support for the TNonBlockingServer\n\nSummary: Need to use IPv6 compliant constructs here. Submitted by Paul Saab.\n\nReviewed By: dreiss\n\nTest Plan: Rebuild Thrift TNonblockingServer with this patch and verify behaves just the same\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665353 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "3788038a3564e131372b3e54832d513dcc36917f", "tree": "8c48456d8d15b31b21175b8773a8b24c125b66dc", "parents": [ "0502e61fb99d4aab9717e2ba42ac6d9987ea5e2d" ], "author": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Tue Nov 06 06:33:06 2007 +0000" }, "committer": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Tue Nov 06 06:33:06 2007 +0000" }, "message": "-- ensure that flush is called in close() of any wrapper transport\n\nSummary:\n- unflushed data should be flushed when transport is closed\n- this diff calls flush for TBufferedTransport and TFramedTransport\n\nReviewed By: dreiss\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665323 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "14b0ed6fad8fab2a22595f6a2a0407cf1b211763", "tree": "82c438f8426124c8d5298373827f9e5c4a172603", "parents": [ "2b9ddab14cf8bc64e50e3f2cf2334b9503b60866" ], "author": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Fri Oct 19 01:03:32 2007 +0000" }, "committer": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Fri Oct 19 01:03:32 2007 +0000" }, "message": "[thrift] TSocket host and port getters\n\nSummary: \"Porting\" this feature from PHP; I find it useful in the Synapse client.\nReviewed By: mcslee\nTest Plan: It compiles, ship it!\nRevert: svn\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665304 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "2b9ddab14cf8bc64e50e3f2cf2334b9503b60866", "tree": "3ae2c7dcee501a9efb0e164c276af714af85b8f7", "parents": [ "65e595f54fb188b112ef050fbd56914b509f7b2e" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Oct 17 03:39:55 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Oct 17 03:39:55 2007 +0000" }, "message": "Thrift: Kill a warning.\n\nSummary:\nThese should always have been const.\n\nReviewed By: mcslee\n\nTest Plan:\nRe-ran the dense protocol test.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665303 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "d1372829e65dcca66ab0ca75a20919e76bbf7fc9", "tree": "410e4bd08e9febf46b94a40b0cbb8727b50999d4", "parents": [ "34b2926d5ca9b6068fa863e7d5e0a4055cbbef30" ], "author": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Tue Oct 09 22:57:23 2007 +0000" }, "committer": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Tue Oct 09 22:57:23 2007 +0000" }, "message": "[thrift] TSocketPool::addServer, c++ version\n\nSummary: Same thing as the previous PHP change. Also includes a new constructor for easy building of a TSocketPool with a single host (for later filling in via addServer) without extra std::vector boxing/unboxing.\n\nReviewed By: mcslee\n\nTest Plan: Synapse c++ client at r62896 uses this.\n\nRevert: OK\n\nTracCamp Project: Thrift\n\nDiffCamp Revision: 909\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665297 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "145429602687d1785c485bcd1ea9dcd83f28bda4", "tree": "ab61887bb062628587ca928e29bfd33693ff9d15", "parents": [ "73e3dd7d5fdd30301816982d2cd6a961380538ac" ], "author": { "name": "yunfang", "email": "dev-null@apache.org", "time": "Wed Oct 03 22:59:41 2007 +0000" }, "committer": { "name": "yunfang", "email": "dev-null@apache.org", "time": "Wed Oct 03 22:59:41 2007 +0000" }, "message": "[Explicitly declare shared_ptr]\nSummary:\njust some simple styling changes. moving using boost::shared_ptr to .cpp\n and using the full path name in .h\nReviewed by: boz, dreiss\nTest Plan: compiled and tested on the adfinder\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665289 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "19cee90ca41922a4437d547a2298201359bbcdcc", "tree": "b39d2712ba039decb838237549fdb846432e0b63", "parents": [ "623096780fa745658e6336390c8e45bfd1f28d24" ], "author": { "name": "boz", "email": "dev-null@apache.org", "time": "Sat Sep 22 23:08:11 2007 +0000" }, "committer": { "name": "boz", "email": "dev-null@apache.org", "time": "Sat Sep 22 23:08:11 2007 +0000" }, "message": "THRIFT: Make the mutex assignable\n\nSummary: we need to use a shared_ptr instead of an old fashioned one if we\u0027re\ngoing to stick with this PIMPL model\n\nReviewed By: dreiss, marc\n\nTest Plan: test program didn\u0027t fail or leak memory, foreman (fb303 client)\nworked without problem\n\nRevert Plan: just make sure you find some other solution to this problem\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665280 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "623096780fa745658e6336390c8e45bfd1f28d24", "tree": "bf9bd7b0ccf89b632afccff4b1f69c2b060d4724", "parents": [ "aa3c5a882c747a7686fc3dac8f7a5572cc55cdfd" ], "author": { "name": "boz", "email": "dev-null@apache.org", "time": "Thu Sep 20 23:24:16 2007 +0000" }, "committer": { "name": "boz", "email": "dev-null@apache.org", "time": "Thu Sep 20 23:24:16 2007 +0000" }, "message": "THRIFT: Mutex and ReadWriteMutex leaked memory, now they don\u0027t\n\nSummary: also added myself to CONTRIBUTORS.\n\nReviewed By: marc\n\nTest Plan: the following program no longer leaks memory (valgrind):\n\nint main(int argc, char **argv){\n Mutex mu;\n mu.lock();\n mu.unlock();\n}\n\nRevert Plan: ok\n\nNotes: this is kind of important\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665279 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "b72d19f653878dddfe09d01082dad3f077ecf95a", "tree": "c36fec3a5ec85072c64a70a12e07b94619f18265", "parents": [ "93a0664affc0805d11c9d69ae9989e96f2700842" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Sep 18 19:46:00 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Sep 18 19:46:00 2007 +0000" }, "message": "Thrift: Prep for release.\n\nSummary:\n- make dist is no fun. Had to add a lot of stuff to Makefile.am to\n make sure stuff got included in the tarball.\n- Added a permanent NEWS file with the release notes for this release.\n- clean.sh removes ylwrap also.\n- Gave it a real version for make dist.\n- Added ACLOCAL_AMFLAGS to lib/cpp/Makefile.am to make it easier to\n work on configure.ac.\n- Made concurrency_test a non-installed binary because\n no one wants to install it.\n- Dropped some symlinks that were annoying make dist.\n- Updated README.\n\nTest Plan:\n./bootstrap.sh \u0026\u0026 ./configure \u0026\u0026 make dist\nCompared contents of tarball to source tree.\nDid this from a fresh git tree so no gross untracked files would be around.\nOn devrs: ./bootstrap.sh \u0026\u0026 ./configure \u0026\u0026 make install DESTDIR\u003d/tmp/relinst1\nMade sure concurrency_test was built but not installed.\nChecked zlib URL with firefox.\n\nReviewed By: mcslee\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665274 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "faebedd356985c3b2df5e39e1cf5b152c29fc179", "tree": "ed22638b9d0e355fd9db1ba9d0f4f6045f6f9610", "parents": [ "f84b360d5c593653a3f038d526797805861b8ace" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Sep 17 23:20:38 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Sep 17 23:20:38 2007 +0000" }, "message": "Thrift: Re-committing zlib.\n\nSummary:\nSame as the last (reverted) zlib patch,\nbut this time with way more awesome support for building\nwith no zlib headers installed.\n\nReviewed By: mcslee\n\nTest Plan:\n- Did lots of really pathological stuff in my VMware.\n- On devrs004:\n ./bootstrap.sh \u0026\u0026 ./configure \u0026\u0026 make \u0026\u0026 make install DESTDIR\u003d/tmp/tzinst \u0026\u0026 echo \"Yay\"\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665269 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "79ae0f8d485a568ce94be9f86a2aa5f143856dda", "tree": "95c5f6646d253458157da32722db0c31c4999d83", "parents": [ "476b796fd7d4d7036a106682ebcb73a63349b408" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Sep 17 21:15:47 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Sep 17 21:15:47 2007 +0000" }, "message": "Thrift: Compile without libevent.\n\nSummary:\n- Totally re-did the libevent check.\n- Thrift now compiles and instals cleanly without libevent.\n- (libevent is still needed to build libthriftnb.)\n\nReviewed By: mcslee\n\nTest Plan:\n- Ran configure and make in various configurations in my VMware.\n- Clean build and install of Thrift on devrs004 (into /tmp).\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665267 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "fd7c26fec0ed25e5f6e134c7788258082723ee2c", "tree": "96bf20196c667405287e3456747e3bf03603f008", "parents": [ "df72c01c37f4404df65971b5e538c4a47985bf81" ], "author": { "name": "Martin Kraemer", "email": "martin@apache.org", "time": "Mon Sep 17 06:58:47 2007 +0000" }, "committer": { "name": "Martin Kraemer", "email": "martin@apache.org", "time": "Mon Sep 17 06:58:47 2007 +0000" }, "message": "Thrift - typo in comment\n\nSummary:\nNot really worth notice. Just fixing some stray uppercase chars in a comment block.\n\nTrac Bug: #\n\nBlame Rev:\n\nReviewed By:\n\nTest Plan:\n\nRevert Plan:\n\nDatabase Impact:\n\nMemcache Impact:\n\nOther Notes:\n\nEImportant:\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665265 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "5aea7c8d00b1c25fc6611c217d929c61cddd843e", "tree": "261601c8faa3c9bdb93de0d24c9e3c8226e16816", "parents": [ "b8c6334d99acdc36eda81a1105f7760fd16cb3e5" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sat Sep 15 01:54:56 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sat Sep 15 01:54:56 2007 +0000" }, "message": "Thrift: Reverting TZlibTransport\n\nSummary:\nStupid Red Hat.\nThe dev boxes don\u0027t have the development packages for zlib.\n\nBlame Rev: 59856\n\nReviewed By: mcslee\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665263 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "b8c6334d99acdc36eda81a1105f7760fd16cb3e5", "tree": "02301766af0b034a2126cc6e46a1e37bcacbf242", "parents": [ "3d029786cda9ecc549e57c0a9a07bfaa454cb34d" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sat Sep 15 01:44:47 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sat Sep 15 01:44:47 2007 +0000" }, "message": "Thrift: Zlib transport.\n\nSummary:\nAdd a new transport to the C++ library: TZLibTransport.\nThis wraps another transport (just like TBufferedTransport),\ncompresses the data written to it, and uncompresses the data it reads.\n\nReviewed By: mcslee\n\nTest Plan:\nFor ax_lib_zlib.m4\n - Ran ./bootstrap.sh.\n - Looked at configure.\n - Ran ./configure.\n - Looked at config.status\n - Ran ./configure --with-zlib\u003d/usr.\n - Looked at config.status\n - Changed configure.ac to AC_LIB_ZLIB(1.2.4)\n - Ran ./configure.\n - Watched it fail.\n\nFor TZlibTransport\n - test/ZlibTest.cpp\n - Code coverage (hotness) report sent with review.\n - 100% line coverage for all the good stuff.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665262 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "ce161a96cddbea8916d0b20406b12d96772482ed", "tree": "deb35caa60008c44d04468e3d8f3298e89e1fd11", "parents": [ "8775c73db2729f85fd66e2c8443a3628fd55a972" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Sep 11 22:09:42 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Sep 11 22:09:42 2007 +0000" }, "message": "Thrift: Clean up and test TDenseProtocol\n\nSummary:\n- TDenseProtocol now includes a part of the struct fingerprint in\n the serialized message, to protect from unserialzing trash.\n- A lot of cleanups and commenting for TDenseProtocol.\n- A lot of test cases for same.\n\nReviewed By: mcslee\n\nTest Plan: test/DenseProtoTest.cpp\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665257 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "e67c0e63b315873aba8fb6770821fc88bd276a74", "tree": "09b34bc3722012fe7489032f4a614006dd9604f4", "parents": [ "d8429fcc1020dec143e36dbfc055edbd3009f11b" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Sep 07 01:34:12 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Sep 07 01:34:12 2007 +0000" }, "message": "Thrift: TDenseProtocol using variable-length integers.\n\nReviewed By: mcslee\n\nTest Plan:\ntest/DenseProtoTest.cpp\n\nStill have to test:\n- Bounds checking.\n- borrow/consume on TBuffered and TFramed.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665252 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "d8429fcc1020dec143e36dbfc055edbd3009f11b", "tree": "42289b730c46428d53483c84cf3a723e208d0564", "parents": [ "2c2e6d27a238746a0db9982cc4eb35c093553361" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Sep 07 01:26:30 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Sep 07 01:26:30 2007 +0000" }, "message": "Thrift: New methods for C++ transports.\n\nSummary:\nTo support the upcoming variable-length encoding of integers in\nTDenseProtocol, augment Thrift transports with two new methods:\nborrow and consume. Borrow copies some data out of the transport\nwithout consuming it, and consume... consumes it.\n\nReviewed By: mcslee\n\nTest Plan:\nThrift compiles.\nShould check in variable-length integer code for TDenseProtocol\nright after this (git ruulz).\n\nRevert Plan: revert stuff that uses these methods also.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665251 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "4529c4b394d39900e1b50f6be08ba31553550c0d", "tree": "595cdd666af3a97b4ada02932f51d2bd33dba1ea", "parents": [ "d683219966237417297e8f0b24e6c8fce166c490" ], "author": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Wed Sep 05 01:01:15 2007 +0000" }, "committer": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Wed Sep 05 01:01:15 2007 +0000" }, "message": "-- adding hostinfo and time to GlobalOutput\n\nSummary:\n- makes thrift errors a lot more useful\n\nReviewed By: jwang, mcslee\n\nTest Plan: tested with search\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665249 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "4e7530d4e5eaee2ba54d67d2b096c7e705bb53ce", "tree": "dd17427ed417d8a1aff25ba6a01d6029cb539023", "parents": [ "47557bc8ad061a90c88d485979009c2ee8237854" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Sep 04 21:49:53 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Sep 04 21:49:53 2007 +0000" }, "message": "Thrift: TDenseProtocol.\n\nSummary:\n- Made some stuff in TBinaryProtocol protected instead of private.\n- Added a preliminary version of TDenseProtocol. This is still\n super highly experimental and gross, and I wrote a super scary\n comment to explain that to anyone foolish enough to try to use\n this in its current state.\n\nReviewed By: mcslee\n\nTest Plan: test/DenseProtoTest.cpp\n\nRevert Plan: ok\n\nMemcache Impact:\nSave memory if/when people use it.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665247 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "47557bc8ad061a90c88d485979009c2ee8237854", "tree": "a0a214d093e4239d88673c929593aeb198e34263", "parents": [ "d3f1a2d2ba1257718e7c442c1cf8ce4fb9516d78" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Sep 04 21:31:04 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Sep 04 21:31:04 2007 +0000" }, "message": "Thrift: Slight tweaks to local reflection.\n\nSummary:\nLocal reflection typespecs for structs now have a dummy T_STOP field at the end\nso we don\u0027t have to check the size on every iteration.\nThey also contain information about which fields are optional.\nAlso put a static pointer to the reflection in each structure.\n\nReviewed By: mcslee\n\nTest Plan: test/DenseLinkingTest.thrift\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665246 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "d3f1a2d2ba1257718e7c442c1cf8ce4fb9516d78", "tree": "8b692868db04ffd0a959013ed34bc8b71c186086", "parents": [ "5de75dd859bf1ffaa974fc8ae6dbd1ff1dada1b0" ], "author": { "name": "James Wang", "email": "jwang@apache.org", "time": "Fri Aug 31 23:45:53 2007 +0000" }, "committer": { "name": "James Wang", "email": "jwang@apache.org", "time": "Fri Aug 31 23:45:53 2007 +0000" }, "message": "Summary: Checking in fix to TFileTransport to remove redundant behavior of readEvent -- just return NULL or the next event\nAlso, checking in changes to the php generation code I made awhile ago, but forgot to check in\n\nReviewed By: aditya, mcslee\n\nTest Plan: Compiled thrift and falcon, and confirmed that falcon\u0027s print binary still worked\n\nRevert Plan: revertible\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665245 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "000b111922ccb9c53390bd8e337ae9d48fc80268", "tree": "14365fec65aca85f6b9a1353a2ff3dd600739fcf", "parents": [ "8b6c2ebf42b6ed4e2c9fced2e29a31483d9ac840" ], "author": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Fri Aug 31 08:03:05 2007 +0000" }, "committer": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Fri Aug 31 08:03:05 2007 +0000" }, "message": "-- cleaning up some Makefile issues\n\nReviewed By: jwang\n\nTest Plan: compiled\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665243 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "8b6c2ebf42b6ed4e2c9fced2e29a31483d9ac840", "tree": "06fd2599788ff1e468110a66c47593c976f49bd8", "parents": [ "f150f1aed51d48c36b05cf92f7a7dedb9c9cfeb7" ], "author": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Fri Aug 31 07:54:40 2007 +0000" }, "committer": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Fri Aug 31 07:54:40 2007 +0000" }, "message": "-- reset all state when seeking to a chunk\n\nSummary:\n- this was causing some bizarre issues with seeking to a particular point in the log\n- I can\u0027t believe we haven\u0027t run into this before\n\nReviewed By: jwang\n\nTest Plan: replayed log file from a partiicular point\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665242 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "d779cbe48c1335169cb87ed8977e293247b1434a", "tree": "c15b17777725a83cc35183d6bb59744046b28b6b", "parents": [ "01a9f8845d38cd32694d91b35d7a844c3646e3c3" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Aug 31 01:42:55 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Aug 31 01:42:55 2007 +0000" }, "message": "Thrift: Local Reflection for C++.\n\nSummary:\nThe compiler now takes a \"-dense\" flag that will cause it to\ngenerate some extra metadata for C++. This metadata will be used by\nTDenseProtocol. This should be the last compiler change necessary\nto enable that feature.\n\nReviewed By: mcslee\n\nTest Plan: test/DenseLinkingTest.thrift\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665240 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "792df0bf78d061ede0af7f12bf92c72254ed12d8", "tree": "e2266f7f0cbc621fc67bb786f8c2716170c18689", "parents": [ "c6fc329a4040f9945576bc7007ab8df44d112635" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Aug 30 03:30:22 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Aug 30 03:30:22 2007 +0000" }, "message": "Thrift: Pre-generate reflection_limited for Python.\n\nSummary:\n- Give reflection_limited a nice clean Python module.\n- if/regen.sh now generates reflection_limited for Python and copies it to src.\n- Added the generated Python for reflection_limited to version control.\n- lib/py/setup.py installs reflection_limited.\n- lib/py/cleanup.sh now removes build (make sure to run as root).\n- The C++ version of reflection_limited was also updated by regen.sh.\n\nReviewed By: mcslee\n\nTest Plan:\n- Clean build and install.\n- Look at the installed Python files.\n- python -c \u0027from thrift.reflection.limited.ttypes import *\u0027\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665235 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "2375312fa05e1560f0fc83c642dcb2535d9d2eba", "tree": "c97b21fea0603a3e3f36a596de4597f034a946c9", "parents": [ "5ec8e26d25dc459041e7c31aa2c65eff4f70ad4e" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Aug 27 19:57:34 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Aug 27 19:57:34 2007 +0000" }, "message": "Thrift: Limited Reflection for C++.\n\nSummary:\nThe Thrift compiler now generates static methods for every service to generate\na reflection of the methods provided by the service. This reflection is fairly\nlimited, but should be enough for what we want to do with SMC.\n\nReviewed By: mcslee\n\nTest Plan: test/ReflectionTest.cpp\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665226 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "40c6ac574c0090900736da744ef8cb72340b6c07", "tree": "4e81f0b10d9e652fcbe8910cf021c9888bbe913f", "parents": [ "3f808ab33787044e149fb25d1c6c6c18811afde9" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Aug 24 19:24:10 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Aug 24 19:24:10 2007 +0000" }, "message": "Possible Thrift memory leak\n\nSummary: Don\u0027t throw new Exception, just throw Exception\n\nReviewed By: mcslee\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665223 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "3f808ab33787044e149fb25d1c6c6c18811afde9", "tree": "7c68abef4969f6cb577945d1d18d8183e9f2c881", "parents": [ "cf3c124f29346f26be9d707ef11d30563a45f43b" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Aug 24 00:19:12 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Aug 24 00:19:12 2007 +0000" }, "message": "Thrift: TMemoryBuffer::getAppendBufferToString fix.\n\nSummary:\nSame fix as getBufferAsString\n\nBlame Rev: 55988\n\nReviewed By: dreiss\n\nTest Plan: Thrift compiles.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665222 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "a41c8705db8f09227e22c04bbb98ca046c819ca9", "tree": "e69693d6dc1d14cdb4d0bd41791becf2d410e27d", "parents": [ "d4a269cdb5ecf62e91384e33cdb6bf887f69e9a9" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Aug 23 17:20:38 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Aug 23 17:20:38 2007 +0000" }, "message": "Thrift: TMemoryBuffer::getBufferAsString only returns written portion.\n(This change was by Adam, diff sent by email, I\u0027m just checking it in.)\n\nBlame Rev: 55988\n\nReviewed By: adam\n\nTest Plan: Thrift compiles.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665219 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "d4a269cdb5ecf62e91384e33cdb6bf887f69e9a9", "tree": "013cc9892421f3738e9cda3be933ee12c1f08d53", "parents": [ "402ee28f87dd855d8825182b79617891a7ac4b93" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Aug 23 02:37:19 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Aug 23 02:37:19 2007 +0000" }, "message": "Thrift: No using namespace.\n\nSummary:\nusing namespace XXX; is tricky because it imports a lot of crap into your namespace.\nAlso, if we ever decide to remove boost as a dependency, \"using namespace boost\"\nmakes it harder.\n\nThis patch removes all using namesapce XXX; with one or more using XXX::YYY;\nThere are some exceptions, such as test, tutorial, namespace std, and\nfacebook namespaces.\n\nReviewed By: mcslee\n\nTest Plan:\nRecompiled thrift.\ngrep --binary-files\u003dwithout-match -r \u0027using namespace\u0027 . | \\\n egrep -v \u0027^[^:]*: *using namespace (std;$|facebook)\u0027 | \\\n grep -v \u0027\u003c\u003c endl\u0027 | \\\n grep -v \u0027[^:]*/tutorial/\u0027 | \\\n grep -v \u0027^./test/\u0027\n\nRevert Plan: ok\n\nNotes: I wouldn\u0027t bother, but it is fixathon.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665218 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "402ee28f87dd855d8825182b79617891a7ac4b93", "tree": "575a3efb8fc18c8ee41185bd61be23c5ba29b13a", "parents": [ "25b5ee3285d9230fcda9ec30ca99db306906ae89" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Aug 23 01:43:20 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Aug 23 01:43:20 2007 +0000" }, "message": "Fix TNonBlockingServer libevent issue in ThreadPool mode\n\nSummary: If using TNonBlockingServer with a ThreadManager, when you send a task off to the threadmanager you need to cancel the event that you have set on that client socket. Otherwise, when you give control back to libevent, it might trigger more read events if there are more requests coming down the pipe. This is an issue, because the server will be in the wrong state at that point and will have no way of handling reading more data if it is still in the WAIT_TASK state trying to see if it should write something back to the client. So, when we hit that control flow, we must setIdle() on the TConnection so that libevent doesn\u0027t trigger it anymore. Later, after the result is written, we\u0027ll setRead() and go back to the init state.\n\nReviewed By: akhil\n\nTest Plan: Akhil\u0027s async + TNonBlocking karma server\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665217 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "25b5ee3285d9230fcda9ec30ca99db306906ae89", "tree": "a3fb97a26c21ca02b500503e6a181129a681c288", "parents": [ "bc3dddb91c1e26ecfa290c10f9a5950adc8dedd1" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Aug 23 00:14:48 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Aug 23 00:14:48 2007 +0000" }, "message": "Thrift: TMemoryBuffer now handles NULLs again.\n\nSummary:\nBoz is using TMemoryBuffer by constructing it will a NULL buffer,\nthen doing a resetBuffer later. This patch re-enables that.\n\nBlame Rev: 55988\n\nReviewed By: aditya\n\nTest Plan:\nThrift compiles.\nWill test feed after this is comitted.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665216 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "bc3dddb91c1e26ecfa290c10f9a5950adc8dedd1", "tree": "72dd53e97fb611ea7eaafaa6b6328673a1e832b5", "parents": [ "95aaaf1852dd245e106a5879eb5b9baba32ce5a8" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Aug 22 23:20:24 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Aug 22 23:20:24 2007 +0000" }, "message": "Thrift: Better handling of strerror_r.\n\nSummary:\nSomeone thought it would be a good idea to have two different signatures\nfor strerror_r, with subtly different semantics (strlcpy \u003d smart).\nWe now work properly with either of them.\n\nAlso fixed a test to work on 32-bit, you sloppy \u003cexpletive\u003es.\n\nReviewed By: mcslee\n\nTest Plan:\nRebuild thrift.\nForce one of these errors to be thrown.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665215 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "95aaaf1852dd245e106a5879eb5b9baba32ce5a8", "tree": "25ba553769075c7e8322f63456f3b88ec6e54be1", "parents": [ "2dc72c3864e76d9eb14c1f83def63fa2351f4fb2" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Aug 22 02:32:11 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Aug 22 02:32:11 2007 +0000" }, "message": "Thrift: Bugfix.\n\nSummary: Missed one.\n\nBlame Rev: 55988\n\nReviewed By: yunfang\n\nTest Plan: make\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665214 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "2dc72c3864e76d9eb14c1f83def63fa2351f4fb2", "tree": "a9d1cb7875bb45a5ee9eba760ca229902a34408c", "parents": [ "dd56497a7c97f07c8d97b9c7323652fb2b7154e0" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Aug 21 23:59:34 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Aug 21 23:59:34 2007 +0000" }, "message": "Thrift: Move TStringBuffer functionality into TMemoryBuffer.\n\nSummary:\nTMemoryBuffer already has the necessary plubming to work with C++ strings.\nThis revision implements that functionality with a few wrapper methods.\nRemoved TStringBuffer as it should no longer be required (and it is tricky\nto safely inherit from a class that has a non-virtual destructor).\nAlso refactored the TMemoryBuffer constructors a bit.\n\nReviewed By: aditya, yunfang\n\nTest Plan:\ntest/TMemoryBufferTest.cpp\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665213 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "dd56497a7c97f07c8d97b9c7323652fb2b7154e0", "tree": "129ba7de35bfddb39da2c8304dd3852c3dbffc78", "parents": [ "98439158db96e682467f87b0d6533896db9ae72a" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Aug 21 02:39:57 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Aug 21 02:39:57 2007 +0000" }, "message": "Need sys/types.h includes for FreeBSD\n\nReviewed By: dreiss\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665212 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "98439158db96e682467f87b0d6533896db9ae72a", "tree": "484ed060d6336ed30e7a36715b53a1b45a23d35f", "parents": [ "04f0b7b21b4902f356809fced858de8d00bae1b6" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Aug 21 02:39:40 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Aug 21 02:39:40 2007 +0000" }, "message": "Fix thread_t cast again\n\nSummary: reinterpret_cast actually breaks on linux, despite working on FreeBSD\n\nReviewed By: dreiss\n\nTest Plan: Compile on Linux OR FreeBSD\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665211 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "04f0b7b21b4902f356809fced858de8d00bae1b6", "tree": "c901a6dd7cf587e1ed0561ad917ebe5bb25eda28", "parents": [ "1ec47d4395be54319598aa5cd74ee8d44246b335" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Aug 21 01:54:36 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Aug 21 01:54:36 2007 +0000" }, "message": "Use reinterpret_cast instead of static_cast for pthread_t \u003d\u003e Thread::id_t\n\nSummary: On FreeBSD pthread_t is a pthread*, not uint64_t, so static_cast gest upset\n\nReviewed By: dreiss\n\nTest Plan: Compile on FreeBSD\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665210 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "1ec47d4395be54319598aa5cd74ee8d44246b335", "tree": "918d05ee0f28ba6825bced213f0ab592bd586760", "parents": [ "94112d699411fcca2bde9721da46ddcd4c15a5bf" ], "author": { "name": "yunfang", "email": "dev-null@apache.org", "time": "Sun Aug 19 22:18:38 2007 +0000" }, "committer": { "name": "yunfang", "email": "dev-null@apache.org", "time": "Sun Aug 19 22:18:38 2007 +0000" }, "message": "[adding TStringBuffer for serialization/deserialization from a string]\nSummary:\n/**\n * A string buffer is a tranpsort that simply reads from and writes to a\n * string. Anytime you call write on it, the data is serialized\n * into the underlying buffer, you can call getString() to get the serialized\n * string. Before you call read, you should call resetString(data) to set the\n * underlying buffer, you can then call read to get the\n * de-serialized data structure.\n *\n * The string buffer is inherited from the memory buffer\n * Thus, buffers are allocated using C constructs malloc,realloc, and the size\n * doubles as necessary.\n */\n\nReviewed by: aditya\n\nTest Plan:\nint main(int argc, char** argv) {\n shared_ptr\u003cTStringBuffer\u003e strBuffer(new TStringBuffer());\n shared_ptr\u003cTBinaryProtocol\u003e binaryProtcol(new TBinaryProtocol(strBuffer));\n\n testStruct a;\n a.i1 \u003d 10;\n a.i2 \u003d 30;\n a.s1 \u003d string(\"holla back a\");\n\n a.write(binaryProtcol.get());\n string serialized \u003d strBuffer-\u003egetString();\n\n shared_ptr\u003cTStringBuffer\u003e strBuffer2(new TStringBuffer());\n shared_ptr\u003cTBinaryProtocol\u003e binaryProtcol2(new TBinaryProtocol(strBuffer2));\n\n strBuffer2-\u003eresetString(serialized);\n testStruct a2;\n a2.read(binaryProtcol2.get());\n\n if (a \u003d\u003d a2) {\n printf(\"serialization working\\n\");\n } else {\n printf(\"serialization not working\\n\");\n }\n}\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665209 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "5362e70f8f3c58f0f1fc67ea0a8fc299c554e1bc", "tree": "c16926b192819343292fd79e6663b25ff5a3218c", "parents": [ "3429b6a9a046bbc4bd6e476467aca89ce7317cc2" ], "author": { "name": "boz", "email": "dev-null@apache.org", "time": "Wed Aug 15 20:55:36 2007 +0000" }, "committer": { "name": "boz", "email": "dev-null@apache.org", "time": "Wed Aug 15 20:55:36 2007 +0000" }, "message": "THRIFT: mutex trylock support\n\nSummary: add trylock support to the Mutex class\n\nReviewed By: mcslee\n\nTest Plan: added trylock mutexes to foreman, walked through them in gdb\n(behaved correctly) and then ran an entire sweep (behaved correctly)\n\nNotes: slee ftw\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665204 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "17496a04d61a5ed0dbece2d5067135871a526da4", "tree": "1b6cfd3beaccd12b1b57bcfe4739c6c56b63d8a9", "parents": [ "80cdca7344fba98dcda6bcc694a1419cb2dc60a6" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Aug 02 06:37:40 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Aug 02 06:37:40 2007 +0000" }, "message": "Typo and comment fix\n\nReviewed By: marc\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665189 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "80cdca7344fba98dcda6bcc694a1419cb2dc60a6", "tree": "d4fabd5b684072b6d7d8160634a34ba79383cbc7", "parents": [ "c3c6c0c9c4dc77c6b2b7dce952eeb2fe69513a40" ], "author": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Thu Aug 02 06:26:11 2007 +0000" }, "committer": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Thu Aug 02 06:26:11 2007 +0000" }, "message": "-- fix memory leak in TThreadedServer\n\nSummary:\n- need detached\u003dtrue\n\nReviewed By: mcslee\n\nTest Plan: replayable test case\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665188 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "5b4181919de0245098b481ea2ed5ecd1e7a0d83f", "tree": "b64a1241a9966ce5c70848df466ab3aa3db9d4c9", "parents": [ "877237abcf93e7bd7bc9a7d095d3a850c309817e" ], "author": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Fri Jul 27 07:04:49 2007 +0000" }, "committer": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Fri Jul 27 07:04:49 2007 +0000" }, "message": "-- remove default seekToEnd\n\nfixed search so no need for this anymore\n\nReviewed By: jwang\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665178 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "96d2388ade7af4f23d2c95b92496b79ec0321133", "tree": "fb9840256a746c1b3889b25ddd8131955265ec60", "parents": [ "5f5fdf3a20f2459eabbee771e6eff4159c6f2bca" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Jul 26 21:10:32 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Jul 26 21:10:32 2007 +0000" }, "message": "Thrift: Cleaned up whitespace.\n\nSummary:\nReplaced a lot of tabs with spaces in the thrift codebase.\nRemoved a lot of trailing whitespace from thrift-generated c++.\nAdded a few things to cleanup.sh.\n\nTrac Bug: #\n\nBlame Rev:\n\nReviewed By: mcslee\n\nTest Plan:\nRecompiled thrift.\nRe-thrifted some test .thrifts.\nCompiled the genrated c++.\nRan cleanup.sh.\n\nRevert Plan: ok\n\nNotes:\n\nEImportant:\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665176 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "e9cd65557916236ff4e29bcffdd33751190d55c9", "tree": "a297f789666c95a09f0d06ed47bd14ec60e031b9", "parents": [ "d51643cbf99f57f1945eaedb30bde8efa714c7ac" ], "author": { "name": "James Wang", "email": "jwang@apache.org", "time": "Mon Jul 23 17:35:32 2007 +0000" }, "committer": { "name": "James Wang", "email": "jwang@apache.org", "time": "Mon Jul 23 17:35:32 2007 +0000" }, "message": "Readding seekToEnd() call to openLogFile() temporarily so that search doesn\u0027t break\n\nReviewed By: aditya\n\nTest Plan: Thrift compiles, falcon works\n\nRevert Plan: revertible\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665168 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "d51643cbf99f57f1945eaedb30bde8efa714c7ac", "tree": "4128e024057a6ad2bf935f746bf6be37f6889632", "parents": [ "00dcccfef251bb99836760eb31b2522608c23418" ], "author": { "name": "James Wang", "email": "jwang@apache.org", "time": "Sun Jul 22 05:48:12 2007 +0000" }, "committer": { "name": "James Wang", "email": "jwang@apache.org", "time": "Sun Jul 22 05:48:12 2007 +0000" }, "message": "Summary: Changing TFileTransport to not go to end of file by default\n\nReviewed By: boz\n\nTest Plan: compiled and tested falcon\u0027s print utility\n\nRevert Plan: revertible\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665167 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "00dcccfef251bb99836760eb31b2522608c23418", "tree": "7c4d27924a3050fb1725eb70cd1494881bd55355", "parents": [ "8639e1056d6db52d53ff579f0f8d4728b702740e" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sat Jul 21 01:18:10 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sat Jul 21 01:18:10 2007 +0000" }, "message": "Thrift: Debug Protocol\n\nSummary:\nAdded TDebugProtocol, a write-only Thrift protocol for C++\nthat produces human-readable representations of thrift structs.\n\nTrac Bug: #\n\nBlame Rev:\n\nReviewed By: mcslee\n\nTest Plan:\nRecompiled Thrift.\n./test/TestDebugProto.* see compile instructions at the top.\nRan that, and it looked good.\n\nRevert Plan:\ngrep TDebugProtocol \u003cworld\u003e\ngrep ThriftDebugString \u003cworld\u003e\nRevert or comment out whatever you find so that they still compile.\nThen svn revert.\n\nNotes:\n\nEImportant:\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665166 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "a36f5db4b323adbcd13cd298ab73eee2be6200f2", "tree": "64cf754afe6c383e34e08570887c8f62e64269e4", "parents": [ "b1ad0141d4df4b4488882880a6d9d4aa84f3b178" ], "author": { "name": "yunfang", "email": "dev-null@apache.org", "time": "Sat Jul 14 01:23:05 2007 +0000" }, "committer": { "name": "yunfang", "email": "dev-null@apache.org", "time": "Sat Jul 14 01:23:05 2007 +0000" }, "message": "[scope lock wrapped for ReadWriteMutex]\nSummary:\n scope lock wrapped around ReadWriteMutex. It\u0027s like Guard but you can specify to use it as a read or write lock.\n\nReviewed by: boz\n\nTest Plan: used it in AdFinder\n\nRevertible: yes\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665162 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "8b82fb7a757f54659c88f294a217613a9fea59ca", "tree": "34a4fbc50b6c17371390913244da63b11a767335", "parents": [ "d093e7c32aa8f99b5696603fdd39ceeeebbdc150" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Jul 10 00:49:04 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Jul 10 00:49:04 2007 +0000" }, "message": "Fix SET serialization borked-ness in Thrift\n\nSummary: Extra return floating in the code\n\nReviewed By: boz\n\nTest Plan: Rebuild and deploy feed\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665160 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "85287d3989359231026807bac52364cbe49b8d84", "tree": "ac944a48f83ef03133f20f61b38377ac5522baae", "parents": [ "e6c4fa671e63f9bfcc443d3fb5802e886f237c9a" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon Jul 09 19:50:30 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon Jul 09 19:50:30 2007 +0000" }, "message": "Fix addrinfo structure memory leak in TSocket\n\nSummary: Need to free the IPv6 memory structure\n\nReviewed By: mcslee\n\nNotes: Submitted by paul@powerset.com\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665157 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "e6c4fa671e63f9bfcc443d3fb5802e886f237c9a", "tree": "c1b4b7aebdd340b47086094df1e69f296ba94b19", "parents": [ "6d56eb9d651a72a1fe10b7829e569a7ac12afb20" ], "author": { "name": "Martin Kraemer", "email": "martin@apache.org", "time": "Mon Jul 09 19:08:25 2007 +0000" }, "committer": { "name": "Martin Kraemer", "email": "martin@apache.org", "time": "Mon Jul 09 19:08:25 2007 +0000" }, "message": "sys_errlist is deprecated.\n\nSummary:\nAvoiding usage of sys_errlist. It is deprecated, prefer strerror or strerror_r instead.\n\nTrac Bug: #\n\nBlame Rev:\n\nReviewed By: mcslee, karl\n\nTest Plan:\n\nRevert Plan: revertible\n\nNotes:\n\nEImportant:\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665156 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "6d56eb9d651a72a1fe10b7829e569a7ac12afb20", "tree": "7cca951df72149fa9987a860ff486740b33090ed", "parents": [ "cce8184d997b37a2da1b885125b43bcda103fa76" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Jul 06 22:28:15 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Jul 06 22:28:15 2007 +0000" }, "message": "TSocket IPv6 support for C++\n\nSummary: From Paul Saab at Powerset\n\nReviewed By: mcslee\n\nTest Plan: test/cpp/TestClient\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665155 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "cce8184d997b37a2da1b885125b43bcda103fa76", "tree": "556497122de3691d3446023a7960a4df4d7104bc", "parents": [ "22974602532c9d1e1dacb5d0f873667a237b0981" ], "author": { "name": "boz", "email": "dev-null@apache.org", "time": "Fri Jul 06 22:27:52 2007 +0000" }, "committer": { "name": "boz", "email": "dev-null@apache.org", "time": "Fri Jul 06 22:27:52 2007 +0000" }, "message": "THRIFT ReadWriteMutex\n\nSummary: Implemented a read/write lock class in thrift::concurrency\n\nReviewed By: marc\n\nTest Plan: I compiled this, then compiled a version of fb303 that uses this\n(future checkin pending further tests), then ran a binary using the new fb303\nand it didn\u0027t crash as things were added to the map using the ReadWriteMutex\n\nRevert Plan: yup\n\nNotes: this should replace rw_lock.h for most clients\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665154 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "f79031e87531464b84d911acf9aee57cac8b83d8", "tree": "f24a3e9989a757cf75e15eef59d43bbc24628628", "parents": [ "58dfb4fbe82c346814c2e4f33b6045468bfd68c6" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Jul 06 21:43:48 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Jul 06 21:43:48 2007 +0000" }, "message": "Fixed possible Thrift serialization bug\n\nSummary: TBinaryProtocol.cpp was making assumptions about evaluation order\nthat are not guaranteed by the standard. Now it does not (at least in these\nfunctions).\n\nTrac Bug: #\n\nBlame Rev:\n\nReviewed By: mcslee\n\nTest Plan: still compiles.\n\nRevert Plan: svn revert\n\nNotes:\n\nEImportant:\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665152 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "82883299ef730cd2badf11ba4225de47709392e1", "tree": "40229442bace4933546f032c2c48991bd20a818e", "parents": [ "58500e976364aea0df156a08b6c0336f6da26cd1" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Jun 26 20:19:56 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Jun 26 20:19:56 2007 +0000" }, "message": "Removing protocol.txt\n\nSummary: This is not accurate anymore\n\nReviewed By: aditya\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665144 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "58500e976364aea0df156a08b6c0336f6da26cd1", "tree": "6b700f916a3ddd25c6a7d6f64d32e848f798e449", "parents": [ "66ccee2a7489a26d58197f75c0136eebdb345dff" ], "author": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Tue Jun 26 02:57:04 2007 +0000" }, "committer": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Tue Jun 26 02:57:04 2007 +0000" }, "message": "-- make sure TFileTransport always starts at EOF\n\nReviewed By: jwang\n\nTest Plan: search\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665143 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "a9294a9522bb6045f468b04abfee648b71c9b99b", "tree": "cad4fedc7d672c02d33eb633cf9920f236152a17", "parents": [ "552410c037c323085e075bd4b0f268ee941083b8" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Jun 22 19:43:12 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Jun 22 19:43:12 2007 +0000" }, "message": "Teensy insignificant thrift bug\n\nSummary: Wasn\u0027t causing any issues because it\u0027s a noop with the binary protocol\n\nReviewed By: jwang\n\nTest Plan: honky tonk, no diff in functionality\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665140 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "808454ec634278eec7e0ee5c523b00e3e4257287", "tree": "a8b896d05d162699ac11e45aca3d129e119379f4", "parents": [ "589859984f43af1ed0f9ee45ce8374a0d1640813" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Jun 20 21:51:57 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Jun 20 21:51:57 2007 +0000" }, "message": "Thrift TBinaryProtocol change\n\nSummary: New Thrift TBinaryProtocol with a version identifier\n\nReviewed By: aditya, eugene\n\nTest Plan: Modify your services to have strictRead_ and strictWrite_ both set to FALSE. Then redeploy your services and test running clients against them. Once you have clients and servers running stably on this new code, you should redploy versions with strictWrite_ set to TRUE. Once that\u0027s all good, we can set strictRead_ to TRUE as well, and eventually deprecate the old protocol code entirely.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665138 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "589859984f43af1ed0f9ee45ce8374a0d1640813", "tree": "542ef2b0e9b7979373ab9736bafffc89995e47b0", "parents": [ "3e5d2d72b4f48e2008462fbb9ac86f76011ceb91" ], "author": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Tue Jun 19 23:10:19 2007 +0000" }, "committer": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Tue Jun 19 23:10:19 2007 +0000" }, "message": "[thrift] Add optional callback inside of serve()\n\nSummary: If enabled, the callback function will be run after the listening socket is opened and the event loop initialized, just prior to calling event_loop()\n\nThis is handy if you want to defer some of your initialization until after the socket is open -- allowing clients to connect, but not processing requests until the initialization is complete. I use this in the Synapse tablet server to minimize the communications interruption that happens during a tablet split (replaying commit logs after opening the listening socket).\n\nReview: mcslee\nTest Plan: compiled it into Synapse\u0027s tablet server\nRevert: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665137 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "8eceaeacfb084dd603c4d0fe07cc26066ca70abe", "tree": "244ffc9cacb477e30180e1adfdb538ff35d3b1f8", "parents": [ "447d7d236590db3dad60dc10eed72274a5b66edf" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Jun 15 01:43:21 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Jun 15 01:43:21 2007 +0000" }, "message": "Missing variable in initializer list for TNonblockingServer constructor\n\nSummary: Making tablemaster very unhappy\n\nReviewed By: dweatherford\n\nTest Plan: tablemaster on synampse tier\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665135 13f79535-47bb-0310-9956-ffa450edef68\n" } ], "next": "1d2ead34a23602a1dd248648204bbbeea356bc0c" }