)]}' { "log": [ { "commit": "8440605c277339770483a7daf31da7858bff2b38", "tree": "9b518e9af2f19e324b8ef31c15812f93961b94d9", "parents": [ "fb4b514028ed073302ffa8d3dcbfba3a89b427f0" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 20 01:39:25 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 20 01:39:25 2007 +0000" }, "message": "Cocoa Thrift binding patches from Andrew McGeachie\n\nSummary: Latest updates to the Cocoa bindings\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665354 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "fb4b514028ed073302ffa8d3dcbfba3a89b427f0", "tree": "2ef7120fc936e0dfd3f78bbdd1ef089e34bc8b62", "parents": [ "b6014f494f41ecee4f8e1c7264e99a883805e99f" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 20 01:27:08 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 20 01:27:08 2007 +0000" }, "message": "IPv6 support for the TNonBlockingServer\n\nSummary: Need to use IPv6 compliant constructs here. Submitted by Paul Saab.\n\nReviewed By: dreiss\n\nTest Plan: Rebuild Thrift TNonblockingServer with this patch and verify behaves just the same\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665353 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "b6014f494f41ecee4f8e1c7264e99a883805e99f", "tree": "41217d03d2233ac9784ed3e69095ba3a34de94eb", "parents": [ "7fcc9e87ba180909c7309ecb713321f6aabfe9f4" ], "author": { "name": "hzhao", "email": "dev-null@apache.org", "time": "Sun Nov 18 20:54:30 2007 +0000" }, "committer": { "name": "hzhao", "email": "dev-null@apache.org", "time": "Sun Nov 18 20:54:30 2007 +0000" }, "message": "added trunk\n\nReviewed By: shire\nTest Plan: ape work\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665352 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "7fcc9e87ba180909c7309ecb713321f6aabfe9f4", "tree": "b43eed62d6207d3dc51f32fa542f22a1831f3f99", "parents": [ "de11d852113dcb2284c54ab47333e6f602320fc9" ], "author": { "name": "hzhao", "email": "dev-null@apache.org", "time": "Sun Nov 18 20:48:56 2007 +0000" }, "committer": { "name": "hzhao", "email": "dev-null@apache.org", "time": "Sun Nov 18 20:48:56 2007 +0000" }, "message": "tagging thrift-protocol-1.0.0\n\nReviewed By: shire\nTest Plan: ape work\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665351 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "de11d852113dcb2284c54ab47333e6f602320fc9", "tree": "f78771d95182132100083724aecee9c52ddc7611", "parents": [ "09f69e052452e973949bc143d0f34c28c51ff15e" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Sun Nov 18 02:10:20 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Sun Nov 18 02:10:20 2007 +0000" }, "message": "[thrift] gut Erlang exception handling\n\nSummary: * move type field to tException from subclasses\n * add backtrace to tException\n * add oop:is_a\n * on exit, wrap exceptions in {thrift_exception, E} ... otherwise can\u0027t distinguish e.g. exit:{{tBinProtException, {tException, ...}}, Stack} vs. exit:{tBinProtException, {tException, ...} -- I hate erlang\n * all throws/exits to tException:throw which does the wrapping described above\n\nReviewed By: eletuchy\n\nTest Plan: been using this code on my live server ^_^\n\nRevert: OK\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665350 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "09f69e052452e973949bc143d0f34c28c51ff15e", "tree": "f738e85f88a874e5ec26620a67ae0b7245437026", "parents": [ "f5a6b0c10939a2c0dd33fa88b8ce4e3f44a33186" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Sat Nov 17 00:32:36 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Sat Nov 17 00:32:36 2007 +0000" }, "message": "Add __autoload() support to Thrift-generated PHP code\n\nSummary: Include thrift/autoload.php and use -phpa flag to generated code that works with autoload. Good for services with lots of methods that are typically not all invoked.\n\nReviewed By: dreiss\n\nTest Plan: Falcon, baby, falcon.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665349 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "f5a6b0c10939a2c0dd33fa88b8ce4e3f44a33186", "tree": "5e03c1bbc1f114964de0b95b4ff02b51433a202a", "parents": [ "611434992a349fb69507a625929f98f61656feef" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Sat Nov 17 00:27:17 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Sat Nov 17 00:27:17 2007 +0000" }, "message": "Fix PHP TBufferedTransport readAll() to work with TSocket timeouts\n\nReviewed By: lucas\n\nTest Plan: Invoke Buffered Transport wrapped around socket\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665348 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "611434992a349fb69507a625929f98f61656feef", "tree": "fd4c0d04aec28492eb62113c66c64e4e5477ff64", "parents": [ "eab6ac8b18db9bb6c83b44845aabea177777addf" ], "author": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Fri Nov 16 03:29:47 2007 +0000" }, "committer": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Fri Nov 16 03:29:47 2007 +0000" }, "message": "[thrift] Fix extension deserialization call with no classname\n\nSummary: The extension expects a classname as a string and does not allow null;\n use the empty string instead of null in the absence of a classname to pass.\n\nReviewed By: mcslee\nTest Plan: php -l\nRevert: svn\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665347 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "eab6ac8b18db9bb6c83b44845aabea177777addf", "tree": "6078f9974a9639f5e37ad864cecfd80cde290922", "parents": [ "9e58f4330ddac304a03e6d240968a6185d4531f3" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Nov 16 03:27:22 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Nov 16 03:27:22 2007 +0000" }, "message": "Make sure to lazily initialize $TSPEC for structs even with no members\n\nReviewed By: dweatherford\n\nTest Plan: Generate code with no E_ALL for method-less args\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665346 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "9e58f4330ddac304a03e6d240968a6185d4531f3", "tree": "72914d4cee015a87cfd67446d356c7ee96eee106", "parents": [ "9230539a6f2b36e25799b97ff45e90743af61269" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Nov 16 02:48:52 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Nov 16 02:48:52 2007 +0000" }, "message": "Fix namespacing of included enum types in C++ generated code\n\nSummary: If you reference enum types from an include you need to fully qualify their namespace in the generated C++ code.\n\nReviewed By: pfung\n\nTest Plan: fbtypes code that pfung is using\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665345 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "9230539a6f2b36e25799b97ff45e90743af61269", "tree": "f245164e7675cb08419aa3896058e852acae5f1d", "parents": [ "10522a7f2b9d413d97f49670e3102826833dcdcf" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 06:26:32 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 06:26:32 2007 +0000" }, "message": "[thrift] Erlang client calls return value from recv_\n\nSummary: only return `ok\u0027 if it\u0027s an async, otherwise return the value of recv_\n\nReviewed By: cvarenhorst\n\nTest Plan: my server works now\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665344 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "10522a7f2b9d413d97f49670e3102826833dcdcf", "tree": "d7ed96344f1690340f790963a7654e6c93385f09", "parents": [ "c2e37c7a617c7e7d55ab79a3f23542aeec42b1af" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 06:26:31 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 06:26:31 2007 +0000" }, "message": "[thrift] fix-ups to Erlang thrift_logger\n\nSummary:\n * no ?INFO for every oop:call ... way too expensive\n * unfactor symbol/1 ... it was that way for a reason apparently\n * upped crash report depth to 3\n\nReviewed By: eletuchy\n\nTest Plan: /much/ less CPU eaten by logging\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665343 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "c2e37c7a617c7e7d55ab79a3f23542aeec42b1af", "tree": "ed52215ea1f313e2b65e2b8097e5089ba66a6095", "parents": [ "90eab4d6e4279e9e61fa295e19a834f4c6ebe632" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 06:26:30 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 06:26:30 2007 +0000" }, "message": "[thrift] change up Erlang crash reports, cleanups in t{,Binary}Protocol\n\nSummary: crash reports aren\u0027t too important so don\u0027t be so verbose -- all the pertinent info shows up elsewhere anyway. refactor while we\u0027re at it.\n\nReviewed By: eletuchy\n\nTest Plan: ok\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665342 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "90eab4d6e4279e9e61fa295e19a834f4c6ebe632", "tree": "75499fce34bf451dd18c1a6de4084c86bf951e14", "parents": [ "2605af3a2d6bd7c8815e08ecf886eb3720d2ac1d" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 06:26:29 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 06:26:29 2007 +0000" }, "message": "[thrift] remove trailing-whitespace-generating code from t_erl_generator.cc\n\nSummary: meta\n\nReviewed By: dcorson\n\nTest Plan: M-x delete-trailing-whitespace does nothing\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665341 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "2605af3a2d6bd7c8815e08ecf886eb3720d2ac1d", "tree": "2e77b7e368e1563323f83b0047d7d1ce605d4aed", "parents": [ "53b6ef670cd70c0f81d6ade52de27dde763b3686" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 06:26:29 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 06:26:29 2007 +0000" }, "message": "[thrift] remove tabs from t_erl_generator.cc\n\nSummary: ididntdoit\n\nReviewed By: eletuchy\n\nTest Plan: ok\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665340 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "53b6ef670cd70c0f81d6ade52de27dde763b3686", "tree": "5b9262f1d83f4e2a0c8f08ddc2fd23ee01228702", "parents": [ "a1650fe55cfdba6c5cad1f09e3142b23b24b66c9" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 06:26:28 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 06:26:28 2007 +0000" }, "message": "[thrift] whole ball of whitespace normalizations in Erlang\n\nSummary: ill-formatted comments, trailing whitespace, and (gasp) tabs: all pwned. better now than later.\n\nReviewed By: eletuchy\n\nTest Plan: ok\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665339 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "a1650fe55cfdba6c5cad1f09e3142b23b24b66c9", "tree": "b59b40a330ee47074cc220bc5b6917627b7caf02", "parents": [ "3121c8271f07b56593df3e6a10ad549590059057" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 06:26:27 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 06:26:27 2007 +0000" }, "message": "[thrift] make open and close `effectful\u0027 in Erlang client\n\nSummary: make uniform across all tTransports. god i want `effectful\u0027 to go away dead. soon.\n\nReviewed By: eletuchy\n\nTest Plan: ok\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665338 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "3121c8271f07b56593df3e6a10ad549590059057", "tree": "78331f2a66dea0146f0421a08e7bc15842cdcfda", "parents": [ "0d5cd8a6b92053df8e8b1f5df9e2e3e55c3a9cd1" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 06:26:26 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 06:26:26 2007 +0000" }, "message": "[thrift] Erlang client receive socket options\n\nSummary: we want {active, false}, etc. for client sockets. make it so.\n\nReviewed By: eletuchy\n\nTest Plan: ok\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665337 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "0d5cd8a6b92053df8e8b1f5df9e2e3e55c3a9cd1", "tree": "5fe3fd13c8aa3385b2dd1287b968cf608f6b7eab", "parents": [ "6c74062262aaad614719227a279dfb7789e56471" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 02:20:59 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 02:20:59 2007 +0000" }, "message": "[thrift] Erlang makefile includes to terse messages\n\nSummary: filter out compiler path and flags and cruft\n\nReviewed By: eletuchy\n\nTest Plan: ok\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665336 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "6c74062262aaad614719227a279dfb7789e56471", "tree": "e85b73f571234af6d281b8fa61a76913655dc3b6", "parents": [ "89d52079834a20411d2b842d2e71a4e3390911a9" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 02:20:58 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 02:20:58 2007 +0000" }, "message": "[thrift] convert oop.erl errors and infos to macros\n\nSummary: old-style error messages get switched over\n\nReviewed By: eletuchy\n\nTest Plan: ok\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665335 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "89d52079834a20411d2b842d2e71a4e3390911a9", "tree": "e304560e5d6e9a1166ef0ac310687759066da20a", "parents": [ "465ccc09240b16f5790dfc5c5e7579c42ec54770" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Nov 14 00:24:14 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Nov 14 00:24:14 2007 +0000" }, "message": "Change Thrift to lazily instantiate $_TSPEC objects on first object instantiation\n\nSummary: Apparently adding the static array costs overhead since it must get preinitialized or something? It\u0027s unclear exactly what\u0027s going on here, but let\u0027s test to see if explicit lazy instantiation helps here.\n\nReviewed By: dreiss\n\nTest Plan: See if this speeds up falcon loading\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665334 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "465ccc09240b16f5790dfc5c5e7579c42ec54770", "tree": "c201156258c1c459a4bc3e1b0745f1b4e5de5fbd", "parents": [ "380298f458dcdedb1e59227c90cee4af890bef08" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Nov 13 21:41:29 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Nov 13 21:41:29 2007 +0000" }, "message": "Thrift: Fix new-style generated PHP code.\n\nSummary:\nFix reading of lists/sets of lists/sets/maps.\n\nReviewed By: mcslee\n\nTest Plan: Tested in trunk.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665333 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "380298f458dcdedb1e59227c90cee4af890bef08", "tree": "2be98a77f77ca033c6c14c9912cdafd0f05466e3", "parents": [ "0cdc6c8cd94cad4407e38db5975715fb67c71fb7" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Nov 13 11:55:06 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Nov 13 11:55:06 2007 +0000" }, "message": "Thrift: Fix new-style generated PHP code.\n\nSummary:\nWe were generating a fatal when constructing a struct with an argument.\n\nReviewed By: lucas\n\nTest Plan: None.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665332 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "0cdc6c8cd94cad4407e38db5975715fb67c71fb7", "tree": "78d41ce3baa549e11852e56a42fdfbc85a4ba065", "parents": [ "c557df42ed89913dd35536fcb30621d64c4ab0e6" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 13 10:19:08 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 13 10:19:08 2007 +0000" }, "message": "Merging PHP transport changes from www trunk to thrift trunk\n\nSummary: Some empty() fixes, plus a few other socket helpers\n\nReviewed By: lucas\n\nTest Plan: Use the transports to make IPC calls!\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665331 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "c557df42ed89913dd35536fcb30621d64c4ab0e6", "tree": "fffaccdacf21258462cf25ea21dbea60e4000c3e", "parents": [ "2b786221edc8a0bfd640e5755459f3973120dd7a" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 13 05:53:44 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 13 05:53:44 2007 +0000" }, "message": "Need to properly namespace the php class names in typespec\n\nReviewed By: aditya\n\nTest Plan: Regenerate ubersearch code\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665330 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "2b786221edc8a0bfd640e5755459f3973120dd7a", "tree": "7d8714f33c59f61498e1a3949eec5d8b3dd093fa", "parents": [ "5b743079da3b0f817545d7e0574222a5c16fc2a9" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 13 05:35:34 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 13 05:35:34 2007 +0000" }, "message": "Fixing typo in Thrift trunk\n\nSummary: xter \u003d\u003e xfer\n\nReviewed By: sgrimm\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665329 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "5b743079da3b0f817545d7e0574222a5c16fc2a9", "tree": "16e0768d3a13702182643c7e00d1c4909132de81", "parents": [ "c0c88ee8056427f66451e527f791b31f7485b4ca" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 13 04:00:29 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 13 04:00:29 2007 +0000" }, "message": "Thrift PHP generation Redux\n\nSummary: Chopping the amount of code generated by Thrift for PHP services by two orders of magnitude (approx 25% of the previous size). This is done via putting more logic in a dynamic base class and taking it out of the generated code. Hopefully this wins back the CPU cycles paid just to load code from APC at the cost of a marginal increase in dynamic execution runtime.\n\nReviewed By: sgrimm, dreiss\n\nTest Plan: Ran all the tests in trunk/test/php, also tested the API generate code and Falcon, etc. in my sandbox\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665328 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "c0c88ee8056427f66451e527f791b31f7485b4ca", "tree": "7f436e8be9f9349be94f31526a71b107809bc5d9", "parents": [ "6eb58926628132770508c146e01686a832b97dc8" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Nov 08 01:05:46 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Nov 08 01:05:46 2007 +0000" }, "message": "Thrift: Perl HttpClient and fixes.\n\nSummary:\nAlso updated the CONTRIBUTORS file. Sorry, Boz.\n\nReviewed By: mcslee\n\nRevert Plan: ok\n\nOther Notes:\nSubmitted by Igor Afanasyev.\nReviewed by Jake Luciani.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665327 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "6eb58926628132770508c146e01686a832b97dc8", "tree": "c31fc4282aed1ea1a594b8e1f29a04d045f050a6", "parents": [ "5151c6279ba4faa6bc3c3450b22da225a10ada8d" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Nov 07 00:48:47 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Nov 07 00:48:47 2007 +0000" }, "message": "Deal with UnsupportedEncodingException in TBinaryProtocol\n\nSummary: In case you are running on a horrendous JVM that doesn\u0027t have UTF-8 support\n\nReviewed By: dreiss\n\nTest Plan: Compile.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665326 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "5151c6279ba4faa6bc3c3450b22da225a10ada8d", "tree": "e80bdac5b4b679c5516c161472ac2b3924638033", "parents": [ "f968926f2b757c1ab7b0bb008e96c58d081f172e" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 06 22:11:29 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 06 22:11:29 2007 +0000" }, "message": "Add include_once statements for generated PHP code that depends upon other types\n\nReviewed By: root\n\nTest Plan: Generate PHP code for a .thrift file with an include in it\n\nOther Notes: Reviewed by Todd Lipcon from AmieStreet\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665325 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "f968926f2b757c1ab7b0bb008e96c58d081f172e", "tree": "51c0e5252818fe33c657697d12d41b940d0ff906", "parents": [ "3788038a3564e131372b3e54832d513dcc36917f" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 06 22:10:24 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 06 22:10:24 2007 +0000" }, "message": "Missing configure check for strerror function\n\nReviewed By: dreiss\n\nTest Plan: Run configure script\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665324 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "3788038a3564e131372b3e54832d513dcc36917f", "tree": "8c48456d8d15b31b21175b8773a8b24c125b66dc", "parents": [ "0502e61fb99d4aab9717e2ba42ac6d9987ea5e2d" ], "author": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Tue Nov 06 06:33:06 2007 +0000" }, "committer": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Tue Nov 06 06:33:06 2007 +0000" }, "message": "-- ensure that flush is called in close() of any wrapper transport\n\nSummary:\n- unflushed data should be flushed when transport is closed\n- this diff calls flush for TBufferedTransport and TFramedTransport\n\nReviewed By: dreiss\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665323 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "0502e61fb99d4aab9717e2ba42ac6d9987ea5e2d", "tree": "7337df72e9109294271f93acf7f817e23a1598c4", "parents": [ "52182d674eff80ac99da38b34273279bce9a327b" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Sat Nov 03 05:30:32 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Sat Nov 03 05:30:32 2007 +0000" }, "message": "Add programatic shutdown option to Java Thrift servers\n\nSummary: Same paradigm as in C++ model. Allow ServerTransport to be interrupted to block an accept loop and cleanly stop serving client requests.\n\nReviewed By: dreiss\n\nTest Plan: Invoke shutdown() method on a TServer\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665322 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "52182d674eff80ac99da38b34273279bce9a327b", "tree": "cea59463c0a348bd5ea8f4b71a5ad51e8f7df1c8", "parents": [ "ffc21fb792b152ed6b45c4e83b4c5fd295465007" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Sat Nov 03 04:48:43 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Sat Nov 03 04:48:43 2007 +0000" }, "message": "Make Java TbinaryProtocol enfore UTF-8\n\nSummary: Java Strings have to have an encoding, they can\u0027t just be binary. The constructor and getBytes() method enforce this, so we are standardizing on UTF-8 to avoid string-mangling.\n\nReviewed By: dreiss\n\nTest Plan: Code all works the exact same in the normal case, and doesn\u0027t mangle characters beyond ASCII or ISO-LATIN-1\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665321 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "ffc21fb792b152ed6b45c4e83b4c5fd295465007", "tree": "04faf4ba5f5bcc7378a4ad08f88f624181afad21", "parents": [ "b000f7433dd0a767e191b7e78b7da38a3b9670cd" ], "author": { "name": "lklots", "email": "dev-null@apache.org", "time": "Fri Nov 02 23:01:27 2007 +0000" }, "committer": { "name": "lklots", "email": "dev-null@apache.org", "time": "Fri Nov 02 23:01:27 2007 +0000" }, "message": "[TMemoryBuffer: an in-memory buffer acting like a transport]\n\nSummary: This is the php equivalent of the cpp TMemoryBuffer.\n It is simply a transport that stores read and fetches write\n requests to and from a string.\n\nTrac Bug: #\n\nBlame Rev:\n\nReviewed By: dreiss\n\nTest Plan: Tested using thrift de/serialization. Wrote thrift objeccts\n to the buffer and then read them later to resconstruct them.\n Tested exceptional cases.\n\nRevert Plan: ok\n\nDatabase Impact: none\n\nMemcache Impact: none\n\nOther Notes:\n\nEImportant:\n\n- begin *PUBLIC* platform impact section -\nBugzilla: #\n- end platform impact -\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665320 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "b000f7433dd0a767e191b7e78b7da38a3b9670cd", "tree": "05acb7b3e8b0af34c7b641bbe563be3a3cd9a420", "parents": [ "f36e484cfb8a919e8bc587bec91d14ef55e2eb1b" ], "author": { "name": "hzhao", "email": "dev-null@apache.org", "time": "Fri Nov 02 03:18:28 2007 +0000" }, "committer": { "name": "hzhao", "email": "dev-null@apache.org", "time": "Fri Nov 02 03:18:28 2007 +0000" }, "message": "[thrift_protocol] need negative testing for default inclusion\n\nReviewed By: dweatherford\nTest Plan: dev026 build\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665319 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "f36e484cfb8a919e8bc587bec91d14ef55e2eb1b", "tree": "05fb3da1de1f24ffce406b69be06e80d654a96c3", "parents": [ "83be086c7d8bf7d6b61f953c15737e3bbd25c91a" ], "author": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Fri Nov 02 02:22:25 2007 +0000" }, "committer": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Fri Nov 02 02:22:25 2007 +0000" }, "message": "[thrift] return empty string instead of NULL\n\nSummary: Turns out they\u0027re different, oops\nReviewed By: marcel\nTest Plan: recompile, reinstall, synapse:tablet.get() on a nonexistent cell (which returns an empty string)\nRevert: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665318 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "83be086c7d8bf7d6b61f953c15737e3bbd25c91a", "tree": "3faf058906f655e58d3ddfbf5b77ae3e2b57d8b4", "parents": [ "8ebe4a1757145121f9af74d0d9f172d418771cfa" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Nov 01 17:15:35 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Nov 01 17:15:35 2007 +0000" }, "message": "Thrift: Create directories with more permissive modes.\n\nSummary:\nHow many times has no one else been able to use your awesome Python script\nbecause the Thrift generated files are in a directory that they can\u0027t access?\nNever again! We now create directories with mode 0777.\nOf course, your process umask will ensure that they are actually created\nwith mode 0755. (This is how the mkdir command works.)\n\nReviewed By: mcslee\n\nTest Plan:\nRebuilt thrift, then did this:\ndreiss@dreiss-vmware:dir_mode:thrift/test$ rm -rf gen-*\ndreiss@dreiss-vmware:dir_mode:thrift/test$ thrift -cpp -java -php -py ThriftTest.thrift\ndreiss@dreiss-vmware:dir_mode:thrift/test$ ls -ld gen-*\ndrwx------ 2 dreiss dreiss 4096 2007-10-18 12:20 gen-cpp\ndrwx------ 3 dreiss dreiss 4096 2007-10-18 12:20 gen-java\ndrwx------ 2 dreiss dreiss 4096 2007-10-18 12:20 gen-php\ndrwx------ 3 dreiss dreiss 4096 2007-10-18 12:20 gen-py\ndreiss@dreiss-vmware:dir_mode:thrift/test$ rm -rf gen-*\ndreiss@dreiss-vmware:dir_mode:thrift/test$ ../compiler/cpp/thrift -cpp -java -php -py ThriftTest.thrift\ndreiss@dreiss-vmware:dir_mode:thrift/test$ ls -ld gen-*\ndrwxr-xr-x 2 dreiss dreiss 4096 2007-10-18 12:20 gen-cpp\ndrwxr-xr-x 3 dreiss dreiss 4096 2007-10-18 12:20 gen-java\ndrwxr-xr-x 2 dreiss dreiss 4096 2007-10-18 12:20 gen-php\ndrwxr-xr-x 3 dreiss dreiss 4096 2007-10-18 12:20 gen-py\ndreiss@dreiss-vmware:dir_mode:thrift/test$\n\nRevert Plan: ok\n\nOther Notes:\nWith some help from external contributor Ben Maurer.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665317 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "8ebe4a1757145121f9af74d0d9f172d418771cfa", "tree": "30ee85f23bd0b046d003d0761b78bf24953ed635", "parents": [ "80940b70e8af3d379e0c822895fa5fcfa51a7dad" ], "author": { "name": "boz", "email": "dev-null@apache.org", "time": "Thu Nov 01 07:37:45 2007 +0000" }, "committer": { "name": "boz", "email": "dev-null@apache.org", "time": "Thu Nov 01 07:37:45 2007 +0000" }, "message": "THRIFT: update the thrift extension\n\nSummary: more ZTS stuff\n\nReviewed By: hzhao\n\nTest Plan: the same tests still pass\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665316 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "80940b70e8af3d379e0c822895fa5fcfa51a7dad", "tree": "bb4c7d3919aa3dc0bc2afa9030e139c3f0d6067e", "parents": [ "83f14ee795917b2f8fa7eb8c18564161b69d9780" ], "author": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Wed Oct 31 23:30:56 2007 +0000" }, "committer": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Wed Oct 31 23:30:56 2007 +0000" }, "message": "[thrift] Merge protocol/transport changes from tfb/www\n\nSummary: Supporting the thrift_protocol extension.\n Relevant changesets are r66531, r66700, r66708\nReviewed By: mcslee\nTest Plan: same code already runs in tfb trunk, php -l\nRevert: svn\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665315 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "83f14ee795917b2f8fa7eb8c18564161b69d9780", "tree": "0e8d192793eca0fbc289239b92c08f282b475b6a", "parents": [ "5afc0aae324e8ad31ff2122ae33d6963ebf75c1d" ], "author": { "name": "eletuchy", "email": "dev-null@apache.org", "time": "Wed Oct 31 13:40:48 2007 +0000" }, "committer": { "name": "eletuchy", "email": "dev-null@apache.org", "time": "Wed Oct 31 13:40:48 2007 +0000" }, "message": "[thrift] erlang structs now compile\n\nSummary: if \"cond and cond -\u003e\" is not valid erlang,\n if \"cond andalso cond -\u003e\" is.\n\nReviewed By: cpiro\n\nTest Plan: generated erlang from and thrift file with structs ...\n generated code compiles\n\nRevert Plan: sure\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665314 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "5afc0aae324e8ad31ff2122ae33d6963ebf75c1d", "tree": "104285205de15887aefc0391be41cb77ad949679", "parents": [ "51c03936206fbde7b6b980c8d745f758b464c9bc" ], "author": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Wed Oct 31 06:03:54 2007 +0000" }, "committer": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Wed Oct 31 06:03:54 2007 +0000" }, "message": "[thrift] PHP generator: extension support\n\nSummary: Adds php code generation to take advantage of the php\n \u0027thrift_protocol\u0027 extension (currently for deserialization only)\n\n Requires you to swap your protocol for a TBinaryProtocolAccelerated\n (which just inherits TBinaryProtocol without actually adding any\n new functionality) and that you use a TFramedTransport or wrap your\n transport in a TBufferedTransport.\n\n TBinaryProtocolAccelerated is currently only in tfb/www/lib (or will\n be momentarily).\n\nReviewed By: mcslee\nTest Plan: synapse_feed uses this in my sandbox, works fine\nRevert: svn\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665313 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "51c03936206fbde7b6b980c8d745f758b464c9bc", "tree": "1a43a1601e12cacb8ec58608bc57aa4f7dabdf2c", "parents": [ "65b7075b5aa64c139ad59a3db35ddddda6a2203f" ], "author": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Wed Oct 31 04:22:12 2007 +0000" }, "committer": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Wed Oct 31 04:22:12 2007 +0000" }, "message": "[thrift] PHP thrift_protocol extension\n\nSummary: Implement a deserializer for thrift integral types and containers\n in C++ for extra performance. To be combined with compiler support to\n generate code that uses the extension + TBinaryProtocolAccelerated to\n enable it.\n\nReviewed By: mcslee\nTest Plan: runs fine in my sandbox...\nRevert: svn\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665312 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "65b7075b5aa64c139ad59a3db35ddddda6a2203f", "tree": "2dcfa8fdb35e09fd420adb69a7965a29c2545819", "parents": [ "3e098b1757724eb2e78a4abc1306a32abaf610b2" ], "author": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Wed Oct 31 02:18:14 2007 +0000" }, "committer": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Wed Oct 31 02:18:14 2007 +0000" }, "message": "[thrift] Output dir selection + updated TSCons\n\nSummary: Allows setting the output directory via the new \u0027-o dir\u0027 cmdline option.\n\n TSCons is updated to use this to put the output in the right place no matter\n the cwd, so doing dependent builds from different directories won\u0027t break.\n\nReviewed By: martin\nTest Plan: mkdir /tmp/honk; thrift -cpp -java -javabean -php -phpi -py -rb -xsd -perl -erl -ocaml -hs -cocoa -o /tmp/honk Tablet.thrift\nRevert: svn\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665311 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "3e098b1757724eb2e78a4abc1306a32abaf610b2", "tree": "a1a38406cc2393d8bcf023a4807a840904134b60", "parents": [ "5e60901123f267ab6f1aa3c395560c965dbac724" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Oct 30 16:55:47 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Oct 30 16:55:47 2007 +0000" }, "message": "Fix handling of ruby write parameters due to nil vs false\n\nSummary: Need to check for !\u003d nil, not just boolean expression\n\nReviewed By: mcslee\n\nTest Plan: Send a boolean \"false\" value\n\nOther Notes: Patch submitted by Patrick Collison\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665310 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "5e60901123f267ab6f1aa3c395560c965dbac724", "tree": "57dcd5c063cd0c4ab624e365eb58657df499ac4f", "parents": [ "2e7801d7c0b7b881067f4f84c664f22e64a988fa" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Oct 24 03:35:36 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Oct 24 03:35:36 2007 +0000" }, "message": "Thrift: Reorganize Cocoa library.\n\nSummary:\nExternal patch from Andrew McGeachie.\nJust shuffle the Cocoa library files around.\n\nReviewed By: mcslee\n\nTest Plan: In Andrew we trust.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665309 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "2e7801d7c0b7b881067f4f84c664f22e64a988fa", "tree": "f18e308bc0d93a5203be62f991466a2d78a1a191", "parents": [ "6c46f1a8c98113ff5951ae8974339cdeda0eb4bc" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Oct 24 02:56:24 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Oct 24 02:56:24 2007 +0000" }, "message": "Make the Java generator respect the optional keyword in struct writers\n\nReviewed By: dreiss\n\nTest Plan: Generate Java code. Check functionality and safe compile\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665308 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "6c46f1a8c98113ff5951ae8974339cdeda0eb4bc", "tree": "e29bd774c1126039dd2928dccd2dcef32e308891", "parents": [ "969b226b06aa80b4d35e0190b69569bdeb8d926c" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Tue Oct 23 09:47:15 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Tue Oct 23 09:47:15 2007 +0000" }, "message": "[thrift] gut Erlang Thrift configuration; start using get_env\n\nSummary: I patterned some config stuff after iserve, but Erlang\u0027s built-in stuff is better\n\nReviewed By: gopher\n\nTest Plan: works with recent ch server\n\nRevert Plan: ok\n\nOther Notes: default config given in thrift.app\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665307 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "969b226b06aa80b4d35e0190b69569bdeb8d926c", "tree": "3eb0153d6b22c4ba67049f92bd19f86e26d9e766", "parents": [ "3b63fe4d3c75b20250ca1977750d4b4b3f80bf9b" ], "author": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Tue Oct 23 00:26:44 2007 +0000" }, "committer": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Tue Oct 23 00:26:44 2007 +0000" }, "message": "[thrift] Updating gen_phpi for new header format\n\nSummary: This was still sending/expecting the old style (no version field); should be fixed now.\nReviewed By: mcslee\nTest Plan: build and use Tablemaster and Tablet interfaces with gen-phpi\nRevert: svn\nDiffCamp Revision: 1435\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665306 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "3b63fe4d3c75b20250ca1977750d4b4b3f80bf9b", "tree": "fe2cb616eea354fe68ade995f24d43c0e4107e30", "parents": [ "14b0ed6fad8fab2a22595f6a2a0407cf1b211763" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Fri Oct 19 21:34:31 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Fri Oct 19 21:34:31 2007 +0000" }, "message": "[thrift] clean up error logging in Erlang\n\nSummary: pushed all formatting out of thrift_error_logger.erl, reenable crash logs, standardize\n\nReviewed By: eletuchy\n\nTest Plan: works with latest ch server\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665305 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "14b0ed6fad8fab2a22595f6a2a0407cf1b211763", "tree": "82c438f8426124c8d5298373827f9e5c4a172603", "parents": [ "2b9ddab14cf8bc64e50e3f2cf2334b9503b60866" ], "author": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Fri Oct 19 01:03:32 2007 +0000" }, "committer": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Fri Oct 19 01:03:32 2007 +0000" }, "message": "[thrift] TSocket host and port getters\n\nSummary: \"Porting\" this feature from PHP; I find it useful in the Synapse client.\nReviewed By: mcslee\nTest Plan: It compiles, ship it!\nRevert: svn\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665304 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "2b9ddab14cf8bc64e50e3f2cf2334b9503b60866", "tree": "3ae2c7dcee501a9efb0e164c276af714af85b8f7", "parents": [ "65e595f54fb188b112ef050fbd56914b509f7b2e" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Oct 17 03:39:55 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Oct 17 03:39:55 2007 +0000" }, "message": "Thrift: Kill a warning.\n\nSummary:\nThese should always have been const.\n\nReviewed By: mcslee\n\nTest Plan:\nRe-ran the dense protocol test.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665303 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "65e595f54fb188b112ef050fbd56914b509f7b2e", "tree": "f7993673a825005b7d30dc7bbbc3203fbc994891", "parents": [ "524c3ecef7954fbd1c7820b160426a069fef819f" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon Oct 15 21:32:12 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon Oct 15 21:32:12 2007 +0000" }, "message": "Generate REST code properly for objects/struct arguments\n\nReviewed By: hzhao\n\nTest Plan: Data store API\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665302 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "524c3ecef7954fbd1c7820b160426a069fef819f", "tree": "1134cfce7ab82aac6ecf77c735856c9d9b685253", "parents": [ "7b19b65a1623d197395b0cac79720666e8aa5d82" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Sat Oct 13 05:15:33 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Sat Oct 13 05:15:33 2007 +0000" }, "message": "[thrift] make thrift_logger.erl more robust against badmatch\n\nSummary: more robust logic theres\n\nReviewed By: eletuchy\n\nTest Plan: ok\n\nRevert Plan: ok\n\nOther Notes: the precommit hooks should forbid out-of-towners from being cited as reviewers\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665301 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "7b19b65a1623d197395b0cac79720666e8aa5d82", "tree": "8864ed574e6e7dbc8ab77117a8348776eec85d4c", "parents": [ "b6dcd2b595724fd9c3d575466db8394dc16be3ae" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Sat Oct 13 05:10:52 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Sat Oct 13 05:10:52 2007 +0000" }, "message": "[thrift] Erlang Thrift \u0027oop:get\u0027 -\u003e \u0027This#\u0027\n\nSummary: the client structures aren\u0027t oop objects, they\u0027re vanilla records ... adjust accordingly\n\nReviewed By: eletuchy\n\nTest Plan: ok\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665300 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "b6dcd2b595724fd9c3d575466db8394dc16be3ae", "tree": "bff0f569f3a1bd1d3ab10ee082a9b53f4e4a360c", "parents": [ "b92e3164767027e7b0048717dcac6741c31d7a3e" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Sat Oct 13 01:11:46 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Sat Oct 13 01:11:46 2007 +0000" }, "message": "[thrift] retool oop.erl, fix tBufferedTransportFactory.erl\n\nSummary: oop.erl used to assume that an undef or function_clause meant a method wasn\u0027t defined, but sometimes a method does exist and an undef happens while it\u0027s executing.\n\nCase in point, getTransport in tBufferedTransportFactory totally didn\u0027t work and instead of exiting, oop.erl fell back silently to tTransportFactory, so everywhere I thought I was talking to tBufferedTransport, I was talking directly to the tSocket. borkborkbork.\n\nBlame: all me baby\n\nReviewed By: eletuchy\n\nTest Plan: channel server works\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665299 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "b92e3164767027e7b0048717dcac6741c31d7a3e", "tree": "6cb238388fa567d22b3bc263a2df1c6cf9e52809", "parents": [ "d1372829e65dcca66ab0ca75a20919e76bbf7fc9" ], "author": { "name": "pkeyani", "email": "dev-null@apache.org", "time": "Wed Oct 10 05:22:31 2007 +0000" }, "committer": { "name": "pkeyani", "email": "dev-null@apache.org", "time": "Wed Oct 10 05:22:31 2007 +0000" }, "message": "made tutorial.thrift executable\n\nSummary: made tutorial.thrift executable\n\nTrac Bug: #\n\nBlame Rev:\n\nReviewed By: mcslee\n\nTest Plan: tested locally\n\nRevert Plan: revertable\n\nNotes:\n\nEImportant:\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665298 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "d1372829e65dcca66ab0ca75a20919e76bbf7fc9", "tree": "410e4bd08e9febf46b94a40b0cbb8727b50999d4", "parents": [ "34b2926d5ca9b6068fa863e7d5e0a4055cbbef30" ], "author": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Tue Oct 09 22:57:23 2007 +0000" }, "committer": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Tue Oct 09 22:57:23 2007 +0000" }, "message": "[thrift] TSocketPool::addServer, c++ version\n\nSummary: Same thing as the previous PHP change. Also includes a new constructor for easy building of a TSocketPool with a single host (for later filling in via addServer) without extra std::vector boxing/unboxing.\n\nReviewed By: mcslee\n\nTest Plan: Synapse c++ client at r62896 uses this.\n\nRevert: OK\n\nTracCamp Project: Thrift\n\nDiffCamp Revision: 909\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665297 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "34b2926d5ca9b6068fa863e7d5e0a4055cbbef30", "tree": "3e91dfc24532df55f48a61ad2b1745366fd8287c", "parents": [ "4c3d7b84b62c7a0f5974e376a0cb32fe599d0277" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Oct 09 20:55:10 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Oct 09 20:55:10 2007 +0000" }, "message": "Java Thrift objects implement common base interface\n\nReviewed By: dreiss\n\nTest Plan: Generate java code and run against new library.\n\nRevert: OK\n\nDiffCamp Revision: 900\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665296 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "4c3d7b84b62c7a0f5974e376a0cb32fe599d0277", "tree": "917048687443f9ef924aa9a695e22d12ec6752d8", "parents": [ "6c848a02df5cf8276f25091e96582ac16a4358fb" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Tue Oct 09 04:41:48 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Tue Oct 09 04:41:48 2007 +0000" }, "message": "[thrift] don\u0027t scope non-service types in Erlang\n\nSummary: kind of funny ... exact same patch as for the Ruby version; both were unexposed until I tried using reflection_limited\n\nTest Plan: thx but nothx\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665295 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "6c848a02df5cf8276f25091e96582ac16a4358fb", "tree": "3a6278695b130a5b933b7829fc071e79d46620cc", "parents": [ "5299a959e0ac89ce26b6ad4f73b893207f9bae3d" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon Oct 08 22:31:03 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon Oct 08 22:31:03 2007 +0000" }, "message": "Use json encoding logic for \u003clist\u003e and \u003cset\u003e args in Thrift PHP/REST\n\nReviewed By: hzhao\n\nTest Plan: Data store API interface\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665294 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "5299a959e0ac89ce26b6ad4f73b893207f9bae3d", "tree": "3315cf30cdcf8c8524bcb49a35f254f130f9eac2", "parents": [ "6fc7be28bb1363adaedee47c34ea0262e3346eb4" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Oct 05 00:13:24 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Oct 05 00:13:24 2007 +0000" }, "message": "Python automated test patch\n\nSummary: Submitted by Ben Maurer\n\nReviewed By: dreiss\n\nTest Plan: Automated python testing for Thrift, lovely.\n\nRevert: OK\n\nDiffCamp Revision: 737\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665293 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "6fc7be28bb1363adaedee47c34ea0262e3346eb4", "tree": "c1629a69032bf6582b17e0ffb80549aa048a11a7", "parents": [ "e4e1968935f0dce5720f82baef19605f64512120" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Oct 04 23:02:01 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Oct 04 23:02:01 2007 +0000" }, "message": "Thrift: TNullTransport for PHP.\n\nSummary:\nWe have this in C++. Adding an implementation for PHP.\n\nReviewed By: mcslee\n\nTest Plan:\nUsed it while testing web code.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665292 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "e4e1968935f0dce5720f82baef19605f64512120", "tree": "bdf95efc989c54f684e5884105eb5cbaec886372", "parents": [ "165eca9c7cdfcbc3b6ac4d8eeadb8e1c80a2584c" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Oct 04 01:54:11 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Oct 04 01:54:11 2007 +0000" }, "message": "[thrift] don\u0027t scope non-service types in Ruby\n\nSummary: non-service types live in the top-level namespace, so look for them there. example from FacebookService.rb (accessing Service from reflection_limited_types.rb):\n\n FIELDS \u003d {\n - 0 \u003d\u003e {:type \u003d\u003e TType::STRUCT, :name \u003d\u003e \u0027success\u0027, :class \u003d\u003e reflection_limited_types.Service}\n + 0 \u003d\u003e {:type \u003d\u003e TType::STRUCT, :name \u003d\u003e \u0027success\u0027, :class \u003d\u003e Service}\n }\n\n preferable to adding a \"module honk_types ... end\" around honk_types.rb ... non-service types should land in top-level space (or whatever ruby_namespace has been defined). if ruby_namespace even works ... who knows\n\nReviewed By: mcslee\n\nTest Plan: now reflection_limited works with my simple Ruby client\n\n honestly, there\u0027s no test suite for these? TODO:cpiro\n\nRevert: OK\n\nTracCamp Project: Thrift\n\nDiffCamp Revision: 735\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665291 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "165eca9c7cdfcbc3b6ac4d8eeadb8e1c80a2584c", "tree": "24ef4cdd778c7b3342262c77994a4046193df80a", "parents": [ "145429602687d1785c485bcd1ea9dcd83f28bda4" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Oct 04 01:19:20 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Oct 04 01:19:20 2007 +0000" }, "message": "Make REST PHP deserializer generated PHP code support map/list/set\n\nSummary: list/set are comma-separated and explode, map is JSON decoded\n\nReviewed By: hzhao\n\nTest Plan: Invoke API methods via JSON\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665290 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "145429602687d1785c485bcd1ea9dcd83f28bda4", "tree": "ab61887bb062628587ca928e29bfd33693ff9d15", "parents": [ "73e3dd7d5fdd30301816982d2cd6a961380538ac" ], "author": { "name": "yunfang", "email": "dev-null@apache.org", "time": "Wed Oct 03 22:59:41 2007 +0000" }, "committer": { "name": "yunfang", "email": "dev-null@apache.org", "time": "Wed Oct 03 22:59:41 2007 +0000" }, "message": "[Explicitly declare shared_ptr]\nSummary:\njust some simple styling changes. moving using boost::shared_ptr to .cpp\n and using the full path name in .h\nReviewed by: boz, dreiss\nTest Plan: compiled and tested on the adfinder\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665289 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "73e3dd7d5fdd30301816982d2cd6a961380538ac", "tree": "4c67bf32c240134da6ccc6231ec5a56058ba171f", "parents": [ "9b36ef3575c13aa360f1b2fac312683270978094" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Wed Oct 03 07:13:44 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Wed Oct 03 07:13:44 2007 +0000" }, "message": "[thrift] fix Ruby codegen: capitalize module name for enums\n\nSummary: all module names must be capitalized in Ruby -- if the enum name from the interface isn\u0027t capitalized \\\n then it\u0027s a runtime error, e.g. in fb303_types.rb:\n\n -module fb_status\n +module Fb_status\n\nReviewed By: mcslee\n\nTest Plan: fb303 now works with Ruby binding\n\nRevert: OK\n\nTracCamp Project: Thrift\n\nDiffCamp Revision: 692\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665288 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "9b36ef3575c13aa360f1b2fac312683270978094", "tree": "3c0651d83576a9fe1b704d690e6b8f01e7014653", "parents": [ "780e4ecac988ba8aeea794631da2ea9a24c7717b" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Oct 02 04:44:48 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Oct 02 04:44:48 2007 +0000" }, "message": "Fix 32-bit Python encoding integer issue\n\nSummary: Python on 32-bit platforms 2.4+ wants to keep hexconstants positive, therefore converting 0x800000000 to a (long) type to keep that. This causes issues when performing comparison with a signed negative integer.\n\nReviewed By: dreiss\n\nTest Plan: Python on 32 bit 2.4+ system making Thrift calls\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665287 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "780e4ecac988ba8aeea794631da2ea9a24c7717b", "tree": "cf6b1b6ebf3d86b89c5fd9034b4233da05413828", "parents": [ "efd5eec21194c7b9e92fb17a26329e26b202e4f3" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Oct 02 04:43:31 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Oct 02 04:43:31 2007 +0000" }, "message": "Fix missing break statements in Java ProtocolUtil\n\nSummary: Oops. switch statement n00b error.\n\nReviewed By: jssarma\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665286 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "efd5eec21194c7b9e92fb17a26329e26b202e4f3", "tree": "cf9f713b4d689bae82321038e7bfe9ca95ffbf6b", "parents": [ "68940295e1b2e8caca6376b95879ef252bc5dd3e" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Tue Oct 02 01:33:37 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Tue Oct 02 01:33:37 2007 +0000" }, "message": "[thrift] Erlang Thrift changes, take 3\n\nSummary: svn ci missed a bunch of paths ... blew away the whole thing and copied from the git repo. this is getting ridiculous.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665285 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "68940295e1b2e8caca6376b95879ef252bc5dd3e", "tree": "ad1821a19f6391c8455b244a1bc90000e4ee61dc", "parents": [ "42fe4b9a3e20e07160b5f32c652b47fa2cb09141" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Tue Oct 02 00:35:12 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Tue Oct 02 00:35:12 2007 +0000" }, "message": "[thrift] otpification and sane configuration for Erlang Thrift\n\nSummary: a small victory in the neverending quest of OTPifying this binding -- search for config files in ./conf/ (relative to the cwd of the emulator). for example, when you start the channel server, ./conf/{channel,thrift}.conf should exist. better than having to recompile to change a configuration ... reconfig should take care of that in running code.\n\nTest Plan: works with channel server\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665284 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "42fe4b9a3e20e07160b5f32c652b47fa2cb09141", "tree": "df5de2468581f2286c6036f743fb816acb350583", "parents": [ "c7fd7639b7a4fbfd5948d9c552baf118bc94c3c3" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Tue Oct 02 00:24:07 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Tue Oct 02 00:24:07 2007 +0000" }, "message": "[thrift] revert 61883\n\nSummary: i suck at git/svn ... commited not enough and with no commitlog\n\nNotes: YOU\u0027RE DOING IT WRONG\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665283 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "c7fd7639b7a4fbfd5948d9c552baf118bc94c3c3", "tree": "ad1821a19f6391c8455b244a1bc90000e4ee61dc", "parents": [ "77575e69bbb9a8bc4b7d392abec781150c4cb039" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Tue Oct 02 00:05:04 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Tue Oct 02 00:05:04 2007 +0000" }, "message": "Merge branch \u0027otp\u0027\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665282 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "77575e69bbb9a8bc4b7d392abec781150c4cb039", "tree": "b07eff1a631b1290c35fc983f527bb483b8e75fc", "parents": [ "19cee90ca41922a4437d547a2298201359bbcdcc" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon Sep 24 19:24:53 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon Sep 24 19:24:53 2007 +0000" }, "message": "Merging more server support and exception fixes for Cocoa\n\nSummary: Submitted by Andrew McGeachie.\n\nReviewed By: mcslee\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665281 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "19cee90ca41922a4437d547a2298201359bbcdcc", "tree": "b39d2712ba039decb838237549fdb846432e0b63", "parents": [ "623096780fa745658e6336390c8e45bfd1f28d24" ], "author": { "name": "boz", "email": "dev-null@apache.org", "time": "Sat Sep 22 23:08:11 2007 +0000" }, "committer": { "name": "boz", "email": "dev-null@apache.org", "time": "Sat Sep 22 23:08:11 2007 +0000" }, "message": "THRIFT: Make the mutex assignable\n\nSummary: we need to use a shared_ptr instead of an old fashioned one if we\u0027re\ngoing to stick with this PIMPL model\n\nReviewed By: dreiss, marc\n\nTest Plan: test program didn\u0027t fail or leak memory, foreman (fb303 client)\nworked without problem\n\nRevert Plan: just make sure you find some other solution to this problem\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665280 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "623096780fa745658e6336390c8e45bfd1f28d24", "tree": "bf9bd7b0ccf89b632afccff4b1f69c2b060d4724", "parents": [ "aa3c5a882c747a7686fc3dac8f7a5572cc55cdfd" ], "author": { "name": "boz", "email": "dev-null@apache.org", "time": "Thu Sep 20 23:24:16 2007 +0000" }, "committer": { "name": "boz", "email": "dev-null@apache.org", "time": "Thu Sep 20 23:24:16 2007 +0000" }, "message": "THRIFT: Mutex and ReadWriteMutex leaked memory, now they don\u0027t\n\nSummary: also added myself to CONTRIBUTORS.\n\nReviewed By: marc\n\nTest Plan: the following program no longer leaks memory (valgrind):\n\nint main(int argc, char **argv){\n Mutex mu;\n mu.lock();\n mu.unlock();\n}\n\nRevert Plan: ok\n\nNotes: this is kind of important\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665279 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "aa3c5a882c747a7686fc3dac8f7a5572cc55cdfd", "tree": "0e69a7c6e38e421caff3242338080e645ba4dcfa", "parents": [ "2ac60ed96d3075b367ef18aa96787c68330d0248" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Sep 19 21:12:52 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Sep 19 21:12:52 2007 +0000" }, "message": "Merging latest minor Cocoa changes\n\nSummary: BinaryProtocol handling of null strings, destructor, and contributors email fix. Submitted by Andrew McGeachie\n\nReviewed By: mcslee\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665278 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "2ac60ed96d3075b367ef18aa96787c68330d0248", "tree": "fdf8d1ed046e20516cac60d0527beb66eff523ec", "parents": [ "8266443d925794b4323bae7cc840f5a9827ac874" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Sep 19 21:10:18 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Sep 19 21:10:18 2007 +0000" }, "message": "Whoops forgot to actually svn add Andrew\u0027s files\n\nSummary: Tricky svn add command will get you every time\n\nReviewed By: dreiss\n\nTest Plan: test/ tutorial/ Cocoa code\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665277 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "8266443d925794b4323bae7cc840f5a9827ac874", "tree": "146ffeadd96ac21ba0fa58b1b5bc7ef68f9cb25d", "parents": [ "b8f0d496c16504f43e0d5c9ec6e6090742a4a086" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Sep 19 06:49:30 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Sep 19 06:49:30 2007 +0000" }, "message": "OO perl accessors for Thrift objects\n\nSummary: Submitted by Jake Luciani\n\nReviewed By: cpiro\n\nTest Plan: Supplied in test/tutorial code\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665276 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "b8f0d496c16504f43e0d5c9ec6e6090742a4a086", "tree": "b23607cab42bfc36b9feee6b08565d2f8c18aa91", "parents": [ "b72d19f653878dddfe09d01082dad3f077ecf95a" ], "author": { "name": "eletuchy", "email": "dev-null@apache.org", "time": "Wed Sep 19 01:23:19 2007 +0000" }, "committer": { "name": "eletuchy", "email": "dev-null@apache.org", "time": "Wed Sep 19 01:23:19 2007 +0000" }, "message": "[thrift] checking in generated reflection code into java library\n\nSummary: Generated this code using:\n /usr/local/share/thrift/if/reflection_limited.thrift\n\nReviewed By: dreiss\n\nTest Plan: compiled chat_importer (a java FacebookService) against this.\n\nRevert Plan: sure\n\nDatabase Impact:\n\nMemcache Impact:\n\nOther Notes:\n\nEImportant:\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665275 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "b72d19f653878dddfe09d01082dad3f077ecf95a", "tree": "c36fec3a5ec85072c64a70a12e07b94619f18265", "parents": [ "93a0664affc0805d11c9d69ae9989e96f2700842" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Sep 18 19:46:00 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Sep 18 19:46:00 2007 +0000" }, "message": "Thrift: Prep for release.\n\nSummary:\n- make dist is no fun. Had to add a lot of stuff to Makefile.am to\n make sure stuff got included in the tarball.\n- Added a permanent NEWS file with the release notes for this release.\n- clean.sh removes ylwrap also.\n- Gave it a real version for make dist.\n- Added ACLOCAL_AMFLAGS to lib/cpp/Makefile.am to make it easier to\n work on configure.ac.\n- Made concurrency_test a non-installed binary because\n no one wants to install it.\n- Dropped some symlinks that were annoying make dist.\n- Updated README.\n\nTest Plan:\n./bootstrap.sh \u0026\u0026 ./configure \u0026\u0026 make dist\nCompared contents of tarball to source tree.\nDid this from a fresh git tree so no gross untracked files would be around.\nOn devrs: ./bootstrap.sh \u0026\u0026 ./configure \u0026\u0026 make install DESTDIR\u003d/tmp/relinst1\nMade sure concurrency_test was built but not installed.\nChecked zlib URL with firefox.\n\nReviewed By: mcslee\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665274 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "93a0664affc0805d11c9d69ae9989e96f2700842", "tree": "daa5392f33fe1daf9f129588bdc7d74a659e6221", "parents": [ "0f6cc29f7237e4d2b1b757848e27ccc3efdbc513" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Tue Sep 18 06:23:33 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Tue Sep 18 06:23:33 2007 +0000" }, "message": "[thrift] spruce up Erlang binding for tonight\u0027s release\n\nSummary:\n * got rid of most of the otp_base jonx ... save that for a future release unfortunately\n * cleaned up the tutorial server, added -erl to tutorial.thrift\u0027s shebang\n * made better README and TODO\n\nTest Plan: checked out a copy, read my directions, built and ran the tutorial, and pretended that it didn\u0027t blow\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665273 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "0f6cc29f7237e4d2b1b757848e27ccc3efdbc513", "tree": "b59bd6d4a3aa2489458bba30cc6217ce4bb41784", "parents": [ "b97b89d1dc5398021443a3c281536c27f61ac038" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Tue Sep 18 02:14:31 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Tue Sep 18 02:14:31 2007 +0000" }, "message": "[thrift] fix _thrift for inheriting services\n\nSummary: obviously Iain\u0027s fault\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665272 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "b97b89d1dc5398021443a3c281536c27f61ac038", "tree": "237cf0c1ede456d26de42576ce7a063f2b0daf0e", "parents": [ "6137146329d2344aaba1a9b9492a7ed24b48a39e" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Tue Sep 18 00:07:42 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Tue Sep 18 00:07:42 2007 +0000" }, "message": "[thrift] give the generated Erlang service file a _thrift\n\nSummary: Before they were names Service.erl, but the Service module name should be reserved for more important things. Namespaces what?\n\nTest Plan: with channel server\n\nRiders: also fixes whitespace, puts -erl in its right place\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665271 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "6137146329d2344aaba1a9b9492a7ed24b48a39e", "tree": "5ea89a0f06e0b35f4b0c7f3367ea7d7ff9995054", "parents": [ "faebedd356985c3b2df5e39e1cf5b152c29fc179" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Sep 17 23:53:58 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Sep 17 23:53:58 2007 +0000" }, "message": "Thrift: Put today\u0027s date as the next Thrift release.\n\nReviewed By: root\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665270 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "faebedd356985c3b2df5e39e1cf5b152c29fc179", "tree": "ed22638b9d0e355fd9db1ba9d0f4f6045f6f9610", "parents": [ "f84b360d5c593653a3f038d526797805861b8ace" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Sep 17 23:20:38 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Sep 17 23:20:38 2007 +0000" }, "message": "Thrift: Re-committing zlib.\n\nSummary:\nSame as the last (reverted) zlib patch,\nbut this time with way more awesome support for building\nwith no zlib headers installed.\n\nReviewed By: mcslee\n\nTest Plan:\n- Did lots of really pathological stuff in my VMware.\n- On devrs004:\n ./bootstrap.sh \u0026\u0026 ./configure \u0026\u0026 make \u0026\u0026 make install DESTDIR\u003d/tmp/tzinst \u0026\u0026 echo \"Yay\"\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665269 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "f84b360d5c593653a3f038d526797805861b8ace", "tree": "671d7ce07ba060df01e4bd5028e94e5297658082", "parents": [ "79ae0f8d485a568ce94be9f86a2aa5f143856dda" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Sep 17 21:16:32 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Sep 17 21:16:32 2007 +0000" }, "message": "Thrift: Fix fingerprinting bug.\n\nSummary:\nFingerprints were\u0027nt being initialized properly because I forgot to move\nthe initialization from t_struct to t_type. Fixed that.\nAlso, typedefs weren\u0027t generating fingerprints for their true types.\n\nReviewed By: mcslee\n\nTest Plan:\nThis didn\u0027t work before with -cpp -dense. Now it does.\ntypedef list\u003ci32\u003e ilist\nstruct foo { 1: ilist l }\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665268 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "79ae0f8d485a568ce94be9f86a2aa5f143856dda", "tree": "95c5f6646d253458157da32722db0c31c4999d83", "parents": [ "476b796fd7d4d7036a106682ebcb73a63349b408" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Sep 17 21:15:47 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Sep 17 21:15:47 2007 +0000" }, "message": "Thrift: Compile without libevent.\n\nSummary:\n- Totally re-did the libevent check.\n- Thrift now compiles and instals cleanly without libevent.\n- (libevent is still needed to build libthriftnb.)\n\nReviewed By: mcslee\n\nTest Plan:\n- Ran configure and make in various configurations in my VMware.\n- Clean build and install of Thrift on devrs004 (into /tmp).\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665267 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "476b796fd7d4d7036a106682ebcb73a63349b408", "tree": "7423853fbf20f59d7e072d7659fe4a5d74f732b1", "parents": [ "fd7c26fec0ed25e5f6e134c7788258082723ee2c" ], "author": { "name": "mvaradachari", "email": "dev-null@apache.org", "time": "Mon Sep 17 20:40:16 2007 +0000" }, "committer": { "name": "mvaradachari", "email": "dev-null@apache.org", "time": "Mon Sep 17 20:40:16 2007 +0000" }, "message": "Updating TSCons.py to provide capability of passing additional flags to thrift besides the default flag --cpp. EX: scons_env(env,\u0027--py --php\u0027)\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665266 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "fd7c26fec0ed25e5f6e134c7788258082723ee2c", "tree": "96bf20196c667405287e3456747e3bf03603f008", "parents": [ "df72c01c37f4404df65971b5e538c4a47985bf81" ], "author": { "name": "Martin Kraemer", "email": "martin@apache.org", "time": "Mon Sep 17 06:58:47 2007 +0000" }, "committer": { "name": "Martin Kraemer", "email": "martin@apache.org", "time": "Mon Sep 17 06:58:47 2007 +0000" }, "message": "Thrift - typo in comment\n\nSummary:\nNot really worth notice. Just fixing some stray uppercase chars in a comment block.\n\nTrac Bug: #\n\nBlame Rev:\n\nReviewed By:\n\nTest Plan:\n\nRevert Plan:\n\nDatabase Impact:\n\nMemcache Impact:\n\nOther Notes:\n\nEImportant:\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665265 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "df72c01c37f4404df65971b5e538c4a47985bf81", "tree": "940f65d964992aea66900b8b938050e9e6b33de8", "parents": [ "5aea7c8d00b1c25fc6611c217d929c61cddd843e" ], "author": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Sat Sep 15 08:49:48 2007 +0000" }, "committer": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Sat Sep 15 08:49:48 2007 +0000" }, "message": "[thrift] C++: Pass std::exception from server to client\n\nSummary: Rather than an uncaught exception dropping the connection, catching std::exception (and anything derived from it) and passing its message payload back in the form of a T_EXCEPTION message is a much cleaner response.\nReviewed By: mcslee\nTest Plan: compile generated code for Synapse\u0027s tablet interface, throw a generic exception at the server, observe the message for the exception arising from the client in the form of a TApplicationException (instead of the previous \u0027no more data to read\u0027 exception)\nRevert: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665264 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "5aea7c8d00b1c25fc6611c217d929c61cddd843e", "tree": "261601c8faa3c9bdb93de0d24c9e3c8226e16816", "parents": [ "b8c6334d99acdc36eda81a1105f7760fd16cb3e5" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sat Sep 15 01:54:56 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sat Sep 15 01:54:56 2007 +0000" }, "message": "Thrift: Reverting TZlibTransport\n\nSummary:\nStupid Red Hat.\nThe dev boxes don\u0027t have the development packages for zlib.\n\nBlame Rev: 59856\n\nReviewed By: mcslee\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665263 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "b8c6334d99acdc36eda81a1105f7760fd16cb3e5", "tree": "02301766af0b034a2126cc6e46a1e37bcacbf242", "parents": [ "3d029786cda9ecc549e57c0a9a07bfaa454cb34d" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sat Sep 15 01:44:47 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sat Sep 15 01:44:47 2007 +0000" }, "message": "Thrift: Zlib transport.\n\nSummary:\nAdd a new transport to the C++ library: TZLibTransport.\nThis wraps another transport (just like TBufferedTransport),\ncompresses the data written to it, and uncompresses the data it reads.\n\nReviewed By: mcslee\n\nTest Plan:\nFor ax_lib_zlib.m4\n - Ran ./bootstrap.sh.\n - Looked at configure.\n - Ran ./configure.\n - Looked at config.status\n - Ran ./configure --with-zlib\u003d/usr.\n - Looked at config.status\n - Changed configure.ac to AC_LIB_ZLIB(1.2.4)\n - Ran ./configure.\n - Watched it fail.\n\nFor TZlibTransport\n - test/ZlibTest.cpp\n - Code coverage (hotness) report sent with review.\n - 100% line coverage for all the good stuff.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665262 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "3d029786cda9ecc549e57c0a9a07bfaa454cb34d", "tree": "261601c8faa3c9bdb93de0d24c9e3c8226e16816", "parents": [ "1ca5129de0946e777cc6dab9f0ce0c8646bff0d5" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Sep 14 22:18:09 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Sep 14 22:18:09 2007 +0000" }, "message": "Add missing writeEnd calls\n\nSummary: When flush is called this also should be\n\nReviewed By: aditya\n\nTest Plan: Use w/ PipedTransport. Should writeEnd() when an exception is thrown\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665261 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "1ca5129de0946e777cc6dab9f0ce0c8646bff0d5", "tree": "88ae7f91e759958b3fff3dec6ab8f19e1833fbcd", "parents": [ "33a7d898ca8d40d02cbd6a5b7547b7fa3958c3cf" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Sep 14 19:45:12 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Sep 14 19:45:12 2007 +0000" }, "message": "Update the Thrift CONTRIBUTORS file\n\nSummary: A bunch of people belong on this list. So we added them.\n\nReviewed By: root\n\nTest Plan: This is a text file\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665260 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "33a7d898ca8d40d02cbd6a5b7547b7fa3958c3cf", "tree": "e96beab79b6538313bb89bcadeac0d3ee76c3fd2", "parents": [ "ae8f1d3f2341660a84a9b64e05c1ee4bec6df581" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Sep 14 19:44:30 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Sep 14 19:44:30 2007 +0000" }, "message": "Merge more cocoa changes from Andrew McGeachie\n\nReviewed By: dreiss\n\nTest Plan: To be provided later by McGeachie. Compiler builds fine. Does not affect other libraries.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665259 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "ae8f1d3f2341660a84a9b64e05c1ee4bec6df581", "tree": "97ef60341542b5541752e6ff5a3b995b5aab244f", "parents": [ "ce161a96cddbea8916d0b20406b12d96772482ed" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Sep 12 01:45:12 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Sep 12 01:45:12 2007 +0000" }, "message": "Thrift: Update syntax files for Vim and Emacs.\n\nSummary:\nAdd recognition of the new Thrift keyword cocoa_prefix to\nthrift.vim and thrift.el.\n\nReviewed By: mcslee\n\nTest Plan: We don\u0027t need no stinkin\u0027 test plans!\n\nRevert Plan: ok\n\nOther Notes:\nAWESOMESAUCE! Thrift now supports namespaces, packages, prefixes, and modules.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665258 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "ce161a96cddbea8916d0b20406b12d96772482ed", "tree": "deb35caa60008c44d04468e3d8f3298e89e1fd11", "parents": [ "8775c73db2729f85fd66e2c8443a3628fd55a972" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Sep 11 22:09:42 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Sep 11 22:09:42 2007 +0000" }, "message": "Thrift: Clean up and test TDenseProtocol\n\nSummary:\n- TDenseProtocol now includes a part of the struct fingerprint in\n the serialized message, to protect from unserialzing trash.\n- A lot of cleanups and commenting for TDenseProtocol.\n- A lot of test cases for same.\n\nReviewed By: mcslee\n\nTest Plan: test/DenseProtoTest.cpp\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665257 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "8775c73db2729f85fd66e2c8443a3628fd55a972", "tree": "f5572c814637a67dd44d8a10a802d2cf4eb1b8ec", "parents": [ "7816572784c7ddafc2c4350b221469af12d198fc" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon Sep 10 22:33:05 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon Sep 10 22:33:05 2007 +0000" }, "message": "Add JavaDoc comments to generated Thrift Java code\n Reviewed By: dreiss\n Test Plan: Generate Java code from .thrift file w/ javadoc comments\n Revert: OK\n Notes: My first backend diffcamp review\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665256 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "7816572784c7ddafc2c4350b221469af12d198fc", "tree": "05aa1150e22b94f436fabc60e31751dc7aa7a1cc", "parents": [ "7e9eea48711d015a2764f119ea5e78d8b6447476" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon Sep 10 22:08:49 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon Sep 10 22:08:49 2007 +0000" }, "message": "Modify Thrift parser to disallow optional/required keywords in argument lists\n\nReviewed By: dreiss\n\nTest Plan: Toss an optional/required in an arg list, check that it\u0027s ignored and compiler spits a warning\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665255 13f79535-47bb-0310-9956-ffa450edef68\n" } ], "next": "7e9eea48711d015a2764f119ea5e78d8b6447476" }