)]}' { "log": [ { "commit": "79ae0f8d485a568ce94be9f86a2aa5f143856dda", "tree": "95c5f6646d253458157da32722db0c31c4999d83", "parents": [ "476b796fd7d4d7036a106682ebcb73a63349b408" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Sep 17 21:15:47 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Sep 17 21:15:47 2007 +0000" }, "message": "Thrift: Compile without libevent.\n\nSummary:\n- Totally re-did the libevent check.\n- Thrift now compiles and instals cleanly without libevent.\n- (libevent is still needed to build libthriftnb.)\n\nReviewed By: mcslee\n\nTest Plan:\n- Ran configure and make in various configurations in my VMware.\n- Clean build and install of Thrift on devrs004 (into /tmp).\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665267 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "fd7c26fec0ed25e5f6e134c7788258082723ee2c", "tree": "96bf20196c667405287e3456747e3bf03603f008", "parents": [ "df72c01c37f4404df65971b5e538c4a47985bf81" ], "author": { "name": "Martin Kraemer", "email": "martin@apache.org", "time": "Mon Sep 17 06:58:47 2007 +0000" }, "committer": { "name": "Martin Kraemer", "email": "martin@apache.org", "time": "Mon Sep 17 06:58:47 2007 +0000" }, "message": "Thrift - typo in comment\n\nSummary:\nNot really worth notice. Just fixing some stray uppercase chars in a comment block.\n\nTrac Bug: #\n\nBlame Rev:\n\nReviewed By:\n\nTest Plan:\n\nRevert Plan:\n\nDatabase Impact:\n\nMemcache Impact:\n\nOther Notes:\n\nEImportant:\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665265 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "5aea7c8d00b1c25fc6611c217d929c61cddd843e", "tree": "261601c8faa3c9bdb93de0d24c9e3c8226e16816", "parents": [ "b8c6334d99acdc36eda81a1105f7760fd16cb3e5" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sat Sep 15 01:54:56 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sat Sep 15 01:54:56 2007 +0000" }, "message": "Thrift: Reverting TZlibTransport\n\nSummary:\nStupid Red Hat.\nThe dev boxes don\u0027t have the development packages for zlib.\n\nBlame Rev: 59856\n\nReviewed By: mcslee\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665263 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "b8c6334d99acdc36eda81a1105f7760fd16cb3e5", "tree": "02301766af0b034a2126cc6e46a1e37bcacbf242", "parents": [ "3d029786cda9ecc549e57c0a9a07bfaa454cb34d" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sat Sep 15 01:44:47 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sat Sep 15 01:44:47 2007 +0000" }, "message": "Thrift: Zlib transport.\n\nSummary:\nAdd a new transport to the C++ library: TZLibTransport.\nThis wraps another transport (just like TBufferedTransport),\ncompresses the data written to it, and uncompresses the data it reads.\n\nReviewed By: mcslee\n\nTest Plan:\nFor ax_lib_zlib.m4\n - Ran ./bootstrap.sh.\n - Looked at configure.\n - Ran ./configure.\n - Looked at config.status\n - Ran ./configure --with-zlib\u003d/usr.\n - Looked at config.status\n - Changed configure.ac to AC_LIB_ZLIB(1.2.4)\n - Ran ./configure.\n - Watched it fail.\n\nFor TZlibTransport\n - test/ZlibTest.cpp\n - Code coverage (hotness) report sent with review.\n - 100% line coverage for all the good stuff.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665262 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "ce161a96cddbea8916d0b20406b12d96772482ed", "tree": "deb35caa60008c44d04468e3d8f3298e89e1fd11", "parents": [ "8775c73db2729f85fd66e2c8443a3628fd55a972" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Sep 11 22:09:42 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Sep 11 22:09:42 2007 +0000" }, "message": "Thrift: Clean up and test TDenseProtocol\n\nSummary:\n- TDenseProtocol now includes a part of the struct fingerprint in\n the serialized message, to protect from unserialzing trash.\n- A lot of cleanups and commenting for TDenseProtocol.\n- A lot of test cases for same.\n\nReviewed By: mcslee\n\nTest Plan: test/DenseProtoTest.cpp\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665257 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "e67c0e63b315873aba8fb6770821fc88bd276a74", "tree": "09b34bc3722012fe7489032f4a614006dd9604f4", "parents": [ "d8429fcc1020dec143e36dbfc055edbd3009f11b" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Sep 07 01:34:12 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Sep 07 01:34:12 2007 +0000" }, "message": "Thrift: TDenseProtocol using variable-length integers.\n\nReviewed By: mcslee\n\nTest Plan:\ntest/DenseProtoTest.cpp\n\nStill have to test:\n- Bounds checking.\n- borrow/consume on TBuffered and TFramed.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665252 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "d8429fcc1020dec143e36dbfc055edbd3009f11b", "tree": "42289b730c46428d53483c84cf3a723e208d0564", "parents": [ "2c2e6d27a238746a0db9982cc4eb35c093553361" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Sep 07 01:26:30 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Sep 07 01:26:30 2007 +0000" }, "message": "Thrift: New methods for C++ transports.\n\nSummary:\nTo support the upcoming variable-length encoding of integers in\nTDenseProtocol, augment Thrift transports with two new methods:\nborrow and consume. Borrow copies some data out of the transport\nwithout consuming it, and consume... consumes it.\n\nReviewed By: mcslee\n\nTest Plan:\nThrift compiles.\nShould check in variable-length integer code for TDenseProtocol\nright after this (git ruulz).\n\nRevert Plan: revert stuff that uses these methods also.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665251 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "4529c4b394d39900e1b50f6be08ba31553550c0d", "tree": "595cdd666af3a97b4ada02932f51d2bd33dba1ea", "parents": [ "d683219966237417297e8f0b24e6c8fce166c490" ], "author": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Wed Sep 05 01:01:15 2007 +0000" }, "committer": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Wed Sep 05 01:01:15 2007 +0000" }, "message": "-- adding hostinfo and time to GlobalOutput\n\nSummary:\n- makes thrift errors a lot more useful\n\nReviewed By: jwang, mcslee\n\nTest Plan: tested with search\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665249 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "4e7530d4e5eaee2ba54d67d2b096c7e705bb53ce", "tree": "dd17427ed417d8a1aff25ba6a01d6029cb539023", "parents": [ "47557bc8ad061a90c88d485979009c2ee8237854" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Sep 04 21:49:53 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Sep 04 21:49:53 2007 +0000" }, "message": "Thrift: TDenseProtocol.\n\nSummary:\n- Made some stuff in TBinaryProtocol protected instead of private.\n- Added a preliminary version of TDenseProtocol. This is still\n super highly experimental and gross, and I wrote a super scary\n comment to explain that to anyone foolish enough to try to use\n this in its current state.\n\nReviewed By: mcslee\n\nTest Plan: test/DenseProtoTest.cpp\n\nRevert Plan: ok\n\nMemcache Impact:\nSave memory if/when people use it.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665247 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "47557bc8ad061a90c88d485979009c2ee8237854", "tree": "a0a214d093e4239d88673c929593aeb198e34263", "parents": [ "d3f1a2d2ba1257718e7c442c1cf8ce4fb9516d78" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Sep 04 21:31:04 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Sep 04 21:31:04 2007 +0000" }, "message": "Thrift: Slight tweaks to local reflection.\n\nSummary:\nLocal reflection typespecs for structs now have a dummy T_STOP field at the end\nso we don\u0027t have to check the size on every iteration.\nThey also contain information about which fields are optional.\nAlso put a static pointer to the reflection in each structure.\n\nReviewed By: mcslee\n\nTest Plan: test/DenseLinkingTest.thrift\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665246 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "d3f1a2d2ba1257718e7c442c1cf8ce4fb9516d78", "tree": "8b692868db04ffd0a959013ed34bc8b71c186086", "parents": [ "5de75dd859bf1ffaa974fc8ae6dbd1ff1dada1b0" ], "author": { "name": "James Wang", "email": "jwang@apache.org", "time": "Fri Aug 31 23:45:53 2007 +0000" }, "committer": { "name": "James Wang", "email": "jwang@apache.org", "time": "Fri Aug 31 23:45:53 2007 +0000" }, "message": "Summary: Checking in fix to TFileTransport to remove redundant behavior of readEvent -- just return NULL or the next event\nAlso, checking in changes to the php generation code I made awhile ago, but forgot to check in\n\nReviewed By: aditya, mcslee\n\nTest Plan: Compiled thrift and falcon, and confirmed that falcon\u0027s print binary still worked\n\nRevert Plan: revertible\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665245 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "000b111922ccb9c53390bd8e337ae9d48fc80268", "tree": "14365fec65aca85f6b9a1353a2ff3dd600739fcf", "parents": [ "8b6c2ebf42b6ed4e2c9fced2e29a31483d9ac840" ], "author": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Fri Aug 31 08:03:05 2007 +0000" }, "committer": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Fri Aug 31 08:03:05 2007 +0000" }, "message": "-- cleaning up some Makefile issues\n\nReviewed By: jwang\n\nTest Plan: compiled\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665243 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "8b6c2ebf42b6ed4e2c9fced2e29a31483d9ac840", "tree": "06fd2599788ff1e468110a66c47593c976f49bd8", "parents": [ "f150f1aed51d48c36b05cf92f7a7dedb9c9cfeb7" ], "author": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Fri Aug 31 07:54:40 2007 +0000" }, "committer": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Fri Aug 31 07:54:40 2007 +0000" }, "message": "-- reset all state when seeking to a chunk\n\nSummary:\n- this was causing some bizarre issues with seeking to a particular point in the log\n- I can\u0027t believe we haven\u0027t run into this before\n\nReviewed By: jwang\n\nTest Plan: replayed log file from a partiicular point\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665242 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "d779cbe48c1335169cb87ed8977e293247b1434a", "tree": "c15b17777725a83cc35183d6bb59744046b28b6b", "parents": [ "01a9f8845d38cd32694d91b35d7a844c3646e3c3" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Aug 31 01:42:55 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Aug 31 01:42:55 2007 +0000" }, "message": "Thrift: Local Reflection for C++.\n\nSummary:\nThe compiler now takes a \"-dense\" flag that will cause it to\ngenerate some extra metadata for C++. This metadata will be used by\nTDenseProtocol. This should be the last compiler change necessary\nto enable that feature.\n\nReviewed By: mcslee\n\nTest Plan: test/DenseLinkingTest.thrift\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665240 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "792df0bf78d061ede0af7f12bf92c72254ed12d8", "tree": "e2266f7f0cbc621fc67bb786f8c2716170c18689", "parents": [ "c6fc329a4040f9945576bc7007ab8df44d112635" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Aug 30 03:30:22 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Aug 30 03:30:22 2007 +0000" }, "message": "Thrift: Pre-generate reflection_limited for Python.\n\nSummary:\n- Give reflection_limited a nice clean Python module.\n- if/regen.sh now generates reflection_limited for Python and copies it to src.\n- Added the generated Python for reflection_limited to version control.\n- lib/py/setup.py installs reflection_limited.\n- lib/py/cleanup.sh now removes build (make sure to run as root).\n- The C++ version of reflection_limited was also updated by regen.sh.\n\nReviewed By: mcslee\n\nTest Plan:\n- Clean build and install.\n- Look at the installed Python files.\n- python -c \u0027from thrift.reflection.limited.ttypes import *\u0027\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665235 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "2375312fa05e1560f0fc83c642dcb2535d9d2eba", "tree": "c97b21fea0603a3e3f36a596de4597f034a946c9", "parents": [ "5ec8e26d25dc459041e7c31aa2c65eff4f70ad4e" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Aug 27 19:57:34 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Aug 27 19:57:34 2007 +0000" }, "message": "Thrift: Limited Reflection for C++.\n\nSummary:\nThe Thrift compiler now generates static methods for every service to generate\na reflection of the methods provided by the service. This reflection is fairly\nlimited, but should be enough for what we want to do with SMC.\n\nReviewed By: mcslee\n\nTest Plan: test/ReflectionTest.cpp\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665226 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "40c6ac574c0090900736da744ef8cb72340b6c07", "tree": "4e81f0b10d9e652fcbe8910cf021c9888bbe913f", "parents": [ "3f808ab33787044e149fb25d1c6c6c18811afde9" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Aug 24 19:24:10 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Aug 24 19:24:10 2007 +0000" }, "message": "Possible Thrift memory leak\n\nSummary: Don\u0027t throw new Exception, just throw Exception\n\nReviewed By: mcslee\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665223 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "3f808ab33787044e149fb25d1c6c6c18811afde9", "tree": "7c68abef4969f6cb577945d1d18d8183e9f2c881", "parents": [ "cf3c124f29346f26be9d707ef11d30563a45f43b" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Aug 24 00:19:12 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Aug 24 00:19:12 2007 +0000" }, "message": "Thrift: TMemoryBuffer::getAppendBufferToString fix.\n\nSummary:\nSame fix as getBufferAsString\n\nBlame Rev: 55988\n\nReviewed By: dreiss\n\nTest Plan: Thrift compiles.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665222 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "a41c8705db8f09227e22c04bbb98ca046c819ca9", "tree": "e69693d6dc1d14cdb4d0bd41791becf2d410e27d", "parents": [ "d4a269cdb5ecf62e91384e33cdb6bf887f69e9a9" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Aug 23 17:20:38 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Aug 23 17:20:38 2007 +0000" }, "message": "Thrift: TMemoryBuffer::getBufferAsString only returns written portion.\n(This change was by Adam, diff sent by email, I\u0027m just checking it in.)\n\nBlame Rev: 55988\n\nReviewed By: adam\n\nTest Plan: Thrift compiles.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665219 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "d4a269cdb5ecf62e91384e33cdb6bf887f69e9a9", "tree": "013cc9892421f3738e9cda3be933ee12c1f08d53", "parents": [ "402ee28f87dd855d8825182b79617891a7ac4b93" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Aug 23 02:37:19 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Aug 23 02:37:19 2007 +0000" }, "message": "Thrift: No using namespace.\n\nSummary:\nusing namespace XXX; is tricky because it imports a lot of crap into your namespace.\nAlso, if we ever decide to remove boost as a dependency, \"using namespace boost\"\nmakes it harder.\n\nThis patch removes all using namesapce XXX; with one or more using XXX::YYY;\nThere are some exceptions, such as test, tutorial, namespace std, and\nfacebook namespaces.\n\nReviewed By: mcslee\n\nTest Plan:\nRecompiled thrift.\ngrep --binary-files\u003dwithout-match -r \u0027using namespace\u0027 . | \\\n egrep -v \u0027^[^:]*: *using namespace (std;$|facebook)\u0027 | \\\n grep -v \u0027\u003c\u003c endl\u0027 | \\\n grep -v \u0027[^:]*/tutorial/\u0027 | \\\n grep -v \u0027^./test/\u0027\n\nRevert Plan: ok\n\nNotes: I wouldn\u0027t bother, but it is fixathon.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665218 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "402ee28f87dd855d8825182b79617891a7ac4b93", "tree": "575a3efb8fc18c8ee41185bd61be23c5ba29b13a", "parents": [ "25b5ee3285d9230fcda9ec30ca99db306906ae89" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Aug 23 01:43:20 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Aug 23 01:43:20 2007 +0000" }, "message": "Fix TNonBlockingServer libevent issue in ThreadPool mode\n\nSummary: If using TNonBlockingServer with a ThreadManager, when you send a task off to the threadmanager you need to cancel the event that you have set on that client socket. Otherwise, when you give control back to libevent, it might trigger more read events if there are more requests coming down the pipe. This is an issue, because the server will be in the wrong state at that point and will have no way of handling reading more data if it is still in the WAIT_TASK state trying to see if it should write something back to the client. So, when we hit that control flow, we must setIdle() on the TConnection so that libevent doesn\u0027t trigger it anymore. Later, after the result is written, we\u0027ll setRead() and go back to the init state.\n\nReviewed By: akhil\n\nTest Plan: Akhil\u0027s async + TNonBlocking karma server\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665217 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "25b5ee3285d9230fcda9ec30ca99db306906ae89", "tree": "a3fb97a26c21ca02b500503e6a181129a681c288", "parents": [ "bc3dddb91c1e26ecfa290c10f9a5950adc8dedd1" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Aug 23 00:14:48 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Aug 23 00:14:48 2007 +0000" }, "message": "Thrift: TMemoryBuffer now handles NULLs again.\n\nSummary:\nBoz is using TMemoryBuffer by constructing it will a NULL buffer,\nthen doing a resetBuffer later. This patch re-enables that.\n\nBlame Rev: 55988\n\nReviewed By: aditya\n\nTest Plan:\nThrift compiles.\nWill test feed after this is comitted.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665216 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "bc3dddb91c1e26ecfa290c10f9a5950adc8dedd1", "tree": "72dd53e97fb611ea7eaafaa6b6328673a1e832b5", "parents": [ "95aaaf1852dd245e106a5879eb5b9baba32ce5a8" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Aug 22 23:20:24 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Aug 22 23:20:24 2007 +0000" }, "message": "Thrift: Better handling of strerror_r.\n\nSummary:\nSomeone thought it would be a good idea to have two different signatures\nfor strerror_r, with subtly different semantics (strlcpy \u003d smart).\nWe now work properly with either of them.\n\nAlso fixed a test to work on 32-bit, you sloppy \u003cexpletive\u003es.\n\nReviewed By: mcslee\n\nTest Plan:\nRebuild thrift.\nForce one of these errors to be thrown.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665215 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "95aaaf1852dd245e106a5879eb5b9baba32ce5a8", "tree": "25ba553769075c7e8322f63456f3b88ec6e54be1", "parents": [ "2dc72c3864e76d9eb14c1f83def63fa2351f4fb2" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Aug 22 02:32:11 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Aug 22 02:32:11 2007 +0000" }, "message": "Thrift: Bugfix.\n\nSummary: Missed one.\n\nBlame Rev: 55988\n\nReviewed By: yunfang\n\nTest Plan: make\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665214 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "2dc72c3864e76d9eb14c1f83def63fa2351f4fb2", "tree": "a9d1cb7875bb45a5ee9eba760ca229902a34408c", "parents": [ "dd56497a7c97f07c8d97b9c7323652fb2b7154e0" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Aug 21 23:59:34 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Aug 21 23:59:34 2007 +0000" }, "message": "Thrift: Move TStringBuffer functionality into TMemoryBuffer.\n\nSummary:\nTMemoryBuffer already has the necessary plubming to work with C++ strings.\nThis revision implements that functionality with a few wrapper methods.\nRemoved TStringBuffer as it should no longer be required (and it is tricky\nto safely inherit from a class that has a non-virtual destructor).\nAlso refactored the TMemoryBuffer constructors a bit.\n\nReviewed By: aditya, yunfang\n\nTest Plan:\ntest/TMemoryBufferTest.cpp\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665213 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "dd56497a7c97f07c8d97b9c7323652fb2b7154e0", "tree": "129ba7de35bfddb39da2c8304dd3852c3dbffc78", "parents": [ "98439158db96e682467f87b0d6533896db9ae72a" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Aug 21 02:39:57 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Aug 21 02:39:57 2007 +0000" }, "message": "Need sys/types.h includes for FreeBSD\n\nReviewed By: dreiss\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665212 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "98439158db96e682467f87b0d6533896db9ae72a", "tree": "484ed060d6336ed30e7a36715b53a1b45a23d35f", "parents": [ "04f0b7b21b4902f356809fced858de8d00bae1b6" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Aug 21 02:39:40 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Aug 21 02:39:40 2007 +0000" }, "message": "Fix thread_t cast again\n\nSummary: reinterpret_cast actually breaks on linux, despite working on FreeBSD\n\nReviewed By: dreiss\n\nTest Plan: Compile on Linux OR FreeBSD\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665211 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "04f0b7b21b4902f356809fced858de8d00bae1b6", "tree": "c901a6dd7cf587e1ed0561ad917ebe5bb25eda28", "parents": [ "1ec47d4395be54319598aa5cd74ee8d44246b335" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Aug 21 01:54:36 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Aug 21 01:54:36 2007 +0000" }, "message": "Use reinterpret_cast instead of static_cast for pthread_t \u003d\u003e Thread::id_t\n\nSummary: On FreeBSD pthread_t is a pthread*, not uint64_t, so static_cast gest upset\n\nReviewed By: dreiss\n\nTest Plan: Compile on FreeBSD\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665210 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "1ec47d4395be54319598aa5cd74ee8d44246b335", "tree": "918d05ee0f28ba6825bced213f0ab592bd586760", "parents": [ "94112d699411fcca2bde9721da46ddcd4c15a5bf" ], "author": { "name": "yunfang", "email": "dev-null@apache.org", "time": "Sun Aug 19 22:18:38 2007 +0000" }, "committer": { "name": "yunfang", "email": "dev-null@apache.org", "time": "Sun Aug 19 22:18:38 2007 +0000" }, "message": "[adding TStringBuffer for serialization/deserialization from a string]\nSummary:\n/**\n * A string buffer is a tranpsort that simply reads from and writes to a\n * string. Anytime you call write on it, the data is serialized\n * into the underlying buffer, you can call getString() to get the serialized\n * string. Before you call read, you should call resetString(data) to set the\n * underlying buffer, you can then call read to get the\n * de-serialized data structure.\n *\n * The string buffer is inherited from the memory buffer\n * Thus, buffers are allocated using C constructs malloc,realloc, and the size\n * doubles as necessary.\n */\n\nReviewed by: aditya\n\nTest Plan:\nint main(int argc, char** argv) {\n shared_ptr\u003cTStringBuffer\u003e strBuffer(new TStringBuffer());\n shared_ptr\u003cTBinaryProtocol\u003e binaryProtcol(new TBinaryProtocol(strBuffer));\n\n testStruct a;\n a.i1 \u003d 10;\n a.i2 \u003d 30;\n a.s1 \u003d string(\"holla back a\");\n\n a.write(binaryProtcol.get());\n string serialized \u003d strBuffer-\u003egetString();\n\n shared_ptr\u003cTStringBuffer\u003e strBuffer2(new TStringBuffer());\n shared_ptr\u003cTBinaryProtocol\u003e binaryProtcol2(new TBinaryProtocol(strBuffer2));\n\n strBuffer2-\u003eresetString(serialized);\n testStruct a2;\n a2.read(binaryProtcol2.get());\n\n if (a \u003d\u003d a2) {\n printf(\"serialization working\\n\");\n } else {\n printf(\"serialization not working\\n\");\n }\n}\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665209 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "5362e70f8f3c58f0f1fc67ea0a8fc299c554e1bc", "tree": "c16926b192819343292fd79e6663b25ff5a3218c", "parents": [ "3429b6a9a046bbc4bd6e476467aca89ce7317cc2" ], "author": { "name": "boz", "email": "dev-null@apache.org", "time": "Wed Aug 15 20:55:36 2007 +0000" }, "committer": { "name": "boz", "email": "dev-null@apache.org", "time": "Wed Aug 15 20:55:36 2007 +0000" }, "message": "THRIFT: mutex trylock support\n\nSummary: add trylock support to the Mutex class\n\nReviewed By: mcslee\n\nTest Plan: added trylock mutexes to foreman, walked through them in gdb\n(behaved correctly) and then ran an entire sweep (behaved correctly)\n\nNotes: slee ftw\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665204 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "17496a04d61a5ed0dbece2d5067135871a526da4", "tree": "1b6cfd3beaccd12b1b57bcfe4739c6c56b63d8a9", "parents": [ "80cdca7344fba98dcda6bcc694a1419cb2dc60a6" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Aug 02 06:37:40 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Aug 02 06:37:40 2007 +0000" }, "message": "Typo and comment fix\n\nReviewed By: marc\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665189 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "80cdca7344fba98dcda6bcc694a1419cb2dc60a6", "tree": "d4fabd5b684072b6d7d8160634a34ba79383cbc7", "parents": [ "c3c6c0c9c4dc77c6b2b7dce952eeb2fe69513a40" ], "author": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Thu Aug 02 06:26:11 2007 +0000" }, "committer": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Thu Aug 02 06:26:11 2007 +0000" }, "message": "-- fix memory leak in TThreadedServer\n\nSummary:\n- need detached\u003dtrue\n\nReviewed By: mcslee\n\nTest Plan: replayable test case\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665188 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "5b4181919de0245098b481ea2ed5ecd1e7a0d83f", "tree": "b64a1241a9966ce5c70848df466ab3aa3db9d4c9", "parents": [ "877237abcf93e7bd7bc9a7d095d3a850c309817e" ], "author": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Fri Jul 27 07:04:49 2007 +0000" }, "committer": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Fri Jul 27 07:04:49 2007 +0000" }, "message": "-- remove default seekToEnd\n\nfixed search so no need for this anymore\n\nReviewed By: jwang\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665178 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "96d2388ade7af4f23d2c95b92496b79ec0321133", "tree": "fb9840256a746c1b3889b25ddd8131955265ec60", "parents": [ "5f5fdf3a20f2459eabbee771e6eff4159c6f2bca" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Jul 26 21:10:32 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Jul 26 21:10:32 2007 +0000" }, "message": "Thrift: Cleaned up whitespace.\n\nSummary:\nReplaced a lot of tabs with spaces in the thrift codebase.\nRemoved a lot of trailing whitespace from thrift-generated c++.\nAdded a few things to cleanup.sh.\n\nTrac Bug: #\n\nBlame Rev:\n\nReviewed By: mcslee\n\nTest Plan:\nRecompiled thrift.\nRe-thrifted some test .thrifts.\nCompiled the genrated c++.\nRan cleanup.sh.\n\nRevert Plan: ok\n\nNotes:\n\nEImportant:\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665176 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "e9cd65557916236ff4e29bcffdd33751190d55c9", "tree": "a297f789666c95a09f0d06ed47bd14ec60e031b9", "parents": [ "d51643cbf99f57f1945eaedb30bde8efa714c7ac" ], "author": { "name": "James Wang", "email": "jwang@apache.org", "time": "Mon Jul 23 17:35:32 2007 +0000" }, "committer": { "name": "James Wang", "email": "jwang@apache.org", "time": "Mon Jul 23 17:35:32 2007 +0000" }, "message": "Readding seekToEnd() call to openLogFile() temporarily so that search doesn\u0027t break\n\nReviewed By: aditya\n\nTest Plan: Thrift compiles, falcon works\n\nRevert Plan: revertible\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665168 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "d51643cbf99f57f1945eaedb30bde8efa714c7ac", "tree": "4128e024057a6ad2bf935f746bf6be37f6889632", "parents": [ "00dcccfef251bb99836760eb31b2522608c23418" ], "author": { "name": "James Wang", "email": "jwang@apache.org", "time": "Sun Jul 22 05:48:12 2007 +0000" }, "committer": { "name": "James Wang", "email": "jwang@apache.org", "time": "Sun Jul 22 05:48:12 2007 +0000" }, "message": "Summary: Changing TFileTransport to not go to end of file by default\n\nReviewed By: boz\n\nTest Plan: compiled and tested falcon\u0027s print utility\n\nRevert Plan: revertible\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665167 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "00dcccfef251bb99836760eb31b2522608c23418", "tree": "7c4d27924a3050fb1725eb70cd1494881bd55355", "parents": [ "8639e1056d6db52d53ff579f0f8d4728b702740e" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sat Jul 21 01:18:10 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sat Jul 21 01:18:10 2007 +0000" }, "message": "Thrift: Debug Protocol\n\nSummary:\nAdded TDebugProtocol, a write-only Thrift protocol for C++\nthat produces human-readable representations of thrift structs.\n\nTrac Bug: #\n\nBlame Rev:\n\nReviewed By: mcslee\n\nTest Plan:\nRecompiled Thrift.\n./test/TestDebugProto.* see compile instructions at the top.\nRan that, and it looked good.\n\nRevert Plan:\ngrep TDebugProtocol \u003cworld\u003e\ngrep ThriftDebugString \u003cworld\u003e\nRevert or comment out whatever you find so that they still compile.\nThen svn revert.\n\nNotes:\n\nEImportant:\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665166 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "a36f5db4b323adbcd13cd298ab73eee2be6200f2", "tree": "64cf754afe6c383e34e08570887c8f62e64269e4", "parents": [ "b1ad0141d4df4b4488882880a6d9d4aa84f3b178" ], "author": { "name": "yunfang", "email": "dev-null@apache.org", "time": "Sat Jul 14 01:23:05 2007 +0000" }, "committer": { "name": "yunfang", "email": "dev-null@apache.org", "time": "Sat Jul 14 01:23:05 2007 +0000" }, "message": "[scope lock wrapped for ReadWriteMutex]\nSummary:\n scope lock wrapped around ReadWriteMutex. It\u0027s like Guard but you can specify to use it as a read or write lock.\n\nReviewed by: boz\n\nTest Plan: used it in AdFinder\n\nRevertible: yes\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665162 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "8b82fb7a757f54659c88f294a217613a9fea59ca", "tree": "34a4fbc50b6c17371390913244da63b11a767335", "parents": [ "d093e7c32aa8f99b5696603fdd39ceeeebbdc150" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Jul 10 00:49:04 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Jul 10 00:49:04 2007 +0000" }, "message": "Fix SET serialization borked-ness in Thrift\n\nSummary: Extra return floating in the code\n\nReviewed By: boz\n\nTest Plan: Rebuild and deploy feed\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665160 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "85287d3989359231026807bac52364cbe49b8d84", "tree": "ac944a48f83ef03133f20f61b38377ac5522baae", "parents": [ "e6c4fa671e63f9bfcc443d3fb5802e886f237c9a" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon Jul 09 19:50:30 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon Jul 09 19:50:30 2007 +0000" }, "message": "Fix addrinfo structure memory leak in TSocket\n\nSummary: Need to free the IPv6 memory structure\n\nReviewed By: mcslee\n\nNotes: Submitted by paul@powerset.com\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665157 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "e6c4fa671e63f9bfcc443d3fb5802e886f237c9a", "tree": "c1b4b7aebdd340b47086094df1e69f296ba94b19", "parents": [ "6d56eb9d651a72a1fe10b7829e569a7ac12afb20" ], "author": { "name": "Martin Kraemer", "email": "martin@apache.org", "time": "Mon Jul 09 19:08:25 2007 +0000" }, "committer": { "name": "Martin Kraemer", "email": "martin@apache.org", "time": "Mon Jul 09 19:08:25 2007 +0000" }, "message": "sys_errlist is deprecated.\n\nSummary:\nAvoiding usage of sys_errlist. It is deprecated, prefer strerror or strerror_r instead.\n\nTrac Bug: #\n\nBlame Rev:\n\nReviewed By: mcslee, karl\n\nTest Plan:\n\nRevert Plan: revertible\n\nNotes:\n\nEImportant:\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665156 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "6d56eb9d651a72a1fe10b7829e569a7ac12afb20", "tree": "7cca951df72149fa9987a860ff486740b33090ed", "parents": [ "cce8184d997b37a2da1b885125b43bcda103fa76" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Jul 06 22:28:15 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Jul 06 22:28:15 2007 +0000" }, "message": "TSocket IPv6 support for C++\n\nSummary: From Paul Saab at Powerset\n\nReviewed By: mcslee\n\nTest Plan: test/cpp/TestClient\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665155 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "cce8184d997b37a2da1b885125b43bcda103fa76", "tree": "556497122de3691d3446023a7960a4df4d7104bc", "parents": [ "22974602532c9d1e1dacb5d0f873667a237b0981" ], "author": { "name": "boz", "email": "dev-null@apache.org", "time": "Fri Jul 06 22:27:52 2007 +0000" }, "committer": { "name": "boz", "email": "dev-null@apache.org", "time": "Fri Jul 06 22:27:52 2007 +0000" }, "message": "THRIFT ReadWriteMutex\n\nSummary: Implemented a read/write lock class in thrift::concurrency\n\nReviewed By: marc\n\nTest Plan: I compiled this, then compiled a version of fb303 that uses this\n(future checkin pending further tests), then ran a binary using the new fb303\nand it didn\u0027t crash as things were added to the map using the ReadWriteMutex\n\nRevert Plan: yup\n\nNotes: this should replace rw_lock.h for most clients\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665154 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "f79031e87531464b84d911acf9aee57cac8b83d8", "tree": "f24a3e9989a757cf75e15eef59d43bbc24628628", "parents": [ "58dfb4fbe82c346814c2e4f33b6045468bfd68c6" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Jul 06 21:43:48 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Jul 06 21:43:48 2007 +0000" }, "message": "Fixed possible Thrift serialization bug\n\nSummary: TBinaryProtocol.cpp was making assumptions about evaluation order\nthat are not guaranteed by the standard. Now it does not (at least in these\nfunctions).\n\nTrac Bug: #\n\nBlame Rev:\n\nReviewed By: mcslee\n\nTest Plan: still compiles.\n\nRevert Plan: svn revert\n\nNotes:\n\nEImportant:\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665152 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "82883299ef730cd2badf11ba4225de47709392e1", "tree": "40229442bace4933546f032c2c48991bd20a818e", "parents": [ "58500e976364aea0df156a08b6c0336f6da26cd1" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Jun 26 20:19:56 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Jun 26 20:19:56 2007 +0000" }, "message": "Removing protocol.txt\n\nSummary: This is not accurate anymore\n\nReviewed By: aditya\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665144 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "58500e976364aea0df156a08b6c0336f6da26cd1", "tree": "6b700f916a3ddd25c6a7d6f64d32e848f798e449", "parents": [ "66ccee2a7489a26d58197f75c0136eebdb345dff" ], "author": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Tue Jun 26 02:57:04 2007 +0000" }, "committer": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Tue Jun 26 02:57:04 2007 +0000" }, "message": "-- make sure TFileTransport always starts at EOF\n\nReviewed By: jwang\n\nTest Plan: search\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665143 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "a9294a9522bb6045f468b04abfee648b71c9b99b", "tree": "cad4fedc7d672c02d33eb633cf9920f236152a17", "parents": [ "552410c037c323085e075bd4b0f268ee941083b8" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Jun 22 19:43:12 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Jun 22 19:43:12 2007 +0000" }, "message": "Teensy insignificant thrift bug\n\nSummary: Wasn\u0027t causing any issues because it\u0027s a noop with the binary protocol\n\nReviewed By: jwang\n\nTest Plan: honky tonk, no diff in functionality\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665140 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "808454ec634278eec7e0ee5c523b00e3e4257287", "tree": "a8b896d05d162699ac11e45aca3d129e119379f4", "parents": [ "589859984f43af1ed0f9ee45ce8374a0d1640813" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Jun 20 21:51:57 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Jun 20 21:51:57 2007 +0000" }, "message": "Thrift TBinaryProtocol change\n\nSummary: New Thrift TBinaryProtocol with a version identifier\n\nReviewed By: aditya, eugene\n\nTest Plan: Modify your services to have strictRead_ and strictWrite_ both set to FALSE. Then redeploy your services and test running clients against them. Once you have clients and servers running stably on this new code, you should redploy versions with strictWrite_ set to TRUE. Once that\u0027s all good, we can set strictRead_ to TRUE as well, and eventually deprecate the old protocol code entirely.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665138 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "589859984f43af1ed0f9ee45ce8374a0d1640813", "tree": "542ef2b0e9b7979373ab9736bafffc89995e47b0", "parents": [ "3e5d2d72b4f48e2008462fbb9ac86f76011ceb91" ], "author": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Tue Jun 19 23:10:19 2007 +0000" }, "committer": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Tue Jun 19 23:10:19 2007 +0000" }, "message": "[thrift] Add optional callback inside of serve()\n\nSummary: If enabled, the callback function will be run after the listening socket is opened and the event loop initialized, just prior to calling event_loop()\n\nThis is handy if you want to defer some of your initialization until after the socket is open -- allowing clients to connect, but not processing requests until the initialization is complete. I use this in the Synapse tablet server to minimize the communications interruption that happens during a tablet split (replaying commit logs after opening the listening socket).\n\nReview: mcslee\nTest Plan: compiled it into Synapse\u0027s tablet server\nRevert: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665137 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "8eceaeacfb084dd603c4d0fe07cc26066ca70abe", "tree": "244ffc9cacb477e30180e1adfdb538ff35d3b1f8", "parents": [ "447d7d236590db3dad60dc10eed72274a5b66edf" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Jun 15 01:43:21 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Jun 15 01:43:21 2007 +0000" }, "message": "Missing variable in initializer list for TNonblockingServer constructor\n\nSummary: Making tablemaster very unhappy\n\nReviewed By: dweatherford\n\nTest Plan: tablemaster on synampse tier\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665135 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "1d2ead34a23602a1dd248648204bbbeea356bc0c", "tree": "296d818ba5543fd3589c5a3e11c0fa5a39ab9026", "parents": [ "e02385b0b4e84aed0e456cb697a471c211705eba" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Sat Jun 09 01:23:04 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Sat Jun 09 01:23:04 2007 +0000" }, "message": "Darwin endianness junk\n\nReviewed By: darwin\n\nTest Plan: build on OSX\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665133 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "e02385b0b4e84aed0e456cb697a471c211705eba", "tree": "f1452d1f52603401032ba15b00dfc3248aaea576", "parents": [ "6ded775196d10f86ac5b99843f018aa2b29772b8" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Sat Jun 09 01:21:16 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Sat Jun 09 01:21:16 2007 +0000" }, "message": "Add thread pool option to NonblockingServer\n\nSummary: If you want requests processed outside of the I/O thread\n\nReviewed By: jake luciani, aditya\n\nTest Plan: nb-main.cpp, in the test folder\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665132 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "6ded775196d10f86ac5b99843f018aa2b29772b8", "tree": "df77ad7759e46f4aa57e65e75849ef26702020bd", "parents": [ "a647903dd2edaa8cf846fe9dac4df82cf74740a0" ], "author": { "name": "boz", "email": "dev-null@apache.org", "time": "Tue Jun 05 22:41:18 2007 +0000" }, "committer": { "name": "boz", "email": "dev-null@apache.org", "time": "Tue Jun 05 22:41:18 2007 +0000" }, "message": "THRIFT: generic output handler\n\nSummary: I\u0027m tired of getting output from thrift via perror AND exceptions, so\nthis class allows the client to set an alternate (or empty) handler for error\noutput\n\nReviewed By: mcslee\n\nTest Plan: I ran on the worker with the default, got output via perror, then\noverloaded with my own function and got output via syslog and then NULL\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665131 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "a647903dd2edaa8cf846fe9dac4df82cf74740a0", "tree": "a844a1aa23e630d62c2e918cbd55ef96cc019caa", "parents": [ "67606e5d7207874d003bc9ba433edd66d74662f0" ], "author": { "name": "Marc Slemko", "email": "marc@apache.org", "time": "Tue Jun 05 22:20:14 2007 +0000" }, "committer": { "name": "Marc Slemko", "email": "marc@apache.org", "time": "Tue Jun 05 22:20:14 2007 +0000" }, "message": "Modified PosixThreadFactory\n Added explicit detached getter and setter\nModified PosixThreadFactory::~PThread:\n Check for join failing and don\u0027t transition to detached_ state if it does. Potential thread-handle leak for\n threads created joinable who aren\u0027t referenced by any external thread. Solution for now has to be\n \"DONT DO THAT\", the clever approach doesn\u0027t always work.\n\nAdded ThreadFactoryTests.floodNThreads:\n Loop M times for N threads where M x N is bigger than 32K to verify that detached threads can be created\n ad infinitum.\n\nReviewed By: mcslee\n\nRevert Plan: revertible\n\nTest Plan: concurrency_test thread-factory passes\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665130 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "67606e5d7207874d003bc9ba433edd66d74662f0", "tree": "e0c1d491867848f528ed6696c5df251f200be635", "parents": [ "5e707a6cd9aa9c3de9b3eddb83307a8268449f58" ], "author": { "name": "Marc Slemko", "email": "marc@apache.org", "time": "Mon Jun 04 21:01:19 2007 +0000" }, "committer": { "name": "Marc Slemko", "email": "marc@apache.org", "time": "Mon Jun 04 21:01:19 2007 +0000" }, "message": "Modified PosixThreadFactory::PThread:\n Pay attention to detached flags. If thread is create non-detached and has not been joined when all references are given up,\n (ie boost::share_ptr calls ~PThread) do the join in the destructor to prevent thread ids from being leaked.\n\nModified ThreadFactoryTests.reapNThreads:\n Loop M times for M threads where M x N is bigger than 32K to verify that thread ids aren\u0027t leaked\n\nModified TimerManager.cpp:\n Removed debug messages.\n\nReviewed By: mcslee\n\nRevert Plan: revertible\n\nTest Plan: concurrency_test thread-factory passes\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665129 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "f83c9dbf6ffdcd7c2fa833b243211822ba521e16", "tree": "ad95ceb441f8718035dc6a36a5aa043e3955b49c", "parents": [ "7a2fb142f12a68aa661100bd9c7ce8d6f0775c85" ], "author": { "name": "boz", "email": "dev-null@apache.org", "time": "Thu May 31 23:38:37 2007 +0000" }, "committer": { "name": "boz", "email": "dev-null@apache.org", "time": "Thu May 31 23:38:37 2007 +0000" }, "message": "THRIFT: ADITYASLOP\n\nSummary: thrift didn\u0027t compile\n\nReviewed By: marc\n\nTest Plan: thrift compiles\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665127 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "7859a579db3d0a4d2d4ca62993ee98e90dc9d617", "tree": "a4955c2b5ccec19cd66f7b3058c3f4095d6ead9c", "parents": [ "448849deede56f011dae0049e7b5bb142271eaf6" ], "author": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Thu May 31 01:33:07 2007 +0000" }, "committer": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Thu May 31 01:33:07 2007 +0000" }, "message": "-- handle EINTRS in accept()\n\nSummary:\n- I love unix.\n\nReviewed By: mcslee\n\nTest Plan: boz will test it\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665125 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "9b82d275c627b1f4f64b5d3c82d54422fe6b5d5a", "tree": "7daf5768bc2619697e08b8e681cd72b52af409c6", "parents": [ "2782d6d205344fc6b02f30c674812bd91bcff2a1" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed May 23 05:16:07 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed May 23 05:16:07 2007 +0000" }, "message": "Get the long longs out of the Thrift codebase\n\nSummary: Replace with int64_t and don\u0027t worry about what architecture machine you\u0027re on, the typedefed int64_t will do the right thing.\n\nReviewed By: aditya, marc\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665123 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "2782d6d205344fc6b02f30c674812bd91bcff2a1", "tree": "3482e36f4175673a3594e0e55d82da20a12beafb", "parents": [ "e04475b5aaa2bba920a2c1b4021a1a447f947dd9" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed May 23 04:55:30 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed May 23 04:55:30 2007 +0000" }, "message": "mcslee: being nitpicky ensuring consistent coding style\n\nSummary: no tabs, conditionals with spaces around them, etc\n\nReviewed By: thrift style rules\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665122 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "e04475b5aaa2bba920a2c1b4021a1a447f947dd9", "tree": "3d1a40d17e951eb8ee56748ba955873beb8a08e3", "parents": [ "3a3b53bc6eefa91ea60e5da2b2c91519ca1d9b2e" ], "author": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Wed May 23 02:14:58 2007 +0000" }, "committer": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Wed May 23 02:14:58 2007 +0000" }, "message": "-- fix read timeout handling in TSocket\n\nSummary:\n- turns out that EAGAIN can be returned both when there is a transmission timeout and when there\n is a lack of system resources.\n\nThis diff has a hacky fix for respecting a user specified read timeout.\n\nReviewed By: Steve Grimm, Marc, Slee\n\nTest Plan:\n- Tested by trying to crash an srp machine\n\nRevert Plan: No.\n\nNotes:\n- Also added functionality to allow users to specify the max number of recv retries (in the case\n when EAGAIN is returned due to a lack of system resources)\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665121 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "3a3b53bc6eefa91ea60e5da2b2c91519ca1d9b2e", "tree": "9bd43f88b0e1cb8959dbacc90a7d9babf16e10b3", "parents": [ "f4f18ec514d42cec7a1368242015db1c3ad9da29" ], "author": { "name": "Marc Slemko", "email": "marc@apache.org", "time": "Tue May 22 23:59:54 2007 +0000" }, "committer": { "name": "Marc Slemko", "email": "marc@apache.org", "time": "Tue May 22 23:59:54 2007 +0000" }, "message": "Modified facebook::thrift::concurrency::Monitor.wait:\n Throw TimedOutException on wait timeout so caller can distinguish between timeout and event.\n\nModified facebook::thrift::concurrency::PthreadThread.start:\n Throw SystemrResourceException on any pthread_* function call failure rather than asserting 0.\n\nAdded facebook::thrift::concurrency::Thread.id() and facebook::thrift::concurrency::ThreadFactory.currentThreadId():\n Return thread-id of thread and current thread respectively. Needed for reentrancy tests in ThreadManager\n\nAdded facebook::thrift::concurrency::ThreadManager.pendingTaskCountMaxN\nModified facebook::thrift::concurrency::ThreadManager.add():\n Now support a maximum pending task count and block if the current pending task count is max.\n If timeout is specified for add, TimedOutException is thrown if pending task count doesn\u0027t decrease\n in the timeout interval. If add() is called by a ThreadManager worker thread and the task cannot\n be added, a TooManyPendingTasksException is thrown rather than blocking, since deadlocks can ensue\n if worker threads block waiting for works threads to complete tasks.\n\nReviewed By: mcslee, aditya\n\nRevert Plan: revertible\n\nTest Plan: concurrency/test/ThreadManagerTests.h\n run concurrency-test thread-manager\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665120 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "bf8215109490924ccf8d6fb92a1c2129ce00fb78", "tree": "82ae7b0f06410f4306a0485ab51500dfb262d80f", "parents": [ "e9ce01cf402fca4c275554847c85aff9fff17dc6" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed May 16 02:31:53 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed May 16 02:31:53 2007 +0000" }, "message": "Some filetransport indentation and style fixes\n\nReviewed By: null, no code change, style only\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665114 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "1ea81ce9b08d554a6256611adc5089184692ab71", "tree": "3aafd291ab5d0405401275a6df21c10b3c1538bf", "parents": [ "b5f93b0b3a3c57ce6ff75f37120688276512c869" ], "author": { "name": "boz", "email": "dev-null@apache.org", "time": "Mon May 14 23:04:33 2007 +0000" }, "committer": { "name": "boz", "email": "dev-null@apache.org", "time": "Mon May 14 23:04:33 2007 +0000" }, "message": "THRIFT: configurable retry settings for bind\n\nSummary: SO_REUSEADDR doesn\u0027t always work, and some of my servers have\nexpensive init routines that I really want to run before it becomes available\nto services, so I want thrift to retry the bind several times at varied\nintervals before giving up\n\nReviewed By: slee\n\nTest Plan: running a service in GDB with no problems binding, with another\nservice bound to the port for all the retries, another service bound to the\nport for only some of the retries\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665109 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "5f68c7161daf70b4f04f0157d8d0b265d729247a", "tree": "6cd1711aed828c888117bdf1b5552267f52977a2", "parents": [ "e02e42448611b7c2103ef03b0a5a5a197fd92c1b" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri May 11 17:58:54 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri May 11 17:58:54 2007 +0000" }, "message": "Fix messed up exception error printing\n\nReviewed By: boz\n\nTest Plan: comes up in feed\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665107 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "e02e42448611b7c2103ef03b0a5a5a197fd92c1b", "tree": "8f155311ba3c47711a8f4d94229c4f42523b51f8", "parents": [ "3690ee412a245f5287563fe57e5e5d2d66161a9e" ], "author": { "name": "jsobel", "email": "dev-null@apache.org", "time": "Tue May 08 17:51:49 2007 +0000" }, "committer": { "name": "jsobel", "email": "dev-null@apache.org", "time": "Tue May 08 17:51:49 2007 +0000" }, "message": "thrift: cpp tsocketpool support\nsummary: simple port of tsocketpool from php to cpp. missing a lot of functionality due to lack of apc support\nreview: slee\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665106 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "3690ee412a245f5287563fe57e5e5d2d66161a9e", "tree": "89de7faf2369cb6387cb0cb47531fd08b709c32b", "parents": [ "fa6ac9f2aa503922224c14c290206bcc115630ff" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon May 07 22:54:18 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon May 07 22:54:18 2007 +0000" }, "message": "TEOFException must publicly inherit TTransportException\n\nReviewed By: boz\n\nTest Plan: Queuemap\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665105 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "4fd2dbaf0698662ad46bdb4b0a1507f325a0b051", "tree": "a266685c0420121e480c94e37e5feca2466637a1", "parents": [ "5f45207ee9774226ef39fa93e6a2100e9e8d8ff5" ], "author": { "name": "James Wang", "email": "jwang@apache.org", "time": "Tue Apr 17 22:38:58 2007 +0000" }, "committer": { "name": "James Wang", "email": "jwang@apache.org", "time": "Tue Apr 17 22:38:58 2007 +0000" }, "message": "Thrift: Fixing memory leak issue with memory buffer used in TPipedTransport\n\nReviewed by: boz\n\nTest Plan: tested with falcon action_listener using PeekProcessor\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665101 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "5f45207ee9774226ef39fa93e6a2100e9e8d8ff5", "tree": "fc10f161616bbee7ca7cd51af13347e0a0bb059c", "parents": [ "8d725a27385fb33bce8fe50fff77f763617b49d4" ], "author": { "name": "James Wang", "email": "jwang@apache.org", "time": "Fri Apr 13 20:10:39 2007 +0000" }, "committer": { "name": "James Wang", "email": "jwang@apache.org", "time": "Fri Apr 13 20:10:39 2007 +0000" }, "message": "Thrift: Modifications to PeekProcessor to be able to support nested PeekProcessors\n\nReviewed by: boz\n\nTest Plan: Tested with Falcon\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665100 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "4f261c5b23d2eb3b01da4b894a1d5eabc48f6817", "tree": "a977bbc0f6eb722dd1291716a29c6fc79c0f1a94", "parents": [ "0f2916c3f63e50a6265685be6cdac98f4260785c" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Apr 13 00:33:24 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Apr 13 00:33:24 2007 +0000" }, "message": "Crazy byteswapping thrift patches from david reiss\n\nReviewed By: ninjitsu\n\nTest Plan: bswap64, holla holla\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665098 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "8dc76e6a87be426d05331dc3fcbd4c947df04805", "tree": "2df61704fbb52ee8c145339a94f22303238bd353", "parents": [ "89b85f87d8b222c72c864b68f6d820d7f4b5daa7" ], "author": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Wed Apr 11 00:13:09 2007 +0000" }, "committer": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Wed Apr 11 00:13:09 2007 +0000" }, "message": "-- trying to make TFileTransport destructor quicker\n\nSummary:\n- setFlushMaxTimeUs to a lower value before trying to close the file\n\nReviewed By: jwang\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665095 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "89b85f87d8b222c72c864b68f6d820d7f4b5daa7", "tree": "3cc1bfbb3af2c936f36d4d33a8bcd9850072b0aa", "parents": [ "c10bba1e1628748c8902e6a465d39ab1285b92aa" ], "author": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Tue Apr 10 23:15:04 2007 +0000" }, "committer": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Tue Apr 10 23:15:04 2007 +0000" }, "message": "-- fix issues with TFileTransport\n\nSummary:\n- Make sure that buffers are always emptied when destructor is called (or when file is closed)\n- make flush a no-op if file is not open\n- dont allow new events to be enqueued if the file is in the process of being closed\n\nReviewed By: slee, jwang\n\nTest Plan: tested with building search indices on top of thrift logs\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665094 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "c10bba1e1628748c8902e6a465d39ab1285b92aa", "tree": "75958a44209fe1e86ce082366e521e544443bcca", "parents": [ "b86c4b251e99dde627fdbe74b453cc6bf885d783" ], "author": { "name": "James Wang", "email": "jwang@apache.org", "time": "Tue Apr 10 17:29:06 2007 +0000" }, "committer": { "name": "James Wang", "email": "jwang@apache.org", "time": "Tue Apr 10 17:29:06 2007 +0000" }, "message": "Thrift: Checking in readonly option for TFileTransport\n\nReviewed by: boz\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665093 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "86efa707480155ab7a9497ae295faad4ef9e973e", "tree": "c20f613344172af0d9a197344abf4e370890c9df", "parents": [ "ff24f74b49efaa25eb443f03d814fd29f4cd664c" ], "author": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Thu Apr 05 00:20:40 2007 +0000" }, "committer": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Thu Apr 05 00:20:40 2007 +0000" }, "message": "[thrift] Build fix for TFileTransport\n\nSummary: Not including config.h means we never get the HAVE_CLOCK_GETTIME #define, breaking the build with a duplicate function definition on machines that have a clock_gettime() function in the standard library.\n\nReviewed By: slee\nTest Plan: it compiles, ship it\nRevert: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665087 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "ff24f74b49efaa25eb443f03d814fd29f4cd664c", "tree": "9c7084e62416095e0613351440d14082071e4622", "parents": [ "a28d819d1345f9c14adfd0fd2b2b0f8f73fcc9f7" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Apr 04 22:13:37 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Apr 04 22:13:37 2007 +0000" }, "message": "Oops typo.\n\nReviewed By: mcslee\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665086 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "a28d819d1345f9c14adfd0fd2b2b0f8f73fcc9f7", "tree": "c3a7a1e6e973df015cb99d052fd0ed3e4293bd1b", "parents": [ "82a6c0f2590a6681f122eb9654afc1c967319acb" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Apr 04 22:11:17 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Apr 04 22:11:17 2007 +0000" }, "message": "Build fixes and clock_get_time copy from paul querna\n\nReviewed By: mcslee\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665085 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "82a6c0f2590a6681f122eb9654afc1c967319acb", "tree": "a64c1a15130ab974701e18b7dd134886d033b2c5", "parents": [ "09bfd615301dd2af23d6f251f6334a3e149d5b99" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Apr 04 21:08:21 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Apr 04 21:08:21 2007 +0000" }, "message": "Thrift string copy construction pathces from kevin ko\n\nSummary: Remove unnecessary string copy constructions in C++ code\n\nReviewed By: mcslee\n\nTest Plan: build\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665084 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "ba35456acfbd00b8e623977dbc9679f6c2e49270", "tree": "2bacad10aa9abfdba2489d4fde74631861396681", "parents": [ "8142b9d122078793b8a2ff8d4510ff03ecd1a5b7" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Apr 03 07:31:51 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Apr 03 07:31:51 2007 +0000" }, "message": "Fix build script reference problem\n\nReviewed By: pquerna@apache.org\n\nTest Plan: build w/o libevent installed\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665081 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "ba8f8d7953c06e27bac7f569d628a49c27231c73", "tree": "482dc9670e2ca2b27e52db22f26912e5b2cfff0b", "parents": [ "c11045ade243dfc9d60a2d231ea7b378540fa65d" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Apr 03 00:34:00 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Apr 03 00:34:00 2007 +0000" }, "message": "Remove extra TApplicationException:: in Thrift.h\n\nSummary: G++ 4.1.1 compatibility\n\nReviewed By: alex tribble\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665078 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "b6b5a9e001071b781a2bd826770ad56165dc08e4", "tree": "7b817341a512a2814e4cda0f0687e39875e310f7", "parents": [ "10b3bdbb853519b922a0b18ca9f384167b82d035" ], "author": { "name": "Marc Slemko", "email": "marc@apache.org", "time": "Sun Apr 01 20:17:02 2007 +0000" }, "committer": { "name": "Marc Slemko", "email": "marc@apache.org", "time": "Sun Apr 01 20:17:02 2007 +0000" }, "message": "Removed comment about needing a lock in thread main. Access through boost::shared_ptr is thread safe\n\nReviewed By: none\n\nTest Plan: N.A.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665076 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "3f234dad0ed5e5eb629e5eaf451672366ce1f89e", "tree": "57d28c29b8c2994c28a18cfb2dce6a14bbf22da6", "parents": [ "9dc57402b5297a14a53f47658e72fcdab7e99f72" ], "author": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Sun Apr 01 01:19:57 2007 +0000" }, "committer": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Sun Apr 01 01:19:57 2007 +0000" }, "message": "-- more assert fixes for thrift concurrency\n\nReviewed By: mcslee\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665074 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "9dc57402b5297a14a53f47658e72fcdab7e99f72", "tree": "f1c88340c5b92ba0efd2e76ce719b14a3f77b394", "parents": [ "adf3e7f0c6127967ab546b8a460131c07de84b2d" ], "author": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Sat Mar 31 17:45:12 2007 +0000" }, "committer": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Sat Mar 31 17:45:12 2007 +0000" }, "message": "-- assert fixes for thrift concurrency lib\n\nSummary:\n- cannot assume that assert.h is defined\n\nReviewed By: marc k\n\nTest Plan: everything compiles\n\nNotes:\n- need to reflect these changes in libfacebook/fbthread\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665073 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "ac62f948cc0775ea5c9af317f4d301f7f8143e11", "tree": "0866859a62360acae5c4f31fd4c54732420385ca", "parents": [ "f1ceb477ea0ce6a5f2938582404b56bd345247e3" ], "author": { "name": "Martin Kraemer", "email": "martin@apache.org", "time": "Fri Mar 30 18:41:48 2007 +0000" }, "committer": { "name": "Martin Kraemer", "email": "martin@apache.org", "time": "Fri Mar 30 18:41:48 2007 +0000" }, "message": "Thrift - remove client disconnect error\n\nSummary:\nIt\u0027s fairly obnoxious.\n\nReviewed By: Slee and Karl\n\nTest Plan:\n\nRevert Plan: revertible\n\nNotes:\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665069 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "f1ceb477ea0ce6a5f2938582404b56bd345247e3", "tree": "ecaa56bbf6e2781d0ab4c1724cb2e30ebc66171b", "parents": [ "8f6e207a5ded3c0dd12eca450031ff6f01c406c5" ], "author": { "name": "James Wang", "email": "jwang@apache.org", "time": "Wed Mar 28 22:43:57 2007 +0000" }, "committer": { "name": "James Wang", "email": "jwang@apache.org", "time": "Wed Mar 28 22:43:57 2007 +0000" }, "message": "Thrift: Making TProcessor::process(io) non-virtual again, since my last change which made it virtual caused compiling errors of functions being hidden, ugh\n\nReviewed by: Karl\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665068 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "8f6e207a5ded3c0dd12eca450031ff6f01c406c5", "tree": "2ee8efb479cccf587817f8716eff654e3b479122", "parents": [ "3e9d177fd2a063a027262735adafc4d256748b1c" ], "author": { "name": "James Wang", "email": "jwang@apache.org", "time": "Wed Mar 28 00:47:09 2007 +0000" }, "committer": { "name": "James Wang", "email": "jwang@apache.org", "time": "Wed Mar 28 00:47:09 2007 +0000" }, "message": "Thrift: PeekProcessor - moving PeekEnd call after PeekBuffer\n\nReviewed by: boz\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665067 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "3e9d177fd2a063a027262735adafc4d256748b1c", "tree": "4920db5ee918f35189e15c6c6f8339098aa0239c", "parents": [ "be0ae5b1be0dcd1272a351bfb9c21d6466a62240" ], "author": { "name": "James Wang", "email": "jwang@apache.org", "time": "Tue Mar 27 23:17:34 2007 +0000" }, "committer": { "name": "James Wang", "email": "jwang@apache.org", "time": "Tue Mar 27 23:17:34 2007 +0000" }, "message": "Thrift: Adding StatsProcessor, PeekProcessor, TPipedFileReaderTransport, and TPipedFileReaderTransportFactory classes\n- StatsProcessor can be used to print events, or keep track of event frequency\n- PeekProcessor is used to examine data in a thrift event, prior to passing it along to an underlying processor\n- TPipedFileReaderTransport and its factory are used to pipe a TFileReaderTransport (which TFileProcessor requires)\n\nAlso fixed some bugs in TFileTransport - next flush time was overflowing and not always being reset\n\nReviewed by: aditya, mcslee\n\nTest Plan: Tested using various thrift clients (scribe, falcon) and gdb in sandbox and on dev008.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665066 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "be0ae5b1be0dcd1272a351bfb9c21d6466a62240", "tree": "d7cfe59a6034b45af38b7e70102be049f4e07abb", "parents": [ "a821cfd39f077e5372260ba1bcf7365754a76167" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Mar 22 02:35:33 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Mar 22 02:35:33 2007 +0000" }, "message": "Fix heinous TMemoryBuffer bug and warning in FileTransport\n\nReviewed By: dweatherford\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665065 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "561b5368886ced8ac0bca947a2bcdc6d70666206", "tree": "d444e336bd0c0a6301e33b9a7e6bb08a8bea698a", "parents": [ "4265a2c4d9701078d595f8a319621247fa5e3b59" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Mar 09 19:26:29 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Mar 09 19:26:29 2007 +0000" }, "message": "Fix TServerSocket accept() to not do 200ms polling\n\nSummary: Better to signal to unix file in select\n\nReviewed By: marc\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665056 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "4265a2c4d9701078d595f8a319621247fa5e3b59", "tree": "fabc5afaeff5a48f4aa7001843eae7d9f6a13e05", "parents": [ "4c91e554185e25d81ca2026070e3f6d7d13ac819" ], "author": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Thu Mar 08 03:10:29 2007 +0000" }, "committer": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Thu Mar 08 03:10:29 2007 +0000" }, "message": "-- Fix compiler warnings\n\nSummary:\n- These showed up when I was compiling on my local machine (cygwin!!)\n\nReviewed By: thrifty\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665055 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "1d4ce80af87143025b7d830e39d0f86475b980a6", "tree": "8a2dc386e67e3e201f4992900f6f15bc35d07071", "parents": [ "54b7ab9b53d82020b7cb055f11cd895db97a43a4" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Mar 07 05:16:16 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Mar 07 05:16:16 2007 +0000" }, "message": "Implement proper TThreadedServer shutdown\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665049 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "54b7ab9b53d82020b7cb055f11cd895db97a43a4", "tree": "3cc3c46af3f4f7089477636199e8f82075c93991", "parents": [ "5ea15f9e3206a4bb903f77d149b9cb8c1c2a392e" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Mar 06 00:06:27 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Mar 06 00:06:27 2007 +0000" }, "message": "READMEs and DOCs and ant tasks, oh my\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665048 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "5ea15f9e3206a4bb903f77d149b9cb8c1c2a392e", "tree": "82e645c266f38ccb080e60935fd49c8def6ec3d2", "parents": [ "5d06feab210f1175bc95d2ea435fd59a82b76024" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon Mar 05 22:55:59 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon Mar 05 22:55:59 2007 +0000" }, "message": "Get rid of all the using namespace and using boost:: declarations in Thrift header files\n\nSummary: To remove upstream dependencies. Still keeping some specific using directives around.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665047 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "5d06feab210f1175bc95d2ea435fd59a82b76024", "tree": "1acd7c92789d1871397e76eda2fcdff09460e360", "parents": [ "3303f360818aa39fc197f1f73ce3f7d578fbc2b1" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon Mar 05 22:18:18 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon Mar 05 22:18:18 2007 +0000" }, "message": "Thrift build cleanup stuff\n\nSummary: Get rid of autoconf stuff for lib/php, it doesn\u0027t do anything\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665046 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "3303f360818aa39fc197f1f73ce3f7d578fbc2b1", "tree": "fcc10f8cf612b573293abbf6da51e8cf844b5fcc", "parents": [ "c2c82c97f40e0c0eb52db001c28ce1acae8fa69e" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon Mar 05 20:09:37 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon Mar 05 20:09:37 2007 +0000" }, "message": "Thrift CPP threading fixes\n\nReviewed By: karl\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665045 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "4e441e296c1c525d404e882057adda0691a9b594", "tree": "cbcab3af4ad812e152e0574fbb389030ceeacf89", "parents": [ "a5a783f9534dc8a5bdd11d8da1472091859bc79b" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Mar 02 21:23:30 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Mar 02 21:23:30 2007 +0000" }, "message": "Do not check error code if select returns 0\n\nSummary: They don\u0027t seem to be guaranteed on our system, 0 just means timeout\n\nReviewed By: karl\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665040 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "a5a783f9534dc8a5bdd11d8da1472091859bc79b", "tree": "22d29357c2b93ba106cc94d7c0ff00b600342aeb", "parents": [ "6e3f637bab9bb19621382047d413100fe6c44e0a" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Mar 02 19:41:08 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Fri Mar 02 19:41:08 2007 +0000" }, "message": "Server robustness fixes in Thrift C++ libs\n\nSummary: ServerSockets can be interrupt() ed\n\nReviewed By: marc, karl\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665039 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "6e3f637bab9bb19621382047d413100fe6c44e0a", "tree": "8d4be56d3acda015ed1a6bf120f649cac8aac1f9", "parents": [ "7c10eaf35c200b46e26b9165be088b6a5d7dd791" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Mar 01 22:05:46 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Mar 01 22:05:46 2007 +0000" }, "message": "Proper shutdown functionality for Thrift servers\n\nReviewed By: karl\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665038 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "7c10eaf35c200b46e26b9165be088b6a5d7dd791", "tree": "0188a1742791e0e19337c516a809fd4a4f341d28", "parents": [ "adde9687c6b09af70a65c88764fd1ee3422d9163" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Mar 01 02:45:10 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Mar 01 02:45:10 2007 +0000" }, "message": "Add join to the ThreadManager\n\nSummary: Now you can join against all the threads in a ThreadManager\n\nReviewed By: marc, xp-style\n\nTest Plan: Use with new ThriftServer shutdown mechanisms\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665037 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "9f0c65153c6c0100071029c27b20db62bf98ffa4", "tree": "7c71be2e652730d5374daa5243e5406d7b7b5b1e", "parents": [ "57cc25e2a348bd8fe844b39321207226181e62c3" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Feb 28 23:58:26 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Feb 28 23:58:26 2007 +0000" }, "message": "Thrift license applied to all the C++ files\n\nReviewed By: bash\n\nNotes: marc says $*, corson says \"$@\"\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665030 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "57cc25e2a348bd8fe844b39321207226181e62c3", "tree": "9c2e7ea4a3ed88b57b015321c4c8a266a9f4c12b", "parents": [ "7a49888fc6990ec7485e3804a1958db7cbe70b07" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Feb 28 21:43:54 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Feb 28 21:43:54 2007 +0000" }, "message": "Some Thrift documentation cleanups\n\nSummary: Getting ready to hand this over to powerset, just want to have the right licenses in place and such first.\n\nReviewed By: thrift\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665029 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "2a22a88c5761620b41fded977c5d68abff49a12c", "tree": "152f1f3391b0d3db729034c70e1594737ec62233", "parents": [ "4401814d3a4ea2ef02215073d74e9ec4b946afab" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Feb 27 19:53:38 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Feb 27 19:53:38 2007 +0000" }, "message": "Thrift HTTP client optimizations\n\nSummary: When reading chunked encoding don\u0027t always get all the parts right away, return one part at a time so that reading code can deserialize the data on the fly.\n\nReviewed By: http\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665025 13f79535-47bb-0310-9956-ffa450edef68\n" } ], "next": "4401814d3a4ea2ef02215073d74e9ec4b946afab" }