)]}' { "log": [ { "commit": "3de1c4e4d33cc5c32809771f2bbec746501d1f94", "tree": "09a5117a44da903a96121ce2bfa164c735609d7b", "parents": [ "2ca456a8ae1599a2112eed0ddffa922657c8b123" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sun Feb 24 17:45:03 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sun Feb 24 17:45:03 2008 +0000" }, "message": "Use \"all-local\" instead of all in Makefile.am.\n\nSummary:\nRedefining an Automake rule totally blows away anything Automake puts in place.\nBy using all-local instead of all, we can just add to the generated rule.\n\nReviewed By: marc\n\nTest Plan: make\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665499 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "2ca456a8ae1599a2112eed0ddffa922657c8b123", "tree": "262d58e0e9af878b5534c6e399350c6df4edc401", "parents": [ "223d6bd1ac0c033aa01cad3aad8051df8a161a49" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sun Feb 24 16:42:18 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sun Feb 24 16:42:18 2008 +0000" }, "message": "Make \"make clean\" rules a bit more standard.\n\nSummary:\nmake-generic is some sort of internal undocumented thing.\nmake-local is what is supposed to be used for this stuff.\nAlso use $(RM) instead of \"rm -f\".\n\nReviewed By: marc\n\nTest Plan: make clean\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665498 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "223d6bd1ac0c033aa01cad3aad8051df8a161a49", "tree": "0731fd691717f902a294b3b872bdaaca7c81bdc4", "parents": [ "ff50f28700b68264f2d54d8f6fb3b929b64c5a32" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sun Feb 24 02:03:17 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sun Feb 24 02:03:17 2008 +0000" }, "message": "Make \"make check\" work properly for Python and Java.\n\nSummary:\nThe Python and Java versions of \"make check\" only work if \"make all\" has\nbeen run. Our automake-fu isn\u0027t strong enough to make proper dependencies,\nso this hack suggested by Nitay will force the libraries to be built\nbefore make check is run.\n\nTest Plan: make check\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665497 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "f8dcf03416bec49ee4ba7cc1615f61fa5e5419d7", "tree": "c7f17e9f1586c51207d598890d4d0d49fa871693", "parents": [ "dab2ad85dab534fb0488ce530d5231261c56487c" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sat Feb 23 22:07:39 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sat Feb 23 22:07:39 2008 +0000" }, "message": "Add automake support for building the Java library.\n\nIf java, javac, and ant are all available, the Java library will be built as part of the standard make target.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665494 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "132cc46d07a2b92f273b37f4c163b03a001f1a5a", "tree": "ab49fe619b0ab636dbf9b2ac02a464d3f2f9d01d", "parents": [ "1e62ab468cda132ae29b849d7c1ea4eac141140b" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Feb 21 22:49:58 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Feb 21 22:49:58 2008 +0000" }, "message": "Rename TJSONProtocol.java -\u003e TSimpleJSONProtocol.java\n\nSummary:\nChad Walters is developing a full-featured JSON-based protocol for Java,\nso we\u0027re renaming the existing protocol to something more descriptive.\nI also edited the file to rename the class and add to the header comment.\nI have no idea if Subversion does explicit rename tracking, or if\ngit svn is smart enough to mark renames as such, but I would predict\n\"yes\" to both. Let\u0027s find out.\n\nReviewed By: mcslee, jssarma\n\nTest Plan: Ran \"ant\" in lib/java\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665492 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "1e62ab468cda132ae29b849d7c1ea4eac141140b", "tree": "f5bda6d453d2d0c45702199ed0f57a857434a887", "parents": [ "215ba5c310dd82b56805982634b346e3f99c6a49" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Feb 21 22:37:45 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Feb 21 22:37:45 2008 +0000" }, "message": "TJSONProtocol no longer uses borrow, and miscellaneous fixes.\n\nSummary:\nAdded a LookaheadReader to the TJSONProtocol so it doesn\u0027t have to\nrely on the transport to borrow.\nAlso added a check to a corner case and fixed up some comments and whitespace.\n\nReviewed By: mcslee\n\nTest Plan: make check\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665491 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "215ba5c310dd82b56805982634b346e3f99c6a49", "tree": "3789e64869c7d3d11e2d414a907c860dbaa98935", "parents": [ "c91d07c784e603dfb49a0721bab34b0ff960fc3f" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Wed Feb 20 08:19:38 2008 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Wed Feb 20 08:19:38 2008 +0000" }, "message": "[thrift] Erlang thrift_sup will exit if it can\u0027t bind to the given address\n\nSummary: before it would complain and not exit. that\u0027s not right.\n\nReviewed By: eletuchy\n\nTest Plan: DEATH ENSUES\n\nRevert Plan: sounds reasonable\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665490 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "d7a16f4c111599f8b78905df70f0f60af0721e08", "tree": "4cc509319fdbaac889dca4205ca34aba274ad12c", "parents": [ "2845b52f47a361d89434b3234545811e082f7716" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Feb 19 22:47:29 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Feb 19 22:47:29 2008 +0000" }, "message": "Thrift: Add \"#include \u003ccstdlib\u003e\" in a few places and s/malloc/std::malloc/\n\nSummary:\nThere were a few places where we were calling malloc/reallaoc/free without\nincluding cstdlib (or stdlib.h). This is broken, but it worked because\nother headers that we were including included stdlib.h. However, on a\nplatform where this wasn\u0027t true, it broke the Thrift build. This change\nadds the proper includes. It also changes malloc to std::malloc (same\nwith realloc and free) in a few places, because that is the correct way\nof doing it when you include cstdlib.\n\nReviewed By: mcslee\n\nTest Plan: Compiled Thrift.\n\nRevert Plan: ok\n\nOther Notes:\nThis bug was noticed by a Thrudb user, and the patch was sent in by\nRoss McFarland.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665487 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "db0ea15310339c504f37128e49421bba58051933", "tree": "50e25907ca864ba90804ca3754238fdd514dc722", "parents": [ "c005b1b65ed24bba18e843c85b9a2a281bfec265" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Feb 18 01:49:37 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Feb 18 01:49:37 2008 +0000" }, "message": "Thrift: Add a full-featured JSON protocol for C++.\n\nSummary:\nThis change adds a new and exciting protocol to Thrift. It uses\nRFC-compliant JSON as the wire protocol and is fully human readable.\n(once a little whitespace has been inserted.) Unlike the existing\nJSON protocol for Java, which is intended to allow Thrift data to be\ntransferred to scripting languages, this protocol is lossless and fully\nread-write. It was written by Chad Walters of Powerset and reviewed\nby David Reiss.\n\nTested by running make check.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665482 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "c005b1b65ed24bba18e843c85b9a2a281bfec265", "tree": "94f0ec3d3776882ec3364bbfca09183798324890", "parents": [ "9ff3b9d5fc823fdc0d25cb3e034b00d098ebbdda" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Feb 15 01:38:18 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Feb 15 01:38:18 2008 +0000" }, "message": "Thrift: Distinguish between string and binary types in C++ and Java.\n\nSummary:\nThe upcoming TJSONProtocol handles string and binary types quite differently.\nThis change makes that distinction in all parts of the C++ binding.\n\nJava already distinguished between string and binary, but this change\nalso updates the Java skip method to skip over strings as binary\nso we don\u0027t get encoding errors when skipping binary data.\n\nReviewed By: mcslee\n\nTest Plan: make check\n\nRevert Plan: ok\n\nOther Notes:\nI just pulled this out of Chad Walters\u0027 JSON patch.\nThe only other change was adding readBinary (or was it writeBinary)\nto TDenseProtocol. Maybe inheriting from TBinaryProtocol wasn\u0027t a good idea.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665481 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "bc444b034e79b521b0512198a1feaa37da6d3ee7", "tree": "fd46151d59d5b294077ee7c353ec7750a7442f31", "parents": [ "bbf8062e4f37bde9e698e080b9f2017dd93bbfc6" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Feb 14 20:20:08 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Feb 14 20:20:08 2008 +0000" }, "message": "Thrift: Fix a bug in the skip function in Python\u0027s fastbinary.c\n\nReviewed By: mcslee\n\nOther Notes:\nSubmitted by Ben Maurer (the original author).\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665479 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "260a5fa08e87643bd5c001cc25311e9074795cfc", "tree": "3078959b1567149a43df8dd1170c66cb28ef8210", "parents": [ "dd43eb85c767118c89137dc5ac5b9f29f2cc80f6" ], "author": { "name": "eletuchy", "email": "dev-null@apache.org", "time": "Wed Feb 13 22:41:03 2008 +0000" }, "committer": { "name": "eletuchy", "email": "dev-null@apache.org", "time": "Wed Feb 13 22:41:03 2008 +0000" }, "message": " [thrift] grrrr ... TPhpStream can read the string \u00270\u0027\n\n Summary: php sucks\n\n Reviewed By: mcslee\n\n Test Plan: thrift call with string \u00270\u0027 has same behavior as string \u00271\u0027\n\n Revert Plan: sure\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665477 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "bd03e3e40e4117ffb32fe5d4ed703f0f7c233680", "tree": "2da538a64e556af0a1b39e346753a25f3fc7f3a4", "parents": [ "7ed4b98a44e8af506991634482a41da77c1b7838" ], "author": { "name": "eletuchy", "email": "dev-null@apache.org", "time": "Wed Feb 13 00:48:15 2008 +0000" }, "committer": { "name": "eletuchy", "email": "dev-null@apache.org", "time": "Wed Feb 13 00:48:15 2008 +0000" }, "message": "[erl-thrift] tiny change to exception message for tSocket:connect\n\nSummary: calls integer_to_list on the port\n\nReviewed By: dreiss\n\nTest Plan: connected a client to non-running server. oh noes, exception.\n\nRevert Plan: sure\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665475 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "55aebc404b52971909e8edd41c03c49b398698c1", "tree": "58d7626ad280c9f1a195df797a58b1dee4574c63", "parents": [ "407c9e7865ba63409bb842b9286f18fb3d19abc5" ], "author": { "name": "iproctor", "email": "dev-null@apache.org", "time": "Mon Feb 11 22:59:01 2008 +0000" }, "committer": { "name": "iproctor", "email": "dev-null@apache.org", "time": "Mon Feb 11 22:59:01 2008 +0000" }, "message": "Thrift haskell getTransport working\n\nSummary: getTransport is now a method of Protocol. To flush the transport one does tflush (getTransport p) instead of pflush p. This is more like how it is done with other languages.\n\nReviewed By: dcorson\n\nTest Plan: Ran thrifttest for haskell.\n\nRevert: OK\n\nDiffCamp Revision: 7515\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665473 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "a8de4895f61196d6bf139c3becbad5800b977e1c", "tree": "f72134854794ffffcc3de95164dee0705b54c650", "parents": [ "3c5d2fd9a87f3bdb07aac7afa2c50e5e90d88fa8" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Sat Feb 09 00:02:26 2008 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Sat Feb 09 00:02:26 2008 +0000" }, "message": "Patch from Ross McFarland to compile with strict warnings\n\nSummary: Use comment trick in params that are unused to prevent warnings\n\nReviewed By: dreiss\n\nTest Plan: Generate C++ code and compile -W -Wall\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665469 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "0c90f6f8af1d64ec9272bb2f6092336f3d0b8df8", "tree": "15245f459a76acc769d8fe99179176b4965bf66d", "parents": [ "3160971286aea0d5b28d5a7a87acaa8a12209ef8" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Feb 06 22:18:40 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Feb 06 22:18:40 2008 +0000" }, "message": "Thrift: Whitespace cleanup.\n\nSummary:\n- Expanded tabs to spaces where spaces were the norm.\n- Deleted almost all trailing whitespace.\n- Added newlines to the ends of a few files.\n- Ran dos2unix on one file or two.\n\nReviewed By: mcslee\n\nTest Plan: git diff -b\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665467 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "3160971286aea0d5b28d5a7a87acaa8a12209ef8", "tree": "57afe653e58c3d1fd009b169ce30cf2c8d5f08e6", "parents": [ "1fdb59242a697202587c3ef714e703144073dfbb" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Feb 06 22:10:26 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Feb 06 22:10:26 2008 +0000" }, "message": "Thrift: Update some makefiles to make \"make dist\" work.\n\nReviewed By: mcslee\n\nTest Plan: Ran \"make dist\" and did a diff.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665466 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "1fdb59242a697202587c3ef714e703144073dfbb", "tree": "8a20622336cf2725756a5bd6e768df98b856a624", "parents": [ "46dc62950d24cf785415de040255b3b0c67ecb3a" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Feb 06 22:10:12 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Feb 06 22:10:12 2008 +0000" }, "message": "Thrift: Add a Makefile to build the C# library with Mono.\n\nReviewed By: mcslee\n\nTest Plan: Installed Mono and built it.\n\nRevert Plan: ok\n\nOther Notes:\nSubmitted by Ben Maurer.\nActually reviewed by Todd Berman.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665465 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "46dc62950d24cf785415de040255b3b0c67ecb3a", "tree": "d9ef9c5a5261285903108c7cb40391ad3b07ea8b", "parents": [ "cba5727a3fc49a1c8e93bc8cfd5ba4e20326cbc3" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Feb 06 22:09:58 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Feb 06 22:09:58 2008 +0000" }, "message": "Thrift: Miscellaneous optimizations for C#.\n\nReviewed By: mcslee\n\nTest Plan: Built it after a future revision.\n\nRevert Plan: ok\n\nOther Notes:\nSubmitted by Ben Maurer.\nActually reviewed by Todd Berman.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665464 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "cba5727a3fc49a1c8e93bc8cfd5ba4e20326cbc3", "tree": "adc9fabdcbf713a4c964df9f4d1469bc1bcbde6b", "parents": [ "e4667378c4e30f1b7b465e89837462a2fed28b16" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Feb 06 22:09:44 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Feb 06 22:09:44 2008 +0000" }, "message": "Thrift: String/Binary distinction for C#.\n\nReviewed By: mcslee\n\nTest Plan: Built it after a future revision.\n\nRevert Plan: ok\n\nOther Notes:\nSubmitted by Ben Maurer.\nActually reviewed by Todd Berman.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665463 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "e4667378c4e30f1b7b465e89837462a2fed28b16", "tree": "d6125e8b032948a36abf7545ecefafdd7abc9daa", "parents": [ "f7baf549bcea8793f7882eb7e01cb3affaea97b8" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Feb 06 18:22:39 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Feb 06 18:22:39 2008 +0000" }, "message": "Thrift/Ruby: Bug fix.\n\nSummary:\nSome member variables were actually being treated as local variables.\n\nReviewed By: mcslee\n\nTest Plan: None.\n\nRevert Plan: ok\n\nOther Notes:\nActually reviewed by Kevin Clark.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665462 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "f7baf549bcea8793f7882eb7e01cb3affaea97b8", "tree": "b09ef9b309f15139699de5a417612121033d97bb", "parents": [ "adb5cad7d32c1dd2f11b18b8d0f14b6955df3606" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Feb 04 21:56:27 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Feb 04 21:56:27 2008 +0000" }, "message": "Thrift: Revamp TMemoryBuffer constructors.\n\nSummary:\nThere were some weird cases where the implicit conversion from\nconst char* to std::string was causing the wrong constructor to be called.\nThere wasn\u0027t really a clean workaround, so we\u0027re dropping the string\nconstructors.\n\nReviewed By: mcslee\n\nTest Plan:\nRan the test.\nGrepped around the /projects tree for uses that had to fixed,\nand fixed them.\n\nRevert Plan: ok\n\nOther Notes:\nThis risk was pointed out by Ben Maurer.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665461 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "20f009d6251af0f838c4ef8799d6b238cd230606", "tree": "35b26d27d4c7326e20947ef49c030c512dca4e4f", "parents": [ "46379900138403d9012cc504d9143d971920ec91" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Feb 04 19:24:00 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Feb 04 19:24:00 2008 +0000" }, "message": "Thrift: Forgot to dereference a pointer.\n\nSummary:\nThis didn\u0027t get updated when the interface changed,\nand the cast silenced the warning message. Stupid C.\n\nReviewed By: mcslee\n\nTest Plan: Trust Chad Walters.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665457 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "f495f367c9d7dd89c15b9732a7ac8d0db43596bf", "tree": "7d3510adfb14a0b9f45c3281e43d05b53344e711", "parents": [ "d46eb09befca3e43b01a00476611c7a0c0fc0254" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sat Feb 02 00:54:55 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sat Feb 02 00:54:55 2008 +0000" }, "message": "Thrift: Make borrow (almost) always succeed for TBufferedTransport.\n\nChad Walters is writing a JSON protocol for Thrift, but he wants\nborrow to always succeed. That would be a pain to implement,\nbut here is a first step: borrow will almost always work with\nTBufferedTransport.\n\nReviewed by: mcslee\n\nTest Plan: Ran the DenseProtocol test and Zlib test, but more needs to be done.\n\nOther Notes:\nAlso reviewed by Chad Walters, and maybe Ben Maurer.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665455 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "d46eb09befca3e43b01a00476611c7a0c0fc0254", "tree": "dfd7091441c87b5a760c56a6bcc2cd9e0789c931", "parents": [ "84e5022bfc9a815ce5f14e6effd980c6672da872" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sat Feb 02 00:54:48 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Sat Feb 02 00:54:48 2008 +0000" }, "message": "Thrift: Update the interface for TTransport\u0027s \"borrow\" method.\n\nSummary:\nI don\u0027t know what I was thinking when I first wrote this.\nIt makes sense that the transport might not want to allocate its own memory,\nso the protocol is expected to provide a buffer for the data.\nHowever, if the transport already has the data buffered,\nthere is no need to memcpy it; it can just return a pointer into its buffer.\nThe new interface still requires the protocol to provide a buffer,\nbut allows the transport to return a pointer to an interal buffer.\nIn addition, I made len a pass-by-pointer parameter so that\nthe transport can return more than the requested data if it has it\navailable in its buffers.\n\nReviewed By: mcslee\n\nTest Plan: Ran the DenseProtocol test and the Zlib test.\n\nRevert Plan: ok\n\nOther Notes:\nAlso got this reviewed by Chad Walters from Powerset.\nBen Maurer suggested making len a reference parameter.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665454 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "aa93451dbfd068c4e661e646b3e8a24f1f7ee29a", "tree": "600635bb4f5cab0ea573c129c4dd910afb3dad5b", "parents": [ "073e2cfeb5eea795ca6941774633243d3958e970" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Wed Jan 30 01:39:01 2008 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Wed Jan 30 01:39:01 2008 +0000" }, "message": "[thrift] iolists and binaries in Erlang\n\nSummary: three related changes:\n * for numeric types in tBinaryProtocol call effectful_write with binary(), not [char()]\n * tBinaryProtocol:writeString now takes either [char()], iolist(), or binary() ... now you can use any of the three where a Thrift string is required\n * tBufferedTransport now buffers by building an iolist() rather than Buffer++Data. zomg.\n\nReviewed By: eletuchy\n\nTest Plan: everything seems to work as usual, and binary() works as expected\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665447 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "f09b8a01b1082f581442a08d6e28891e2495c0a6", "tree": "7e8187fea7b91524a1ccbc8b1ed964d4b9f1cb33", "parents": [ "fe6d1488eb5196764c7fa41190dd5f2e1fac0e3f" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Jan 28 20:46:53 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Jan 28 20:46:53 2008 +0000" }, "message": "Thrift/Ruby: TSimpleServer closes its listen socket on an uncaught exception.\n\nSubmitted by William Morgan.\nApproved by Kevin Clark.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665444 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "fe6d1488eb5196764c7fa41190dd5f2e1fac0e3f", "tree": "c0ad606939ea2329859100eae9a86745f861b8e6", "parents": [ "41911a516663fec077b4b5228fc66ddebc1aae47" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Jan 28 20:46:50 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Jan 28 20:46:50 2008 +0000" }, "message": "Thrift/Ruby: Remove a debugging message.\n\nSubmitted by William Morgan.\nApproved by Kevin Clark.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665443 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "41911a516663fec077b4b5228fc66ddebc1aae47", "tree": "3612127f89cfe4b946bf6f41a5d940403b1dd028", "parents": [ "0e87ef7ae72e4f897adca447f1932147cb05a57e" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Jan 25 20:12:26 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Jan 25 20:12:26 2008 +0000" }, "message": "Thrift: Better exception handling in Ruby.\n\nReviewed By: mcslee\n\nTest Plan: None.\n\nRevert Plan: ok\n\nOther Notes:\nSubmitted by William Morgan.\nApproved by Kevin Clark.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665442 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "0e87ef7ae72e4f897adca447f1932147cb05a57e", "tree": "159308cc3b06d23cbbe2bd3a9a6fd97f717f93ef", "parents": [ "b0232b39e365b25d2aab5e6dc76e4b40cb37d74f" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Jan 25 20:05:50 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Jan 25 20:05:50 2008 +0000" }, "message": "Thrift: Some sort of Ruby performance fix.\n\nReviewed By: mcslee\n\nTest Plan: None.\n\nRevert Plan: ok\n\nOther Notes:\nSubmitted by Dave Simpson.\nApproved by Kevin Clark.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665441 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "b0232b39e365b25d2aab5e6dc76e4b40cb37d74f", "tree": "03d90269173fb6094aa9bfa23e1ad749512ef4d5", "parents": [ "1e150185daeb953d8ed1b91cc9694bbacb5518e5" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Jan 23 20:35:39 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Jan 23 20:35:39 2008 +0000" }, "message": "Thrift: Allow a custom User-Agent with the Cocoa THttpClient.\n\nReviewed By: mcslee\n\nTest Plan: None.\n\nOther Notes:\nSubmitted by Andrew McGeachie, the author of the Cocoa bindings.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665440 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "1e150185daeb953d8ed1b91cc9694bbacb5518e5", "tree": "512a90b7226459b4da6375a9d28e903f87d300f8", "parents": [ "a9a4d481e08b44972324db1620871cd1a83a804f" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Jan 22 04:04:30 2008 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Jan 22 04:04:30 2008 +0000" }, "message": "Thrift CSharp build to check compiler return code\n\nSummary: If non-zero, toss an error to the log\n\nReviewed By: dreiss\n\nOther Notes: Submitted by Will Palmeri\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665439 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "a9a4d481e08b44972324db1620871cd1a83a804f", "tree": "73463aab131c267415c3678c17ab6d4b4d77acb4", "parents": [ "050f3200a2963d00212d4f4b62acfe428ad789a6" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Fri Jan 18 21:35:34 2008 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Fri Jan 18 21:35:34 2008 +0000" }, "message": "[thrift] Ruby TThreadedServer and TThreadPoolServer\n\nSummary: They both use the same handler for all connections and thus assume the handler is thread-safe. The TThreadPoolServer preserves threads, so it wouldn\u0027t be too hard to make a variant that used a separate handler for each thread and thus didn\u0027t require thread safety.\n\nReviewed By: mcslee\n\nTest Plan: loads without error\n\nRevert Plan: ok\n\nOther Notes: contributed by William Morgan (w@adap.tv)\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665438 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "2e8a8d40951ba3708ddb377e90e34b270bfc5446", "tree": "1a13a01d6dec6f6b69f40477a193199fd0df9b68", "parents": [ "1c99140ec009fad8e8e03e9896ed078fabee7c98" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Jan 16 00:38:20 2008 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Jan 16 00:38:20 2008 +0000" }, "message": "Make sure exceptinos in servers are caught\n\nSummary: There was potential for a write exception in close() because it might call flush() internally\n\nReviewed By: dreiss\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665430 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "737ce021d1eebc100df83ee04489cb85e4a5f56c", "tree": "64aff389ccd28928321428dafe975bb2c1e3498b", "parents": [ "1c4ced7409e86f64b449b4e33cf0a50b7f1e4c34" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Jan 15 02:59:12 2008 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Jan 15 02:59:12 2008 +0000" }, "message": "Add some more TThreadPoolServer constructors\n\nSummary: Change the default to Executors.newCachedThreadPool() which is a good default and basically what we should always want.\n\nReviewed By: dreiss\n\nTest Plan: Run a Java server with default args\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665424 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "21db52de163e27f6cb01410fec812dc5f9e6e6a9", "tree": "144633e60560d915a889e9abc4aa3d0b1eeabd85", "parents": [ "7f42bcf97c8961d5f25cb88220d0b358a1cbccae" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Mon Jan 14 05:54:50 2008 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Mon Jan 14 05:54:50 2008 +0000" }, "message": "[thrift] fix thrift_logger.erl when show_pid option is enabled\n\nSummary: this gets rid of a lot of messy useless output every time the error logger prints something\n\nReviewed By: eletuchy\n\nTest Plan: works as expected\n\nRevert Plan: ok\n\nOther Notes: contributed by Todd Lipcon (todd@amiestreet.com)\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665422 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "7f42bcf97c8961d5f25cb88220d0b358a1cbccae", "tree": "e10c327a36496b5f3b1146a2c5b84d6fb6f159bc", "parents": [ "204420fa56d93adb59ac9fe339bb25e8d9b13fb2" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Jan 11 20:59:12 2008 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Jan 11 20:59:12 2008 +0000" }, "message": "Thrift: C# Bindings.\n\nSummary:\nC# generator, library, and MS Build task contributed by imeem.\n\nReviewed By: mcslee\n\nTest Plan:\nBuilt the Thrift compiler and generated some C# code.\nI\u0027d love to say I installed Mono or Portable.NET and built the C# code,\nbut I did not.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665421 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "19c9777583bf4614a237be824bbed80fa6db9213", "tree": "3b3d94d10fb25b1f88b843132fc9768260896786", "parents": [ "89f57164215850cc1b0d12460ce242a44a4143af" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Jan 10 19:57:47 2008 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Jan 10 19:57:47 2008 +0000" }, "message": "Chagnge TThreadPoolServer in Java to use SynchronousQueue by default\n\nSummary: Read the documentation on ThreadPoolExecutor. It\u0027s very confusing. Basically, what we want is a queue that always defers to the threadpool and will always create a new thread to do work. We never want the queue to take priority over the thread pool by default.\n\nReviewed By: dreiss\n\nTest Plan: Run a Java Thrift server\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665419 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "89f57164215850cc1b0d12460ce242a44a4143af", "tree": "269b3cbb6d012ee622aec4ecc8f0dc59bf65b119", "parents": [ "8c46b1a88180d8ca1cd943439e3c365d91e33672" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Jan 10 00:53:08 2008 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Jan 10 00:53:08 2008 +0000" }, "message": "Ruby default values patch\n\nSummary: Submitted by Dan Sully, reviewed by Kevin Clark\n\nReviewed By: dreiss\n\nTest Plan: New ruby generated code with default vals, and new test scripts\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665418 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "26484fb7b145a10a3aa8f3b396a32c4f5b85236c", "tree": "7dd401415c536dbab54131ba4e66268ed6bbf175", "parents": [ "33d8f340dcca637e3b91d946f3f6f92daff64456" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Tue Jan 08 03:14:19 2008 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Tue Jan 08 03:14:19 2008 +0000" }, "message": "[thrift] in erlang add {nodelay, true} and {reuseaddr, true} to gen_tcp socket options\n\nSummary: for parity with the C++ implementation\n\nReviewed By: eletuchy\n\nTest Plan: ok\n\nRevert Plan: ok\n\nOther Notes: contributed by Todd Lipcon (todd@amiestreet.com)\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665415 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "33d8f340dcca637e3b91d946f3f6f92daff64456", "tree": "8c9e312a1f284f2f935fe93a45d8625c2a1b1303", "parents": [ "8ec70e88e68aba3e3fa636b6ac23cbf2ec726152" ], "author": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Mon Jan 07 22:23:07 2008 +0000" }, "committer": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Mon Jan 07 22:23:07 2008 +0000" }, "message": "[thrift] py: TApplicationException.__str__\n\nSummary: Now infinitely more printable than ever before!\nReviewed by: mcslee\nTest Plan: except TApplicationException, inst: \\n\\t\\t print inst\nRevert: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665414 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "e8abada6ad63306c38d2107601a5645ff8f1d22c", "tree": "22ddba2ae5d0353aeee37a674c011f7154c233a0", "parents": [ "7ab31e4fd1bf3c6389d1743ee0e8554aa8b97ad4" ], "author": { "name": "pfung", "email": "dev-null@apache.org", "time": "Sat Jan 05 23:23:53 2008 +0000" }, "committer": { "name": "pfung", "email": "dev-null@apache.org", "time": "Sat Jan 05 23:23:53 2008 +0000" }, "message": "[Thrift] disabling catching general type exceptions in Tthreadpoolserver\n\nthe threadpoolserver should just crash if an unknown exception type is thrown.\n\nThis should probably be true for all server types, will put this on the TODO list.\n\nreviewed by jwang\ntest plan: network selector servers in production\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665412 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "7ab31e4fd1bf3c6389d1743ee0e8554aa8b97ad4", "tree": "5876bcd1f0688e7ea3a65d756ac7660b93b77aaf", "parents": [ "fbc911438de5b86f665b3e8b7d2499d52e37d357" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Fri Jan 04 00:21:18 2008 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Fri Jan 04 00:21:18 2008 +0000" }, "message": "[thrift] add show_pid option to thrift.app.src (Erlang)\n\nSummary: we\u0027ve been using this option in our apps but we never added it to thrift\u0027s own config\n\nReviewed By: eletuchy\n\nTest Plan: ok\n\nOther Notes: contributed by Jason Ganetsky (jason@amiestreet.com)\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665411 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "832b262acab7656ce5d5541f010c29f060580693", "tree": "8fecf364acbfb94a60a1bcf929f8f891e5130510", "parents": [ "65704511459cdfc0f3e7d70b5008ea4e18a6f538" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Dec 28 18:25:33 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Dec 28 18:25:33 2007 +0000" }, "message": "Thrift: Revamp build to use a single configure.ac.\n\nSummary:\nBen Maurer suggested that it would make sense for Thrift to build as\na single project, with one configure.ac and multiple Makefile.am.\nHe was also kind enough to do the heavy lifting, and this commit\nis the application of his patch (with minor modifications).\nThe most significant visible change from this diff is that\nin order to buidl one of the thrift sub-projects (i.e.: the compiler,\nthe C++ library, or the Python library) you must run bootstrap.sh\nand configure in the Thrift root, then make in the specific project.\nUsers who want to build and install the Python library but\ncan\u0027t run configure because they don\u0027t have Boost can simply\nrun setup.py directly.\n\nReviewed By: mcslee\n\nTest Plan: Built Thrift from scratch.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665409 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "5d86e399036740633954c50cc88f2a98908f54b0", "tree": "949268984e1d6c5bcd9580a5bf8a7017ec26cbc7", "parents": [ "4b6ff2dabcc67b437f9fb9e6930cb4705bd936df" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Dec 26 20:23:03 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Dec 26 20:23:03 2007 +0000" }, "message": "Thrift: Wide string support for Perl.\n\nSummary:\nThis patch allows the TBinaryProtocol to encode wide character strings\nas UTF-8 before serializing. It does not support decoding when receiving.\n\nReviewed By: mcslee\n\nTest Plan: None.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665407 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "4b6ff2dabcc67b437f9fb9e6930cb4705bd936df", "tree": "69506044310a25eca841ac4ddfac9088bcd2d171", "parents": [ "f845b7d3e097097446067b3a0bc96c6dc85008ca" ], "author": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Tue Dec 25 22:58:50 2007 +0000" }, "committer": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Tue Dec 25 22:58:50 2007 +0000" }, "message": "-- Allow ThreadPoolManager tp return immediately from addTask\n\nSummary:\n- it should be possible to specify a zero timeout if the pendingTaskQueue\n is already full\n\nReviewed By: marc\n\nTest Plan:\n- Tested in search\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665406 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "16cf270283cd08e53467baa765b05c0427a4f5b8", "tree": "ffa1212f0dd77b34bea3fd2f2d05d35528e2c258", "parents": [ "eaa61e43630c68ee2e98f7b649047e45c524f9d8" ], "author": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Fri Dec 21 07:07:31 2007 +0000" }, "committer": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Fri Dec 21 07:07:31 2007 +0000" }, "message": "[thrift] Make TTransportException::getType const throw()\n\nSummary: const so that catching via \"catch (const TTransportException\u0026 e)\" works\n properly, and throw() for good convention.\nReviewed By: mcslee\nTest Plan: still compiles\nRevert: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665403 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "eaa61e43630c68ee2e98f7b649047e45c524f9d8", "tree": "c0aac25d067e39e31e0f5e6bcbb5b9ca378e7356", "parents": [ "97264864df4e7c14d8a4323af6ad37e726c52ef9" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Dec 20 21:42:05 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Thu Dec 20 21:42:05 2007 +0000" }, "message": "Thrift: A hack to prevent incorrect usage of Mutex Guards.\n\nReviewed By: boz\n\nTest Plan:\ndreiss@dreiss-vmware:safe_concurrency:thrift/test$ nl -ba guard_test.cc\n 1 #include \"../lib/cpp/src/concurrency/Mutex.h\"\n 2 using facebook::thrift::concurrency::Guard;\n 3 void test() {\n 4 facebook::thrift::concurrency::Mutex m;\n 5 Guard(m);\n 6 Guard g1(m);\n 7\n 8 facebook::thrift::concurrency::ReadWriteMutex rwm;\n 9 facebook::thrift::concurrency::RWGuard(m);\n 10 facebook::thrift::concurrency::RWGuard g2(rwm);\n 11 }\ndreiss@dreiss-vmware:safe_concurrency:thrift/test$ g++ -c guard_test.cc\nguard_test.cc: In function ‘void test()’:\nguard_test.cc:5: error: ‘incorrect_use_of_Guard’ was not declared in this scope\nguard_test.cc:9: error: ‘incorrect_use_of_RWGuard’ is not a member of ‘facebook::thrift::concurrency’\ndreiss@dreiss-vmware:safe_concurrency:thrift/test$\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665402 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "97264864df4e7c14d8a4323af6ad37e726c52ef9", "tree": "31dc8f2b531dbb29911ba9f944a28e30cd7a1c82", "parents": [ "a89cd7b03e1a1071094bacdfbf74cff3739b2911" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Dec 20 03:23:27 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Dec 20 03:23:27 2007 +0000" }, "message": "is_a is deprecated, instanceof only takes vars or constants\n\nSummary: Solution, dummy static class var to use instanceof\n\nReviewed By: dweatherford\n\nTest Plan: Regen\u0027d some mobile code in trunk using this\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665401 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "a89cd7b03e1a1071094bacdfbf74cff3739b2911", "tree": "42e3191c5475e7e2e3da3d52d60ed5f3a2fc75e2", "parents": [ "6495adb992eca5eb37da1bd72ebb5cc798e1afb1" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Wed Dec 19 00:00:39 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Wed Dec 19 00:00:39 2007 +0000" }, "message": "[thrift] squelch crash reports in Erlang R12B-0\n\nSummary: there\u0027s a new format for errors in R12B-0, so don\u0027t echo a crash report if it matches the new one\n\nReviewed By: eletuchy\n\nTest Plan: completely unnecessary\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665400 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "677ffc50446082e3cd12bbf3e2cc1364c603429a", "tree": "277ad1b115eac2ece202773cb2af3505f26cb74a", "parents": [ "5ddd2f13faa12c5a45ebafcb229c570031678a78" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Dec 18 02:06:44 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Dec 18 02:06:44 2007 +0000" }, "message": "Private methods called not via self.\n\nSummary: Because self. puts you in public scope\n\nReviewed By: mcslee\n\nTest Plan: Use Ruby framed transport\n\nOther Notes: Submitted by Jake Luciani\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665397 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "5ddd2f13faa12c5a45ebafcb229c570031678a78", "tree": "5e0aae6deaa0b22edf4746ac048580c0c50cf57c", "parents": [ "5f54566f8ad4bac927de425dee555b9627957533" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Dec 17 09:49:10 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Mon Dec 17 09:49:10 2007 +0000" }, "message": "Thrift: Fix a bug in the Java runtime.\n\nReviewed By: mcslee\n\nTest Plan: Looked at the C++ version side-by-side.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665396 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "c16a8f6e45015299ed65fbdbfb3bda9017663a6d", "tree": "0d5436efb101750b88f61c7b0c10d54b569119bb", "parents": [ "4a15eb7f7114e1ef585365c0cbcd2fb0de982d27" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Dec 14 23:46:47 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Dec 14 23:46:47 2007 +0000" }, "message": "Thrift: Python support for Unix-domain sockets, and eager timeout setting.\n\nReviewed By: mcslee\n\nTest Plan: Ran the test script.\n\nRevert Plan: ok\n\nOther Notes:\nContributed by Ben Maurer.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665394 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "4a15eb7f7114e1ef585365c0cbcd2fb0de982d27", "tree": "ff7e90e571cf3fc8ebb0f933a75ea2d410b83d41", "parents": [ "adad4ab20356d4c16f2df521b205aae7272c105f" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Dec 14 22:14:47 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Dec 14 22:14:47 2007 +0000" }, "message": "Thrift: Maximum read length for Java.\n\nSummary:\nA feature to improve handling of invalid wire data by the Java Thrift library.\n\nReviewed By: mcslee\n\nTest Plan: I trust Dave Engberg.\n\nRevert Plan: ok\n\nOther Notes:\nSubmitted by Dave Engberg.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665393 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "adad4ab20356d4c16f2df521b205aae7272c105f", "tree": "300dfb6d00a841773f2df1876b5d05d971023436", "parents": [ "15457c9b08a75e0b5a8c82936151468bddfd27b8" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Dec 14 20:56:04 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Dec 14 20:56:04 2007 +0000" }, "message": "Thrift: Fix dangling pointer errors and make messages a bit more uniform.\n\nReviewed By: mcslee\n\nTest Plan: Honestly, just built the library.\n\nRevert Plan: ok\n\nOther Notes:\nThanks to Ben Maurer.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665392 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "77a31384b89683f7cb5ae7132ca3961a88886793", "tree": "ced9915210d1b920fb93284cf07375b96cad10e5", "parents": [ "78ee85c911891231030f2045cb17f98530abf9d9" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Dec 13 22:47:33 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Dec 13 22:47:33 2007 +0000" }, "message": "Use HAVE_SYS_TIME_H instead of HAVE_CLOCK_GETTIME\n\nSummary: Still need the right include here\n\nReviewed By: mcslee\n\nTest Plan: Paul Saab used this fix to build on Leopard\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665390 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "78ee85c911891231030f2045cb17f98530abf9d9", "tree": "445175e08e8935d897b93163c3bab81698d8ee71", "parents": [ "ae3804f8f7941102d42230a59879dbec8f076223" ], "author": { "name": "pfung", "email": "dev-null@apache.org", "time": "Thu Dec 13 22:30:47 2007 +0000" }, "committer": { "name": "pfung", "email": "dev-null@apache.org", "time": "Thu Dec 13 22:30:47 2007 +0000" }, "message": "[Thrift] message debugging for std::exceptions\n\nstd::exceptions did not have debug messages printed\n\nreviewed by dreiss\ntest plan: compiles\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665389 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "ae3804f8f7941102d42230a59879dbec8f076223", "tree": "c6e391b51b59254e25a8003e0383d277afe00f61", "parents": [ "c31769cceb013d947c2349f21285dfaf90d83fe2" ], "author": { "name": "James Wang", "email": "jwang@apache.org", "time": "Thu Dec 13 19:46:27 2007 +0000" }, "committer": { "name": "James Wang", "email": "jwang@apache.org", "time": "Thu Dec 13 19:46:27 2007 +0000" }, "message": "Fix to TThriftTransport corruption detection\n\nSummary: O_APPEND means that even if the file pointer is in the middle of the file, the next write will go to the end of the file. So when initializing the TThriftTransport to be written to, we need to truncate the file after the last good event. I\u0027m pretty sure this was what was causing queuemap log corruption when the multiplexer is restarted.\n\n The corruption doesn\u0027t necessarily go away at the next chunk boundary because of the offset being recalculated. I think it\u0027s good to have the offset recalculated, but then we shouldn\u0027t use the old chunk boundary data there, but rather use the newly calculated offset to determine the padding (could be an entire chunk, but that\u0027s okay -- way better than corruption)\n\nReviewed By: mcslee\n\nTest Plan: Wrote to a ThriftFile using local scribe instance. Printed it. Then cat\u0027d garbage to it from the command line. Then wrote to it again. Then printed it again. Seems to work fine, whereas with old scribe binary the later entries were corrupted.\n\nRevert: OK\n\nDiffCamp Revision: 4683\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665388 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "c31769cceb013d947c2349f21285dfaf90d83fe2", "tree": "c44fc12e94898f77a0ba5189e763c9277c91d297", "parents": [ "5d1784a7b41939e2ac09005c688b5d8165e3b323" ], "author": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Tue Dec 11 22:23:51 2007 +0000" }, "committer": { "name": "Aditya Agarwal", "email": "aditya@apache.org", "time": "Tue Dec 11 22:23:51 2007 +0000" }, "message": "-- better error checking for setRecvTimeout and setSendTimeout\n\nSummary:\n- could help prevent a 2.6.13 kernel bug\n\nReviewed By: mcslee, dreiss\n\nTest Plan:\n- Testing kernel crashes\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665387 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "5d1784a7b41939e2ac09005c688b5d8165e3b323", "tree": "802c0eb8384242e91a09037a01d2e8018fa66cde", "parents": [ "3f14d3ebec2028bbacbeb0991b236152f2912d1b" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Dec 05 23:20:54 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Dec 05 23:20:54 2007 +0000" }, "message": "Failing to init eventBase_ to NULL in one constructor\n\nReviewed By: dreiss\n\nTest Plan: See if scribe works for powerset\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665386 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "3f14d3ebec2028bbacbeb0991b236152f2912d1b", "tree": "32d566014f7c9b90d50971cd9bce1f2fcd5eaade", "parents": [ "c37b4c5193c344d6827a197bb86c718b42d74e47" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Dec 05 23:13:11 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Dec 05 23:13:11 2007 +0000" }, "message": "Merge Ruby framed transport\n\nSummary: Submitted by Jake Luciani\n\nReviewed By: mcslee\n\nTest Plan: Test code included in this commit\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665385 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "c37b4c5193c344d6827a197bb86c718b42d74e47", "tree": "e4abf0f936a4f47a5598aa1992c1ec1dcca72a4a", "parents": [ "2323cf642226468e6363b031fad6d9f64a45cb9f" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Dec 05 23:03:37 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Dec 05 23:03:37 2007 +0000" }, "message": "Remove unnecessary mutex from C++ socket code\n\nSummary: This is a threadsafe syscall, as it turns out.\n\nReviewed By: hzhao\n\nTest Plan: Thrift Client C++ sockets don\u0027t lock\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665384 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "2323cf642226468e6363b031fad6d9f64a45cb9f", "tree": "0a5c012af4174f85a6397cd949b8a3a29cb7f88a", "parents": [ "ef22dc652fbfaa7b7c718f752f2ca5b1fecdf94e" ], "author": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Wed Dec 05 03:40:19 2007 +0000" }, "committer": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Wed Dec 05 03:40:19 2007 +0000" }, "message": "[thrift] Better default TApplicationException messages\n\nSummary: \"Default TApplicationException\" is pretty meaningless; if we have this\n extra type information, we might as well present it.\n\nReviewed By: mcslee\nTest Plan: caught a couple of INVALID_MESSAGE_TYPE tapplicationexceptions\nRevert: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665383 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "ef22dc652fbfaa7b7c718f752f2ca5b1fecdf94e", "tree": "6c2c0d3a89436d4d4c602e9a15993dd6f08c557b", "parents": [ "9860ee2c86971cbbc1d2593ad67f8ea5bbf2aaa5" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Nov 30 20:38:49 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Fri Nov 30 20:38:49 2007 +0000" }, "message": "Thrift: Make some server methods public.\n\nReviewed By: mcslee\n\nTest Plan: Compiles.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665382 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "f60467efc9d11804f6d38370c4b90fa39e2262df", "tree": "1ef6ef64560e907eaf2db066d6e08233dc6906f9", "parents": [ "6f9ac3ffeb408392d1c3bb3945fe5b261f9e7817" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Nov 29 02:57:34 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Thu Nov 29 02:57:34 2007 +0000" }, "message": "Custom HTTP headers patch from Dave Engberg\n\nReviewed By: mcslee\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665380 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "bef54c0647b22128c9035cfbc4d4b112ab5e68f8", "tree": "edf60c83afb6525eed10110871199ddf78694bec", "parents": [ "b16074d53bd7b66d1e34dc6623637d59be717db5" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Nov 28 20:15:11 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Wed Nov 28 20:15:11 2007 +0000" }, "message": "Thrift: Fix a backwards change.\n\nSummary:\nGot it right in trunk, but wrong in thrift.\n\nBlame Rev: 69504\n\nReviewed By: mcslee\n\nTest Plan:\nTested in trunk AND did a diff with trunk.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665378 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "b16074d53bd7b66d1e34dc6623637d59be717db5", "tree": "bbd9d04e144848717897bf23f35bd142ffb13289", "parents": [ "d0f5b28835d80fc9a0f7bdb61e88e32b98a911c0" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Nov 28 05:54:33 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Nov 28 05:54:33 2007 +0000" }, "message": "Add pkgconfig to Thrift C++ libraries\n\nReviewed By: mcslee\n\nOther Notes: Submitted by Ben Maurer\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665377 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "d0f5b28835d80fc9a0f7bdb61e88e32b98a911c0", "tree": "f1149177c5faefb9e8dc691b95862db37f166c35", "parents": [ "e02ab33cb8e38392d371d08e09dbfb136202d61a" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Nov 28 04:29:25 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Nov 28 04:29:25 2007 +0000" }, "message": "Fix typo in Thrift trunk\n\nSummary: $classl \u003d\u003e $class\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665376 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "e02ab33cb8e38392d371d08e09dbfb136202d61a", "tree": "f8441454e05c0f511495732caa64d95a2ac56339", "parents": [ "645ecea7146b95f4b832a1042e58227216d7db4e" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Nov 28 04:17:49 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Nov 28 04:17:49 2007 +0000" }, "message": "Lowercase autoload strings\n\nSummary: PHP is undebatably the worst programming language in the world. Class names are case insensitive, so new $tHiNg \u003d new $THing. Garbase. Now autoload has to deal with the fallout.\n\nReviewed By: dreiss\n\nTest Plan: autoload enabled falcon code\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665375 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "645ecea7146b95f4b832a1042e58227216d7db4e", "tree": "df60931646706a5004df1b1c4b1c4839021d04fd", "parents": [ "d602f822d50bec166cd34c8ece170b13694268a9" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Nov 28 02:46:24 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Nov 28 02:46:24 2007 +0000" }, "message": "Kill fast binary compliance in TBase, it doesn\u0027t work\n\nReviewed By: akhil\n\nTest Plan: Regenerate code\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665374 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "d602f822d50bec166cd34c8ece170b13694268a9", "tree": "de260a0f17222f6899e945103103febafa68f26a", "parents": [ "b22df7c9639335ce336ba977312b2ad25180595e" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Nov 28 02:45:13 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Nov 28 02:45:13 2007 +0000" }, "message": "Complete the proper handling of all special characters in JSON strings for TJSONProtocol\n\nReviewed By: dreiss\n\nTest Plan: test/java/TestClient\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665373 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "b4d3e7b052c960a5ab96310f7cb16ba46e6d32b4", "tree": "146204125b41bf5ae4f186bd767b21941522eac1", "parents": [ "b45529269934a053b03528e287e66812e1109ad3" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Nov 28 01:51:43 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Nov 28 01:51:43 2007 +0000" }, "message": "Create a TServerEventHandler interface in TServer\n\nSummary: Such that users can supply an event handler to a server that will be used to signal various events that take place inside the server core.\n\nReviewed By: dreiss\n\nTest Plan: Rebuilt all servers, work by default\n\nOther Notes: Partially submitted and also reviewed by Dave Simpson at Powerset\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665371 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "b45529269934a053b03528e287e66812e1109ad3", "tree": "fa7700a9706bd25b1370a3d20954ee47959bd08e", "parents": [ "fe6ed0dff423a405fabd61e4bef3e490506ba2ba" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Nov 28 00:12:11 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Nov 28 00:12:11 2007 +0000" }, "message": "Add a few utility methods and helpers to Thrift C++ Sockets\n\nSummary: Submitted by Dave Simpson @ Powerset.\n\nReviewed By: mcslee\n\nTest Plan: test/cpp\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665370 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "fe6ed0dff423a405fabd61e4bef3e490506ba2ba", "tree": "a39ff94461ace23e965070c21954a2051342990d", "parents": [ "256bdc444866b90bbdccfb5343e9c9ea8c22603c" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 27 21:54:38 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 27 21:54:38 2007 +0000" }, "message": "Clean up the TSerializer\n\nSummary: Nested Transport subclass wasn\u0027t necessary, add comments\n\nReviewed By: dreiss\n\nTest Plan: Same as before, test/java/TestClient\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665369 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "256bdc444866b90bbdccfb5343e9c9ea8c22603c", "tree": "4348ac98f2cf36305bbddfca45686a40e097093d", "parents": [ "844ac12489600d7647f01ab4f9b99d9e1b81e69e" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 27 08:42:19 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 27 08:42:19 2007 +0000" }, "message": "IPv6 tweaks for Thrift\n\nSummary: Need to pass hints including AI_ADDRCONFIG to getaddrinfo to make sure no IPv6 addresses come back on non-IPv6 enabled systems\n\nReviewed By: mcslee\n\nOther Notes: Submitted by Paul Saab\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665368 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "844ac12489600d7647f01ab4f9b99d9e1b81e69e", "tree": "95e8c0b69f48680209948d5f3df5dad8602ea5bc", "parents": [ "5ab570558f55d73472fbf6c0e66e6e165093c7d8" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 27 08:38:52 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 27 08:38:52 2007 +0000" }, "message": "TJSONProtocol writing support in Java\n\nSummary: TJSONProtocol for Java with write support and a TSerializer utility for easier conversion of Thrift objects into byte[] or strings.\n\nReviewed By: dreiss\n\nTest Plan: Included a basic piece of this in test/ client for Java.\n\nRevert: OK\n\nDiffCamp Revision: 3890\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665367 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "53d9c0c20bd5af65676928b9b7a73dcb2cad3d78", "tree": "f0c76bf24315da72fbca98a993d97f5d1c72f93f", "parents": [ "79b1694043e07a673c343c42ad75d72f3b560539" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon Nov 26 21:15:40 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon Nov 26 21:15:40 2007 +0000" }, "message": "Merging EOFException changes from Ben Maurer\n\nSummary: Throw a proper EOFError in this case. Long term we want to change this to properly fit into the Thrift TException heirarchy with a good way to handle the original exception as well. For now, Ben is the primary user of this so we\u0027ll go ahead with his patch.\n\nReviewed By: mcslee\n\nTest Plan: Included in test/py/TestEof.py\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665365 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "79b1694043e07a673c343c42ad75d72f3b560539", "tree": "617cb13f6ab9b974ded27479c7579b732907bd08", "parents": [ "7962223ce299bbeb20348b3819a423a72efa2335" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon Nov 26 19:05:29 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Mon Nov 26 19:05:29 2007 +0000" }, "message": "Refactor TNonblockingServer to use event_base construct\n\nSummary: This allows the event loop to be shared across different components of a program of for a separate thread in a TNonblockingServer to safely use its own libevent code without conflicts.\n\nReviewed By: mcslee\n\nTest Plan: Updated test/ committed here\n\nOther Notes: submitted by Ben Maurer, patched in by mcslee with slight modifications\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665364 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "bd5882259de8bbe7e3f8283c8959d99acee9a501", "tree": "ee9b10ef8d2d21a5a5715fc7c20b298d3080d240", "parents": [ "12a28758a684321f29a3ceab17df9ae19570591d" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Nov 21 08:43:35 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Wed Nov 21 08:43:35 2007 +0000" }, "message": "Merging in some Smalltalk changes from Patrick Collison\n\nReviewed By: mcslee\n\nTest Plan: Rebuild Thrift compiler\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665361 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "efd37f14d25bb446e8ed0975803d228ef8e20dd8", "tree": "c6dbf68bfd439fa05c426ac92613a0c2ce2bd953", "parents": [ "a1d4cab45f1d061e6121a7ed6b826dc79beca02a" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 20 05:13:09 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 20 05:13:09 2007 +0000" }, "message": "Add Smalltalk support to Thrift\n\nSummary: Submitted by Patrick Collison\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665358 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "a1d4cab45f1d061e6121a7ed6b826dc79beca02a", "tree": "e86304799daf298fe65a8b020c911b5bddeb7ec1", "parents": [ "276eea68b78e61713ac747c41960fcd469edd0e4" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 20 04:58:16 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 20 04:58:16 2007 +0000" }, "message": "Make Java TBinaryProtocol default to strictWrite\n\nSummary: About time we did this. Breaks the test suite\u0027s defaults\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665357 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "276eea68b78e61713ac747c41960fcd469edd0e4", "tree": "5eee311ae3949ed0f2a1f7ed2d6060f8d4c0121c", "parents": [ "12a3b4e002b34ba115959b89f113e76a325e5389" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 20 02:06:47 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 20 02:06:47 2007 +0000" }, "message": "Add (int) case to Thrift version comparison\n\nSummary: Deals with 32 bit machines doing a weird sign-bit thing here.\n\nReviewed By: dreiss\n\nTest Plan: For 32 bit AmieStreet partners\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665356 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "8440605c277339770483a7daf31da7858bff2b38", "tree": "9b518e9af2f19e324b8ef31c15812f93961b94d9", "parents": [ "fb4b514028ed073302ffa8d3dcbfba3a89b427f0" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 20 01:39:25 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 20 01:39:25 2007 +0000" }, "message": "Cocoa Thrift binding patches from Andrew McGeachie\n\nSummary: Latest updates to the Cocoa bindings\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665354 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "fb4b514028ed073302ffa8d3dcbfba3a89b427f0", "tree": "2ef7120fc936e0dfd3f78bbdd1ef089e34bc8b62", "parents": [ "b6014f494f41ecee4f8e1c7264e99a883805e99f" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 20 01:27:08 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 20 01:27:08 2007 +0000" }, "message": "IPv6 support for the TNonBlockingServer\n\nSummary: Need to use IPv6 compliant constructs here. Submitted by Paul Saab.\n\nReviewed By: dreiss\n\nTest Plan: Rebuild Thrift TNonblockingServer with this patch and verify behaves just the same\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665353 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "b6014f494f41ecee4f8e1c7264e99a883805e99f", "tree": "41217d03d2233ac9784ed3e69095ba3a34de94eb", "parents": [ "7fcc9e87ba180909c7309ecb713321f6aabfe9f4" ], "author": { "name": "hzhao", "email": "dev-null@apache.org", "time": "Sun Nov 18 20:54:30 2007 +0000" }, "committer": { "name": "hzhao", "email": "dev-null@apache.org", "time": "Sun Nov 18 20:54:30 2007 +0000" }, "message": "added trunk\n\nReviewed By: shire\nTest Plan: ape work\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665352 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "7fcc9e87ba180909c7309ecb713321f6aabfe9f4", "tree": "b43eed62d6207d3dc51f32fa542f22a1831f3f99", "parents": [ "de11d852113dcb2284c54ab47333e6f602320fc9" ], "author": { "name": "hzhao", "email": "dev-null@apache.org", "time": "Sun Nov 18 20:48:56 2007 +0000" }, "committer": { "name": "hzhao", "email": "dev-null@apache.org", "time": "Sun Nov 18 20:48:56 2007 +0000" }, "message": "tagging thrift-protocol-1.0.0\n\nReviewed By: shire\nTest Plan: ape work\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665351 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "de11d852113dcb2284c54ab47333e6f602320fc9", "tree": "f78771d95182132100083724aecee9c52ddc7611", "parents": [ "09f69e052452e973949bc143d0f34c28c51ff15e" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Sun Nov 18 02:10:20 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Sun Nov 18 02:10:20 2007 +0000" }, "message": "[thrift] gut Erlang exception handling\n\nSummary: * move type field to tException from subclasses\n * add backtrace to tException\n * add oop:is_a\n * on exit, wrap exceptions in {thrift_exception, E} ... otherwise can\u0027t distinguish e.g. exit:{{tBinProtException, {tException, ...}}, Stack} vs. exit:{tBinProtException, {tException, ...} -- I hate erlang\n * all throws/exits to tException:throw which does the wrapping described above\n\nReviewed By: eletuchy\n\nTest Plan: been using this code on my live server ^_^\n\nRevert: OK\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665350 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "09f69e052452e973949bc143d0f34c28c51ff15e", "tree": "f738e85f88a874e5ec26620a67ae0b7245437026", "parents": [ "f5a6b0c10939a2c0dd33fa88b8ce4e3f44a33186" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Sat Nov 17 00:32:36 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Sat Nov 17 00:32:36 2007 +0000" }, "message": "Add __autoload() support to Thrift-generated PHP code\n\nSummary: Include thrift/autoload.php and use -phpa flag to generated code that works with autoload. Good for services with lots of methods that are typically not all invoked.\n\nReviewed By: dreiss\n\nTest Plan: Falcon, baby, falcon.\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665349 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "f5a6b0c10939a2c0dd33fa88b8ce4e3f44a33186", "tree": "5e03c1bbc1f114964de0b95b4ff02b51433a202a", "parents": [ "611434992a349fb69507a625929f98f61656feef" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Sat Nov 17 00:27:17 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Sat Nov 17 00:27:17 2007 +0000" }, "message": "Fix PHP TBufferedTransport readAll() to work with TSocket timeouts\n\nReviewed By: lucas\n\nTest Plan: Invoke Buffered Transport wrapped around socket\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665348 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "611434992a349fb69507a625929f98f61656feef", "tree": "fd4c0d04aec28492eb62113c66c64e4e5477ff64", "parents": [ "eab6ac8b18db9bb6c83b44845aabea177777addf" ], "author": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Fri Nov 16 03:29:47 2007 +0000" }, "committer": { "name": "dweatherford", "email": "dev-null@apache.org", "time": "Fri Nov 16 03:29:47 2007 +0000" }, "message": "[thrift] Fix extension deserialization call with no classname\n\nSummary: The extension expects a classname as a string and does not allow null;\n use the empty string instead of null in the absence of a classname to pass.\n\nReviewed By: mcslee\nTest Plan: php -l\nRevert: svn\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665347 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "10522a7f2b9d413d97f49670e3102826833dcdcf", "tree": "d7ed96344f1690340f790963a7654e6c93385f09", "parents": [ "c2e37c7a617c7e7d55ab79a3f23542aeec42b1af" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 06:26:31 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 06:26:31 2007 +0000" }, "message": "[thrift] fix-ups to Erlang thrift_logger\n\nSummary:\n * no ?INFO for every oop:call ... way too expensive\n * unfactor symbol/1 ... it was that way for a reason apparently\n * upped crash report depth to 3\n\nReviewed By: eletuchy\n\nTest Plan: /much/ less CPU eaten by logging\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665343 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "c2e37c7a617c7e7d55ab79a3f23542aeec42b1af", "tree": "ed52215ea1f313e2b65e2b8097e5089ba66a6095", "parents": [ "90eab4d6e4279e9e61fa295e19a834f4c6ebe632" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 06:26:30 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 06:26:30 2007 +0000" }, "message": "[thrift] change up Erlang crash reports, cleanups in t{,Binary}Protocol\n\nSummary: crash reports aren\u0027t too important so don\u0027t be so verbose -- all the pertinent info shows up elsewhere anyway. refactor while we\u0027re at it.\n\nReviewed By: eletuchy\n\nTest Plan: ok\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665342 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "53b6ef670cd70c0f81d6ade52de27dde763b3686", "tree": "5b9262f1d83f4e2a0c8f08ddc2fd23ee01228702", "parents": [ "a1650fe55cfdba6c5cad1f09e3142b23b24b66c9" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 06:26:28 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 06:26:28 2007 +0000" }, "message": "[thrift] whole ball of whitespace normalizations in Erlang\n\nSummary: ill-formatted comments, trailing whitespace, and (gasp) tabs: all pwned. better now than later.\n\nReviewed By: eletuchy\n\nTest Plan: ok\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665339 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "a1650fe55cfdba6c5cad1f09e3142b23b24b66c9", "tree": "b59b40a330ee47074cc220bc5b6917627b7caf02", "parents": [ "3121c8271f07b56593df3e6a10ad549590059057" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 06:26:27 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 06:26:27 2007 +0000" }, "message": "[thrift] make open and close `effectful\u0027 in Erlang client\n\nSummary: make uniform across all tTransports. god i want `effectful\u0027 to go away dead. soon.\n\nReviewed By: eletuchy\n\nTest Plan: ok\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665338 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "3121c8271f07b56593df3e6a10ad549590059057", "tree": "78331f2a66dea0146f0421a08e7bc15842cdcfda", "parents": [ "0d5cd8a6b92053df8e8b1f5df9e2e3e55c3a9cd1" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 06:26:26 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 06:26:26 2007 +0000" }, "message": "[thrift] Erlang client receive socket options\n\nSummary: we want {active, false}, etc. for client sockets. make it so.\n\nReviewed By: eletuchy\n\nTest Plan: ok\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665337 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "0d5cd8a6b92053df8e8b1f5df9e2e3e55c3a9cd1", "tree": "5fe3fd13c8aa3385b2dd1287b968cf608f6b7eab", "parents": [ "6c74062262aaad614719227a279dfb7789e56471" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 02:20:59 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 02:20:59 2007 +0000" }, "message": "[thrift] Erlang makefile includes to terse messages\n\nSummary: filter out compiler path and flags and cruft\n\nReviewed By: eletuchy\n\nTest Plan: ok\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665336 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "6c74062262aaad614719227a279dfb7789e56471", "tree": "e85b73f571234af6d281b8fa61a76913655dc3b6", "parents": [ "89d52079834a20411d2b842d2e71a4e3390911a9" ], "author": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 02:20:58 2007 +0000" }, "committer": { "name": "Christopher Piro", "email": "cpiro@apache.org", "time": "Thu Nov 15 02:20:58 2007 +0000" }, "message": "[thrift] convert oop.erl errors and infos to macros\n\nSummary: old-style error messages get switched over\n\nReviewed By: eletuchy\n\nTest Plan: ok\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665335 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "465ccc09240b16f5790dfc5c5e7579c42ec54770", "tree": "c201156258c1c459a4bc3e1b0745f1b4e5de5fbd", "parents": [ "380298f458dcdedb1e59227c90cee4af890bef08" ], "author": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Nov 13 21:41:29 2007 +0000" }, "committer": { "name": "David Reiss", "email": "dreiss@apache.org", "time": "Tue Nov 13 21:41:29 2007 +0000" }, "message": "Thrift: Fix new-style generated PHP code.\n\nSummary:\nFix reading of lists/sets of lists/sets/maps.\n\nReviewed By: mcslee\n\nTest Plan: Tested in trunk.\n\nRevert Plan: ok\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665333 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "0cdc6c8cd94cad4407e38db5975715fb67c71fb7", "tree": "78d41ce3baa549e11852e56a42fdfbc85a4ba065", "parents": [ "c557df42ed89913dd35536fcb30621d64c4ab0e6" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 13 10:19:08 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 13 10:19:08 2007 +0000" }, "message": "Merging PHP transport changes from www trunk to thrift trunk\n\nSummary: Some empty() fixes, plus a few other socket helpers\n\nReviewed By: lucas\n\nTest Plan: Use the transports to make IPC calls!\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665331 13f79535-47bb-0310-9956-ffa450edef68\n" }, { "commit": "2b786221edc8a0bfd640e5755459f3973120dd7a", "tree": "7d8714f33c59f61498e1a3949eec5d8b3dd093fa", "parents": [ "5b743079da3b0f817545d7e0574222a5c16fc2a9" ], "author": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 13 05:35:34 2007 +0000" }, "committer": { "name": "Mark Slee", "email": "mcslee@apache.org", "time": "Tue Nov 13 05:35:34 2007 +0000" }, "message": "Fixing typo in Thrift trunk\n\nSummary: xter \u003d\u003e xfer\n\nReviewed By: sgrimm\n\n\ngit-svn-id: https://svn.apache.org/repos/asf/incubator/thrift/trunk@665329 13f79535-47bb-0310-9956-ffa450edef68\n" } ], "next": "5b743079da3b0f817545d7e0574222a5c16fc2a9" }