commit feea9477e75ed2f9d2654bda200c1cf79c1f7a31
author alisdair sullivan <alisdairsullivan@yahoo.ca> Mon Jul 21 02:24:40 2014 -0700
committer Roger Meier <roger@apache.org> Tue Jul 22 22:04:42 2014 +0200
tree 9ea79b988278aeffd02200f5d8f29dcd522d5d6e
parent 1d7e35a7cb588a1e1f679a7306ff4bb57305ee11

THRIFT-2633 remove 'this is a dummy struct' structs from generated erlang

client: erlang
patch: talentdeficit (alisdair sullivan)

removes dummy struct info clauses from generated code and replaces
them with error that matches other undefined structs. adds error
for non-existent functions to function_info/2

compiler/cpp/src/generate/t_erl_generator.cc

diff --git a/compiler/cpp/src/generate/t_erl_generator.cc b/compiler/cpp/src/generate/t_erl_generator.cc
index 67242ea..8eb1b1c 100644
--- a/compiler/cpp/src/generate/t_erl_generator.cc
+++ b/compiler/cpp/src/generate/t_erl_generator.cc
@@ -301,10 +301,10 @@
   f_types_file_ << "-export([" << export_types_lines_.str() << "])." << endl << endl;
 
   f_types_file_ << f_info_.str();
-  f_types_file_ << "struct_info('i am a dummy struct') -> undefined." << endl << endl;
+  f_types_file_ << "struct_info(_) -> erlang:error(function_clause)." << endl << endl;
 
   f_types_file_ << f_info_ext_.str();
-  f_types_file_ << "struct_info_ext('i am a dummy struct') -> undefined." << endl << endl;
+  f_types_file_ << "struct_info_ext(_) -> erlang:error(function_clause)." << endl << endl;
 
   hrl_footer(f_types_hrl_file_, string("BOGUS"));
 
@@ -716,7 +716,7 @@
   for (f_iter = functions.begin(); f_iter != functions.end(); ++f_iter) {
     generate_erl_function_helpers(*f_iter);
   }
-  f_service_    << "struct_info('i am a dummy struct') -> undefined." << endl;
+  f_service_    << "struct_info(_) -> erlang:error(function_clause)." << endl;
 }
 
 /**
@@ -755,8 +755,9 @@
                          << "_thrift:function_info(Function, InfoType)." << endl;
       indent_down();
   } else {
-      // Use a special return code for nonexistent functions
-      indent(f_service_) << "function_info(_Func, _Info) -> no_function." << endl;
+      // return function_clause error for non-existent functions
+      indent(f_service_) << "function_info(_Func, _Info) -> erlang:error(function_clause)."
+                         << endl;
   }
 
   indent(f_service_) << endl;

lib/erl/src/thrift_client.erl

diff --git a/lib/erl/src/thrift_client.erl b/lib/erl/src/thrift_client.erl
index c91c3ea..ff5c3dc 100644
--- a/lib/erl/src/thrift_client.erl
+++ b/lib/erl/src/thrift_client.erl
@@ -67,7 +67,9 @@
                                      seqid    = SeqId},
                    Function,
                    Args) ->
-    Params = Service:function_info(Function, params_type),
+    Params = try Service:function_info(Function, params_type)
+    catch error:function_clause -> no_function
+    end,
     case Params of
         no_function ->
             {Client, {error, {no_function, Function}}};