tree 04a582b268b2ac6d01d128850a42e398dabaff74
parent 80415f05d621c861aeaa791fa93a1c3bee8b84bc
author Yuxuan 'fishy' Wang <yuxuan.wang@reddit.com> 1619578618 -0700
committer Yuxuan 'fishy' Wang <fishywang@gmail.com> 1619660998 -0700

THRIFT-5404: Allow other types of TTransportException to be timeouts

Client: go

Currently we only treat TTransportException with typeId == TIMED_OUT as
timeout (return true in Timeout function). When opening a new socket, if
we got a connect timeout from net.Dial, we wrap the error as
TTransportException with typeId == NOT_OPEN, thus it's no longer treated
as a timeout error.

Change the error to be directly wrapping the original error (instead of
recreate a new error with the same error message), and change
tTransportException.Timeout to also return true if the wrapped error
is a timeout error. This way we don't have to break anything (if code
rely on TTransportException.TypeId being NOT_OPEN in this case, that's
still true).

While I'm here, also update CHANGES.md from #2359.