THRIFT-3950: Memory leak while calling oneway methods (#1568)
* THRIFT-3950: Memory leak while calling oneway methods
* THRIFT-3950: Update NodeJS Oneway tests
diff --git a/lib/nodejs/test/test_driver.js b/lib/nodejs/test/test_driver.js
index 03ec513..4612a32 100644
--- a/lib/nodejs/test/test_driver.js
+++ b/lib/nodejs/test/test_driver.js
@@ -125,7 +125,8 @@
});
client.testOneway(0, function(err, response) {
- assert.fail('testOneway should not answer');
+ assert.error(err, 'testOneway: no callback error');
+ assert.strictEqual(response, undefined, 'testOneway: void response');
});
checkOffByOne(function(done) {
@@ -223,7 +224,11 @@
})
.fail(fail('testException'));
- client.testOneway(0, fail('testOneway: should not answer'));
+ client.testOneway(0)
+ .then(function(response) {
+ assert.strictEqual(response, undefined, 'testOneway: void response')
+ })
+ .fail(fail('testOneway: should not reject'));
checkOffByOne(function(done) {
client.testI32(-1)