tree 38d928d572d45117e00779c59d199da9e728e3ad
parent b53fa8e14b352431036a1902d6cebbc06de97244
author Lukas Barth <mail@tinloaf.de> 1675845183 +0100
committer Jens Geyer <Jens-G@users.noreply.github.com> 1709919071 +0100

Move default constructor and operator== implementation to CPP file

Both the default constructor and operator== implementations reference
certain member functions of the class' members. As an example, the default
constructor references (i.e., "uses") the default constructors of its
members.

If a class contains a std::vector<Foo>, and Foo has only been *forward*-
declared (which happens often in Thrift-generated code), this creates
undefined behavior: The std::vector specification states that as long as
Foo is an incomplete type, it is fine to reference std::vector<Foo>, but
not any members (such as its default constructor).

Thus, we must defer our default constructor's implementation (which references
the default constructor of std::vector<Foo>) to a point where Foo is a
complete type. That is the case in the .cpp file.

The same holds for operator==.