THRIFT-5016 Do Not Check 'other' For Null in Equals
Client: Java
Patch: David Mollitor
This closes #1937
diff --git a/compiler/cpp/src/thrift/generate/t_java_generator.cc b/compiler/cpp/src/thrift/generate/t_java_generator.cc
index 1805585..24637d3 100644
--- a/compiler/cpp/src/thrift/generate/t_java_generator.cc
+++ b/compiler/cpp/src/thrift/generate/t_java_generator.cc
@@ -1912,8 +1912,7 @@
out << indent() << "@Override" << endl << indent() << "public boolean equals(java.lang.Object that) {"
<< endl;
indent_up();
- out << indent() << "if (that == null)" << endl << indent() << " return false;" << endl
- << indent() << "if (that instanceof " << tstruct->get_name() << ")" << endl << indent()
+ out << indent() << "if (that instanceof " << tstruct->get_name() << ")" << endl << indent()
<< " return this.equals((" << tstruct->get_name() << ")that);" << endl << indent()
<< "return false;" << endl;
scope_down(out);