commit e73b238faa0baa7ab7f6600bc1529a550586c6b9
author Hasnain Lakhani <m.hasnain.lakhani@gmail.com> Sat May 17 21:18:33 2025 -0700
committer Jens Geyer <Jens-G@users.noreply.github.com> Mon May 19 22:18:49 2025 +0200
tree 4bcc819cffe8449b0369314f3e8e64313ada9f24
parent 94e1a308973d617b19c07acbda3d8844132a04f7

[nit] Use more consistent free method in c_glib generated code for binary types

compiler/cpp/src/thrift/generate/t_c_glib_generator.cc

diff --git a/compiler/cpp/src/thrift/generate/t_c_glib_generator.cc b/compiler/cpp/src/thrift/generate/t_c_glib_generator.cc
index b5eb603..06dce57 100644
--- a/compiler/cpp/src/thrift/generate/t_c_glib_generator.cc
+++ b/compiler/cpp/src/thrift/generate/t_c_glib_generator.cc
@@ -4023,7 +4023,12 @@
     if (tbase == t_base_type::TYPE_STRING) {
       indent(out) << "if (" << name << " != NULL)" << '\n' << indent() << "{" << '\n';
       indent_up();
-      indent(out) << "g_free(" << name << ");" << '\n' << indent() << name << " = NULL;" << '\n';
+      if (type->is_binary()) {
+        indent(out) << "g_byte_array_free(" << name << ", TRUE);" << '\n';
+      } else {
+        indent(out) << "g_free(" << name << ");" << '\n';
+      }
+      indent(out) << name << " = NULL;" << '\n';
       indent_down();
       indent(out) << "}" << '\n' << '\n';
     }