tree 8ebdc3505706490f048a923795a98727ef0f5dc1
parent 37aac3bb58b9a7413b25e5eba4fb95fc8796cd3c
author Håkon Hitland <hakon.hitland@zedge.net> 1480959761 +0100
committer James E. King, III <jking@apache.org> 1487868225 -0500

THRIFT-3984 PHP7 extension causes segfault

The PHP 7 extension can sometimes free strings it does not own,
when serializing string map keys, or the name of called methods.
The latter case was somewhat migitated since the double-free has no
effect on interned strings.
Using ZVAL_STR_COPY instead of ZVAL_STR will increment the reference
count, making the following destructor call correct.

Fix memory leak in PHP 7

Fix memory leak when deserializing maps or sets.
zend_hash_update will add its own reference to the key, so we need to
destruct the key zval to not leak.
We don't need to destruct the value, the hash table will take ownership
of it.

This closes #1152