commit e1b8540a0af2cd66d3edf5c80b0198009143ba12
author Nobuaki Sukegawa <nsuke@apache.org> Mon Jul 18 21:27:27 2016 +0900
committer Nobuaki Sukegawa <nsuke@apache.org> Sat Jul 23 16:52:53 2016 +0900
tree 6268ec3a40c8af26dcff551f8cfdac8420c22c04
parent c09cb6fc5cf60868563563b5a28930f42e581b8a

THRIFT-3884 Fix Erlang compact protocol double endianess and boolean list

This close #1051

lib/erl/src/thrift_compact_protocol.erl

diff --git a/lib/erl/src/thrift_compact_protocol.erl b/lib/erl/src/thrift_compact_protocol.erl
index 5942f0a..0f14221 100644
--- a/lib/erl/src/thrift_compact_protocol.erl
+++ b/lib/erl/src/thrift_compact_protocol.erl
@@ -55,11 +55,12 @@
 -define(TYPE_SHIFT_AMOUNT, 5).
 
 typeid_to_compact(?tType_STOP) -> 16#0;
-typeid_to_compact(?tType_DOUBLE) -> 16#7;
+typeid_to_compact(?tType_BOOL) -> 16#2;
 typeid_to_compact(?tType_I8) -> 16#3;
 typeid_to_compact(?tType_I16) -> 16#4;
 typeid_to_compact(?tType_I32) -> 16#5;
 typeid_to_compact(?tType_I64) -> 16#6;
+typeid_to_compact(?tType_DOUBLE) -> 16#7;
 typeid_to_compact(?tType_STRING) -> 16#8;
 typeid_to_compact(?tType_STRUCT) -> 16#C;
 typeid_to_compact(?tType_MAP) -> 16#B;
@@ -113,7 +114,7 @@
   end.
 
 -spec to_zigzag(integer()) -> non_neg_integer().
-to_zigzag(Value) -> (Value bsl 1) bxor (Value bsr 63).
+to_zigzag(Value) -> 16#FFFFFFFFFFFFFFFF band ((Value bsl 1) bxor (Value bsr 63)).
 
 -spec from_zigzag(non_neg_integer()) -> integer().
 from_zigzag(Value) -> (Value bsr 1) bxor -(Value band 1).
@@ -218,7 +219,7 @@
 write(This, {i64, Value}) when is_integer(Value) -> write(This, to_varint(to_zigzag(Value), []));
 
 write(This, {double, Double}) ->
-  write(This, <<Double:64/big-signed-float>>);
+  write(This, <<Double:64/float-signed-little>>);
 
 write(This0, {string, Str}) when is_list(Str) ->
   % TODO: limit length
@@ -355,7 +356,7 @@
 read(This0, double) ->
   {This1, Bytes} = read_data(This0, 8),
   case Bytes of
-    {ok, <<Val:64/float-signed-big, _/binary>>} -> {This1, {ok, Val}};
+    {ok, <<Val:64/float-signed-little, _/binary>>} -> {This1, {ok, Val}};
     Else -> {This1, Else}
   end;