commit d9d51208549d0fe630791847b2904410c418d829
author Roger Meier <roger@apache.org> Sun Oct 11 09:13:37 2015 +0200
committer Roger Meier <roger@apache.org> Sun Oct 11 09:13:37 2015 +0200
tree ce6515cce92fcb09a2fe664e118269de478c904c
parent a175437f66fa1a0b36233e7dd40b061d471276ff

THRIFT-3237 Fix TNamedPipeServer::createNamedPipe memory leak

Client: cpp
Patch: Paweł Janicki & James E. King, III
This closes #632

lib/cpp/src/thrift/transport/TPipeServer.cpp

diff --git a/lib/cpp/src/thrift/transport/TPipeServer.cpp b/lib/cpp/src/thrift/transport/TPipeServer.cpp
index baa2603..7923102 100644
--- a/lib/cpp/src/thrift/transport/TPipeServer.cpp
+++ b/lib/cpp/src/thrift/transport/TPipeServer.cpp
@@ -351,12 +351,17 @@
                                      0,                    // client time-out
                                      &sa));                // security attributes
 
+  DWORD lastError = GetLastError();
+  LocalFree(sd);
+  LocalFree(acl);
+  FreeSid(everyone_sid);
+
   if (hPipe.h == INVALID_HANDLE_VALUE) {
     Pipe_.reset();
-    GlobalOutput.perror("TPipeServer::TCreateNamedPipe() GLE=", GetLastError());
+    GlobalOutput.perror("TPipeServer::TCreateNamedPipe() GLE=", lastError);
     throw TTransportException(TTransportException::NOT_OPEN,
                               "TCreateNamedPipe() failed",
-                              GetLastError());
+							  lastError);
     return false;
   }