THRIFT-1351 Compiler does not care about binary strings
Patch: Wade Simmons & Jens Geyer
diff --git a/compiler/cpp/src/generate/t_js_generator.cc b/compiler/cpp/src/generate/t_js_generator.cc
index e27f5de..9f7fa04 100644
--- a/compiler/cpp/src/generate/t_js_generator.cc
+++ b/compiler/cpp/src/generate/t_js_generator.cc
@@ -1259,7 +1259,7 @@
name;
break;
case t_base_type::TYPE_STRING:
- out << "readString()";
+ out << (((t_base_type*)type)->is_binary() ? "readBinary()" : "readString()");
break;
case t_base_type::TYPE_BOOL:
out << "readBool()";
@@ -1498,7 +1498,7 @@
"compiler error: cannot serialize void field in a struct: " + name;
break;
case t_base_type::TYPE_STRING:
- out << "writeString(" << name << ")";
+ out << (((t_base_type*)type)->is_binary() ? "writeBinary(" : "writeString(") << name << ")";
break;
case t_base_type::TYPE_BOOL:
out << "writeBool(" << name << ")";