tree 39e689e4941568f5b05892fcfbba02c0573eddeb
parent e382275bad2bd11fb5df33dd7db520fd7596f4ac
author Yuxuan 'fishy' Wang <yuxuan.wang@reddit.com> 1591733258 -0700
committer GitHub <noreply@github.com> 1591733258 +0100
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJe3+wKCRBK7hj4Ov3rIwAAdHIIAG4gVX5beiw9yaLynN+5w4Q2
 2BPgZATqmOKAQcvd4tTcQEE39zyfjJidqqU2MJT1hGxQx6KPVNeDuz355q1eD7ZI
 /61ADumSNHzJa7HCn3cNstRZcS6fTsb9m1OkgcIOWPz5M0bO1lebgEfW0ziIaIY/
 sK9UBAHAOu+QnGJBuHbqtpweR6lACQ1CWL7HpD0+VnQ9RpJ1pEWjHsAJAfkUn5yn
 V5q5RWvB8KGY5cA4P/jx+I3yl2+YzL20H744t0kfi2ymVf05tjYHuIZ9VB8sGGk2
 KdY9gn2Diwty962NnNpzTuGFeIDkxl1yOt5dZfV+j9zcS62tjUsg7bNM+8llhcA=
 =KhGC
 -----END PGP SIGNATURE-----
 

THRIFT-5214: Reset read deadline in socketConn

Client: go

This is a slightly different, and less error-prone approach from the
fix in e382275b.

The previous approach relies on passing the set socket timeout into the
underlying socketConn from TSocket and TSSLSocket. But since we have so
many different constructors for TSocket and TSSLSocket, some makes the
initial connection in the constructor and some does not, there are so
many different places we would need to remember to pass socketTimeout
into socketConn. In the future, when we add another constructor to them,
we could either forget to pass the socket timeout into socketConn, or
try to pass it while we haven't constructed socketConn yet (which will
cause panic), both are bad.

In this approach we just clear the read deadline in the connectivity
check read. Because that's a non-blocking read, it would work just fine
without a read deadline.