THRIFT-2458 Generated golang server code for "oneway" methods is incorrect
Client: Go compiler
Patch: Jens Geyer & Aleksey Pesternikov
diff --git a/lib/go/test/Makefile.am b/lib/go/test/Makefile.am
index cb6073c..046448c 100644
--- a/lib/go/test/Makefile.am
+++ b/lib/go/test/Makefile.am
@@ -21,11 +21,12 @@
THRIFTTEST = $(top_srcdir)/test/ThriftTest.thrift
# Thrift for GO has problems with complex map keys: THRIFT-2063
-gopath: $(top_srcdir)/compiler/cpp/thrift $(THRIFTTEST) IncludesTest.thrift NamespacedTest.thrift
+gopath: $(top_srcdir)/compiler/cpp/thrift $(THRIFTTEST) IncludesTest.thrift NamespacedTest.thrift OnewayTest.thrift
mkdir -p gopath/src
grep -v list.*map.*list.*map $(THRIFTTEST) > ThriftTest.thrift
$(THRIFT) -r IncludesTest.thrift
$(THRIFT) BinaryKeyTest.thrift
+ $(THRIFT) OnewayTest.thrift
ln -nfs ../../../thrift gopath/src/thrift
ln -nfs ../../tests gopath/src/tests
touch gopath
diff --git a/lib/go/test/OnewayTest.thrift b/lib/go/test/OnewayTest.thrift
new file mode 100644
index 0000000..9ba7525
--- /dev/null
+++ b/lib/go/test/OnewayTest.thrift
@@ -0,0 +1,5 @@
+service OneWay {
+ oneway void hi(1: i64 i, 2: string s)
+ void emptyfunc()
+ i64 echo_int(1: i64 param)
+}
diff --git a/lib/go/test/tests/one_way_test.go b/lib/go/test/tests/one_way_test.go
new file mode 100644
index 0000000..5ffbbfe
--- /dev/null
+++ b/lib/go/test/tests/one_way_test.go
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package tests
+
+import (
+ "OnewayTest"
+ "fmt"
+ "net"
+ "testing"
+ "thrift"
+ "time"
+)
+
+func findPort() net.Addr {
+ if l, err := net.Listen("tcp", "127.0.0.1:0"); err != nil {
+ panic("Could not find available server port")
+ } else {
+ defer l.Close()
+ return l.Addr()
+ }
+}
+
+type impl struct{}
+
+func (i *impl) Hi(in int64, s string) (err error) { fmt.Println("Hi!"); return }
+func (i *impl) Emptyfunc() (err error) { return }
+func (i *impl) EchoInt(param int64) (r int64, err error) { return param, nil }
+
+const TIMEOUT = time.Second
+
+var addr net.Addr
+var server *thrift.TSimpleServer
+var client *OnewayTest.OneWayClient
+
+func TestInitOneway(t *testing.T) {
+ var err error
+ addr = findPort()
+ serverTransport, err := thrift.NewTServerSocketTimeout(addr.String(), TIMEOUT)
+ if err != nil {
+ t.Fatal("Unable to create server socket", err)
+ }
+ processor := OnewayTest.NewOneWayProcessor(&impl{})
+ server = thrift.NewTSimpleServer2(processor, serverTransport)
+
+ go server.Serve()
+}
+
+func TestInitOnewayClient(t *testing.T) {
+ transport := thrift.NewTSocketFromAddrTimeout(addr, TIMEOUT)
+ protocol := thrift.NewTBinaryProtocolTransport(transport)
+ client = OnewayTest.NewOneWayClientProtocol(transport, protocol, protocol)
+ err := transport.Open()
+ if err != nil {
+ t.Fatal("Unable to open client socket", err)
+ }
+}
+
+func TestCallOnewayServer(t *testing.T) {
+ //call oneway function
+ err := client.Hi(1, "")
+ if err != nil {
+ t.Fatal("Unexpected error: ", err)
+ }
+ //There is no way to detect protocol problems with single oneway call so we call it second time
+ i, err := client.EchoInt(42)
+ if err != nil {
+ t.Fatal("Unexpected error: ", err)
+ }
+ if i != 42 {
+ t.Fatal("Unexpected returned value: ", i)
+ }
+}