THRIFT-2751: repair node oneway bug and symlink issue
Client: Node Lib
Patch: Randy Abernethy
This patch keep npm from creating sym links on npm install.
Sym links fail when writting to some shared volumes.
Also fixes multiplex oneway bug in nodejs
diff --git a/lib/nodejs/Makefile.am b/lib/nodejs/Makefile.am
index bd381bf..3868905 100755
--- a/lib/nodejs/Makefile.am
+++ b/lib/nodejs/Makefile.am
@@ -22,7 +22,7 @@
# $(THRIFT) --gen js:node -o test/ $(top_srcdir)/test/ThriftTest.thrift
deps: package.json
- $(NPM) install
+ $(NPM) install --no-bin-links
check: deps
$(NPM) test
diff --git a/lib/nodejs/lib/thrift/multiplexed_processor.js b/lib/nodejs/lib/thrift/multiplexed_processor.js
index 1aef4c3..fbceb79 100644
--- a/lib/nodejs/lib/thrift/multiplexed_processor.js
+++ b/lib/nodejs/lib/thrift/multiplexed_processor.js
@@ -27,10 +27,8 @@
};
MultiplexedProcessor.prototype.process = function(inp, out) {
-
var begin = inp.readMessageBegin();
-
- if (begin.mtype != Thrift.MessageType.CALL || begin.mtype == Thrift.MessageType.ONEWAY) {
+ if (begin.mtype != Thrift.MessageType.CALL && begin.mtype != Thrift.MessageType.ONEWAY) {
throw new Thrift.TException("TMultiplexedProcessor: Unexpected message type");
}
@@ -57,5 +55,4 @@
};
this.services[sname].process(inpProxy, out);
-
};