commit bccca9301dedd6403062ef6be4c56533f889e5b5
author Prasenjit Sarkar <prasenjit.sarkar@datos.io> Thu Jul 06 21:26:32 2023 -0700
committer Jens Geyer <jensg@apache.org> Sat Jul 08 10:18:33 2023 +0200
tree 99d82953eb5a7146d574cfec24046e113999200d
parent ff9850eda6b9e00cffe4e07bc7f56c50851cd06e

THRIFT-5725: Fix the comparison check for bio_get_fd
Client: cpp
Patch: Prasenjit Sarkar

This closes #2831

lib/cpp/src/thrift/transport/TSSLSocket.cpp

diff --git a/lib/cpp/src/thrift/transport/TSSLSocket.cpp b/lib/cpp/src/thrift/transport/TSSLSocket.cpp
index eb96a73..26ae2be 100644
--- a/lib/cpp/src/thrift/transport/TSSLSocket.cpp
+++ b/lib/cpp/src/thrift/transport/TSSLSocket.cpp
@@ -825,7 +825,7 @@
     throw TSSLException("SSL_get_?bio returned nullptr");
   }
 
-  if (BIO_get_fd(bio, &fdSocket) <= 0) {
+  if (BIO_get_fd(bio, &fdSocket) < 0) {
     throw TSSLException("BIO_get_fd failed");
   }