commit bb8cac570441e543265fd2402a162a5a889a216f
author Kurt Alfred Kluever <kak@google.com> Sat Dec 28 21:56:46 2024 -0500
committer Jens Geyer <Jens-G@users.noreply.github.com> Mon Jan 06 22:37:25 2025 +0100
tree 741661852777499d0d07bad54329ed909ce397a8
parent 0825ca31e664817168c83e46e494718640227066

Update generated array style

C-style array declarations (e.g. `Foo foos[]`) is discouraged by the JLS. Java style (e.g., `Foo[] foos`) should be preferred.

compiler/cpp/src/thrift/generate/t_java_generator.cc

diff --git a/compiler/cpp/src/thrift/generate/t_java_generator.cc b/compiler/cpp/src/thrift/generate/t_java_generator.cc
index e81744e..d944e26 100644
--- a/compiler/cpp/src/thrift/generate/t_java_generator.cc
+++ b/compiler/cpp/src/thrift/generate/t_java_generator.cc
@@ -1629,7 +1629,7 @@
     }
 
     if (optionals > 0) {
-      std::string output_string = "private static final _Fields optionals[] = {";
+      std::string output_string = "private static final _Fields[] optionals = {";
       for (m_iter = members.begin(); m_iter != members.end(); ++m_iter) {
         if ((*m_iter)->get_req() == t_field::T_OPTIONAL) {
           output_string = output_string + "_Fields." + constant_name((*m_iter)->get_name()) + ",";