commit b3f5ffc42d4c52e4a76ff429411164d27fb65b22
author Konrad Grochowski <hcorg@apache.org> Thu Nov 06 19:32:59 2014 +0100
committer Konrad Grochowski <hcorg@apache.org> Thu Nov 06 19:32:59 2014 +0100
tree c52d420b92e59bdd9e2b1cce94f5f808cc7283f7
parent cc092b37c8665384f2f7cb60d184a44f59ac3ba3

THRIFT-2801: cpp - compilation warnings removed from test suite

Client: C++
Patch: Konrad Grochowski

Unused parameters mostly

lib/cpp/test/processor/Handlers.h

diff --git a/lib/cpp/test/processor/Handlers.h b/lib/cpp/test/processor/Handlers.h
index 2be262a..75f4349 100644
--- a/lib/cpp/test/processor/Handlers.h
+++ b/lib/cpp/test/processor/Handlers.h
@@ -244,6 +244,9 @@
 #if 0
     ConnContext* context = reinterpret_cast<ConnContext*>(serverContext);
     log_->append(EventLog::ET_PROCESS, context->id, 0);
+#else
+    THRIFT_UNUSED_VARIABLE(serverContext);
+    THRIFT_UNUSED_VARIABLE(transport);
 #endif
   }
 
@@ -285,6 +288,7 @@
   }
 
   void postRead(void* ctx, const char* fnName, uint32_t bytes) {
+    THRIFT_UNUSED_VARIABLE(bytes);
     CallContext* context = reinterpret_cast<CallContext*>(ctx);
     checkName(context, fnName);
     log_->append(EventLog::ET_POST_READ, context->connContext->id, context->id,
@@ -299,6 +303,7 @@
   }
 
   void postWrite(void* ctx, const char* fnName, uint32_t bytes) {
+    THRIFT_UNUSED_VARIABLE(bytes);
     CallContext* context = reinterpret_cast<CallContext*>(ctx);
     checkName(context, fnName);
     log_->append(EventLog::ET_POST_WRITE, context->connContext->id,

lib/cpp/test/processor/ProcessorTest.cpp

diff --git a/lib/cpp/test/processor/ProcessorTest.cpp b/lib/cpp/test/processor/ProcessorTest.cpp
index 0283d20..8b806b4 100644
--- a/lib/cpp/test/processor/ProcessorTest.cpp
+++ b/lib/cpp/test/processor/ProcessorTest.cpp
@@ -932,10 +932,9 @@
 
 // TODO: We should test TEventServer in the future.
 // For now, it is known not to work correctly with TProcessorEventHandler.
-
 unit_test::test_suite* init_unit_test_suite(int argc, char* argv[]) {
-  unit_test::framework::master_test_suite().p_name.value =
-    "ProcessorTest";
-
+  THRIFT_UNUSED_VARIABLE(argc);
+  THRIFT_UNUSED_VARIABLE(argv);
+  unit_test::framework::master_test_suite().p_name.value = "ProcessorTest";
   return NULL;
 }

lib/cpp/test/processor/ServerThread.h

diff --git a/lib/cpp/test/processor/ServerThread.h b/lib/cpp/test/processor/ServerThread.h
index 0dd5127..f7fa0d5 100644
--- a/lib/cpp/test/processor/ServerThread.h
+++ b/lib/cpp/test/processor/ServerThread.h
@@ -61,7 +61,7 @@
    * Subclasses may override this method if they wish to record the final
    * port that was used for the server.
    */
-  virtual void bindSuccessful(uint16_t port) {
+  virtual void bindSuccessful(uint16_t /*port*/) {
   }
 };