commit b3a42dd050db2657a589b7b73e3d121211649fe5
author Josh Elser <josh.elser@gmail.com> Tue Dec 08 13:32:55 2015 -0500
committer Nobuaki Sukegawa <nsuke@apache.org> Fri Mar 18 22:37:02 2016 +0900
tree 9cf59eeba09eadee31c3dd1df430f9107fa5a559
parent a8765276d80fa86d258fa323cfd30bfcf22a0d67

THRIFT-3479 Avoid returning a message to a client on TException.

lib/java/src/org/apache/thrift/ProcessFunction.java

diff --git a/lib/java/src/org/apache/thrift/ProcessFunction.java b/lib/java/src/org/apache/thrift/ProcessFunction.java
index 19c8f14..992e859 100644
--- a/lib/java/src/org/apache/thrift/ProcessFunction.java
+++ b/lib/java/src/org/apache/thrift/ProcessFunction.java
@@ -39,12 +39,14 @@
       result = getResult(iface, args);
     } catch(TException tex) {
       LOGGER.error("Internal error processing " + getMethodName(), tex);
-      TApplicationException x = new TApplicationException(TApplicationException.INTERNAL_ERROR, 
-        "Internal error processing " + getMethodName());
-      oprot.writeMessageBegin(new TMessage(getMethodName(), TMessageType.EXCEPTION, seqid));
-      x.write(oprot);
-      oprot.writeMessageEnd();
-      oprot.getTransport().flush();
+      if (!isOneway()) {
+        TApplicationException x = new TApplicationException(TApplicationException.INTERNAL_ERROR, 
+          "Internal error processing " + getMethodName());
+        oprot.writeMessageBegin(new TMessage(getMethodName(), TMessageType.EXCEPTION, seqid));
+        x.write(oprot);
+        oprot.writeMessageEnd();
+        oprot.getTransport().flush();
+      }
       return;
     }