commit b012318fc8f1d3de4c64514d5d32cb424952d905
author Jens Geyer <jensg@apache.org> Wed Feb 12 12:16:19 2020 +0100
committer Jens Geyer <jensg@apache.org> Wed Feb 12 22:40:42 2020 +0100
tree d7400d3ced0335c6c58713fedeeae5c58309c66e
parent ded326101af3c6c9daad9814ce6404d385f36a1f

THRIFT-5088 Memory leak in TWinHttpTransport
Client: Delphi
Patch: Jens Geyer

lib/delphi/src/Thrift.Transport.WinHTTP.pas

diff --git a/lib/delphi/src/Thrift.Transport.WinHTTP.pas b/lib/delphi/src/Thrift.Transport.WinHTTP.pas
index 7a1b48f..5794b1c 100644
--- a/lib/delphi/src/Thrift.Transport.WinHTTP.pas
+++ b/lib/delphi/src/Thrift.Transport.WinHTTP.pas
@@ -309,7 +309,7 @@
   http  : IWinHTTPRequest;
   pData : PByte;
   len   : Integer;
-  error : Cardinal;
+  error, dwSize : Cardinal;
   sMsg  : string;
 begin
   http := CreateRequest;
@@ -334,7 +334,8 @@
   end;
 
   FInputStream := THTTPResponseStream.Create( http);
-  UpdateKnownMessageSize( http.QueryTotalResponseSize);
+  if http.QueryTotalResponseSize( dwSize)  // FALSE indicates "no info available"
+  then UpdateKnownMessageSize( dwSize);
 end;
 
 procedure TWinHTTPClientImpl.Write( const pBuf : Pointer; off, len : Integer);