THRIFT-3184 Thrift Go leaves file descriptors open
Client: Go
Patch: Prashant Varanasi <prashant@uber.com>
This closes #518
diff --git a/lib/go/thrift/http_client.go b/lib/go/thrift/http_client.go
index 2bce078..b7cb101 100644
--- a/lib/go/thrift/http_client.go
+++ b/lib/go/thrift/http_client.go
@@ -183,6 +183,8 @@
return NewTTransportExceptionFromError(err)
}
if response.StatusCode != http.StatusOK {
+ // Close the response to avoid leaking file descriptors.
+ response.Body.Close()
// TODO(pomack) log bad response
return NewTTransportException(UNKNOWN_TRANSPORT_EXCEPTION, "HTTP Response code: "+strconv.Itoa(response.StatusCode))
}