THRIFT-1957 NodeJS TFramedTransport and TBufferedTransport read bytes as unsigned
Patch: Matthew Imrie
Add method to binary.js to properly read a byte type as
signed Changed transport.js readByte methods in
TFramedBuffer and TBufferedTransport to use binary.js
readByte method Added unit test for binary.js readByte
method to binary.test.js and changed test harness to
nodeunit.
diff --git a/test/nodejs/Makefile.am b/test/nodejs/Makefile.am
index 32397f1..8f74ba8 100755
--- a/test/nodejs/Makefile.am
+++ b/test/nodejs/Makefile.am
@@ -22,6 +22,14 @@
$(THRIFT) --gen js:node ../ThriftTest.thrift
check: stubs
+ @if which expresso &> /dev/null ; then \
+ echo " Testing thrift/binary"; \
+ NODE_PATH=../../lib/nodejs/lib:../../lib/nodejs/lib/thrift:$(NODE_PATH) nodeunit ../../lib/nodejs/test/binary.test.js; \
+ fi
+ timeout 2 $(MAKE) server &
+ @sleep 1
+ $(MAKE) client
+ @sleep 1
clean-local:
$(RM) -r gen-nodejs