commit 93c15c202247892fd7378ef19a346ff13e201263
author Hasnain Lakhani <m.hasnain.lakhani@gmail.com> Sun Feb 02 16:58:28 2025 -0800
committer Jens Geyer <Jens-G@users.noreply.github.com> Mon Feb 03 22:22:04 2025 +0100
tree 19f0c7c1303b28fb9191959fad5b157b2617f7cd
parent a45618e05bbb2d29737514541b6d61f6850d9b16

Various build fixes for clang and rust

compiler/cpp/src/thrift/generate/t_go_generator.h

diff --git a/compiler/cpp/src/thrift/generate/t_go_generator.h b/compiler/cpp/src/thrift/generate/t_go_generator.h
index d84b186..72825bc 100644
--- a/compiler/cpp/src/thrift/generate/t_go_generator.h
+++ b/compiler/cpp/src/thrift/generate/t_go_generator.h
@@ -288,7 +288,7 @@
 
   static bool is_pointer_field(t_field* tfield, bool in_container = false);
 
-  std::string indent_str() const {
+  std::string indent_str() const override {
     return "\t";
   }
 

compiler/cpp/src/thrift/parse/t_function.h

diff --git a/compiler/cpp/src/thrift/parse/t_function.h b/compiler/cpp/src/thrift/parse/t_function.h
index d2cb19b..abe2903 100644
--- a/compiler/cpp/src/thrift/parse/t_function.h
+++ b/compiler/cpp/src/thrift/parse/t_function.h
@@ -83,7 +83,7 @@
 
   std::map<std::string, std::vector<std::string>> annotations_;
 
-  void validate() const {
+  void validate() const override {
     get_returntype()->validate();
 
 #ifndef ALLOW_EXCEPTIONS_AS_TYPE

compiler/cpp/src/thrift/parse/t_list.h

diff --git a/compiler/cpp/src/thrift/parse/t_list.h b/compiler/cpp/src/thrift/parse/t_list.h
index 162281c..9c1dfad 100644
--- a/compiler/cpp/src/thrift/parse/t_list.h
+++ b/compiler/cpp/src/thrift/parse/t_list.h
@@ -34,7 +34,7 @@
 
   bool is_list() const override { return true; }
 
-  void validate() const {
+  void validate() const override {
 #ifndef ALLOW_EXCEPTIONS_AS_TYPE
     if( get_elem_type()->get_true_type()->is_xception()) {
       failure("exception type \"%s\" cannot be used inside a list", get_elem_type()->get_name().c_str());

compiler/cpp/src/thrift/parse/t_map.h

diff --git a/compiler/cpp/src/thrift/parse/t_map.h b/compiler/cpp/src/thrift/parse/t_map.h
index 30a8b06..6ec58cf 100644
--- a/compiler/cpp/src/thrift/parse/t_map.h
+++ b/compiler/cpp/src/thrift/parse/t_map.h
@@ -37,7 +37,7 @@
 
   bool is_map() const override { return true; }
 
-  void validate() const {
+  void validate() const override {
 #ifndef ALLOW_EXCEPTIONS_AS_TYPE
     if( get_key_type()->get_true_type()->is_xception()) {
       failure("exception type \"%s\" cannot be used inside a map", get_key_type()->get_name().c_str());

compiler/cpp/src/thrift/parse/t_set.h

diff --git a/compiler/cpp/src/thrift/parse/t_set.h b/compiler/cpp/src/thrift/parse/t_set.h
index 88de93f..8f7599a 100644
--- a/compiler/cpp/src/thrift/parse/t_set.h
+++ b/compiler/cpp/src/thrift/parse/t_set.h
@@ -36,7 +36,7 @@
 
   bool is_set() const override { return true; }
 
-  void validate() const {
+  void validate() const override {
 #ifndef ALLOW_EXCEPTIONS_AS_TYPE
     if( get_elem_type()->get_true_type()->is_xception()) {
       failure("exception type \"%s\" cannot be used inside a set", get_elem_type()->get_name().c_str());

compiler/cpp/src/thrift/parse/t_struct.h

diff --git a/compiler/cpp/src/thrift/parse/t_struct.h b/compiler/cpp/src/thrift/parse/t_struct.h
index 3aa67c0..8b33ee6 100644
--- a/compiler/cpp/src/thrift/parse/t_struct.h
+++ b/compiler/cpp/src/thrift/parse/t_struct.h
@@ -130,7 +130,7 @@
     return nullptr;
   }
 
-  void validate() const {
+  void validate() const override {
     std::string what = "struct";
     if( is_union()) {
       what = "union";

tutorial/rs/src/bin/tutorial_client.rs

diff --git a/tutorial/rs/src/bin/tutorial_client.rs b/tutorial/rs/src/bin/tutorial_client.rs
index 4bf2ec0..b79ae83 100644
--- a/tutorial/rs/src/bin/tutorial_client.rs
+++ b/tutorial/rs/src/bin/tutorial_client.rs
@@ -107,7 +107,7 @@
 
     // open the underlying TCP stream
     println!("connecting to tutorial server on {}:{}", host, port);
-    c.open(&format!("{}:{}", host, port))?;
+    c.open(format!("{}:{}", host, port))?;
 
     // clone the TCP channel into two halves, one which
     // we'll use for reading, the other for writing