commit 8e217dca69081016b6b7df344fbf957342243c7f
author Yuxuan 'fishy' Wang <yuxuan.wang@reddit.com> Tue May 10 13:21:11 2022 -0700
committer Yuxuan 'fishy' Wang <fishywang@gmail.com> Thu May 12 13:28:14 2022 -0700
tree 1610da6f7730200f1aaeb26e6b8a285a3f3c6329
parent 71ba05ba2dd50aff11f1e88df0712aa9f6df8c9d

Revert "THRIFT-5569: add negative size checks in Go generator when reading maps, sets and lists"

This reverts commit 8987820e84ac26392293ab40480cf8f2971fb314.

compiler/cpp/src/thrift/generate/t_go_generator.cc

diff --git a/compiler/cpp/src/thrift/generate/t_go_generator.cc b/compiler/cpp/src/thrift/generate/t_go_generator.cc
index 4833420..f4b94a4 100644
--- a/compiler/cpp/src/thrift/generate/t_go_generator.cc
+++ b/compiler/cpp/src/thrift/generate/t_go_generator.cc
@@ -3375,9 +3375,6 @@
   // Declare variables, read header
   if (ttype->is_map()) {
     out << indent() << "_, _, size, err := iprot.ReadMapBegin(ctx)" << endl;
-    out << indent() << "if size < 0 {" << endl;
-    out << indent() << "  return errors.New(\"map size is negative\")" << endl;
-    out << indent() << "}" << endl;
     out << indent() << "if err != nil {" << endl;
     out << indent() << "  return thrift.PrependError(\"error reading map begin: \", err)" << endl;
     out << indent() << "}" << endl;
@@ -3385,9 +3382,6 @@
     out << indent() << prefix << eq << " " << (pointer_field ? "&" : "") << "tMap" << endl;
   } else if (ttype->is_set()) {
     out << indent() << "_, size, err := iprot.ReadSetBegin(ctx)" << endl;
-    out << indent() << "if size < 0 {" << endl;
-    out << indent() << "  return errors.New(\"set size is negative\")" << endl;
-    out << indent() << "}" << endl;
     out << indent() << "if err != nil {" << endl;
     out << indent() << "  return thrift.PrependError(\"error reading set begin: \", err)" << endl;
     out << indent() << "}" << endl;
@@ -3395,9 +3389,6 @@
     out << indent() << prefix << eq << " " << (pointer_field ? "&" : "") << "tSet" << endl;
   } else if (ttype->is_list()) {
     out << indent() << "_, size, err := iprot.ReadListBegin(ctx)" << endl;
-    out << indent() << "if size < 0 {" << endl;
-    out << indent() << "  return errors.New(\"list size is negative\")" << endl;
-    out << indent() << "}" << endl;
     out << indent() << "if err != nil {" << endl;
     out << indent() << "  return thrift.PrependError(\"error reading list begin: \", err)" << endl;
     out << indent() << "}" << endl;