commit 8cd3efe50a42975375e8ff3bc03306d9e4174314
author Jens Geyer <jensg@apache.org> Mon Sep 16 22:17:52 2013 +0200
committer Jens Geyer <jensg@apache.org> Mon Sep 16 22:17:52 2013 +0200
tree a162351b1b4eeb42f9b201e4ce6995e5c4a9a1fd
parent b2501a71a79304fa27dfd6d2e55b75d8eacf0cef

THRIFT-1755 Comment parsing bug

Patch: Brian Brooks & Jens Geyer

compiler/cpp/src/main.cc

diff --git a/compiler/cpp/src/main.cc b/compiler/cpp/src/main.cc
index 0cefa7e..54c23f5 100755
--- a/compiler/cpp/src/main.cc
+++ b/compiler/cpp/src/main.cc
@@ -517,8 +517,13 @@
     docstring += '\n';
   }
 
-  assert(docstring.length() <= strlen(doctext));
-  strcpy(doctext, docstring.c_str());
+  //assert(docstring.length() <= strlen(doctext));  may happen, see THRIFT-1755
+  if(docstring.length() <= strlen(doctext)) {
+    strcpy(doctext, docstring.c_str());
+  } else {
+    free(doctext);  // too short
+    doctext = strdup(docstring.c_str());
+  }
   return doctext;
 }