THRIFT-2886 Integrate binary type in standard Thrift cross test
Client: C_glib, C++, D, Erlang, Go, Haskell, Lua, Java/Me, JavaScript, Node, Ocaml, Perl, PHP, Python, Ruby
Patch: Jens Geyer
This closes #341
Minimal server-side implementations and TODO stubs for various languages to let "make check" succeeed.
Not contained in this patch and still TODO:
- client side implementations, i.e. calls to testBinary() and appropriate tests
- server side hex printout missing for some languages
diff --git a/test/py/TestClient.py b/test/py/TestClient.py
index 87fede6..a810b3f 100755
--- a/test/py/TestClient.py
+++ b/test/py/TestClient.py
@@ -118,6 +118,8 @@
self.assertEqual(self.client.testDouble(0), 0)
self.assertEqual(self.client.testDouble(-1), -1)
+ # TODO: def testBinary(self) ...
+
def testStruct(self):
x = Xtruct()
x.string_thing = "Zero"
diff --git a/test/py/TestServer.py b/test/py/TestServer.py
index 820b816..b29eabd 100755
--- a/test/py/TestServer.py
+++ b/test/py/TestServer.py
@@ -101,6 +101,11 @@
print 'testDouble(%f)' % dub
return dub
+ def testBinary(self, thing):
+ if options.verbose > 1:
+ print 'testBinary()' # TODO: hex output
+ return thring
+
def testStruct(self, thing):
if options.verbose > 1:
print 'testStruct({%s, %d, %d, %d})' % (thing.string_thing, thing.byte_thing, thing.i32_thing, thing.i64_thing)