THRIFT-4164: update openssl cleanup to match current requirements and document TSSLSocketFactory lifetime requirements
Client: cpp
This closes #1235
diff --git a/test/cpp/src/TestClient.cpp b/test/cpp/src/TestClient.cpp
index a918bfb..6ecf540 100644
--- a/test/cpp/src/TestClient.cpp
+++ b/test/cpp/src/TestClient.cpp
@@ -228,12 +228,12 @@
noinsane = true;
}
+ // THRIFT-4164: The factory MUST outlive any sockets it creates for correct behavior!
+ boost::shared_ptr<TSSLSocketFactory> factory;
+ boost::shared_ptr<TSocket> socket;
boost::shared_ptr<TTransport> transport;
boost::shared_ptr<TProtocol> protocol;
- boost::shared_ptr<TSocket> socket;
- boost::shared_ptr<TSSLSocketFactory> factory;
-
if (ssl) {
cout << "Client Certificate File: " << certPath << endl;
cout << "Client Key File: " << keyPath << endl;