commit 75386db8c0eaba39ec5ad374cba27e039d2493e2
author Changli Gao <xiaosuo@gmail.com> Fri Mar 10 13:15:37 2017 +0800
committer James E. King, III <jking@apache.org> Wed Mar 22 15:03:37 2017 -0400
tree d44e249f957c7b6f9b0c4b40fb3388be4a150108
parent e576b26e39e5b34df1fa81cec039a0066a280f65

THRIFT-4129: Fix fd leak when failing to dispatch new connections
Client: C++

This closes #1210

lib/cpp/src/thrift/server/TNonblockingServer.cpp

diff --git a/lib/cpp/src/thrift/server/TNonblockingServer.cpp b/lib/cpp/src/thrift/server/TNonblockingServer.cpp
index d4418bd..2cf64f8 100644
--- a/lib/cpp/src/thrift/server/TNonblockingServer.cpp
+++ b/lib/cpp/src/thrift/server/TNonblockingServer.cpp
@@ -1004,7 +1004,7 @@
     } else {
       if (!clientConnection->notifyIOThread()) {
         GlobalOutput.perror("[ERROR] notifyIOThread failed on fresh connection, closing", errno);
-        returnConnection(clientConnection);
+        clientConnection->close();
       }
     }