tree 6ae3e070cc4de22f43b3da5ee5651f8b7df46ebd
parent bb311a772e0a6fc142387abc3489a103662ea187
author Yuxuan 'fishy' Wang <yuxuan.wang@reddit.com> 1565006348 -0700
committer Duru Can Celasun <dcelasun@apache.org> 1565006348 +0100

THRIFT-4612: Avoid double wrapping THeaderTransport

Client: go

Previously the library didn't check against double wrapping, so when
NewTSimpleServerN was used with both THeaderTransportFactory and
THeaderProtocolFactory, inside THeaderProtocolFactory the transport 
was double wrapped with THeaderTransport.

Worse, the transport still appeared to work, because THeaderTransport 
is backwards compatible with TBinaryProtocol and TCompactProtocol
so the outer layer of THeaderTransport wrapper (the one directly accessible 
from the protocol) would assume the client doesn't support THeader and 
fallback. So when double wrapping happened, it appeared like everything 
was fine, except you couldn't get the headers from the protocol (because 
they were in the inner THeaderTransport, not the outer one that's directly 
accessible from the protocol), making it very hard to debug.

This commit adds protection against such double wrapping.

This closes #1839.