commit 699b5bc47a90c47cf8954c4e8900af44990d1f0f
author James E. King, III <jking@apache.org> Thu Sep 14 08:07:08 2017 -0700
committer James E. King, III <jking@apache.org> Thu Sep 21 07:02:51 2017 -0700
tree 64faf6bcc588c504654957651034c26915e78ffc
parent 04d983c14e4a7669e4bd2143ab546a301b36d279

THRIFT-4064: update node dependencies

This closes #1359

lib/nodejs/README.md

diff --git a/lib/nodejs/README.md b/lib/nodejs/README.md
index af88c68..8c25380 100644
--- a/lib/nodejs/README.md
+++ b/lib/nodejs/README.md
@@ -20,6 +20,9 @@
 specific language governing permissions and limitations
 under the License.
 
+## Compatibility
+
+node version 4 or later is required
 
 ## Install
 

lib/nodejs/test/testAll.sh

diff --git a/lib/nodejs/test/testAll.sh b/lib/nodejs/test/testAll.sh
index 38b284a..aae451a 100755
--- a/lib/nodejs/test/testAll.sh
+++ b/lib/nodejs/test/testAll.sh
@@ -43,7 +43,7 @@
     node ${DIR}/server.js --type $1 -p $2 -t $3 $4 &
   fi
   SERVERPID=$!
-  sleep 1
+  sleep 0.1
   if [ -n "${COVER}" ]; then
     ${ISTANBUL} cover ${DIR}/client.js --dir ${REPORT_PREFIX}${COUNT} -- --type $1 -p $2 -t $3 $4 || RET=1
     COUNT=$((COUNT+1))
@@ -51,6 +51,7 @@
     node ${DIR}/client.js --type $1 -p $2 -t $3 $4 || RET=1
   fi
   kill -2 $SERVERPID || RET=1
+  wait $SERVERPID
   return $RET
 }
 
@@ -96,7 +97,7 @@
 done
 
 # XHR only until phantomjs 2 is released.
-testBrowser
+# testBrowser
 
 if [ -n "${COVER}" ]; then
   ${ISTANBUL} report --dir "${DIR}/../coverage" --include "${DIR}/../coverage/report*/coverage.json" lcov cobertura html