commit 6657b8337d1aedfd2aed22a8cdcf4b96965ece26
author Chandler May <cjmay4754@gmail.com> Sun Mar 27 22:47:06 2016 -0400
committer Nobuaki Sukegawa <nsuke@apache.org> Tue Mar 29 12:03:34 2016 +0900
tree ac6bb5967a9e3baa8afa96a7d3a50698acc2f00e
parent 4ab9a88496413087df1ee3256472b19c5b4be500

THRIFT-3765 fix memory leak in python compact protocol extension

This closes #970

lib/py/src/ext/protocol.tcc

diff --git a/lib/py/src/ext/protocol.tcc b/lib/py/src/ext/protocol.tcc
index 2f0d083..6e978d7 100644
--- a/lib/py/src/ext/protocol.tcc
+++ b/lib/py/src/ext/protocol.tcc
@@ -418,19 +418,24 @@
   }
 
   case T_STRING: {
+    ScopedPyObject nval;
+
     if (PyUnicode_Check(value)) {
-      value = PyUnicode_AsUTF8String(value);
-      if (!value) {
+      nval.reset(PyUnicode_AsUTF8String(value));
+      if (!nval) {
         return false;
       }
+    } else {
+      Py_INCREF(value);
+      nval.reset(value);
     }
 
-    Py_ssize_t len = PyBytes_Size(value);
+    Py_ssize_t len = PyBytes_Size(nval.get());
     if (!detail::check_ssize_t_32(len)) {
       return false;
     }
 
-    impl()->writeString(value, static_cast<int32_t>(len));
+    impl()->writeString(nval.get(), static_cast<int32_t>(len));
     return true;
   }