tree 926e9f08771156659c8cf3aa2c086d7592241300
parent daf620915714b76fce517b376b963440d1f34089
author Yuxuan 'fishy' Wang <yuxuan.wang@reddit.com> 1602380372 -0700
committer Yuxuan 'fishy' Wang <fishywang@gmail.com> 1602695643 -0700

THRIFT-5294: Fix panic in go TSimpleJSONProtocol

Client: go

In go library's TSimpleJSONProtocol and TJSONProtocol implementations,
we use slices as stacks for context info, but didn't do proper boundary
check when peeking/popping, result in it might panic with using -1 as
slice index in certain cases of calling Write*End without matching
Write*Begin before.

Refactor the code to properly implement the stack, and return a
TProtocolException instead on those cases.

Also add unit tests for all protocols. The unit tests shown that
TCompactProtocol.[Read|Write]StructEnd would also panic with unmatched
Begin calls, so fix them as well.