tree 8f3e5d44c3b982d9902420e24ac92828b0738521
parent b941b1124834d38daaa0e4355655b4ce63b80d3e
author Yuxuan 'fishy' Wang <yuxuan.wang@reddit.com> 1647382935 -0700
committer Yuxuan 'fishy' Wang <fishywang@gmail.com> 1647405578 -0700

THRIFT-5539: Decouple TDuplicateToProtocol out of TDebugProtocol

Client: go

Currently go's TDebugProtocol does two things: log the read/writes, and
duplicate all the reads/writes to another TProtocol. For people who only
need the second feature, even if they use NopLogger for the logging
part, they still need to pay the price of all the fmt.Sprintf calls used
by logging, and on some cases those fmt.Sprintf calls alone can cause
significant CPU to be wasted (in one of our services fmt.Sprintf called
by TDebugProtocol used ~10% of CPU).

Create a dedicated TDuplicateToProtocol to reduce cpu waste, and mark
TDebugProtocol.DuplicateTo as deprecated.