commit 62f1bd556110e3e3795a1145c876a33d9dca2d37
author Triton <19377203+EnigmaTriton@users.noreply.github.com> Sat Jan 09 20:29:12 2021 +0100
committer Jens Geyer <jensg@apache.org> Fri Feb 19 09:00:56 2021 +0100
tree ad3c81e99fd53bc25297f916debf338526ba49fa
parent c15e75d4acaa9cd804dd3f6c5e732508f9118f64

THRIFT-5355 Do not rely on compiler and check boundaries
Client: cpp
Patch: Triton <19377203+EnigmaTriton@users.noreply.github.com>

This closes #2305

lib/cpp/src/thrift/async/TConcurrentClientSyncInfo.cpp

diff --git a/lib/cpp/src/thrift/async/TConcurrentClientSyncInfo.cpp b/lib/cpp/src/thrift/async/TConcurrentClientSyncInfo.cpp
index 0dac524..7f1b1cc 100644
--- a/lib/cpp/src/thrift/async/TConcurrentClientSyncInfo.cpp
+++ b/lib/cpp/src/thrift/async/TConcurrentClientSyncInfo.cpp
@@ -184,7 +184,11 @@
       throw apache::thrift::TApplicationException(
         TApplicationException::BAD_SEQUENCE_ID,
         "about to repeat a seqid");
-  int32_t newSeqId = nextseqid_++;
+  int32_t newSeqId = nextseqid_;
+  if (nextseqid_ == (std::numeric_limits<int32_t>::max)())
+    nextseqid_ = (std::numeric_limits<int32_t>::min)();
+  else
+    ++nextseqid_;
   seqidToMonitorMap_[newSeqId] = newMonitor_(seqidGuard);
   return newSeqId;
 }