| commit | 6228b907e0a01659515e8e4715c70f540fe07589 | [log] [tgz] |
|---|---|---|
| author | Jens Geyer <jensg@apache.org> | Fri Apr 09 22:55:11 2021 +0200 |
| committer | Jens Geyer <jensg@apache.org> | Sat Apr 10 10:09:44 2021 +0200 |
| tree | 4d19ecab0f81d5bab2e8048a0717b27ab06bc4a1 | |
| parent | 6583f4e52345c3b05a76f0b188836599628356e8 [diff] |
THRIFT-5395 inconsistent treatment of methods ending in "Async" Client: netstd Patch: Jens Geyer This closes #2372
diff --git a/lib/netstd/Tests/Thrift.PublicInterfaces.Compile.Tests/Impl/Thrift5253/MyService.cs b/lib/netstd/Tests/Thrift.PublicInterfaces.Compile.Tests/Impl/Thrift5253/MyService.cs index 342dd4a..1b8d99f 100644 --- a/lib/netstd/Tests/Thrift.PublicInterfaces.Compile.Tests/Impl/Thrift5253/MyService.cs +++ b/lib/netstd/Tests/Thrift.PublicInterfaces.Compile.Tests/Impl/Thrift5253/MyService.cs
@@ -51,6 +51,16 @@ return Task.FromResult(new InternalStructs() { Foo = input.Foo }); } + public Task TestAsyncAsync(CancellationToken cancellationToken = default) + { + return Task.CompletedTask; + } + + public Task TestXsyncAsync(CancellationToken cancellationToken = default) + { + return Task.CompletedTask; + } + public Task<WorksRslt> WorksAsync(WorksArrrgs input, CancellationToken cancellationToken = default) { return Task.FromResult(new WorksRslt() { Foo = input.Foo });
diff --git a/lib/netstd/Tests/Thrift.PublicInterfaces.Compile.Tests/Thrift5253.thrift b/lib/netstd/Tests/Thrift.PublicInterfaces.Compile.Tests/Thrift5253.thrift index ee3df9b..224ac85 100644 --- a/lib/netstd/Tests/Thrift.PublicInterfaces.Compile.Tests/Thrift5253.thrift +++ b/lib/netstd/Tests/Thrift.PublicInterfaces.Compile.Tests/Thrift5253.thrift
@@ -42,5 +42,9 @@ AsyncProcessor AsyncProcessor ( 1: AsyncProcessor foo) Client Client ( 1: Client foo) IAsync IAsync ( 1: IAsync foo) + + // inconsistent treatment of methods ending in "Async" + void TestXsync() + void TestAsync() }