go: Fix things staticcheck complains about
Client: go
Staticcheck is the recommended replacement of the frozen and deprecated
official golint linter [1].
Fix the things it complained about (or add lint:ignore directive) in:
- lib/go/thrift
- lib/go/test/tests
- tutorial/go/src
- test/go/src
- compiler generated code
The majority of the fixes are in the following categories:
- Use of deprecated function (mainly the TConfiguration related ones)
- Redundant break in switch cases
- Unused and unexported variables/fields/functions
Also in the same spirit as fb539ae, remove the error return from
NewTSSLSocket as it can never be non-nil.
This change will be cherry-picked into 0.15.0 branch after merged.
[1]: https://groups.google.com/g/golang-nuts/c/rCP70Aq_tBc
diff --git a/tutorial/go/src/client.go b/tutorial/go/src/client.go
index 8776f9c..f944cf8 100644
--- a/tutorial/go/src/client.go
+++ b/tutorial/go/src/client.go
@@ -21,7 +21,6 @@
import (
"context"
- "crypto/tls"
"fmt"
"github.com/apache/thrift/lib/go/thrift"
@@ -79,21 +78,14 @@
return err
}
-func runClient(transportFactory thrift.TTransportFactory, protocolFactory thrift.TProtocolFactory, addr string, secure bool) error {
+func runClient(transportFactory thrift.TTransportFactory, protocolFactory thrift.TProtocolFactory, addr string, secure bool, cfg *thrift.TConfiguration) error {
var transport thrift.TTransport
- var err error
if secure {
- cfg := new(tls.Config)
- cfg.InsecureSkipVerify = true
- transport, err = thrift.NewTSSLSocket(addr, cfg)
+ transport = thrift.NewTSSLSocketConf(addr, cfg)
} else {
- transport, err = thrift.NewTSocket(addr)
+ transport = thrift.NewTSocketConf(addr, cfg)
}
- if err != nil {
- fmt.Println("Error opening socket:", err)
- return err
- }
- transport, err = transportFactory.GetTransport(transport)
+ transport, err := transportFactory.GetTransport(transport)
if err != nil {
return err
}