commit 596e25f9b07f4eb626e8644b6cc18b93c417b4e5
author Kevin Wojniak <kainjow@users.noreply.github.com> Sun Nov 03 15:09:51 2019 -0800
committer Jens Geyer <jensg@apache.org> Wed Nov 06 01:11:55 2019 +0100
tree d0fe1d7340e6479a0bb47e019532fffee2882406
parent 4653009035db96228e33e8965e432752b41c8ed1

Fix unknown pragma warnings on mingw
Client: cpp
Patch: Kevin Wojniak

This closes #1917

These pragmas are only valid for MSVC. Fixes warnings found in the logs:

> In file included from C:\projects\thrift\lib\cpp\test\processor\ProcessorTest.cpp:40:
731C:\projects\thrift\lib\cpp\test\processor\Handlers.h:143: warning: ignoring #pragma warning  [-Wunknown-pragmas]
732  143 |   #pragma warning( push )
733      |
734C:\projects\thrift\lib\cpp\test\processor\Handlers.h:144: warning: ignoring #pragma warning  [-Wunknown-pragmas]
735  144 |   #pragma warning (disable : 4250 ) //inheriting methods via dominance
736      |
737C:\projects\thrift\lib\cpp\test\processor\Handlers.h:172: warning: ignoring #pragma warning  [-Wunknown-pragmas]
738  172 |   #pragma warning( pop )
739      |

lib/cpp/test/processor/Handlers.h

diff --git a/lib/cpp/test/processor/Handlers.h b/lib/cpp/test/processor/Handlers.h
index 05d19ed..d72a23c 100644
--- a/lib/cpp/test/processor/Handlers.h
+++ b/lib/cpp/test/processor/Handlers.h
@@ -139,7 +139,7 @@
   std::shared_ptr<EventLog> log_;
 };
 
-#ifdef _WIN32
+#ifdef _MSC_VER
   #pragma warning( push )
   #pragma warning (disable : 4250 ) //inheriting methods via dominance
 #endif
@@ -168,7 +168,7 @@
   int32_t value_;
 };
 
-#ifdef _WIN32
+#ifdef _MSC_VER
   #pragma warning( pop )
 #endif